Merge branch 'main' into cursor/hibernate-keep-soft-hide-current-a8e8

Keep the keep-count decision pure. The application walk reserves the
leaving tab before awaiting a victim, rechecks that slot before
soft-hide, and does not restore a victim that became visible or had
hibernate turned off while the upgrade was in flight.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

application/state/useTerminalSidePanelLayoutState.test.tsx

@@ -279,82 +279,6 @@ test('a pending side-panel write survives an urgent render on another tab', asyn
   }
 });
 
-test('a pending tool switch does not leave another tab ref behind an urgent open', async () => {
-  const dom = new JSDOM('<!doctype html><html><body></body></html>', { url: 'http://localhost' });
-  const previousWindow = globalThis.window;
-  const previousDocument = globalThis.document;
-  Object.defineProperty(globalThis, 'window', { configurable: true, value: dom.window });
-  Object.defineProperty(globalThis, 'document', { configurable: true, value: dom.window.document });
-  const actEnvironment = globalThis as typeof globalThis & { IS_REACT_ACT_ENVIRONMENT?: boolean };
-  const previousActEnvironment = actEnvironment.IS_REACT_ACT_ENVIRONMENT;
-  actEnvironment.IS_REACT_ACT_ENVIRONMENT = true;
-
-  let state: ReturnType<typeof useTerminalSidePanelLayoutState> | null = null;
-  const Probe = () => {
-    state = useTerminalSidePanelLayoutState();
-    return null;
-  };
-
-  const container = document.createElement('div');
-  document.body.appendChild(container);
-  const root: Root = createRoot(container);
-  const focusedTool = (tabId: string, fromRef = false) => {
-    const layout = fromRef
-      ? state?.sidePanelLayoutsRef.current.get(tabId)
-      : state?.sidePanelLayouts.get(tabId);
-    if (!layout) return null;
-    return collectSidePanelPanes(layout.root).find((pane) => pane.id === layout.focusedPaneId)?.tool ?? null;
-  };
-
-  try {
-    await act(async () => {
-      root.render(React.createElement(Probe));
-    });
-    await act(async () => {
-      state?.selectSidePanelToolForTab('terminal-a', 'notes');
-      state?.selectSidePanelToolForTab('terminal-b', 'scripts');
-    });
-
-    await act(async () => {
-      startTransition(() => {
-        state?.selectSidePanelToolForTab('terminal-a', 'history');
-      });
-      flushSync(() => {
-        state?.setSidePanelOpenTabs((previous) => new Map(previous).set('terminal-b', 'browser'));
-      });
-    });
-
-    assert.equal(state!.sidePanelOpenTabs.get('terminal-a'), 'history');
-    assert.equal(state!.sidePanelOpenTabs.get('terminal-b'), 'browser');
-    assert.equal(state!.sidePanelOpenTabsRef.current.get('terminal-a'), 'history');
-    assert.equal(
-      state!.sidePanelOpenTabsRef.current.get('terminal-b'),
-      'browser',
-      'B stays rendered as browser while its ref still reports the pre-queue tool',
-    );
-    assert.equal(focusedTool('terminal-b', true), 'browser');
-
-    // handleSwitchSidePanelTab returns before select when the ref already
-    // matches the clicked tool. A stale scripts ref would ignore this click.
-    assert.notEqual(state!.sidePanelOpenTabsRef.current.get('terminal-b'), 'scripts');
-    await act(async () => {
-      state?.selectSidePanelToolForTab('terminal-b', 'scripts');
-    });
-    assert.equal(state!.sidePanelOpenTabs.get('terminal-b'), 'scripts');
-    assert.equal(state!.sidePanelOpenTabsRef.current.get('terminal-b'), 'scripts');
-    assert.equal(focusedTool('terminal-b'), 'scripts');
-    assert.equal(state!.sidePanelOpenTabs.get('terminal-a'), 'history');
-  } finally {
-    await act(async () => {
-      root.unmount();
-    });
-    actEnvironment.IS_REACT_ACT_ENVIRONMENT = previousActEnvironment;
-    Object.defineProperty(globalThis, 'window', { configurable: true, value: previousWindow });
-    Object.defineProperty(globalThis, 'document', { configurable: true, value: previousDocument });
-    dom.window.close();
-  }
-});
-
 test('side panel icon clicks write the tool through selectSidePanelToolForTab', () => {
   const layerSource = readFileSync(new URL('../../components/TerminalLayer.tsx', import.meta.url), 'utf8');
   const start = layerSource.indexOf('const handleSwitchSidePanelTab = useCallback');

application/state/useTerminalSidePanelLayoutState.ts

@@ -27,64 +27,6 @@ function deleteMapEntry<T>(previous: Map<string, T>, key: string): Map<string, T
   return next;
 }
 
-function entryMatches<T>(left: Map<string, T>, right: Map<string, T>, key: string): boolean {
-  return left.has(key) === right.has(key) && left.get(key) === right.get(key);
-}
-
-/**
- * Keep a ref aligned with committed state without dropping a write React has
- * not rendered yet. An urgent update can rebase onto a transition: the
- * transition updater stores an intermediate map in the ref, and the later
- * updater changes only state. Copy committed entries the pending map did not
- * change, and follow committed once it moves past that pending value.
- */
-function syncTrackedMap<T>(
-  pending: Map<string, T>,
-  lastRendered: Map<string, T>,
-  committed: Map<string, T>,
-): Map<string, T> {
-  if (pending === lastRendered) return committed;
-  if (pending === committed) return pending;
-
-  let changed = false;
-  const merged = new Map(pending);
-
-  for (const key of committed.keys()) {
-    if (entryMatches(pending, committed, key)) continue;
-    const pendingMatchesRendered = entryMatches(pending, lastRendered, key);
-    const committedMatchesRendered = entryMatches(committed, lastRendered, key);
-    if (pendingMatchesRendered || !committedMatchesRendered) {
-      merged.set(key, committed.get(key) as T);
-      changed = true;
-    }
-  }
-
-  for (const key of pending.keys()) {
-    if (committed.has(key)) continue;
-    if (entryMatches(pending, lastRendered, key)) {
-      merged.delete(key);
-      changed = true;
-    }
-  }
-
-  return changed ? merged : pending;
-}
-
-function publishQueuedMap<T>(
-  live: Map<string, T>,
-  capturedBase: Map<string, T>,
-  previous: Map<string, T>,
-  stateNext: Map<string, T>,
-  tabId: string,
-  value: T | null,
-): Map<string, T> {
-  // The captured map is the synchronous write. Replaying it after an
-  // intervening render drops entries that render already merged. When the ref
-  // has moved ahead of this updater's base, reapply only this tab.
-  if (live === capturedBase || live === previous) return stateNext;
-  return value === null ? deleteMapEntry(live, tabId) : replaceMapEntry(live, tabId, value);
-}
-
 function reconcileSidePanelLayouts(
   layouts: Map<string, SidePanelLayout>,
   openTabs: Map<string, SidePanelTool>,
@@ -120,22 +62,17 @@ export function useTerminalSidePanelLayoutState() {
   const sidePanelLayoutsRef = useRef(sidePanelLayouts);
   // Last maps this hook rendered. A transition can update the refs before React
   // commits them; an urgent render in between must not copy the stale state
-  // back over that pending write. Once the queue commits, entries the pending
-  // write did not touch still have to catch up, or the ref stays on the
-  // transition updater's intermediate map.
+  // back over that pending write. Functional updates still merge onto queued
+  // state when the ref and the committed map have diverged.
   const renderedOpenTabsRef = useRef(sidePanelOpenTabs);
   const renderedLayoutsRef = useRef(sidePanelLayouts);
-  sidePanelOpenTabsRef.current = syncTrackedMap(
-    sidePanelOpenTabsRef.current,
-    renderedOpenTabsRef.current,
-    sidePanelOpenTabs,
-  );
+  if (sidePanelOpenTabsRef.current === renderedOpenTabsRef.current) {
+    sidePanelOpenTabsRef.current = sidePanelOpenTabs;
+  }
   renderedOpenTabsRef.current = sidePanelOpenTabs;
-  sidePanelLayoutsRef.current = syncTrackedMap(
-    sidePanelLayoutsRef.current,
-    renderedLayoutsRef.current,
-    sidePanelLayouts,
-  );
+  if (sidePanelLayoutsRef.current === renderedLayoutsRef.current) {
+    sidePanelLayoutsRef.current = sidePanelLayouts;
+  }
   renderedLayoutsRef.current = sidePanelLayouts;
 
   // Legacy and external open paths write the focused-tool map. Reconcile that
@@ -180,28 +117,14 @@ export function useTerminalSidePanelLayoutState() {
       const next = previous === layoutBase
         ? layouts
         : (openTab === null ? deleteMapEntry(previous, tabId) : replaceMapEntry(previous, tabId, layout));
-      sidePanelLayoutsRef.current = publishQueuedMap(
-        sidePanelLayoutsRef.current,
-        layoutBase,
-        previous,
-        next,
-        tabId,
-        openTab === null ? null : layout,
-      );
+      sidePanelLayoutsRef.current = next;
       return next;
     });
     setSidePanelOpenTabs((previous) => {
       const next = previous === openTabBase
         ? openTabs
         : (openTab === null ? deleteMapEntry(previous, tabId) : replaceMapEntry(previous, tabId, openTab));
-      sidePanelOpenTabsRef.current = publishQueuedMap(
-        sidePanelOpenTabsRef.current,
-        openTabBase,
-        previous,
-        next,
-        tabId,
-        openTab,
-      );
+      sidePanelOpenTabsRef.current = next;
       return next;
     });
   }, []);