bincxz
f2ec2a4842
fix(terminal): respect Shift+Enter negotiation
2026-09-02 16:01:10 +08:00
陈大猫
a1fce3ad7c
Merge pull request #3238 from ice616/feat/auto-launch-at-login
...
feat(settings): 支持开机自启动并最小化到系统托盘
2026-09-02 13:30:55 +08:00
陈大猫
7db5a21e3e
Merge pull request #3241 from binaricat/fix/sftp-sudo-i-drag-and-reconnect
...
fix: elevate /root drops after sudo -i
2026-09-02 13:12:59 +08:00
bincxz
10f1c02c5c
fix(sftp): use resolved identity username for /root elevation
...
Keychain identities can change after the host copied username. Use the
same resolveHostAuth username as sudo autofill so a stale host.username
does not skip or force elevation.
2026-09-02 11:58:09 +08:00
bincxz
ffb4d94aec
fix(sftp): use resolved identity passwords for /root drops
...
Keychain identities clear host.password. Reuse the same host-auth
resolution as sudo autofill so those saved identity passwords can
elevate a terminal drop into /root.
2026-09-02 11:53:00 +08:00
bincxz
b818db5f0c
fix(sftp): elevate /root drops and allow sudo reconnect fallback
...
After sudo -i, terminal drag into /root uses the host's saved password for
SFTP sudo. If no usable password is saved, the drop fails with guidance to
enable host Sudo elevation or return to the user directory.
Automatic SFTP reconnect still prefers the originating session, then falls
through to a fresh open so a dead channel after sudo -i can re-elevate.
2026-09-02 11:46:27 +08:00
陈大猫
ce1cdab559
Merge pull request #3239 from binaricat/codex/fix-sftp-drag-drop-routes
...
fix: make terminal drag uploads route-safe
2026-09-02 11:37:37 +08:00
bincxz
d79643d31c
fix(sftp): wait for origin focus before drop cancel or bind
...
Do not treat a lagging split-pane focus as the user leaving the drop
origin, and do not bind a Mosh/ET drop to the still-focused SSH session.
First-open follow treats a missing SSH id as bound to the live focused
terminal so a probe from A cannot apply after focus moves to B.
2026-09-02 11:17:22 +08:00
bincxz
4bb8a224b6
fix(sftp): reject follow probes after focused session changes
...
A follow sync that started probing session A must not navigate after
focus moves to session B. Capture the expected session before the
await and reuse the same guard already used for go-to-terminal-cwd.
2026-09-02 10:24:49 +08:00
netcatty-bot
8788803fb5
fix: address Codex review on PR #3239
2026-09-01 15:49:34 +00:00
bincxz
a7342ff7b8
fix(sftp): drop extra drag-upload routing machinery
...
Keep confirmed active-shell destinations, originating-session bind, sudo
fidelity, and the longer ZMODEM start wait. Remove the dormant queue,
routeSessionId identity, and source-regex contracts that only locked
that extra routing in.
2026-09-01 22:54:16 +08:00
bincxz
e5f2519433
fix(sftp): preserve queued upload routes
2026-09-01 22:33:00 +08:00
netcatty-bot
6e56fe5a8d
fix: address Codex review on PR #3239
2026-09-01 13:58:44 +00:00
netcatty-bot
2c35040e79
fix: address Codex review on PR #3239
2026-09-01 13:35:51 +00:00
netcatty-bot
55ceaa3290
fix: address Codex review on PR #3239
2026-09-01 13:13:23 +00:00
netcatty-bot
74abfe28ef
fix: address Codex review on PR #3239
2026-09-01 12:48:51 +00:00
axe006 and Claude Sonnet 5
d92406a9fd
fix(auto-launch): 补齐跨窗口同步、修正连续切换的陈旧响应竞态
...
针对 PR #3238 的 2 条 Codex review 意见修复:
- application/state/settingsIpcSync.ts / useSettingsState.ts:新增
STORAGE_KEY_AUTO_LAUNCH_ENABLED 的跨窗口广播处理。AppLockGate 会
在每个窗口(主窗口、托盘面板、终端弹窗等)都挂载一份
useSettingsState,即使开机自启动开关只在设置窗口的 UI 里展示和
交互。此前该键缺失在 settingsIpcSync.ts 的广播处理里,其他窗口
收到设置窗口推送的 notifySettingsChanged 广播后不会更新自己
内存里的 autoLaunchEnabled,与项目里几乎所有其它布尔类设置的
跨窗口同步约定不一致。新增结构断言测试验证键处理与端到端接线
都已补齐。
- application/state/systemSettingsEffects.ts:新增
autoLaunchWriteGenerationRef,推送 effect 的写入响应只在"没有
更新的写入请求已经发起"时才被采纳。此前连续快速切换开关会启动
多个并发的 bridge.setAutoLaunch 调用,每个回调只跟自己请求时的
闭包值比较,不知道是否已经有更晚的请求覆盖了它——一个陈旧请求
的延迟响应(比如报告了与自己请求不符的状态)可能在更新的请求
已经成功落地之后才到达,用过时的"纠正"把已经确认生效的最新
状态覆盖掉。新增单测覆盖乱序到达、连续三次切换等场景。
新增/更新单测覆盖上述两个场景,199 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 20:12:36 +08:00
bincxz
ccacb69bb9
fix(sftp): bind terminal drops to active route
2026-09-01 19:58:55 +08:00
axe006 and Claude Sonnet 5
7c419f41de
fix(auto-launch): 修正写入失败回滚、挂载竞态、隐藏启动焦点竞态
...
针对 PR #3238 的 3 条 Codex review 意见修复:
- electron/autoLaunch.cjs:setAutoLaunchEnabled 写入失败时,success
字段改为反映"回退读取本身是否成功"(即返回的 enabled 值是否可信),
而不是"写入操作是否成功",与 getAutoLaunchEnabled 已有的语义保持
一致。此前写入失败一律标记 success:false,导致渲染进程的推送
effect 直接丢弃回退读取到的真实状态(哪怕这次读取本身成功),
乐观开关状态停留在"已开启",即使操作系统层面从未真正创建
登录项。同时修正未支持平台分支的 success 语义(enabled:false
是确定事实,不是未知状态),与 getAutoLaunchEnabled 对齐。
- application/state/systemSettingsEffects.ts:新增
autoLaunchWriteStartedRef,挂载时的水合请求还在等待期间,如果
用户手动切换了开关(触发推送 effect 发起真实写入),水合的
陈旧响应落地时会跳过应用,不再覆盖用户刚做的选择——此前会用
这个陈旧值覆盖用户状态,并连锁触发推送 effect 把陈旧值写回
操作系统,实质上撤销用户刚成功完成的操作。
- electron/main.cjs:second-instance(含 open-terminal-path 无效
路径兜底分支)与 activate(macOS Dock 重新打开/点击)三处调用
createAndShowMainWindow() 后新增 focusMainWindow() 跟随调用。
consumeColdStartHiddenLaunch 是一次性锁存标志,谁先调用
createAndShowMainWindow() 谁就消费掉它——app.whenReady() 之后、
默认冷启动流程真正调用 createAndShowMainWindow() 之前还有若干
await(如应用锁设置加载),期间到达的真实第二实例或 Dock 重新
打开事件可能抢先消费隐藏标志,创建一个隐藏窗口且没有后续动作
让它显示,导致用户显式的重新打开操作看起来毫无反应。深链接和
打开终端路径的四处调用点已经在创建后无条件调用 focusMainWindow()
(因此不受影响),这次是给另外三处缺失该调用的地方补上。
新增/更新单测覆盖上述三个场景,194 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 19:49:27 +08:00
axe006 and Claude Sonnet 5
151364ce4b
fix(auto-launch): 修正 macOS 待审批状态误触发禁用与 Linux 文案
...
针对 PR #3238 的 2 条 Codex review 意见修复:
- electron/autoLaunch.cjs:resolveEffectiveLoginState 新增对 macOS
status: "requires-approval" 的处理。macOS 13+ 用 SMAppService
注册登录项后,用户在"系统设置"里批准前会处于待审批状态,此时
openAtLogin 报告 false,即使注册本身已经成功。此前代码把这个
false 当作真实状态返回给渲染进程,推送 effect 一看到与用户刚
请求的值不一致就会立刻发起相反的写入,在用户还没来得及批准前
就把这个待审批的登录项注销掉。现在待审批状态统一视为 enabled,
与用户请求保持一致,后续读取会在用户批准或系统丢弃待审批请求后
自然反映真实状态。
- i18n(en/zh-CN/zh-TW/ru):unsupportedDesc 文案此前只提到"开发
环境下不支持",但 isAutoLaunchSupported 在打包后的 Linux 构建
(AppImage/deb/rpm/pacman)上同样会返回 false,对 Linux 用户
显示这句话是错误的。改为同时覆盖平台不支持和开发环境两种情况
的中性表述。
新增单测覆盖 macOS 待审批场景,189 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 19:19:15 +08:00
axe006 and Claude Sonnet 5
e6df190b98
fix(auto-launch): 隐藏启动的崩溃保护与读取失败状态误覆盖问题
...
针对 PR #3238 的 2 条 Codex review 意见修复:
- electron/main.cjs:隐藏启动成功后不再传 windowShown: !startHidden,
改为固定传 true。processErrorGuards.cjs 的 hasShownMainWindow 是
一次性锁存标志,只要传 false 就会让运行时保护在整个进程生命周期
内永远处于"启动期严格模式"——任何非网络类未捕获异常都会被判定
为致命错误并可能杀掉进程。隐藏启动时 createWindow() 已经成功
创建窗口并加载完页面,是一次完整的启动,不是失败,理应解除
严格模式。新增结构断言测试覆盖成功/失败两条分支。
- electron/autoLaunch.cjs:getAutoLaunchEnabled 读取失败时新增
success: false 字段,区分"确认关闭"与"状态未知"。此前失败时
返回的 { enabled: false, supported: true } 与正常读到关闭状态
完全无法区分,渲染进程挂载时读取一次失败就会把本地缓存的
true 覆盖成 false,并触发相邻的推送 effect 把这个"假关闭"
写回操作系统,可能误删一个原本有效的登录项。
- application/state/systemSettingsEffects.ts:挂载水合与推送两个
effect 都改为通过新导出的纯函数 isAutoLaunchResultTrustworthy
判断,success:false 时保留原状态、不发起写入。该函数已用普通
单测覆盖(react-test-renderer 在当前环境未安装,无法测试完整
hook 生命周期,故将判断逻辑抽成不依赖 React 的纯函数单独验证)。
新增/更新单测覆盖上述场景,177 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 19:01:30 +08:00
axe006 and Claude Sonnet 5
e5c750398d
fix(auto-launch): 修正 macOS 隐藏启动检测与 Windows 有效状态判定
...
针对 PR #3238 的 2 条 Codex review 意见修复,均已用仓库内绑定的
node_modules/electron/electron.d.ts 核实:
- wasLaunchedHidden 的 macOS 分支改用 wasOpenedAtLogin:openAsHidden/
wasOpenedAsHidden 在 Electron 类型声明里标注为 @deprecated 且
"does not work on macOS 13 and up",继续用它会导致 macOS 13+ 上
真实的开机自启动被误判为非隐藏启动,窗口被错误显示。
wasOpenedAtLogin 未被标记弃用,且 Netcatty 只在"开机自启动并
最小化"这一个场景下才会注册 macOS 登录项,因此把开机启动本身
当作隐藏启动的判定依据是安全的。
- resolveEffectiveLoginState 不再使用 executableWillLaunchAtLogin:
该字段按文档明确会忽略 args,只要该可执行文件以*任意*参数被
设置为登录启动就返回 true,与 buildLoginItemQueryOptions 按
path+args 精确查询的语义相悖,会被同一程序的其他登录项注册
(如历史遗留的无参数项)污染成假阳性。改为在 launchItems 数组
里查找 path+args 完全匹配的那一条目,读取其 enabled 字段
(该字段按文档明确是针对具体条目、反映任务管理器"启动应用"
开关状态的)。
新增/更新单测覆盖上述场景,155 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 18:47:54 +08:00
axe006 and Claude Sonnet 5
d4bfe02dc4
fix(auto-launch): 查询登录项状态时带上注册时的 path/args
...
针对 PR #3238 的 Codex review 意见修复:getAutoLaunchEnabled 和
setAutoLaunchEnabled 写入后的校验查询此前调用
app.getLoginItemSettings() 不带任何参数,而按 Electron 的行为
约定,openAtLogin/executableWillLaunchAtLogin 只针对查询时传入的
同一个 path+args 组合生效。写入时始终使用 path: execPath、
args: ['--hidden'](开启时),查询时不带参数会查到不匹配的登录项,
导致 Windows 上开启开关后立刻读回 enabled: false,UI 又把开关
弹回关闭状态。
新增 buildLoginItemQueryOptions 统一查询参数构造,getAutoLaunchEnabled
和 setAutoLaunchEnabled 的验证查询均已接入。新增/更新单测覆盖,
152 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 18:39:32 +08:00
axe006 and Claude Sonnet 5
ee47c9e15c
fix(auto-launch): 修复隐藏启动托盘保活、macOS 检测与跨平台支持
...
针对 PR #3238 的 4 条 Codex review 意见逐一修复:
- 隐藏启动时新增 pinTrayForHiddenLaunch/releaseHiddenLaunchTrayPin
机制:托盘在窗口首次显示前始终保持存在,不再被渲染进程挂载时
下发的 close-to-tray=false 提前销毁,避免开机自启+关闭托盘最小化
组合下出现无窗口无托盘的僵尸进程。窗口首次 show 后自动释放钉住,
交还给用户的正常 close-to-tray 偏好。
- wasLaunchedHidden 补充 macOS 检测:--hidden 启动参数只在 Windows
生效(openAsHidden 是 macOS 专属设置,不会体现在 argv 里),macOS
上改为读取 app.getLoginItemSettings().wasOpenedAsHidden。
- isAutoLaunchSupported 收紧为仅 macOS/Windows:Linux 打包(AppImage/
deb/rpm/pacman)没有对应的系统登录项钩子,setLoginItemSettings 在
该平台上静默失效,之前会误报"支持"。
- 新增 resolveEffectiveLoginState:Windows 上以
executableWillLaunchAtLogin(考虑任务管理器"启动应用"里被禁用的
情况)作为真实生效状态,而非只看 openAtLogin(仅反映注册表项
是否存在)。
新增/更新单测覆盖以上全部场景,共 149 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 18:35:21 +08:00
axe006
0068180204
Merge branch 'main' of https://github.com/binaricat/Netcatty into feat/auto-launch-at-login
2026-09-01 18:24:53 +08:00
axe006 and Claude Sonnet 5
513b2d66af
feat(settings): 支持开机自启动并最小化到系统托盘
...
在「设置 → 系统 → 网络代理」卡片上方新增开机自启动开关,开启后
系统启动时自动运行 Netcatty,并隐藏到系统托盘(不占用任务栏)。
- 新增 electron/autoLaunch.cjs 封装 app.setLoginItemSettings,
通过 --hidden 启动参数标记本次是登录项冷启动;开发环境
(process.defaultApp)下判定为不支持,避免误操作系统登录项。
- 主窗口首次冷启动读取该标志后跳过 win.show(),并在托管桥注册
完成后强制创建托盘图标(不依赖用户是否开启「关闭时最小化到
托盘」),确保隐藏窗口始终可被找到;后续任何窗口复用/深链接/
托盘点击路径不受影响。
- 开关真实状态以主进程 app.getLoginItemSettings() 为准,设置页
挂载时向主进程查询校准,而非只信任本地缓存。
- 新增单测覆盖 autoLaunch 纯逻辑及 startHidden 透传/托盘保底
行为,过程中发现并修复一处因未走依赖注入直接 require 模块
导致的隐患。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 18:16:42 +08:00
Netcatty-Bot and netcatty-bot
715487b2a0
fix(sftp): keep side panel directory and filter across terminal tab switches ( #3232 )
...
* fix(#3230 ): automated AI fix
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
* fix: address Codex review on PR #3232
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
2026-09-01 16:46:21 +08:00
陈大猫
8f34d2a31f
fix(ssh): identify concurrent terminal joins ( #3234 )
2026-09-01 14:37:28 +08:00
陈大猫 and netcatty-bot
fb034f08bb
fix(sftp): keep bulk queues and large-file resume responsive ( #3226 )
...
* fix(sftp): keep bulk queues and large-file resume responsive
* fix(sftp): preserve resume compatibility and timeout cleanup
* test(sftp): verify fixture cleanup in fresh environments
* fix: address Codex review on PR #3226
* fix(sftp): remove blocking periodic history persistence
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
2026-08-31 19:27:41 +08:00
陈大猫
39d7c38a6a
fix(ai): preserve resumed terminal chats after workspace merge ( #3225 )
2026-08-31 15:03:01 +08:00
Netcatty-Bot
e8c291373b
fix(terminal): add duplicate-session option that opens a fresh connection ( #3222 )
...
Add Duplicate Session as an explicit fresh-login alternative to Copy Tab. Keep authenticated transport reuse for Copy Tab and double-clicks, preserve fresh intent across session restoration, and avoid sending a previous target's directory command to a fresh bastion login.
Verified with focused and full tests, lint/build, independent local reviews, and real Electron menu operations against a local SSH server.
Fixes #3221 .
2026-08-31 14:28:16 +08:00
陈大猫
162b028d39
fix(cli): release consumed second-instance argument copies ( #3223 )
...
Release consumed second-instance argument buffers after deriving connection requests from an independent ordered copy. This closes the late password-retention finding on #3220 without changing connection or Explorer path routing.
Verified with regression tests, the full local suite, lint/build, two independent local reviews, and a real two-process Electron SSH connection that checks credential delivery and removal of both transport copies.
Related to #3218 and #3220 .
2026-08-31 12:47:34 +08:00
2d494e794e
fix(ssh): connect PuTTY-style CLI launches into the running instance ( #3220 )
...
* fix(#3218 ): automated AI fix
* fix: address Codex review on PR #3220
* fix(ssh): permanently cancel disabled scheme launch requests
* fix(ssh): release plaintext launch snapshot after handoff
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-08-31 12:06:15 +08:00
Netcatty-Bot
8f2c51cbcd
fix(tray): restore full panel height through the app lock wrapper ( #3209 )
...
Restore full height through the AppLockGate background wrapper, which otherwise lets the tray content collapse to about half of its window height. Preserve the existing lock-screen interaction restrictions.
Add real Electron regression coverage for repeated opening, session lists, lock/unlock, short windows, and Escape. Run it on macOS and Windows, including 100% and 200% device scale on Windows, and trigger it for the relevant renderer changes.
Fixes #3181
2026-08-31 11:44:08 +08:00
陈大猫
b71c75ed07
Merge pull request #3212 from binaricat/ai/issue-3211-33254121557
...
fix(sftp): add breadcrumb go-to-root button beside home icon
2026-08-31 10:36:18 +08:00
bincxz
03a8c4921b
fix(sftp): keep root navigation enabled for double-slash paths
2026-08-31 10:22:57 +08:00
陈大猫
8df0965066
Merge pull request #3215 from binaricat/codex/fix-3205-notes-comparison-markdown
...
fix(notes): render numeric comparisons without changing source
2026-08-31 10:14:15 +08:00
github-actions[bot] and github-actions[bot]
75eefa50c3
chore: update star history charts [skip ci] ( #3216 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-08-31 00:10:52 +00:00
陈大猫
e052f22148
Merge pull request #3208 from binaricat/ai/issue-3206-33245376344
...
fix(terminal-worker): keep one stray async error from killing every session
2026-08-30 23:08:13 +08:00
bincxz
46aa537c0e
test(notes): provide the browser image element constructor
2026-08-30 22:59:52 +08:00
bincxz
ccb63165c9
fix(terminal-worker): fail all errors before startup completes
2026-08-30 22:54:30 +08:00
bincxz
611f9cca3e
fix(notes): render numeric comparisons without changing source
2026-08-30 22:45:47 +08:00
netcatty-bot
3adf86bcd9
fix( #3211 ): automated AI fix
2026-08-29 13:24:14 +00:00
netcatty-bot
a20065a6a8
fix: address Codex review on PR #3208
2026-08-29 10:00:43 +00:00
netcatty-bot
76fa1c7a2d
fix( #3206 ): automated AI fix
2026-08-29 09:38:14 +00:00
陈大猫
b11dc42a10
Merge pull request #3045 from binaricat/feat/2988-mobaconf-password-import
...
feat(vault): import saved MobaXterm passwords from .mobaconf
2026-08-29 15:44:29 +08:00
bincxz
13dedcf17a
fix(vault): reject Moba AES plaintext truncated at an interior NUL
...
A wrong master password can decrypt to a NUL mid-buffer and leave a short
printable UTF-8 prefix. Treat only a trailing NUL pad as a C string so
vectors like wrong25 no longer save garbage host passwords.
2026-08-29 15:28:44 +08:00
bincxz
4d685557b1
fix(vault): reject wrong MobaXterm master passwords
...
AES-CFB has no authentication, so a mistyped master password can decrypt
to printable Latin-1 junk that was previously saved as a host password.
Require valid UTF-8 plaintext, fail closed if any ciphertext does not
decrypt, and keep leading or trailing whitespace in the master password.
2026-08-29 15:22:14 +08:00
陈大猫
f11378afbc
Merge pull request #3203 from binaricat/fix/2295-stored-key-reconnect-decrypt-race
...
fix(vault): wait for stored-key decrypt before reconnect auth
2026-08-29 14:55:49 +08:00
陈大猫
5b0f949101
Merge pull request #3204 from binaricat/fix/3061-autocomplete-popup-follow-wrap
...
fix(terminal): keep autocomplete popup on the wrapped command start
2026-08-29 14:51:11 +08:00