Commit Graph
1151 Commits
Author SHA1 Message Date
bincxz ef7b552d78 fix(sftp): keep background transfers alive across UI lifecycle 2026-07-29 11:14:11 +08:00
bincxz ae33bddc5d fix(sftp): bound deep directory traversal state 2026-07-29 05:14:51 +08:00
netcatty-bot f4091c149b fix: address Codex review on PR #2555 2026-07-28 21:02:57 +00:00
bincxz a2b9477c11 fix(runtime): close final auth and recorder races 2026-07-29 04:12:14 +08:00
bincxz 208191ed93 fix(sftp): close final transfer review gaps 2026-07-29 03:57:15 +08:00
bincxz 9a7b1b42ae fix(sftp): address current-head review findings 2026-07-29 03:45:13 +08:00
bincxz fe737ec555 fix(perf): unify SFTP lifecycles and bound runtime resources 2026-07-29 03:33:00 +08:00
bincxz 49918fd54a fix(sftp): remove legacy transfer event path 2026-07-28 18:57:15 +08:00
bincxz 2766896207 fix(sftp): throttle transfer progress UI to stop renderer freezes
Main-process progress IPC was ~10 Hz and each tick remapped the full
transfer list plus published the global center, pegging the main window
renderer at 100%+ CPU during large copies. Raise IPC throttle to 250ms/1MB
and coalesce progress-only React/store patches to one paint per frame.
2026-07-28 18:57:15 +08:00
bincxz 7aa3a0c81d fix(sftp): keep dedicated transfer opens off parked transport leases
Restart resume and bulk dedicated opens were still calling openSftp, which
silently borrowed a parked/shared terminal transport. That reattached
checkpoint resume to a lease-bound conn instead of an independent dial.
Dedicated transfer sessions now pass reuseTransport:false so they always
open a fresh vault SSH connection.
2026-07-28 18:57:15 +08:00
bincxz 990bbe5f50 fix(ssh): match transfer source by endpoint and await late unforward
Transfer pool source sessions now require hostname/user/port parity so
multi-tab or overridden endpoints do not borrow the wrong shared transport.
Remote forward cancel-during-forwardIn and stop paths share one timed
unforward helper that discards the transport when the server listen stalls.
2026-07-28 18:57:14 +08:00
bincxz aaf597eb64 fix(ssh): include auth policy in transport keys and migrate TTL
Fingerprint auth type, key id, MFA, agent, and host-key verification so
parked transports cannot bypass profile security edits. Migrate legacy
transfer-pool idle TTL into the SSH keep-alive setting on upgrade.
2026-07-28 18:57:14 +08:00
bincxz 3f706abfeb feat(ssh): unify transport leases and converge transfer keep-alive
Introduce a main-process SSH transport registry (borrow/return leases,
ControlPersist-style idle park) shared by shell, SFTP, transfer, and
port-forward. Transfer pool becomes channel concurrency only; remove the
separate transfer-pool idle TTL UI in favor of a single SSH keep-alive
setting. Register dedicated SFTP dials, reuse parked transports, and fix
TTL 0 (park until quit), jump-host endpoint keys, and remote unforwardIn.
2026-07-28 18:57:14 +08:00
陈大猫andnetcatty-bot 3b51079c51 feat(snippets): open quick add/edit as a centered modal (#2552)
* feat(snippets): open quick add/edit as a centered modal

Replace the scripts side-panel AsidePanel drawer with a Dialog so
snippet create/edit no longer slides over the terminal workspace, while
keeping the same form fields and shortkey capture behavior.

* fix: address Codex review on PR #2552

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 01:39:02 +08:00
陈大猫 8cdc887383 [Feature] Optimize large Vault imports and group management (#2540)
* feat(vault): optimize large imports and vault rendering (#2526)

* fix(vault): address import review findings

* fix(vault): preserve filtered selection and import consistency

* fix(vault): complete import review fixes

* fix(vault): make import cancellation concurrency-safe

* fix(vault): preserve concurrent edits during import rollback

* fix(vault): handle concurrent saves and reset import target

* fix(vault): drop empty source groups after targeted import

* fix(vault): preserve sidebar accessibility check

* fix(vault): correct group counts and selection semantics

* fix(vault): preserve imports across concurrent saves

* fix(vault): preserve concurrent group changes during import

* fix(vault): close concurrent import edge cases

* fix(vault): retry rollback and enable tree keyboard selection

* fix(vault): retain concurrent sources and visible selections

* fix(vault): merge imported sources with persisted state

* fix(vault): serialize duplicate managed imports

* fix(vault): keep imports non-blocking and grouped views responsive

* fix(vault): preserve concurrent managed sessions

* fix(vault): preserve concurrent groups and keyboard access

* fix(vault): serialize cross-window import commits

* fix(vault): make import commits atomic

* fix(vault): surface import rollback failures

* fix(vault): recover import transactions safely

* fix(vault): commit imported hosts atomically

* fix(vault): preserve unfinished import recovery

* fix(vault): wait for edits and preserve keyboard focus

* fix(vault): protect group settings and lock fallback

* fix(vault): keep virtual focus aligned

* fix(vault): complete keyboard navigation semantics

* fix(vault): finish keyboard navigation

* fix(vault): close large-vault concurrency gaps

* fix(vault): finish large-vault interaction safety

* fix(vault): harden filtered large-vault flows

* fix(vault): keep managed deletion atomic

* fix(vault): coordinate managed file deletion

* fix(vault): close cross-window managed races

* fix(vault): refresh persisted managed state

* fix(vault): preserve distinct imported sessions

* fix(vault): keep failed progress accurate

* fix(vault): keep search tree collapsible

* fix(vault): close final review gaps

* fix(vault): reveal filtered tree matches

* fix(vault): close final review edge cases

* fix(vault): preserve concurrent import changes

* fix(vault): serialize all vault saves under one cross-window lock

Hold the shared import lock for ordinary host/group/key writes and the
full import commit path so check-then-write can no longer interleave
across windows. Make the lock re-entrant in-window to avoid nested
deadlocks, and announce large tree item positions for screen readers.

* fix(vault): keep concurrent saves serialized and fix tree ARIA siblings

Stop treating same-window concurrent work as nested lock re-entry; nested
helpers skip re-acquire only when the outer critical section already owns
the lock. Announce treeitem position among true siblings at each level.

* fix(vault): require explicit lock handle for nested saves

Independent concurrent vault writes always queue on the shared lock.
Nested import/deletion helpers continue only when they pass the active
lock handle from their outer critical section.

* fix(vault): avoid lock deadlocks with encrypt-then-write saves

Encrypt outside the shared lock and only acquire it for the final write so
importers waiting on pending work cannot deadlock on lock acquisition.
Retry plugin commits outside the lock when concurrent edits intervene, and
rebase imports onto in-memory host edits when disk is still stale.

* fix(vault): release import lock before concurrent-edit retries

Drain encrypt work under the lock and full disk writes only outside it.
When an import or group deletion is superseded by a concurrent edit, release
the shared lock so that edit can finish, then retry. Functional group updates
now base on the latest in-memory snapshot while a write is still pending.

* fix(vault): tidy import dialog destination and SecureCRT prompts

Move import destination settings behind a bottom-left control with its own
step, and keep SecureCRT guidance in a dedicated chooser instead of inside
the format tile.

* test(vault): fix import dialog layout guard test under ESM

* fix(vault): simplify import destination footer control

Replace the heavy two-line destination card with a single quiet text link
that shows the current placement choice.

* fix(vault): simplify import destination settings page

Drop the nested card and duplicate headings. Show only the three placement
choices, finish immediately for preserve, and keep Done only when a group
name is needed.

* fix(vault): simplify SecureCRT chooser and iconify destination options

Remove redundant SecureCRT prompt copy while keeping the two source cards
with icons. Add small folder icons to the import-location choices so that
page is less plain.

* fix(vault): use SecureCRT logo in import chooser header

* fix(vault): drop border around SecureCRT import logo

* fix(vault): clarify import location footer with icon and label

Show a folder icon plus "Import location · current choice" so the control
is recognizable without becoming a heavy card again.

* fix(vault): remove border from import progress status icon
2026-07-28 00:54:03 +08:00
bincxz 0378028de7 fix stale terminal output cleanup 2026-07-27 18:58:34 +08:00
bincxz ccef87a938 fix terminal signal cleanup lifecycle 2026-07-27 18:58:34 +08:00
bincxz 07fc46a27c refactor terminal session signal state 2026-07-27 18:58:34 +08:00
bincxz a8ae4b680f fix terminal coding CLI icon detection 2026-07-27 18:58:34 +08:00
bincxz aa98d6d34a feat: add system theme to quick controls 2026-07-27 17:25:47 +08:00
陈大猫 7d7c57be99 Merge pull request #2525 from binaricat/feat/scripts-sidepanel-ux
feat(scripts): improve terminal scripts side panel UX
2026-07-27 16:52:55 +08:00
陈大猫 28ba165c3e Merge pull request #2532 from binaricat/codex/fix-stuck-lint-test
fix(ci): prevent lint-and-test hangs
2026-07-27 16:50:41 +08:00
bincxz 3f1e22ce43 fix(sftp): keep resume verification responsive 2026-07-27 16:41:47 +08:00
陈大猫 8acc99b8be Merge pull request #2533 from binaricat/codex/fix-2528-editor-save
fix: preserve SFTP editor saves after maximize
2026-07-27 16:37:14 +08:00
bincxz 72ffc0ee31 fix(sftp): avoid retaining remotes for local editors 2026-07-27 16:31:04 +08:00
bincxz 22d0e5e5e8 fix(sftp): keep promoted editor save session alive 2026-07-27 16:05:03 +08:00
bincxz 0716820ce9 fix(plugins): close remaining provider lifecycle gaps 2026-07-27 14:50:26 +08:00
bincxz ad72ca9dee Merge remote-tracking branch 'origin/main' into codex/pr-2413-finish 2026-07-27 13:55:58 +08:00
bincxz ac8ef5de38 fix(plugins): complete provider contract and lifecycle handling 2026-07-27 13:55:43 +08:00
bincxz 7884524afa fix(scripts): address multi-agent review on side panel UX
Restore modal dialog contract for quick-add (role/data-state/escape),
harden package path validation, skip sensitive sessions on multi-tab
snippet sends, and show a single run-on-all-tabs action for plain snippets.
2026-07-27 13:44:40 +08:00
bincxz 074724eb68 feat(scripts): improve terminal scripts side panel UX
Address #2502: bind shortkeys when quick-adding snippets, add package
creation via a split + menu, convert quick-add to a right-side drawer,
and let code snippets run on all workspace tabs from the context menu.
2026-07-27 13:37:50 +08:00
bincxz 1dfc898366 fix(sftp): persist history deletions immediately 2026-07-27 12:15:52 +08:00
bincxz 8d8abb4956 fix(sftp): preserve pruned cleanup data 2026-07-27 11:43:52 +08:00
bincxz ba8dea5cae fix(sftp): prevent large folder upload renderer stalls 2026-07-27 11:34:02 +08:00
netcatty-bot c7ce544c55 fix: address Codex review on PR #2494 2026-07-26 23:02:53 +08:00
netcatty-bot efbdf84308 fix: address Codex review on PR #2494 2026-07-26 23:02:28 +08:00
netcatty-bot ccb54952db fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 361b4952d2 fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 205ff6d81c fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 19127c0ea0 fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 0731eab9be fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 35895ec8db fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
bincxz c89522f014 fix(sftp): pin clipboard uploads to originating tab endpoint
Capture tabId/connectionId at paste time and resolve external folder/entry
uploads against that pane after awaits so mid-transfer tab switches cannot
retarget remaining multi-folder items to another host. Prefer the pinned
pane host when reconnecting and reconnect by tab id without clobbering the
active tab's lastConnectedHost.
2026-07-26 23:00:43 +08:00
陈大猫 e14c66703c Merge pull request #2510 from binaricat/fix/sftp-restore-2509-regressions
fix(sftp): restore cancel-by-task, clipboard confirm, and browse stay-alive
2026-07-26 22:47:59 +08:00
bincxz e42893b25e fix(sftp): restore cancel-by-task, clipboard confirm, and browse stay-alive
PR #2509's TransferRuntime unify accidentally regressed per-task external
upload cancel (#2495), clipboard confirm close-before-upload (#2478), and
main SftpView interactive browse sessions (#2498). Restore those behaviors
on top of the process-level control plane, keep Pausing copy, and gate
broadcastGlobalTransferEvent so bare Node unit tests do not download Electron.
2026-07-26 22:47:36 +08:00
itzhang89andCursor 6857f7ccc1 fix(ai): point Cursor CLI hints at cursor-agent login
Update Settings copy to use `cursor-agent login` and note that a saved API
key is retained while CLI login mode is active.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-26 22:41:22 +08:00
itzhang89 8e907e1df7 fix(ai): stop Cursor CLI Ask mode from sticking across permission switches
Skip duplicate stream-json assistant flushes that include model_call_id, and
isolate Cursor CLI resume sessions by ask vs agent so switching Observer to
Confirm/Auto starts a writable turn instead of keeping Ask.
2026-07-26 22:41:22 +08:00
陈大猫 370c182102 Merge pull request #2508 from Lynricsy/feat/inline-terminal-images
feat(terminal): support Kitty/SIXEL/iTerm inline images in terminals
2026-07-26 21:45:53 +08:00
bincxz d165e158f7 fix(sftp): unify transfer control under process-level TransferRuntime
Pause and resume now go through one process-level control plane that survives
panel/terminal close: TransferRuntime + soft latches/epochs/walk registry,
soft-then-hard resume, dual-epoch-safe progress, and no-owner soft control.
2026-07-26 21:27:01 +08:00
LynricsyandWine Fox fc7287e328 feat(terminal): render Kitty/SIXEL/iTerm inline images
Load @xterm/addon-image in the shared xterm runtime so remote programs can
draw real raster images (kitten icat, chafa --format kitty, image previews
in file managers and TUIs) instead of ANSI approximations.

- domain/terminalInlineImages.ts owns the limits and turns TerminalSettings
  into addon options; disabled settings resolve to null so the addon is not
  loaded at all and the terminal keeps advertising no graphics capability.
- The addon is loaded right after term.open, before the WebGL renderer, so it
  patches IRenderService.setRenderer first and its canvas layers survive every
  DOM <-> WebGL swap (deferred WebGL, soft-hide suspend, context-loss rebuild).
  It is disposed before term.dispose so bitmaps never outlive their terminal.
- Hibernate restores a tab from a text-only snapshot, which cannot carry image
  data. XTermRuntime.hasInlineImages reads the live image cache, and Terminal
  degrades such a session to soft-hide: hibernateRuntime takes the soft-hide
  branch, canFinishHibernate re-checks after every async step, and an eviction
  request leaves the session soft-hidden. The block lifts by itself once the
  cache is emptied by a terminal reset or FIFO eviction.
- Settings > Terminal > Inline Images exposes the master switch, per-protocol
  switches (Kitty / SIXEL / iTerm IIP) and the memory limits, translated for
  en, zh-CN, zh-TW and ru. Protocol switches cloud-sync; the memory limits stay
  local like the other per-device renderer tuning.

Co-authored-by: Wine Fox <fox@ling.plus>
2026-07-26 19:13:51 +08:00