Redesign the proxy configuration card to match the Jump Hosts and
Environment Variables pattern:
- When configured: clickable summary card with proxy type badge,
address, and X button to clear
- When unconfigured: simple + button to configure
- Removes cramped Badge-next-to-title layout that caused text wrapping
* fix: filter dotfiles as hidden on Linux/Unix systems (#194)
Previously the hidden file filter only checked the Windows hidden
attribute, leaving Unix/Linux dotfiles (starting with '.') always
visible regardless of the "show hidden files" setting.
- Rename isWindowsHiddenFile to isHiddenFile with both checks
- Add dotfile detection (name.startsWith('.'))
- Keep backward-compatible alias for isWindowsHiddenFile
- Update filterHiddenFiles to use the new isHiddenFile function
* fix: limit dotfile filtering to remote connections only
Address review feedback: dotfile filtering was applied unconditionally,
which would hide .gitignore, .env, etc. on local Windows panes.
- Add isLocal param to isHiddenFile/filterHiddenFiles
- When isLocal=true, only check Windows hidden attribute
- When isLocal=false (remote SFTP), also filter dotfiles
- Update all 3 callers to pass connection.isLocal
- Fix useMemo dependency arrays
* fix: preserve isWindowsHiddenFile backward compatibility
isWindowsHiddenFile alias now explicitly passes isLocal=true to
isHiddenFile, so existing callers that don't pass isLocal won't
accidentally filter dotfiles.
The ARM64 AppImage contained x86-64 native modules (node-pty, ssh2)
because both architectures were built on the same x86 runner.
- Split Linux build into linux-x64 (ubuntu-latest) and linux-arm64
(ubuntu-24.04-arm) jobs so native modules compile on the correct arch
- Add pack:linux-x64 and pack:linux-arm64 npm scripts with explicit
--x64/--arm64 flags
- Unify CI build step using matrix variables instead of per-OS conditions
* feat: add SFTP path bookmarks for dual-pane view
- Add SftpBookmark interface and sftpBookmarks field to Host model
- Create useSftpBookmarks hook with toggle/delete/list operations
- Add updateHosts callback through SftpContext for persistence
- Add bookmark star button with Popover dropdown in SftpPaneToolbar
- Wire bookmarks from App.tsx → SftpView → SftpContextProvider → SftpPaneView
- Add i18n translations for en and zh-CN
Closes#193
* refactor: replace encoding Select with compact icon Popover in SFTP toolbar
Replace the wide Select dropdown for filename encoding with a compact
Languages icon button + Popover menu, matching the SftpModal style.
* feat: add bookmark support to SFTPModal with shared hook
Refactor useSftpBookmarks to accept host/onUpdateHost params directly
instead of reading from SftpContext, enabling reuse in both SftpPaneView
(dual-pane) and SFTPModal (terminal).
- Refactor useSftpBookmarks hook to be context-agnostic
- Add bookmark star + Popover UI to SftpModalHeader
- Wire onUpdateHost from Terminal.tsx through SFTPModal
- Update SftpPaneView to use the new hook interface
useSftpHostCredentials.ts omitted `passphrase` when building the
credentials object for the target host, causing SFTP connections with
passphrase-protected private keys to fail with:
Error: Cannot parse privateKey: Encrypted private OpenSSH key
detected, but no passphrase given
The jump host path (L50) already included passphrase correctly.
This adds the same pattern to the main host credentials.
Bug 2: Replace prompt() with state-based dialog for new file/folder
- Electron does not support window.prompt() (returns null)
- Added create dialog following the existing rename dialog pattern
- Dialog renders in SftpModalDialogs with proper input + submit
Bug 3: Add Chinese translations for shortcut key labels
- SettingsShortcutsTab now uses t() for binding labels with fallback
- Added 29 Chinese translations for all keyboard shortcut bindings
- Reverse transfer list in dual-pane SftpView (visibleTransfers)
- Reverse transfer list in sidebar SftpModalUploadTasks
- Newest/active transfers now appear at the top without scrolling
* fix(sftp): prevent stale session race when reopening modal
* fix(sftp): close session on external modal hide
* fix(sftp): clean up late-created sessions after modal hide
* feat: add credential protection guards for enc:v1: placeholders
Prevent encrypted credential placeholders from being sent as
actual passwords when safeStorage decryption is unavailable
(e.g. different device/user profile). Adds guards at terminal
connection, cloud sync, and settings boundaries with user-facing
warnings and i18n support.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: validate base64 format in encrypted credential detection
Only treat values as encrypted placeholders when the content after
the enc:v1: prefix is valid base64. Prevents false positives if a
real password happens to start with the prefix literal.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: resolve regressions in master-key change flow and credential placeholder detection
- Make ensureSyncablePayload non-blocking in changeMasterKey handler so
success toast and dialog close always fire after a successful key change,
even when the payload contains unresolved enc:v1: placeholders
- Add MIN_CIPHERTEXT_BASE64_LENGTH (32) threshold to
isEncryptedCredentialPlaceholder to avoid false-positive matches on
plaintext credentials that happen to start with enc:v1: (e.g. enc:v1:hello)
* fix: clean up chain-progress listener on credential reentry and gate proxy check on auth usage
- Unsubscribe onChainProgress before returning in needsCredentialReentry
branch to prevent listener leaks across connection attempts
- Only block connection for undecryptable proxy password when proxy
authentication is actually in use (has a username)
* fix: reduce enc:v1 placeholder false positives
* fix: require syncable payload before master key rotation
---------
Co-authored-by: rorychou <roryechou@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
Collect SwapTotal and SwapFree from /proc/meminfo and display swap
usage in the memory HoverCard with a dedicated progress bar (rose color).
Only shown when the server has swap configured (swapTotal > 0).
Co-authored-by: rorychou <roryechou@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* Initial plan
* fix: remove extra right spacing next to close button on Windows
On Windows/Linux, the frameless title bar had ~20px of dead space
(12px right padding + 8px drag shim) to the right of the close button.
- Replace Tailwind `px-3` with conditional inline paddingRight (0 on
Windows, 12px on macOS) so the close button sits at the window edge
- Render the drag shim only on macOS where it's useful as a drag region
macOS layout is unchanged.
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com>
On Windows/Linux, the frameless title bar had ~20px of dead space
(12px right padding + 8px drag shim) to the right of the close button.
- Replace Tailwind `px-3` with conditional inline paddingRight (0 on
Windows, 12px on macOS) so the close button sits at the window edge
- Render the drag shim only on macOS where it's useful as a drag region
macOS layout is unchanged.
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com>
- CloudSyncManager: bump providerWriteSeq on storage events so an
in-flight local save is discarded when newer cross-window data arrives
- useVaultState: defer reads of keys/identities/groups/snippets to just
before their processing stage instead of reading all upfront, so data
updated during a prior async decrypt gap is not overwritten by a stale
pre-await snapshot
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- useVaultState: storage-event decrypt callbacks now also check
writeVersion so a local edit during the decrypt gap causes the stale
cross-window result to be discarded
- CloudSyncManager: bump providerDecryptSeq in uploadToProvider before
mutating lastSync/lastSyncVersion so a pending cross-window decrypt
cannot overwrite the newer sync metadata
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split the single providerSeq into providerDecryptSeq (bumped by all state
mutations to guard async decrypt callbacks) and providerWriteSeq (bumped
only by saveProviderConnection). This prevents status-only transitions
like 'error' or 'syncing' from discarding an in-flight encrypted write
from disconnect/auth, which would leave stale credentials in localStorage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- CloudSyncManager: add providerSeq write guard to saveProviderConnection
so overlapping async saves don't let an older encryption overwrite newer
provider state in localStorage
- credentialBridge: verify enc:v1: prefix by attempting trial decryption
instead of prefix-only check, so plaintext values that happen to start
with the sentinel are still encrypted rather than silently skipped
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move hostsWriteVersion/keysWriteVersion/identitiesWriteVersion increments
to before the await decryptHosts/Keys/Identities calls, and guard both
setstate and re-encrypt with the version check. This prevents a write
that occurs during the decryption await (storage event, user edit) from
being overwritten by stale init data.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- useVaultState: bump writeVersion counters on storage events so pending
local encrypts are discarded when newer cross-window data arrives
- CloudSyncManager: bump providerSeq on all local provider mutations
(connect, disconnect, status updates, save) so in-flight decrypt
callbacks from startup or storage events cannot revert newer state
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevent out-of-order async decrypt results from overwriting newer state:
- useVaultState: add per-key readSeq counters for cross-window storage
event decrypt callbacks (hosts, keys, identities)
- CloudSyncManager: add per-provider sequence counters shared between
initProviderDecryption and cross-window storage handler, so stale
decrypt results are discarded in both paths
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Addresses remaining Codex review feedback:
- Add writeVersion checks to startup migration re-encrypt paths to prevent
stale async writes from overwriting newer user edits
- Move `prev` read inside .then() in CloudSyncManager storage event handler
so it compares against latest state rather than a stale snapshot
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1. Race condition: rapid updateHosts/Keys/Identities calls could cause
out-of-order async writes. Added per-collection write-version counters
so only the latest encryption Promise persists to localStorage.
2. WebDAV token-auth: using "password" in config as discriminator failed
for token-auth configs because JSON.stringify drops undefined keys.
Switched to "authType" in config which is a required WebDAVConfig field.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Destroy trayPanelWindow and clear refresh timer during cleanup, preventing
hidden BrowserWindows from keeping the Electron process alive
- Add SIGTERM/SIGINT handlers for graceful shutdown
- Detect crashed webContents in focusMainWindow() and recreate the window
instead of silently failing on second-instance activation
Closes the issue where restarting the app shows "Failed to load the UI"
and leaves multiple zombie processes in the task manager.
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* fix: tray quit button, tree view multi-select, and SFTP banner handling
- Add "Quit Netcatty" button pinned to the bottom of TrayPanel so users
can exit the app when close-to-tray is enabled
- Support multi-select mode in HostTreeView (checkboxes, click-to-select)
so tree view behaves the same as grid/list views
- Patch ssh2 SFTP parser to skip non-SFTP preamble data (MOTD/banner text)
that causes "Packet length exceeds max length" errors on misconfigured
servers, with proper cross-frame buffering
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: gate SFTP preamble scan to client-mode only
Server-mode SFTP expects SSH_FXP_INIT (0x01) as the first packet, not
SSH_FXP_VERSION (0x02). Skip the preamble scan entirely when running in
server mode to avoid stalling server-side SFTP sessions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* Initial plan
* Fix ERR_FAILED when second instance launches by moving single-instance lock before app.whenReady()
Move app.requestSingleInstanceLock() before app.whenReady() registration
and wrap all lifecycle handlers (whenReady, window-all-closed, before-quit,
will-quit) inside the else block. This prevents a second instance from
attempting to register the app:// protocol or create a BrowserWindow,
which would fail with ERR_FAILED.
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com>
All three paste paths (hotkey, context menu, middle-click) were sending
raw clipboard text directly to the session backend via writeToSession(),
bypassing xterm's built-in term.paste() which handles bracketed paste
wrapping. When a remote application like vim enables bracketed paste
mode (CSI ?2004h), pasted text must be wrapped in \e[200~ / \e[201~
so the application can distinguish paste from typed input.
Without these markers, vim's autoindent treats each pasted newline as
a manual Enter keypress, causing indentation to accumulate
progressively with each line (the "staircase effect").
Now checks term.modes.bracketedPasteMode before sending and wraps
the text accordingly on all paste paths.
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* fix: restore built-in editor paste reliability
* fix: prevent Cmd+R window reload while editing in Monaco
Replace the Electron menu `{ role: "reload" }` with a manual click
handler so that Cmd+R no longer registers as a native accelerator.
This prevents accidental window reloads (and loss of unsaved edits)
when the text editor has focus, since the app's hotkey early-return
skips preventDefault for editor surfaces.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: fall back to Monaco native paste when clipboard read is unavailable
When both navigator.clipboard.readText() and the Electron bridge fail,
readClipboardText now returns null instead of '' so handlePaste can
distinguish "read failed" from "clipboard empty" and trigger Monaco's
built-in paste action as a fallback.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: let clipboard bridge errors propagate for proper paste fallback
useClipboardBackend.readClipboardText was swallowing bridge
absence/errors as "", making TextEditorModal's catch-based null
fallback unreachable. Now throws when the bridge is unavailable or
the call fails, so the caller can detect failure and fall back to
Monaco's native paste action.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: preserve multi-cursor paste distribution semantics
When multiple cursors are active and the clipboard line count matches
the cursor count, distribute one line per cursor instead of pasting
the full text at every cursor. This matches Monaco's default
multicursorPaste:'spread' behavior.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Introduces a collapsable sidebar in the Vault view to enhance user experience and optimize screen real estate.
The sidebar's collapsed or expanded state is now persisted across sessions using local storage. Tooltips are added to navigation items, providing clear labels when the sidebar is in its collapsed state.
Additionally, improves tooltip activation behavior in the SFTP modal, delaying their appearance slightly to prevent flickering on modal open.