Commit Graph
4047 Commits
Author SHA1 Message Date
bincxz 82b58b31bc refactor(ssh): drop legacy connRef shape compatibility
Remove ensureTransportShape upgrade of bare { count, conn } descriptors.
Borrow requires a registry transport from createConnectionRef/createTransport.
Update tests to construct real transports instead of hand-rolled count objects.
2026-07-28 18:57:15 +08:00
bincxz efcc33e457 fix(ssh): preserve legacy connRef owner count when upgrading descriptors
Seed placeholder leases for pre-registry count so an existing terminal
owner is not lost when SFTP acquires a share; count correctly becomes 2.
2026-07-28 18:57:15 +08:00
bincxz 9711322c64 fix(ssh): upgrade legacy connRef descriptors before borrow
acquireConnectionRef / borrowTransport now ensure leases Map and registry
fields exist on pre-registry { count, conn } descriptors so older tests and
in-memory sessions do not throw on transport.leases.has.
2026-07-28 18:57:15 +08:00
bincxz 921002d70d fix(ssh): cover password-only auto auth in transport fingerprints
Password-only automatic login now digests the password so vault rotation
invalidates parked reuse, while multi-material auto keeps publicKey-based
matching so key-first transfer opens still find the shared transport.
2026-07-28 18:57:15 +08:00
bincxz 6b2648d687 fix(ssh): digest only selected-method credentials for reuse keys
Auth material fingerprints are method-scoped so key-first / password-retry
SFTP opens still match a parked multi-material transport. Password rotation
invalidates password auth; key/cert content rotation invalidates those methods.
2026-07-28 18:57:15 +08:00
bincxz 5328bba3b8 fix(ssh): fingerprint credential material for transport reuse invalidation
Digest password/privateKey/certificate/passphrase/identity paths into the
auth fingerprint so key or password rotation under the same keyId invalidates
parked transports. Secrets are not retained on the transport registry — only
the digest is indexed.
2026-07-28 18:57:15 +08:00
bincxz 96a096ffc7 fix(ssh): detach shared PF lifecycle before releasing the lease
Bind-failure cleanup must remove close/error handlers while conn is still
attached; releasing first cleared conn and left stale listeners on the
shared transport after local bind errors.
2026-07-28 18:57:15 +08:00
bincxz 67e639c639 fix(ssh): resolve transfer source across multi-tab same hostId sessions
Add resolveSftpTransferSourceSessionId that walks all reusable terminal
sessions instead of the picker one-per-hostId list, so transfers can still
borrow a live transport when another tab for the same hostId has a different
endpoint.
2026-07-28 18:57:14 +08:00
bincxz 1ac0ab767a fix(ssh): release managed PF leases on post-bind listener errors
Dedicated dials that registered a transport lease were leaving the lease
held after local/dynamic server errors. Always release managed leases so
authenticated connections are not orphaned until quit.
2026-07-28 18:57:14 +08:00
bincxz 9030dbb9ef fix(ssh): demote shared PF tunnels after post-bind listener errors
Local/dynamic server errors after start resolved still release the lease
and mark the tunnel inactive so restarts cannot reuse a zombie active entry.
2026-07-28 18:57:14 +08:00
bincxz 559206d4c9 fix(ssh): track pending remote forward and harden idle/error paths
Record remote bind target before forwardIn so cancel-during-listen always
unforwards (or discards). Shared PF transport errors discard instead of park;
identical idle TTL re-sends no longer reset idle deadlines.
2026-07-28 18:57:14 +08:00
bincxz 0d8a1bbfa1 fix(ssh): discard transport on unforward failure and attach PF lifecycle early
Remote unforward callback errors now discard the shared transport like
timeouts, so a half-open remote listen cannot be idle-parked. Shared
port-forward reuse attaches close/error lifecycle before bind so mid-listen
transport drops cannot leave zombie local listeners.
2026-07-28 18:57:14 +08:00
bincxz 20cfd39280 fix(ssh): require exact agentForwarding match for shell reuse
Shell and parked-shell lookup now use endpointAllowsReuse(..., "shell") so
disabling ForwardAgent cannot reattach to a warm conn that still exposes the
local agent. SFTP/port-forward keep asymmetric channel reuse so they can still
borrow a ForwardAgent-enabled terminal transport.
2026-07-28 18:57:14 +08:00
bincxz 9ecc9dbb04 fix(ssh): block transport reuse when agentForwarding is required
Store agentForwarding on the session/transport endpoint and apply an
asymmetric reuse check: opens that need ForwardAgent reject parked conns
that never enabled it, while SFTP/port-forward can still borrow a
ForwardAgent-enabled terminal transport.
2026-07-28 18:57:14 +08:00
bincxz 990bbe5f50 fix(ssh): match transfer source by endpoint and await late unforward
Transfer pool source sessions now require hostname/user/port parity so
multi-tab or overridden endpoints do not borrow the wrong shared transport.
Remote forward cancel-during-forwardIn and stop paths share one timed
unforward helper that discards the transport when the server listen stalls.
2026-07-28 18:57:14 +08:00
bincxz aaf597eb64 fix(ssh): include auth policy in transport keys and migrate TTL
Fingerprint auth type, key id, MFA, agent, and host-key verification so
parked transports cannot bypass profile security edits. Migrate legacy
transfer-pool idle TTL into the SSH keep-alive setting on upgrade.
2026-07-28 18:57:14 +08:00
bincxz 12fd9af5a7 fix(ssh): unique lease ids and discard on unforward timeout
Avoid shell/sftp lease id collisions across reconnect generations, and
discard the shared transport when remote unforward cannot be confirmed
within the stop timeout.
2026-07-28 18:57:14 +08:00
bincxz 6aaaaaeaae fix(ssh): bound remote unforwardIn wait during tunnel stop
Avoid hanging stopPortForward on half-open shared transports by racing
unforwardIn against a 5s timeout, then continuing lease cleanup.
2026-07-28 18:57:14 +08:00
bincxz 84c476ebf2 fix(ssh): ignore late PF bind after cancel on shared transport
If the user stops a shared local/dynamic/remote forward while listen or
forwardIn is still pending, close the listener and resolve cancelled
instead of re-registering the tunnel as active.
2026-07-28 18:57:14 +08:00
bincxz fde7d01e6d fix(ssh): destroy active PF pipes and harden idle/proxy identity
Track accepted forward sockets per tunnel and destroy them on stop, end
already-dead transports instead of parking them, and fingerprint
command-proxy routes so edits invalidate warm reuse.
2026-07-28 18:57:14 +08:00
bincxz 5ceba804db fix(ssh): guard PF bind registration and jump-route fingerprints
Catch transport registration failures inside async bind callbacks so a
dead shared socket cannot crash the main process, and fingerprint jump
hops by both vault id and effective endpoint/proxy.
2026-07-28 18:57:14 +08:00
bincxz da54ff8ea3 fix(ssh): harden shared-transport routing and lifecycle
Include proxy/jump profile identity in transport keys, normalize loopback
remote-forward addresses, detach shared listeners on cancel, and avoid
MFA-retrying dedicated dials for local bind failures.
2026-07-28 18:57:14 +08:00
bincxz 0c0bde9c1c fix(ssh): finish Codex review cleanups for shared tunnels
Attach error/close lifecycle to reused port-forward transports, match
wildcard remote binds by expected listen address, and end unusable
transports whose sockets are destroyed during lookup.
2026-07-28 18:57:14 +08:00
bincxz 0f01dbbf7d fix(ssh): address Codex review on transport reuse safety
Scope transport keys by vault hostId so different profiles cannot share
an authenticated connection. Fix createConnectionRef to preserve hostId.
Route remote-forward accepts by destPort/bind address, await unforwardIn
before success, return stopAllPortForwards as a promise, and update
async cancel tests.
2026-07-28 18:57:14 +08:00
bincxz 3f706abfeb feat(ssh): unify transport leases and converge transfer keep-alive
Introduce a main-process SSH transport registry (borrow/return leases,
ControlPersist-style idle park) shared by shell, SFTP, transfer, and
port-forward. Transfer pool becomes channel concurrency only; remove the
separate transfer-pool idle TTL UI in favor of a single SSH keep-alive
setting. Register dedicated SFTP dials, reuse parked transports, and fix
TTL 0 (park until quit), jump-host endpoint keys, and remote unforwardIn.
2026-07-28 18:57:14 +08:00
陈大猫andClaude b77f0d97db fix(terminal): suppress autocomplete on alternate screen (#2530) (#2565)
* fix(terminal): suppress autocomplete popup on alternate screen (#2530)

Codex CLI's TUI (and other full-screen apps like vim/htop/less) render
their own input UI on the alternate screen buffer. Netcatty's autocomplete
only gated on its shell-prompt heuristic, which codex's composer line
matches — so typing "/" inside codex popped up Netcatty's path/command
list on top of codex's slash-command menu.

Bail out of fetchSuggestions (the single query path for both popup and
ghost text) when term.buffer.active is the alternate buffer. Reuses the
existing isTerminalAlternateScreenActive helper already used by hibernate.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(terminal): keep simple alt-screen autocomplete ban (#2530)

Drop the bloated TUI-vs-multiplexer heuristics from the codex auto-fix loop.
Disable autocomplete unconditionally on the alternate screen buffer — same
simple tradeoff as other hosts; tmux/screen attach has no Netcatty completions.

* fix(terminal): drop alt-screen completions after async lookup too

Same unconditional policy as the entry gate: if the buffer switched to
alternate while getCompletions was in flight, discard results so popup/ghost
cannot paint over a TUI. #2530

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-28 13:49:13 +08:00
Eric ChanandCursor 64148a1d8b fix(ai): route auto-detected network devices to raw PTY exec (#2367) (#2564)
* fix(ai): route auto-detected network devices to raw PTY exec (#2367)

AI exec paths (Catty, worker, MCP) decide whether to send commands raw
(no shell wrapping) based on meta.deviceType === "network". That field
only reflected the manual Network Device Mode toggle (host.deviceType),
so auto-detected switches (Huawei VRP, Cisco IOS, …) still went through
the POSIX shell wrapper. Their vendor CLIs reject the wrapped command,
the start marker never arrives, and the call stalls until the startup
timeout.

Report deviceType: "network" when the detected distro/vendor classifies
as a network device too, mirroring the terminal's own gating. This also
gives the AI system prompt vendor-CLI guidance before the user manually
flips the toggle. Mosh/ET sessions stay suppressed since they require a
shell-backed PTY.

Extract the pure buildAITerminalSessionInfo helper into its own module
for testability and add unit coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(ai): guard network-device classification against substring false positives

Address Codex review: replace non-ASCII ellipsis with ASCII per the
ASCII-only convention, and add a regression test proving classification
is exact-match against the vendor id list (so a custom distro that merely
embeds "cisco"/"huawei" is not treated as a network device).

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-28 13:11:53 +08:00
Netcatty-Botandnetcatty-bot 141c790921 fix(#2562): automated Cursor CLI fix (#2563)
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 11:57:44 +08:00
陈大猫andnetcatty-bot aaff0edc7f perf(vault): virtualize host pickers for large inventories (#2553)
* perf(vault): virtualize host pickers for large inventories

Virtualize Select Host, Quick Switcher, SFTP host picker, and workspace
dialogs so thousands of hosts only mount a viewport window. Shared scroll
and keyboard clamp helpers keep selection and filter-while-scrolled paths
stable under virtualization.

* fix: address Codex review on PR #2553

* fix(vault): plugin row heights and Select Host keyboard types

Give Quick Switcher plugin command/view rows a taller virtual slot so
two-line chrome does not overflow into the next absolute row. Narrow
Select Host navigable rows to group|host so Enter keyboard activation
typechecks cleanly.

* fix(vault): finish host-picker review feedback

Clip and truncate fixed-height Quick Switcher / workspace rows so long
labels never overlap the next virtual slot. Wire Select Host listbox
aria-activedescendant to stable option ids for keyboard AT feedback.

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix(vault): clear remaining host-picker codex findings

Declare multi-select listboxes, drop empty SFTP Hosts headers when only
connected rows remain, size the SFTP list to content under a 360px cap,
and give Quick Switcher / workspace pickers a definite max scroll height
so large inventories remain reachable.

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 11:48:01 +08:00
itzhang89andCursor 05f406ebab fix(ai): use writable temp workspace for Cursor CLI MCP (#2558)
Packaged Netcatty launched from Finder often has process.cwd() === "/", so
merging .cursor/mcp.json failed silently and netcatty-remote-hosts never
mounted. Point CLI turns at Netcatty temp and fail loudly on merge errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-28 11:35:17 +08:00
陈大猫andnetcatty-bot 13b8e26fb4 chore: switch .gitignore to allowlist layout (#2554)
* chore: switch .gitignore to allowlist layout

Default-deny root paths so a mistaken git add cannot pick up secrets,
agent state, or build artifacts. Re-include only known source paths and
keep the existing classical denylist for nested outputs.

Closes #2534

* fix: address Codex review on PR #2554

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 02:36:27 +08:00
陈大猫andnetcatty-bot 3b51079c51 feat(snippets): open quick add/edit as a centered modal (#2552)
* feat(snippets): open quick add/edit as a centered modal

Replace the scripts side-panel AsidePanel drawer with a Dialog so
snippet create/edit no longer slides over the terminal workspace, while
keeping the same form fields and shortkey capture behavior.

* fix: address Codex review on PR #2552

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 01:39:02 +08:00
陈大猫 8cdc887383 [Feature] Optimize large Vault imports and group management (#2540)
* feat(vault): optimize large imports and vault rendering (#2526)

* fix(vault): address import review findings

* fix(vault): preserve filtered selection and import consistency

* fix(vault): complete import review fixes

* fix(vault): make import cancellation concurrency-safe

* fix(vault): preserve concurrent edits during import rollback

* fix(vault): handle concurrent saves and reset import target

* fix(vault): drop empty source groups after targeted import

* fix(vault): preserve sidebar accessibility check

* fix(vault): correct group counts and selection semantics

* fix(vault): preserve imports across concurrent saves

* fix(vault): preserve concurrent group changes during import

* fix(vault): close concurrent import edge cases

* fix(vault): retry rollback and enable tree keyboard selection

* fix(vault): retain concurrent sources and visible selections

* fix(vault): merge imported sources with persisted state

* fix(vault): serialize duplicate managed imports

* fix(vault): keep imports non-blocking and grouped views responsive

* fix(vault): preserve concurrent managed sessions

* fix(vault): preserve concurrent groups and keyboard access

* fix(vault): serialize cross-window import commits

* fix(vault): make import commits atomic

* fix(vault): surface import rollback failures

* fix(vault): recover import transactions safely

* fix(vault): commit imported hosts atomically

* fix(vault): preserve unfinished import recovery

* fix(vault): wait for edits and preserve keyboard focus

* fix(vault): protect group settings and lock fallback

* fix(vault): keep virtual focus aligned

* fix(vault): complete keyboard navigation semantics

* fix(vault): finish keyboard navigation

* fix(vault): close large-vault concurrency gaps

* fix(vault): finish large-vault interaction safety

* fix(vault): harden filtered large-vault flows

* fix(vault): keep managed deletion atomic

* fix(vault): coordinate managed file deletion

* fix(vault): close cross-window managed races

* fix(vault): refresh persisted managed state

* fix(vault): preserve distinct imported sessions

* fix(vault): keep failed progress accurate

* fix(vault): keep search tree collapsible

* fix(vault): close final review gaps

* fix(vault): reveal filtered tree matches

* fix(vault): close final review edge cases

* fix(vault): preserve concurrent import changes

* fix(vault): serialize all vault saves under one cross-window lock

Hold the shared import lock for ordinary host/group/key writes and the
full import commit path so check-then-write can no longer interleave
across windows. Make the lock re-entrant in-window to avoid nested
deadlocks, and announce large tree item positions for screen readers.

* fix(vault): keep concurrent saves serialized and fix tree ARIA siblings

Stop treating same-window concurrent work as nested lock re-entry; nested
helpers skip re-acquire only when the outer critical section already owns
the lock. Announce treeitem position among true siblings at each level.

* fix(vault): require explicit lock handle for nested saves

Independent concurrent vault writes always queue on the shared lock.
Nested import/deletion helpers continue only when they pass the active
lock handle from their outer critical section.

* fix(vault): avoid lock deadlocks with encrypt-then-write saves

Encrypt outside the shared lock and only acquire it for the final write so
importers waiting on pending work cannot deadlock on lock acquisition.
Retry plugin commits outside the lock when concurrent edits intervene, and
rebase imports onto in-memory host edits when disk is still stale.

* fix(vault): release import lock before concurrent-edit retries

Drain encrypt work under the lock and full disk writes only outside it.
When an import or group deletion is superseded by a concurrent edit, release
the shared lock so that edit can finish, then retry. Functional group updates
now base on the latest in-memory snapshot while a write is still pending.

* fix(vault): tidy import dialog destination and SecureCRT prompts

Move import destination settings behind a bottom-left control with its own
step, and keep SecureCRT guidance in a dedicated chooser instead of inside
the format tile.

* test(vault): fix import dialog layout guard test under ESM

* fix(vault): simplify import destination footer control

Replace the heavy two-line destination card with a single quiet text link
that shows the current placement choice.

* fix(vault): simplify import destination settings page

Drop the nested card and duplicate headings. Show only the three placement
choices, finish immediately for preserve, and keep Done only when a group
name is needed.

* fix(vault): simplify SecureCRT chooser and iconify destination options

Remove redundant SecureCRT prompt copy while keeping the two source cards
with icons. Add small folder icons to the import-location choices so that
page is less plain.

* fix(vault): use SecureCRT logo in import chooser header

* fix(vault): drop border around SecureCRT import logo

* fix(vault): clarify import location footer with icon and label

Show a folder icon plus "Import location · current choice" so the control
is recognizable without becoming a heavy card again.

* fix(vault): remove border from import progress status icon
2026-07-28 00:54:03 +08:00
陈大猫andnetcatty-bot d6efb6a313 fix(terminal): keep Enter reconnect working after disconnect (#2550)
* fix(terminal): keep Enter reconnect working after disconnect

Disconnected sessions advertised "Press Enter to reconnect" but often
swallowed the key when focus left xterm (body blur or dialog controls),
and an open terminal search bar globally hid the hint and disabled the
shortcut. Give the disconnected overlay a focus sink + local Enter
handler, and stop treating search-open as a global reconnect gate while
still leaving real buttons/inputs alone.

Closes #2544
Closes #2546

* fix(terminal): stop disconnected dialog focus theft

Only claim Enter-reconnect focus when it is already lost or still inside
this session tree, and restore xterm focus when the overlay unmounts.
Avoid stealing focus from other panes/side panels on disconnect.

* fix(terminal): restore dialog focus only when overlay leaves

Split claim/restore effects so showLogs/error rerenders no longer
yank focus off dialog buttons onto xterm mid-interaction.

* fix(terminal): restore Enter-reconnect focus in popup terminals

Popup Terminal windows lack data-session-id ancestors. Walk up from
the dialog to the local xterm root so claim/restore still work there.

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 00:20:02 +08:00
陈大猫 e74859f786 fix(ci): proxy GitHub screenshots before research (#2551) 2026-07-27 23:15:25 +08:00
陈大猫andgithub-actions[bot] 1801bfe427 chore: update star history charts [skip ci] (#2549)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2026-07-27 22:09:51 +08:00
陈大猫 f91913171b fix(ci): use GITHUB_TOKEN for star history PRs (#2548)
RELEASE_TOKEN can push the chart branch and read stargazers, but lacks
createPullRequest. Keep it for git push; open/merge PRs with GITHUB_TOKEN.
2026-07-27 22:08:20 +08:00
陈大猫 044a2851d1 fix(ci): update star history via PR on protected main (#2547)
Direct pushes to main fail with GH006 because the branch requires PRs
(with admin enforcement). Open or reuse chore/star-history and squash-merge.
2026-07-27 22:05:52 +08:00
陈大猫 5a580ce923 feat(windows): add Explorer open-in-terminal menu
Closes #2513
2026-07-27 19:59:15 +08:00
陈大猫 b838a60e7c Merge pull request #2539 from binaricat/codex/fix-cursor-research-output
fix(ci): accept fenced Cursor research status
2026-07-27 19:53:15 +08:00
陈大猫 2e5ee809a3 Merge pull request #2543 from binaricat/codex/signpath-policy
docs: add privacy and code signing policies
2026-07-27 19:52:51 +08:00
bincxz 709c7ec097 docs: add privacy and code signing policies 2026-07-27 19:45:44 +08:00
bincxz 93f23b9312 fix(ci): require identical research candidates 2026-07-27 19:39:58 +08:00
陈大猫 9eb83d7bce Merge pull request #2537 from binaricat/codex/issue-2506-font-search
feat(settings): add searchable font pickers
2026-07-27 19:37:38 +08:00
bincxz 7c90d40159 fix(ci): validate all research status candidates 2026-07-27 19:37:30 +08:00
bincxz 2d3316093c fix(ci): reject conflicting research statuses 2026-07-27 19:34:32 +08:00
bincxz 0bb06dca72 fix(ci): prefer rebuilt final research fence 2026-07-27 19:31:20 +08:00
bincxz 0d2c435687 fix(ci): parse Cursor partial stream boundaries 2026-07-27 19:28:10 +08:00
bincxz 2d5590a84c fix: reselect restored font value after closing search 2026-07-27 19:26:20 +08:00
bincxz f2c47d2ab7 fix(ci): distinguish Cursor final flushes 2026-07-27 19:23:21 +08:00