mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
* feat: expose advanced AI model parameters in provider settings (#532) Add collapsible "Advanced Parameters" section to provider config with optional max_tokens, temperature, top_p, frequency_penalty, and presence_penalty fields. Parameters are merged into streamText() calls only when explicitly set, otherwise provider defaults apply. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use maxOutputTokens instead of maxTokens for ai@6 SDK The streamText CallSettings in ai@6 expects maxOutputTokens, not maxTokens. Without this fix the user's max_tokens setting is silently ignored. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: allow negative penalty input and clamp params on save - Use raw string state for penalty fields so typing "-" is not discarded before the digit is entered - Clamp all parameters to valid ranges on save (temperature 0-2, topP 0-1, penalties -2 to 2) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use raw string state for all numeric advanced param inputs Prevents intermediate text like "0." from being normalized to "0" during keyboard entry of decimal values for temperature, topP, and maxTokens fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: clamp max_tokens to minimum of 1 after rounding Prevents Math.round(0.4) = 0 from being persisted and causing streamText to reject with "maxOutputTokens must be >= 1". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reject non-finite max_tokens before persisting Guard with Number.isFinite to prevent Infinity from being stored and forwarded to streamText. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
267 lines
13 KiB
TypeScript
267 lines
13 KiB
TypeScript
import React, { useCallback, useEffect, useState } from "react";
|
||
import { Check, ChevronDown, ChevronRight, Eye, EyeOff } from "lucide-react";
|
||
import type { ProviderConfig, ProviderAdvancedParams } from "../../../../infrastructure/ai/types";
|
||
import { PROVIDER_PRESETS } from "../../../../infrastructure/ai/types";
|
||
import { encryptField, decryptField } from "../../../../infrastructure/persistence/secureFieldAdapter";
|
||
import { useI18n } from "../../../../application/i18n/I18nProvider";
|
||
import { Button } from "../../../ui/button";
|
||
import type { ProviderFormState } from "./types";
|
||
import { ModelSelector } from "./ModelSelector";
|
||
|
||
export const ProviderConfigForm: React.FC<{
|
||
provider: ProviderConfig;
|
||
onSave: (updates: Partial<ProviderConfig>) => void;
|
||
onCancel: () => void;
|
||
}> = ({ provider, onSave, onCancel }) => {
|
||
const { t } = useI18n();
|
||
const [form, setForm] = useState<ProviderFormState>({
|
||
name: provider.name ?? PROVIDER_PRESETS[provider.providerId]?.name ?? "",
|
||
apiKey: "",
|
||
baseURL: provider.baseURL ?? PROVIDER_PRESETS[provider.providerId]?.defaultBaseURL ?? "",
|
||
defaultModel: provider.defaultModel ?? "",
|
||
skipTLSVerify: provider.skipTLSVerify ?? false,
|
||
advancedParams: provider.advancedParams ?? {},
|
||
});
|
||
const isCustom = provider.providerId === "custom";
|
||
const [showApiKey, setShowApiKey] = useState(false);
|
||
const [isDecrypting, setIsDecrypting] = useState(false);
|
||
const [showAdvanced, setShowAdvanced] = useState(false);
|
||
|
||
const preset = PROVIDER_PRESETS[provider.providerId];
|
||
|
||
// Decrypt and load existing API key on mount
|
||
useEffect(() => {
|
||
if (provider.apiKey) {
|
||
setIsDecrypting(true);
|
||
decryptField(provider.apiKey)
|
||
.then((decrypted) => {
|
||
setForm((prev) => ({ ...prev, apiKey: decrypted ?? "" }));
|
||
})
|
||
.catch(() => {
|
||
// If decryption fails, show raw value
|
||
setForm((prev) => ({ ...prev, apiKey: provider.apiKey ?? "" }));
|
||
})
|
||
.finally(() => setIsDecrypting(false));
|
||
}
|
||
}, [provider.apiKey]);
|
||
|
||
const [advancedParamRaw, setAdvancedParamRaw] = useState<Record<string, string>>({});
|
||
const handleAdvancedParam = useCallback((key: keyof ProviderAdvancedParams, raw: string) => {
|
||
setAdvancedParamRaw((prev) => ({ ...prev, [key]: raw }));
|
||
setForm((prev) => {
|
||
const next = { ...prev.advancedParams };
|
||
if (raw.trim() === "" || raw.trim() === "-") {
|
||
delete next[key];
|
||
} else {
|
||
const num = Number(raw);
|
||
if (!Number.isNaN(num)) {
|
||
next[key] = num;
|
||
}
|
||
}
|
||
return { ...prev, advancedParams: next };
|
||
});
|
||
}, []);
|
||
|
||
const handleSave = useCallback(async () => {
|
||
const cleanedParams: ProviderAdvancedParams = {};
|
||
const ap = form.advancedParams;
|
||
if (ap.maxTokens != null && Number.isFinite(ap.maxTokens) && ap.maxTokens > 0) cleanedParams.maxTokens = Math.max(1, Math.round(ap.maxTokens));
|
||
if (ap.temperature != null) cleanedParams.temperature = Math.min(2, Math.max(0, ap.temperature));
|
||
if (ap.topP != null) cleanedParams.topP = Math.min(1, Math.max(0, ap.topP));
|
||
if (ap.frequencyPenalty != null) cleanedParams.frequencyPenalty = Math.min(2, Math.max(-2, ap.frequencyPenalty));
|
||
if (ap.presencePenalty != null) cleanedParams.presencePenalty = Math.min(2, Math.max(-2, ap.presencePenalty));
|
||
|
||
const updates: Partial<ProviderConfig> = {
|
||
baseURL: form.baseURL || undefined,
|
||
defaultModel: form.defaultModel || undefined,
|
||
skipTLSVerify: form.skipTLSVerify || undefined,
|
||
advancedParams: Object.keys(cleanedParams).length > 0 ? cleanedParams : undefined,
|
||
...(isCustom && form.name.trim() ? { name: form.name.trim() } : {}),
|
||
};
|
||
|
||
// Encrypt API key before saving
|
||
if (form.apiKey) {
|
||
updates.apiKey = await encryptField(form.apiKey);
|
||
} else {
|
||
updates.apiKey = undefined;
|
||
}
|
||
|
||
onSave(updates);
|
||
}, [form, onSave, isCustom]);
|
||
|
||
return (
|
||
<div className="mt-3 space-y-3 border-t border-border/40 pt-3">
|
||
{/* Name (custom providers only) */}
|
||
{isCustom && (
|
||
<div className="space-y-1.5">
|
||
<label className="text-xs font-medium text-muted-foreground">{t('ai.providers.name')}</label>
|
||
<input
|
||
type="text"
|
||
value={form.name}
|
||
onChange={(e) => setForm((prev) => ({ ...prev, name: e.target.value }))}
|
||
placeholder={t('ai.providers.name.placeholder')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
)}
|
||
{/* API Key */}
|
||
<div className="space-y-1.5">
|
||
<label className="text-xs font-medium text-muted-foreground">{t('ai.providers.apiKey')}</label>
|
||
<div className="flex items-center gap-2">
|
||
<div className="relative flex-1">
|
||
<input
|
||
type={showApiKey ? "text" : "password"}
|
||
value={isDecrypting ? "" : form.apiKey}
|
||
onChange={(e) => setForm((prev) => ({ ...prev, apiKey: e.target.value }))}
|
||
placeholder={isDecrypting ? t('ai.providers.apiKey.decrypting') : t('ai.providers.apiKey.placeholder')}
|
||
disabled={isDecrypting}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 pr-9 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:opacity-50"
|
||
/>
|
||
<button
|
||
type="button"
|
||
onClick={() => setShowApiKey(!showApiKey)}
|
||
className="absolute right-2 top-1/2 -translate-y-1/2 text-muted-foreground hover:text-foreground"
|
||
>
|
||
{showApiKey ? <EyeOff size={14} /> : <Eye size={14} />}
|
||
</button>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
{/* Base URL */}
|
||
<div className="space-y-1.5">
|
||
<label className="text-xs font-medium text-muted-foreground">{t('ai.providers.baseUrl')}</label>
|
||
<input
|
||
type="text"
|
||
value={form.baseURL}
|
||
onChange={(e) => setForm((prev) => ({ ...prev, baseURL: e.target.value }))}
|
||
placeholder={preset?.defaultBaseURL || "https://"}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
|
||
{/* Default Model */}
|
||
<div className="space-y-1.5">
|
||
<label className="text-xs font-medium text-muted-foreground">{t('ai.providers.defaultModel')}</label>
|
||
<ModelSelector
|
||
value={form.defaultModel}
|
||
onChange={(val) => setForm((prev) => ({ ...prev, defaultModel: val }))}
|
||
baseURL={form.baseURL || preset?.defaultBaseURL || ""}
|
||
modelsEndpoint={preset?.modelsEndpoint}
|
||
apiKey={form.apiKey}
|
||
providerId={provider.providerId}
|
||
skipTLSVerify={form.skipTLSVerify}
|
||
/>
|
||
</div>
|
||
|
||
{/* Skip TLS Verification */}
|
||
<label className="flex items-center gap-2 cursor-pointer">
|
||
<input
|
||
type="checkbox"
|
||
checked={form.skipTLSVerify}
|
||
onChange={(e) => setForm((prev) => ({ ...prev, skipTLSVerify: e.target.checked }))}
|
||
className="rounded border-input"
|
||
/>
|
||
<span className="text-xs text-muted-foreground">{t('ai.providers.skipTLSVerify')}</span>
|
||
</label>
|
||
|
||
{/* Advanced Parameters */}
|
||
<div className="space-y-2">
|
||
<button
|
||
type="button"
|
||
onClick={() => setShowAdvanced(!showAdvanced)}
|
||
className="flex items-center gap-1.5 text-xs font-medium text-muted-foreground hover:text-foreground transition-colors"
|
||
>
|
||
{showAdvanced ? <ChevronDown size={14} /> : <ChevronRight size={14} />}
|
||
{t('ai.providers.advancedParams')}
|
||
</button>
|
||
{showAdvanced && (
|
||
<div className="space-y-2.5 pl-1 border-l-2 border-border/40 ml-1">
|
||
<p className="text-[11px] text-muted-foreground/70 pl-3">{t('ai.providers.advancedParams.hint')}</p>
|
||
{/* max_tokens */}
|
||
<div className="space-y-1 pl-3">
|
||
<label className="text-xs text-muted-foreground">max_tokens</label>
|
||
<input
|
||
type="number"
|
||
min={1}
|
||
step={1}
|
||
value={advancedParamRaw.maxTokens ?? (form.advancedParams.maxTokens != null ? String(form.advancedParams.maxTokens) : "")}
|
||
onChange={(e) => handleAdvancedParam("maxTokens", e.target.value)}
|
||
placeholder={t('ai.providers.advancedParams.maxTokens.placeholder')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
{/* temperature */}
|
||
<div className="space-y-1 pl-3">
|
||
<label className="text-xs text-muted-foreground">temperature <span className="text-muted-foreground/50">(0–2)</span></label>
|
||
<input
|
||
type="number"
|
||
min={0}
|
||
max={2}
|
||
step={0.1}
|
||
value={advancedParamRaw.temperature ?? (form.advancedParams.temperature != null ? String(form.advancedParams.temperature) : "")}
|
||
onChange={(e) => handleAdvancedParam("temperature", e.target.value)}
|
||
placeholder={t('ai.providers.advancedParams.default')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
{/* top_p */}
|
||
<div className="space-y-1 pl-3">
|
||
<label className="text-xs text-muted-foreground">top_p <span className="text-muted-foreground/50">(0–1)</span></label>
|
||
<input
|
||
type="number"
|
||
min={0}
|
||
max={1}
|
||
step={0.05}
|
||
value={advancedParamRaw.topP ?? (form.advancedParams.topP != null ? String(form.advancedParams.topP) : "")}
|
||
onChange={(e) => handleAdvancedParam("topP", e.target.value)}
|
||
placeholder={t('ai.providers.advancedParams.default')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
{/* frequency_penalty */}
|
||
<div className="space-y-1 pl-3">
|
||
<label className="text-xs text-muted-foreground">frequency_penalty <span className="text-muted-foreground/50">(-2–2)</span></label>
|
||
<input
|
||
type="number"
|
||
min={-2}
|
||
max={2}
|
||
step={0.1}
|
||
value={advancedParamRaw.frequencyPenalty ?? (form.advancedParams.frequencyPenalty != null ? String(form.advancedParams.frequencyPenalty) : "")}
|
||
onChange={(e) => handleAdvancedParam("frequencyPenalty", e.target.value)}
|
||
placeholder={t('ai.providers.advancedParams.default')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
{/* presence_penalty */}
|
||
<div className="space-y-1 pl-3">
|
||
<label className="text-xs text-muted-foreground">presence_penalty <span className="text-muted-foreground/50">(-2–2)</span></label>
|
||
<input
|
||
type="number"
|
||
min={-2}
|
||
max={2}
|
||
step={0.1}
|
||
value={advancedParamRaw.presencePenalty ?? (form.advancedParams.presencePenalty != null ? String(form.advancedParams.presencePenalty) : "")}
|
||
onChange={(e) => handleAdvancedParam("presencePenalty", e.target.value)}
|
||
placeholder={t('ai.providers.advancedParams.default')}
|
||
className="w-full h-8 rounded-md border border-input bg-background px-3 text-sm placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
|
||
/>
|
||
</div>
|
||
</div>
|
||
)}
|
||
</div>
|
||
|
||
{/* Actions */}
|
||
<div className="flex items-center gap-2 pt-1">
|
||
<Button variant="default" size="sm" onClick={() => void handleSave()}>
|
||
<Check size={14} className="mr-1.5" />
|
||
{t('common.save')}
|
||
</Button>
|
||
<Button variant="ghost" size="sm" onClick={onCancel}>
|
||
{t('common.cancel')}
|
||
</Button>
|
||
</div>
|
||
</div>
|
||
);
|
||
};
|