Files
Netcatty/components/keychain/IdentityPanel.tsx
T
陈大猫andClaude Opus 4.7 ea5320d94a Fix #954: unify Tooltip styling + replace native selects (#961)
* Fix #954: unify Tooltip styling + replace native selects

Replace native HTML title= tooltips and native <select> dropdowns
with the existing Radix-based Tooltip / Select components so they
share the app's rounded styling, theme tokens and i18n pipeline.
Adds a global TooltipProvider in AppWithProviders so every
descendant Tooltip works without a per-file Provider wrapper.

Scope (driven by the issue #954 examples and "全部都处理" follow-up):

- TerminalLayer toolbar: Add Terminal / Split View / SFTP / Scripts
  / Theme / AI Chat / Move panel / Close panel.
- TopTabs middle bar: quick switcher, more tabs, AI assistant, theme
  toggle, settings; window-control buttons (min/max/close), tray
  close and hotkey reset/disable have their native title dropped per
  the user's explicit opt-out ("可以不用Tooltip,直接全局禁用
  原生title 属性").
- AI panels: AIChatSidePanel session history / new chat / delete,
  ConversationExport, AgentSelector, ChatInput attach / expand /
  permission, ModelSelector, ProviderCard, ai-elements/tool-call.
- SFTP: SftpSidePanel header, SftpBreadcrumb, SftpFileRow,
  SftpPaneToolbar, SftpTabBar, SftpTransferQueue.
- Settings: SettingsPage close, SettingsAppearanceTab theme/accent
  swatches, SettingsFileAssociationsTab edit/remove, SettingsSystemTab
  crash-log paths and global hotkey reset.
- Host vault: HostDetailsPanel (clear / suggestions / show-password /
  key path / browse key), GroupDetailsPanel, KnownHostsManager,
  ConnectionLogsManager, KeychainManager, SyncStatusButton,
  CloudSyncSettings, LogView, QuickSwitcher, ScriptsSidePanel,
  Terminal status bar copy-host + broadcast/focus, ZmodemProgressIndicator.
- Terminal subcomponents: HostKeywordHighlightPopover, TerminalComposeBar,
  TerminalConnectionDialog, TerminalSearchBar.
- Editor: TextEditorPane (subtitle, search, wrap, promote-to-tab).
- TrayPanel session rows and port-forwarding rows.

Native <select> migrated to custom Select component:
- SerialConnectModal (data bits, stop bits, parity, flow control)
- SerialHostDetailsPanel (same four fields)
- HostDetailsPanel backspace behavior
- GroupDetailsPanel backspace behavior
- SettingsTerminalTab local shell picker
- terminal/ThemeSidePanel font weight

Hardcoded English strings extracted to i18n. New keys for both
en and zh-CN: terminal.layer.*, topTabs.*, ai.chat.* (sessionHistory,
attach, collapse, expand, enableAgent), zmodem.*, settings.shortcuts.
resetToDefault. Inline help text on SnippetsManager package-name input
removed because the same hint is already shown in a visible <p> below
the input.

Existing per-file <TooltipProvider> wrappers (SnippetsManager,
ScriptsSidePanel, SelectHostPanel, RuleCard, HostDetailsPanel proxy
section) are left in place — they nest harmlessly under the global
provider and stay self-sufficient for component tests.

Tests:
- tsc clean for changed files (pre-existing repo-wide errors
  unrelated to this PR).
- All 802 tests pass (3 skipped pre-existing).
- HostDetailsPanel.proxyProfile.test and TextEditorPane.test
  updated to wrap with TooltipProvider, matching the runtime
  context now needed by the migrated components.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix #954: wrap Settings + Tray windows with TooltipProvider

Settings and the tray panel mount as separate Electron windows with
their own React root in index.tsx, so they do not inherit the global
TooltipProvider added under AppWithProviders. After the unified
Tooltip migration, any settings tab that used a Tooltip (Appearance,
Application, FileAssociations, System, Shortcuts, Terminal, AI
ProviderCard, AI ModelSelector) — and TrayPanel — threw
"Tooltip must be used within TooltipProvider" and rendered nothing.

Wrap both branches with TooltipProvider at the same level as
ToastProvider in index.tsx.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:14:24 +08:00

268 lines
12 KiB
TypeScript

/**
* Identity Panel - Create/Edit identity
*/
import { Eye,EyeOff,Key,Plus,Shield,User,X } from 'lucide-react';
import React,{ useMemo,useState } from 'react';
import { useI18n } from '../../application/i18n/I18nProvider';
import { Identity,SSHKey } from '../../types';
import { Button } from '../ui/button';
import { Combobox } from '../ui/combobox';
import { Input } from '../ui/input';
import { Label } from '../ui/label';
import { Popover,PopoverContent,PopoverTrigger } from '../ui/popover';
import { Tooltip, TooltipContent, TooltipTrigger } from '../ui/tooltip';
interface IdentityPanelProps {
draftIdentity: Partial<Identity>;
setDraftIdentity: (identity: Partial<Identity>) => void;
keys: SSHKey[];
showPassphrase: boolean;
setShowPassphrase: (show: boolean) => void;
isNew: boolean;
onSave: () => void;
}
export const IdentityPanel: React.FC<IdentityPanelProps> = ({
draftIdentity,
setDraftIdentity,
keys,
showPassphrase,
setShowPassphrase,
isNew,
onSave,
}) => {
const { t } = useI18n();
type CredentialType = 'key' | 'certificate' | null;
const [credentialPopoverOpen, setCredentialPopoverOpen] = useState(false);
const [selectedCredentialType, setSelectedCredentialType] = useState<CredentialType>(null);
const selectedKey = useMemo(() => {
if (!draftIdentity.keyId) return undefined;
return keys.find(k => k.id === draftIdentity.keyId);
}, [draftIdentity.keyId, keys]);
const keysByCategory = useMemo(() => {
return {
key: keys.filter(k => k.category === 'key' && !k.certificate),
certificate: keys.filter(k => k.category === 'certificate' || !!k.certificate),
};
}, [keys]);
const clearSelectedKey = () => {
setDraftIdentity({
...draftIdentity,
keyId: undefined,
authMethod: 'password',
});
setSelectedCredentialType(null);
setCredentialPopoverOpen(false);
};
const setSelectedKeyId = (keyId: string, kind: Exclude<CredentialType, null>) => {
setDraftIdentity({
...draftIdentity,
keyId: keyId || undefined,
authMethod: kind === 'certificate' ? 'certificate' : 'key',
});
setSelectedCredentialType(null);
setCredentialPopoverOpen(false);
};
return (
<>
<div className="flex items-center gap-3 mb-4">
<div className="h-10 w-10 rounded-lg bg-green-500/15 text-green-500 flex items-center justify-center">
<User size={20} />
</div>
<Input
value={draftIdentity.label || ''}
onChange={e => setDraftIdentity({ ...draftIdentity, label: e.target.value })}
placeholder={t('keychain.field.label')}
className="flex-1"
/>
</div>
<div className="space-y-2">
<Label>{t('keychain.identity.usernameRequired')}</Label>
<div className="relative">
<User size={14} className="absolute left-3 top-1/2 -translate-y-1/2 text-muted-foreground" />
<Input
value={draftIdentity.username || ''}
onChange={e => setDraftIdentity({ ...draftIdentity, username: e.target.value })}
placeholder={t('terminal.auth.username')}
className="pl-9"
/>
</div>
</div>
<div className="space-y-2">
<Label>{t('terminal.auth.passwordLabel')}</Label>
<div className="relative">
<Input
type={showPassphrase ? 'text' : 'password'}
value={draftIdentity.password || ''}
onChange={e => setDraftIdentity({ ...draftIdentity, password: e.target.value })}
placeholder={t('terminal.auth.password.placeholder')}
className="pr-10"
/>
<Button
type="button"
variant="ghost"
size="icon"
className="absolute right-1 top-1/2 -translate-y-1/2 h-8 w-8"
onClick={() => setShowPassphrase(!showPassphrase)}
>
{showPassphrase ? <EyeOff size={14} /> : <Eye size={14} />}
</Button>
</div>
</div>
{/* Selected credential display */}
{draftIdentity.keyId && (
<div className="flex items-center gap-2 p-2 rounded-md bg-secondary/50 border border-border/60">
{draftIdentity.authMethod === 'certificate' ? (
<Shield size={14} className="text-primary" />
) : (
<Key size={14} className="text-primary" />
)}
<span className="text-sm flex-1 truncate">
{selectedKey?.label || t('hostDetails.credential.missing')}
</span>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-6 w-6"
onClick={clearSelectedKey}
>
<X size={12} />
</Button>
</TooltipTrigger>
<TooltipContent>{t('common.clear')}</TooltipContent>
</Tooltip>
</div>
)}
{/* Credential type selection with inline popover */}
{!draftIdentity.keyId && !selectedCredentialType && (
<Popover open={credentialPopoverOpen} onOpenChange={setCredentialPopoverOpen}>
<PopoverTrigger asChild>
<button
type="button"
className="flex items-center gap-2 text-xs text-muted-foreground hover:text-foreground transition-colors py-1"
>
<Plus size={12} />
<span>{t('hostDetails.credential.keyCertificate')}</span>
</button>
</PopoverTrigger>
<PopoverContent className="w-[200px] p-1" align="start" sideOffset={4}>
<div className="space-y-0.5">
<button
type="button"
className="w-full flex items-center gap-3 px-3 py-2.5 rounded-md hover:bg-secondary/80 transition-colors text-left"
onClick={() => {
setSelectedCredentialType('key');
setCredentialPopoverOpen(false);
}}
>
<Key size={16} className="text-muted-foreground" />
<span className="text-sm font-medium">{t('hostDetails.credential.key')}</span>
</button>
<button
type="button"
className="w-full flex items-center gap-3 px-3 py-2.5 rounded-md hover:bg-secondary/80 transition-colors text-left"
onClick={() => {
setSelectedCredentialType('certificate');
setCredentialPopoverOpen(false);
}}
>
<Shield size={16} className="text-muted-foreground" />
<span className="text-sm font-medium">
{t('hostDetails.credential.certificate')}
</span>
</button>
</div>
</PopoverContent>
</Popover>
)}
{/* Key selection combobox - appears after selecting "Key" type */}
{selectedCredentialType === 'key' && !draftIdentity.keyId && (
<div className="flex items-center gap-1">
<Combobox
options={keysByCategory.key.map(k => ({
value: k.id,
label: k.label,
sublabel: `${k.type}${k.keySize ? ` ${k.keySize}` : ''}`,
icon: <Key size={14} className="text-muted-foreground" />,
}))}
value={draftIdentity.keyId}
onValueChange={(val) => setSelectedKeyId(val, 'key')}
placeholder={t('hostDetails.keys.search')}
emptyText={t('hostDetails.keys.empty')}
icon={<Key size={14} className="text-muted-foreground" />}
className="flex-1"
/>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-8 w-8 shrink-0"
onClick={() => setSelectedCredentialType(null)}
>
<X size={14} />
</Button>
</TooltipTrigger>
<TooltipContent>{t('common.cancel')}</TooltipContent>
</Tooltip>
</div>
)}
{/* Certificate selection combobox */}
{selectedCredentialType === 'certificate' && !draftIdentity.keyId && (
<div className="flex items-center gap-1">
<Combobox
options={keysByCategory.certificate.map(k => ({
value: k.id,
label: k.label,
icon: <Shield size={14} className="text-muted-foreground" />,
}))}
value={draftIdentity.keyId}
onValueChange={(val) => setSelectedKeyId(val, 'certificate')}
placeholder={t('hostDetails.certs.search')}
emptyText={t('hostDetails.certs.empty')}
icon={<Shield size={14} className="text-muted-foreground" />}
className="flex-1"
/>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-8 w-8 shrink-0"
onClick={() => setSelectedCredentialType(null)}
>
<X size={14} />
</Button>
</TooltipTrigger>
<TooltipContent>{t('common.cancel')}</TooltipContent>
</Tooltip>
</div>
)}
<Button
className="w-full h-11"
onClick={onSave}
disabled={!draftIdentity.label?.trim() || !draftIdentity.username?.trim()}
>
{isNew ? t('keychain.identity.save') : t('keychain.identity.update')}
</Button>
</>
);
};