mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-20 07:04:53 +00:00
* feat(vault): let Skills + CLI operate notes with the same approval as MCP Expose vault note list, read, write, and markdown import on the tool CLI so agents can save generated documents only after the user approves. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(vault): keep explicit empty note fields in the CLI A supplied empty string was treated as an omitted flag, so note clears and empty markdown imports never reached the note service. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(vault): allow an explicit empty note body on CLI create notes create --content "" was rejected as a missing flag, so it did not match vault_notes_create. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(vault): stop echoing imported note bodies and recognize leading CLI flags A batch import resent every document over IPC, and a leading --json hid the notes command from artifact inference. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(vault): make note CLI import safe and fail writes cleanly --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
58 lines
2.7 KiB
JavaScript
58 lines
2.7 KiB
JavaScript
"use strict";
|
|
|
|
const test = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
|
|
const {
|
|
VAULT_HOSTS_VS_NOTES_GUIDANCE,
|
|
VAULT_NOTES_CLI_GUIDANCE,
|
|
VAULT_SCRIPTS_GUIDANCE,
|
|
appendVaultAgentGuidance,
|
|
} = require("./vaultAgentGuidance.cjs");
|
|
|
|
test("VAULT_HOSTS_VS_NOTES_GUIDANCE forbids note fallback for host creation", () => {
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /vault_hosts_create/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /NOT vault_notes_create/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /do not silently create a Vault note/i);
|
|
});
|
|
|
|
test("Skills + CLI notes guidance matches the MCP notes rules", () => {
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /notes create or notes update ONLY when the user explicitly wants/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /notes import --attachment-index from attachment list for attached Markdown/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /--content-stdin for generated Markdown/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /Never interpolate note text into a shell command/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /vault host-notes set/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /do not silently create a Vault note/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /vault_notes_import/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /if approval is denied, stop/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /empty --content clears the body/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /notes create requires a body through --content-stdin or an explicit --content/i);
|
|
assert.match(VAULT_NOTES_CLI_GUIDANCE, /notes import accepts an empty --content/i);
|
|
});
|
|
|
|
test("VAULT_HOSTS_VS_NOTES_GUIDANCE routes unknown attached host files through AI extraction", () => {
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /attached/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /unknown/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /extract/i);
|
|
assert.match(VAULT_HOSTS_VS_NOTES_GUIDANCE, /vault_hosts_create/i);
|
|
});
|
|
|
|
test("appendVaultAgentGuidance appends guidance once", () => {
|
|
const once = appendVaultAgentGuidance("Netcatty terminal manager.");
|
|
assert.match(once, /Netcatty terminal manager/);
|
|
assert.match(once, /Vault → Hosts vs Vault → Notes/);
|
|
|
|
const twice = appendVaultAgentGuidance(once);
|
|
assert.equal(twice, once);
|
|
});
|
|
|
|
test("VAULT_SCRIPTS_GUIDANCE prefers explicit wait APIs", () => {
|
|
assert.match(VAULT_SCRIPTS_GUIDANCE, /waitForText\/waitForRegex/);
|
|
assert.doesNotMatch(VAULT_SCRIPTS_GUIDANCE, /sendLine,\s*waitFor,\s*dialogs/);
|
|
});
|
|
|
|
test("VAULT_SCRIPTS_GUIDANCE avoids mustache template braces", () => {
|
|
assert.doesNotMatch(VAULT_SCRIPTS_GUIDANCE, /\{\{/);
|
|
assert.doesNotMatch(appendVaultAgentGuidance("Netcatty terminal manager."), /\{\{/);
|
|
});
|