Files
Netcatty/electron/bridges/windowManager/externalWindows.cjs
T
cc5ad3be16 perf: isolate Terminal hot props, cut memory/jank, and repay architecture debt (#2790)
* refactor: migrate architecture-debt hooks into application/state

Move SFTP Wave A stores/hooks and related vault/AI/terminal/systemManager
hooks out of components into application/state, update importers, and keep
thin deprecated re-exports at the old paths.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* refactor(sftp): align local bookmarks store API with global bookmarks

Export subscribe/get/set/rehydrate helpers from localSftpBookmarks to match
the globalSftpBookmarks external-store pattern.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(electron): reduce baseline memory via spellcheck/GPU/prewarm guards

Disable spellcheck on BrowserWindows and the default session, drop spare
renderers, gate aggressive GPU switches behind NETCATTY_COMPAT_GPU, and make
settings prewarm opt-in via NETCATTY_PREWARM_SETTINGS.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* Isolate notes and customAccent from TerminalLayer hot props

Route vault notes through notesStore (shellHistoryStore pattern) and
app accent through appearanceChromeStore so note edits and accent-drag
ticks no longer rebuild TerminalLayer. Notes/AI slots and Terminal leaves
subscribe locally; VaultView and open-note callbacks stay unchanged.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(ui): cut unnecessary AppView/VaultView/settings re-renders

Stabilize TopTabs close handler, memo AppHostTreeLayer, exclude accent from
settingsVersion, ignore connectionLogs off the logs section, share lastConnected
host refs, and keep rename dialog drafts local so chrome domain stays stable.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* chore: package size, dead code, and consolidation cleanup

Remove unused direct deps, exclude Vite-bundled renderer packages from
electron-builder, delete high-confidence dead code/no-op transfer warm
wiring, consolidate cloud provider IDs and KnownHost/SFTP helpers, and
land UI/AGENTS quick wins (rAF text batching, notes draft debounce,
streaming plain text, tempDirBridge, diagnostics adapter, External MCP
setters).

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: stabilize rAF text batching and diagnostics tests

Polyfill requestAnimationFrame for Node, flush pending text before
steer buffering, bypass rAF while steer is in flight, and stub
global localStorage for AI panel diagnostics adapter tests.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: correct import paths after application/state hook migrations

Migrated vault/AI/system hooks still used components/-relative imports;
point them at repo-root domain/components/types/lib instead.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: address Bugbot/Codex regressions from perf cleanup

- Keep blank Enter from closing RenameDraftDialog; only reset rename state after a non-empty submit
- Flush note drafts before vault mutations so pending title/body edits are not overwritten
- Re-apply appearanceChromeStore accent on appearanceTheme in Terminal, and keep layer themes unaccented

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(notes): flush draft before markdown export paths

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: keep editor-close hotkey ref fresh during render

Assign handleRequestCloseEditorTabRef in render instead of useEffect so
Cmd/Ctrl+W never hits the App stub before the effect runs.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: keep accent in chrome themes without TerminalLayer thrash

Restore accent in globalAppearance for chrome/injection consumers.
Keep resolveFocusedAppearance identity stable across accent drag via
accent ref, while Terminal leaf still re-applies appearanceChromeStore.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: keep compose chrome accent live and merge note renames

Subscribe theme-panel focusedAppearance to appearanceChromeStore so
compose-bar chrome updates during color-picker drag even when
resolveFocusedAppearance identity stays stable. Tree renames now merge
title into the post-flush note instead of replacing from a stale row.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: clear terminal accent when switching back to theme mode

Re-resolve appearanceTheme by catalog id before applyCustomAccent so a
stale baked custom cursor/selection cannot stick after accentMode returns
to theme while TerminalLayer memo ignores accent props.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: register unsaved prompt singleton during render

AppView close handlers call promptUnsavedChanges outside the old
render-prop. Assign the singleton during render so Cmd/Ctrl+W and tab
close never hit the pre-effect null window that auto-cancels.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: keep vault import hooks UI-free and flush notes on teardown

Move ImportOptions into application/state and inject a notifier so
useVaultImportHandlers no longer imports components. Notes drafts also
flush on pagehide/beforeunload when Electron tears down without React
unmount.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: move AI terminal session context builders into domain

buildAITerminalSessionInfo and AIPanelContext now live under domain/ so
application hooks no longer import TerminalLayerSupport and create a
UI → application → UI cycle.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: drop duplicate AIPanelContext type from TerminalLayerSupport

The type is re-exported from domain; the local definition conflicted.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: keep migrated state hooks free of UI-layer imports

Move aiChatStreamingSupport into infrastructure/ai and poll list helpers
into domain/systemManager so useAIChatStreaming / useSystemManager no
longer import from components. Leave thin re-exports at the old paths.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: move remaining migrated-hook deps out of components

Host-key verification types/helpers now live in domain/, and SFTP column
layout types live in application/state/sftp/columnLayout. Application
hooks no longer import those definitions from the UI layer.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix: clear lint blockers and flush notes when panels hide

Move AI panel diagnostics persistence into application/state so
components stop importing localStorageAdapter. Flush note drafts when
retained NotesManager mounts become inactive, and silence related lint
warnings in theme/host-key helpers.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(notes): publish notesStore sync on vault note updates

updateNotes/updateNoteGroups now publishNotesSnapshot immediately so
AI/notes consumers do not briefly read a stale catalog after a hide
flush. Flush inactive drafts in useLayoutEffect before paint.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>
2026-08-07 14:40:38 +08:00

301 lines
11 KiB
JavaScript

/* eslint-disable no-undef */
function createExternalWindowApi(ctx) {
with (ctx) {
const fallbackBrowserWindows = new Set();
function resolveAppIconFromOptions(options = {}) {
const { appIcon, getAppIcon } = options;
if (typeof getAppIcon === "function") {
try {
const resolved = getAppIcon();
if (resolved) return resolved;
} catch {
// ignore
}
}
return appIcon;
}
/**
* Open a URL in a minimal in-app BrowserWindow. Used as a fallback when the
* host OS cannot open the URL with the system browser (e.g. Tiny11 / Windows
* with no default browser configured — error 0x483). The window is
* intentionally stripped down:
* - no preload script (remote content must NEVER touch contextBridge)
* - sandboxed + contextIsolated renderer
* - a separate persisted session partition so cookies and storage do not
* leak into the main app session
*/
function openFallbackBrowser(url, options = {}) {
const { backgroundColor, appIcon, getAppIcon } = options;
const icon = resolveAppIconFromOptions(options);
const electron = require("electron");
const { BrowserWindow, screen } = electron;
// Size and center relative to the main window when possible.
let bounds = { width: 1100, height: 740 };
try {
if (mainWindow && !mainWindow.isDestroyed()) {
const mainBounds = mainWindow.getBounds();
const display = screen.getDisplayMatching(mainBounds);
const area = display.workArea;
const w = Math.min(1200, Math.round(area.width * 0.85));
const h = Math.min(800, Math.round(area.height * 0.85));
bounds = {
width: w,
height: h,
x: Math.round(area.x + (area.width - w) / 2),
y: Math.round(area.y + (area.height - h) / 2),
};
}
} catch {
// Fall through to default bounds.
}
const win = new BrowserWindow({
...bounds,
title: url,
backgroundColor: backgroundColor || THEME_COLORS[currentTheme]?.background,
icon,
show: false,
autoHideMenuBar: true,
webPreferences: {
contextIsolation: true,
nodeIntegration: false,
sandbox: true,
spellcheck: false,
webSecurity: true,
// Isolated session so users' browsing does not mix with main app state.
partition: "persist:netcatty-fallback-browser",
},
});
fallbackBrowserWindows.add(win);
win.on("closed", () => {
fallbackBrowserWindows.delete(win);
});
// Reflect the loaded page title in the window bar; fall back to the URL.
try {
win.webContents.on("page-title-updated", (_event, title) => {
try {
win.setTitle(title || url);
} catch {
// ignore
}
});
} catch {
// ignore
}
// Popups inside the fallback browser: open them in another fallback window
// rather than looping back through shell.openExternal (which is what
// failed in the first place). These popups are fire-and-forget, so we
// explicitly catch the `loaded` rejection to avoid unhandledRejection.
try {
win.webContents.setWindowOpenHandler((details) => {
const targetUrl = details?.url;
if (targetUrl && typeof targetUrl === "string" && /^https?:/i.test(targetUrl)) {
try {
const popup = openFallbackBrowser(targetUrl, { backgroundColor, appIcon, getAppIcon });
popup.loaded.catch((err) => {
console.warn("[windowManager] fallback popup loadURL failed:", err?.message || err);
});
} catch (popupErr) {
console.warn("[windowManager] fallback popup open failed:", popupErr?.message || popupErr);
}
}
return { action: "deny" };
});
} catch {
// ignore
}
// Minimal keyboard navigation: Alt+← / Alt+→ / Ctrl/Cmd+R.
try {
win.webContents.on("before-input-event", (_event, input) => {
if (input.type !== "keyDown") return;
try {
const history = win.webContents.navigationHistory;
if (input.alt && input.key === "ArrowLeft" && history?.canGoBack?.()) {
history.goBack();
} else if (input.alt && input.key === "ArrowRight" && history?.canGoForward?.()) {
history.goForward();
} else if ((input.control || input.meta) && typeof input.key === "string" && input.key.toLowerCase() === "r") {
win.webContents.reload();
}
} catch {
// ignore navigation errors
}
});
} catch {
// ignore
}
win.once("ready-to-show", () => {
try {
win.show();
} catch {
// ignore
}
});
// Return the window together with its initial-load Promise. Callers that
// care about whether the page actually loaded can await `loaded`; fire-
// and-forget callers must still catch the rejection themselves to avoid
// turning it into an unhandledRejection.
const loaded = win.loadURL(url);
return { window: win, loaded };
}
/**
* Try to open a URL with the OS default browser via shell.openExternal; if
* that fails (e.g. no default browser configured), fall back to the in-app
* BrowserWindow. Resolves on success (either via system browser, or when
* the in-app fallback window finishes its initial load). Throws on total
* failure so callers that rely on rejection semantics (e.g. OAuth flows
* waiting on a Promise.race) still abort cleanly when no browser path is
* available.
*/
async function tryOpenExternalWithFallback(shell, url, options = {}) {
if (!url || typeof url !== "string" || !/^https?:/i.test(url)) {
throw new Error("openExternal: invalid URL");
}
try {
await shell?.openExternal?.(url);
return;
} catch (err) {
const message = err?.message || String(err);
console.warn("[windowManager] shell.openExternal failed, using in-app fallback:", message);
let fallback;
try {
fallback = openFallbackBrowser(url, options);
} catch (createErr) {
console.warn("[windowManager] fallback browser creation failed:", createErr?.message || createErr);
throw err instanceof Error ? err : new Error(message);
}
try {
// Wait for the fallback window's initial load. If the URL is
// unreachable or malformed, loadURL rejects — surface that as a real
// failure so callers (e.g. OAuth flows) can cancel early instead of
// waiting for a downstream timeout.
await fallback.loaded;
return;
} catch (loadErr) {
console.warn("[windowManager] fallback browser loadURL failed:", loadErr?.message || loadErr);
try {
if (fallback.window && !fallback.window.isDestroyed()) {
fallback.window.close();
}
} catch {
// ignore cleanup errors
}
throw err instanceof Error ? err : new Error(message);
}
}
}
function createExternalOnlyWindowOpenHandler(shell, options = {}) {
return (details) => {
const targetUrl = details?.url;
if (targetUrl && typeof targetUrl === "string" && /^https?:/i.test(targetUrl)) {
// Run async fallback path without blocking the window-open decision.
tryOpenExternalWithFallback(shell, targetUrl, options).catch((err) => {
console.warn("[windowManager] tryOpenExternalWithFallback threw:", err?.message || err);
});
}
return { action: "deny" };
};
}
function createAppWindowOpenHandler(shell, { backgroundColor, appIcon, getAppIcon }) {
const allowedPopupHosts = new Set([
// OAuth (PKCE loopback)
"accounts.google.com",
"login.microsoftonline.com",
"login.live.com",
]);
const isAllowedInAppPopupUrl = (rawUrl) => {
try {
const u = new URL(String(rawUrl));
if (u.protocol === "https:") {
return allowedPopupHosts.has(u.hostname);
}
if (u.protocol === "http:") {
// Allow ONLY the loopback OAuth callback page, and only while an
// OAuth flow is actively prepared — the acceptable port matches
// whatever oauthBridge just bound for this session.
const isLoopback =
u.hostname === "127.0.0.1" || u.hostname === "localhost";
if (!isLoopback || u.pathname !== "/oauth/callback") return false;
const activePort = oauthBridge.getActiveOAuthPort?.();
return activePort != null && u.port === String(activePort);
}
return false;
} catch {
return false;
}
};
return (details) => {
const targetUrl = details?.url;
const currentIcon = resolveAppIconFromOptions({ appIcon, getAppIcon });
if (!targetUrl || typeof targetUrl !== "string" || !/^https?:/i.test(targetUrl)) {
return { action: "deny" };
}
// Default: open in system browser to reduce remote-content attack surface.
if (!isAllowedInAppPopupUrl(targetUrl)) {
// Try system browser first, fall back to an in-app BrowserWindow when
// the OS has no handler for the URL (see tryOpenExternalWithFallback).
tryOpenExternalWithFallback(shell, targetUrl, {
backgroundColor,
appIcon: currentIcon,
getAppIcon,
}).catch((err) => {
console.warn("[windowManager] tryOpenExternalWithFallback threw:", err?.message || err);
});
return { action: "deny" };
}
const size = parseWindowOpenFeatures(details?.features);
return {
action: "allow",
overrideBrowserWindowOptions: {
width: size.width || OAUTH_DEFAULT_WIDTH,
height: size.height || OAUTH_DEFAULT_HEIGHT,
minWidth: 420,
minHeight: 560,
backgroundColor,
icon: currentIcon,
autoHideMenuBar: true,
menuBarVisible: false,
title: "Netcatty Authorization",
webPreferences: {
contextIsolation: true,
nodeIntegration: false,
// Sandboxed because this window renders remote content and does not need a preload bridge.
sandbox: true,
spellcheck: false,
v8CacheOptions: V8_CACHE_OPTIONS,
},
},
};
};
}
return {
openFallbackBrowser,
tryOpenExternalWithFallback,
createExternalOnlyWindowOpenHandler,
createAppWindowOpenHandler,
};
}
}
module.exports = { createExternalWindowApi };