Files
Netcatty/electron/bridges/mcpServerBridge.attachments.test.cjs
T
fc55e9ac17 feat(vault): let Skills + CLI operate notes with the same approval as MCP (#3512)
* feat(vault): let Skills + CLI operate notes with the same approval as MCP

Expose vault note list, read, write, and markdown import on the tool CLI so agents can save generated documents only after the user approves.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(vault): keep explicit empty note fields in the CLI

A supplied empty string was treated as an omitted flag, so note clears and empty markdown imports never reached the note service.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(vault): allow an explicit empty note body on CLI create

notes create --content "" was rejected as a missing flag, so it did not match vault_notes_create.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(vault): stop echoing imported note bodies and recognize leading CLI flags

A batch import resent every document over IPC, and a leading --json hid the notes command from artifact inference.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(vault): make note CLI import safe and fail writes cleanly

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-09-29 12:22:35 +08:00

101 lines
3.3 KiB
JavaScript

const test = require("node:test");
const assert = require("node:assert/strict");
const fs = require("node:fs");
const os = require("node:os");
const path = require("node:path");
// Keep bridge discovery writes/deletes off the installed app's live file.
const { isolateCliDiscoveryFile } = require("./cliDiscoveryTestIsolation.cjs");
isolateCliDiscoveryFile();
const bridge = require("./mcpServerBridge.cjs");
test("registered chat attachments can be listed and read by path or filename", async (t) => {
t.after(() => bridge.cleanup());
const notePath = path.resolve("/tmp/netcatty-note.txt");
bridge.updateAttachmentMetadata([
{
filename: "note.txt",
mediaType: "text/plain",
filePath: notePath,
base64Data: Buffer.from("hello attachment").toString("base64"),
},
], "chat-a");
const listed = bridge.handleListAttachments({ chatSessionId: "chat-a" });
assert.equal(listed.ok, true);
assert.deepEqual(listed.attachments, [{
filename: "note.txt",
mediaType: "text/plain",
filePath: notePath,
sizeBytes: 16,
}]);
const byPath = bridge.handleReadAttachment({
chatSessionId: "chat-a",
filePath: notePath,
});
assert.equal(byPath.ok, true);
assert.equal(byPath.text, "hello attachment");
const byName = bridge.handleReadAttachment({
chatSessionId: "chat-a",
filename: "note.txt",
});
assert.equal(byName.ok, true);
assert.equal(byName.base64Data, Buffer.from("hello attachment").toString("base64"));
});
test("attachment reads enforce a size limit for disk-backed files", async (t) => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "netcatty-attachment-limit-"));
const filePath = path.join(dir, "large.md");
const emptyPath = path.join(dir, "empty.md");
fs.writeFileSync(filePath, "# Notes\n".repeat(200));
fs.writeFileSync(emptyPath, "");
t.after(() => {
bridge.cleanup();
fs.rmSync(dir, { recursive: true, force: true });
});
bridge.updateAttachmentMetadata([
{ filename: "large.md", mediaType: "text/markdown", filePath },
{ filename: "empty.md", mediaType: "text/markdown", filePath: emptyPath },
], "chat-a");
assert.equal(bridge.handleListAttachments({ chatSessionId: "chat-a" }).attachments[0].sizeBytes, undefined);
assert.match(
bridge.handleReadAttachment({ chatSessionId: "chat-a", filename: "large.md", maxBytes: 100 }).error,
/size limit/,
);
const empty = bridge.handleReadAttachment({ chatSessionId: "chat-a", filename: "empty.md", maxBytes: 100 });
assert.equal(empty.ok, true);
assert.equal(empty.text, "");
});
test("attachment reads reject unregistered local paths", async (t) => {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "netcatty-attachment-test-"));
const secretPath = path.join(dir, "secret.txt");
fs.writeFileSync(secretPath, "secret");
t.after(() => {
bridge.cleanup();
fs.rmSync(dir, { recursive: true, force: true });
});
bridge.updateAttachmentMetadata([
{
filename: "allowed.txt",
mediaType: "text/plain",
filePath: path.join(dir, "allowed.txt"),
base64Data: Buffer.from("allowed").toString("base64"),
},
], "chat-a");
const result = bridge.handleReadAttachment({
chatSessionId: "chat-a",
filePath: secretPath,
});
assert.equal(result.ok, false);
assert.match(result.error, /not registered/i);
});