Files
Netcatty/components/terminalLayer/splitHintEquality.test.ts
T
陈大猫andClaude Opus 5.5 1b9c744fda perf(ui): stop whole-shell re-renders on clicks, focus, typing and modifiers (#4117)
Several everyday interactions re-rendered the entire shell (AppView, TopTabs,
TerminalLayer and every pane) even though nothing they show had changed:

- Clicking or focusing a split pane always replaced the workspaces array
  (twice per click: onClick + onFocusCapture), cascading through the whole
  app and re-saving the session restore snapshot. setWorkspaceFocusedSession
  and moveFocusInWorkspace now keep the same array when focus is unchanged
  (domain/workspace.ts setWorkspaceFocusedSessionId).
- Every window focus/visibility change resynced app lock and produced a new
  runtime state object even when nothing changed, re-rendering the provider
  tree. Equal states keep the current object and useAppLockState's result is
  memoized.
- Quick switcher keystrokes went through AppSideEffects state and the
  app-local UI store, re-rendering AppSideEffects, every host island, AppShell,
  AppView and TopTabs per character. QuickSwitcherOverlay now owns the query
  and host results; the overlay unmounts on close, which resets the query
  exactly where setQuickSearch('') used to.
- Pressing/releasing Ctrl/Cmd (every ⌘C/⌘V/Ctrl+C) re-rendered the whole tab
  bar to toggle shortcut number badges. The held flag now lives in a small
  store read only by each tab's TabIconSlot.
- AppView passed fresh inline callbacks that defeated TopTabs' memo comparator
  and every open editor tab; TextEditorTabView is now memoized. TopTabs
  memoizes per-workspace session lists and hoists the root tab icons.
- Workspace drag previews only update state when the drop hint actually moves.

React commits / render time for 10 repetitions in the real app (profiling
build, 2 split panes, 300 hosts), main -> this change:
  window focus            42 / 17.1 ms -> 2 / 0.4 ms
  press/release Cmd       50 / 41.9 ms -> 22 / 6.6 ms
  click focused pane      42 / 69.6 ms -> 3 / 0.4 ms
  quick switcher typing   41 / 61.3 ms -> 16 / 34.8 ms

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 00:22:10 -08:00

21 lines
780 B
TypeScript

import assert from 'node:assert/strict';
import test from 'node:test';
import { isSameSplitHint } from './splitHintEquality.ts';
const hint = {
direction: 'vertical' as const,
position: 'right' as const,
targetSessionId: 's1',
rect: { x: 100, y: 0, w: 100, h: 200 },
};
test('isSameSplitHint compares drop hints by value', () => {
assert.equal(isSameSplitHint(hint, { ...hint, rect: { ...hint.rect } }), true);
assert.equal(isSameSplitHint(null, null), true);
assert.equal(isSameSplitHint(hint, null), false);
assert.equal(isSameSplitHint(hint, { ...hint, position: 'left' }), false);
assert.equal(isSameSplitHint(hint, { ...hint, targetSessionId: 's2' }), false);
assert.equal(isSameSplitHint(hint, { ...hint, rect: { ...hint.rect, w: 99 } }), false);
});