mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-22 08:03:40 +00:00
Several everyday interactions re-rendered the entire shell (AppView, TopTabs,
TerminalLayer and every pane) even though nothing they show had changed:
- Clicking or focusing a split pane always replaced the workspaces array
(twice per click: onClick + onFocusCapture), cascading through the whole
app and re-saving the session restore snapshot. setWorkspaceFocusedSession
and moveFocusInWorkspace now keep the same array when focus is unchanged
(domain/workspace.ts setWorkspaceFocusedSessionId).
- Every window focus/visibility change resynced app lock and produced a new
runtime state object even when nothing changed, re-rendering the provider
tree. Equal states keep the current object and useAppLockState's result is
memoized.
- Quick switcher keystrokes went through AppSideEffects state and the
app-local UI store, re-rendering AppSideEffects, every host island, AppShell,
AppView and TopTabs per character. QuickSwitcherOverlay now owns the query
and host results; the overlay unmounts on close, which resets the query
exactly where setQuickSearch('') used to.
- Pressing/releasing Ctrl/Cmd (every ⌘C/⌘V/Ctrl+C) re-rendered the whole tab
bar to toggle shortcut number badges. The held flag now lives in a small
store read only by each tab's TabIconSlot.
- AppView passed fresh inline callbacks that defeated TopTabs' memo comparator
and every open editor tab; TextEditorTabView is now memoized. TopTabs
memoizes per-workspace session lists and hoists the root tab icons.
- Workspace drag previews only update state when the drop hint actually moves.
React commits / render time for 10 repetitions in the real app (profiling
build, 2 split panes, 300 hosts), main -> this change:
window focus 42 / 17.1 ms -> 2 / 0.4 ms
press/release Cmd 50 / 41.9 ms -> 22 / 6.6 ms
click focused pane 42 / 69.6 ms -> 3 / 0.4 ms
quick switcher typing 41 / 61.3 ms -> 16 / 34.8 ms
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
86 lines
3.4 KiB
TypeScript
86 lines
3.4 KiB
TypeScript
import { useLayoutEffect, useMemo, useSyncExternalStore } from 'react';
|
|
|
|
import { useEditorTabChromeList } from '../../state/editorTabStore';
|
|
import { getAppHandlers, subscribeAppHandlers } from '../appHandlersBridge';
|
|
import {
|
|
publishAppShellDomainSlice,
|
|
publishAppShellOverlays,
|
|
} from '../appShellPropsStore';
|
|
import { useAppLocalUiStore } from '../appLocalUiStore';
|
|
|
|
/**
|
|
* Dialogs island: local dialog/queue state from `appLocalUiStore`. The quick
|
|
* switcher owns its query and host results (QuickSwitcherOverlay), so typing
|
|
* there no longer republishes this bag.
|
|
* Assembles dialogs + overlays field-by-field — never spreads a prepared bag.
|
|
*/
|
|
export function DialogsHost() {
|
|
const local = useAppLocalUiStore();
|
|
const editorTabs = useEditorTabChromeList();
|
|
const handlers = useSyncExternalStore(
|
|
subscribeAppHandlers,
|
|
getAppHandlers,
|
|
getAppHandlers,
|
|
);
|
|
|
|
const dialogsDomain = useMemo(() => {
|
|
if (!handlers) return null;
|
|
return {
|
|
addToWorkspaceDialog: local.addToWorkspaceDialog,
|
|
clearAndRemoveSource: handlers.clearAndRemoveSource,
|
|
clearAndRemoveSources: handlers.clearAndRemoveSources,
|
|
editorTabs,
|
|
emptyVaultConflict: local.emptyVaultConflict,
|
|
handleHostConnectWithProtocolCheck: handlers.handleHostConnectWithProtocolCheck,
|
|
handleKeyboardInteractiveCancel: handlers.handleKeyboardInteractiveCancel,
|
|
handleKeyboardInteractiveSubmit: handlers.handleKeyboardInteractiveSubmit,
|
|
handlePassphraseCancel: handlers.handlePassphraseCancel,
|
|
handlePassphraseSkip: handlers.handlePassphraseSkip,
|
|
handlePassphraseSubmit: handlers.handlePassphraseSubmit,
|
|
handleFidoPromptCancel: handlers.handleFidoPromptCancel,
|
|
handleFidoPromptSubmit: handlers.handleFidoPromptSubmit,
|
|
handleProtocolSelect: handlers.handleProtocolSelect,
|
|
handleRequestCloseEditorTabRef: handlers.handleRequestCloseEditorTabRef,
|
|
isCreateWorkspaceOpen: local.isCreateWorkspaceOpen,
|
|
isQuickSwitcherOpen: local.isQuickSwitcherOpen,
|
|
keyboardInteractiveQueue: local.keyboardInteractiveQueue,
|
|
passphraseQueue: local.passphraseQueue,
|
|
fidoPromptQueue: local.fidoPromptQueue,
|
|
protocolSelectHost: local.protocolSelectHost,
|
|
resolveEmptyVaultConflict: handlers.resolveEmptyVaultConflict,
|
|
setAddToWorkspaceDialog: handlers.setAddToWorkspaceDialog,
|
|
setIsCreateWorkspaceOpen: handlers.setIsCreateWorkspaceOpen,
|
|
setIsQuickSwitcherOpen: handlers.setIsQuickSwitcherOpen,
|
|
setProtocolSelectHost: handlers.setProtocolSelectHost,
|
|
};
|
|
}, [
|
|
editorTabs,
|
|
handlers,
|
|
local.addToWorkspaceDialog,
|
|
local.emptyVaultConflict,
|
|
local.isCreateWorkspaceOpen,
|
|
local.isQuickSwitcherOpen,
|
|
local.keyboardInteractiveQueue,
|
|
local.passphraseQueue,
|
|
local.fidoPromptQueue,
|
|
local.protocolSelectHost,
|
|
]);
|
|
|
|
const overlays = useMemo(() => {
|
|
if (!handlers) return null;
|
|
return {
|
|
onAddKnownHost: handlers.handleAddKnownHost as (knownHost: never) => void,
|
|
deleteHostConfirm: local.deleteHostConfirm,
|
|
onCancelDeleteHost: handlers.handleCancelDeleteHost as () => void,
|
|
onConfirmDeleteHost: handlers.handleConfirmDeleteHost as () => void,
|
|
};
|
|
}, [handlers, local.deleteHostConfirm]);
|
|
|
|
useLayoutEffect(() => {
|
|
if (dialogsDomain) publishAppShellDomainSlice('dialogs', dialogsDomain);
|
|
if (overlays) publishAppShellOverlays(overlays as never);
|
|
}, [dialogsDomain, overlays]);
|
|
|
|
return null;
|
|
}
|