mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-21 07:32:54 +00:00
* fix: split shortcut in workspace panes and host delete form freeze (#612) Bug 1: Split-pane shortcuts (Ctrl+Shift+D/E) did nothing after the first split because the workspace branch in executeHotkeyAction only logged a message. Now uses workspace.focusedSessionId to split the focused pane. Bug 2: Deleting a host left editingHost state pointing to the removed host, keeping HostDetailsPanel mounted as an overlay that blocked all form interactions. Added a useEffect to close the panel when the edited host is no longer in the hosts array. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: Shift+right-click context menu and split content loss (#612) Bug 4: When rightClickBehavior is 'paste' or 'select-word', the context menu was completely disabled with no fallback. Now Shift+Right-Click always opens the context menu regardless of the right-click behavior setting. Bug 5: Splitting a terminal occasionally caused the original pane's content to disappear due to a race between layout reflow and xterm fit(). Added a second delayed fit (350ms) after workspace layout changes as a safety net for cases where the first fit (100ms) runs before the container dimensions have settled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: guard host-deletion cleanup against unsaved duplicates The cleanup effect that closes the host panel on deletion incorrectly closed it for duplicated/new hosts whose IDs were never in the hosts array. Track known host IDs via ref so the effect only fires when a previously-saved host is actually removed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: check previous host IDs before updating ref in deletion cleanup Merge the two effects into one so the deletion check reads from the previous knownHostIdsRef before overwriting it with the current hosts. Previously both effects ran in the same render cycle, causing the ref to be updated before the check, making it impossible to detect deleted hosts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: open context menu on first Shift+right-click Replace state-based forceMenu approach with always-enabled ContextMenuTrigger. The onContextMenu handler intercepts paste/ select-word actions unless Shift is held, so the Radix context menu opens immediately on the first Shift+Right-Click without needing a second click. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: fallback to first live pane when workspace focus is stale When the focused pane is closed, focusedSessionId may point to a non-existent session. Split shortcuts now fall back to the first session in the workspace tree via collectSessionIds() so the hotkey never silently no-ops. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: validate focusedSessionId against live workspace panes focusedSessionId can be stale (non-null but pointing to a closed pane) after pane closure. Now check it exists in collectSessionIds() before using it, otherwise fall back to the first live pane. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
172 lines
5.6 KiB
TypeScript
172 lines
5.6 KiB
TypeScript
/**
|
|
* Terminal Context Menu
|
|
* Right-click menu for terminal with split, copy/paste, and other actions
|
|
*/
|
|
import {
|
|
ClipboardPaste,
|
|
Copy,
|
|
SplitSquareHorizontal,
|
|
SplitSquareVertical,
|
|
Terminal as TerminalIcon,
|
|
Trash2,
|
|
} from 'lucide-react';
|
|
import React, { useCallback } from 'react';
|
|
import { useI18n } from '../../application/i18n/I18nProvider';
|
|
import { KeyBinding, RightClickBehavior } from '../../domain/models';
|
|
import {
|
|
ContextMenu,
|
|
ContextMenuContent,
|
|
ContextMenuItem,
|
|
ContextMenuSeparator,
|
|
ContextMenuShortcut,
|
|
ContextMenuTrigger,
|
|
} from '../ui/context-menu';
|
|
|
|
export interface TerminalContextMenuProps {
|
|
children: React.ReactNode;
|
|
hasSelection?: boolean;
|
|
hotkeyScheme?: 'disabled' | 'mac' | 'pc';
|
|
keyBindings?: KeyBinding[];
|
|
rightClickBehavior?: RightClickBehavior;
|
|
isAlternateScreen?: boolean;
|
|
onCopy?: () => void;
|
|
onPaste?: () => void;
|
|
onSelectAll?: () => void;
|
|
onClear?: () => void;
|
|
onSplitHorizontal?: () => void;
|
|
onSplitVertical?: () => void;
|
|
onClose?: () => void;
|
|
onSelectWord?: () => void;
|
|
}
|
|
|
|
export const TerminalContextMenu: React.FC<TerminalContextMenuProps> = ({
|
|
children,
|
|
hasSelection = false,
|
|
hotkeyScheme = 'mac',
|
|
keyBindings,
|
|
rightClickBehavior = 'context-menu',
|
|
isAlternateScreen = false,
|
|
onCopy,
|
|
onPaste,
|
|
onSelectAll,
|
|
onClear,
|
|
onSplitHorizontal,
|
|
onSplitVertical,
|
|
onClose,
|
|
onSelectWord,
|
|
}) => {
|
|
const { t } = useI18n();
|
|
const isMac = hotkeyScheme === 'mac';
|
|
|
|
// Helper to get shortcut from keyBindings and format for display
|
|
const getShortcut = (bindingId: string): string => {
|
|
const binding = keyBindings?.find(b => b.id === bindingId);
|
|
if (!binding) return '';
|
|
const key = isMac ? binding.mac : binding.pc;
|
|
if (!key || key === 'Disabled') return '';
|
|
// Replace " + " with space for cleaner display (e.g., "⌘ + Shift + D" → "⌘ Shift D")
|
|
return key.replace(/\s*\+\s*/g, ' ').trim();
|
|
};
|
|
|
|
const copyShortcut = getShortcut('copy');
|
|
const pasteShortcut = getShortcut('paste');
|
|
const selectAllShortcut = getShortcut('select-all');
|
|
const splitHShortcut = getShortcut('split-horizontal');
|
|
const splitVShortcut = getShortcut('split-vertical');
|
|
const clearShortcut = getShortcut('clear-buffer');
|
|
|
|
// Handle right-click: intercept for paste/select-word unless Shift is held
|
|
// or rightClickBehavior is 'context-menu'. The ContextMenuTrigger stays always
|
|
// enabled so Shift+Right-Click opens the menu on the first click.
|
|
const handleRightClick = useCallback(
|
|
(e: React.MouseEvent) => {
|
|
// In alternate screen (tmux, vim, etc.), let the terminal application
|
|
// handle right-click natively to avoid conflicting menus
|
|
if (isAlternateScreen) {
|
|
e.preventDefault();
|
|
return;
|
|
}
|
|
|
|
// Shift+Right-Click or context-menu mode: let Radix open the menu
|
|
if (e.shiftKey || rightClickBehavior === 'context-menu') return;
|
|
|
|
// Paste / select-word: intercept and prevent the context menu
|
|
e.preventDefault();
|
|
if (rightClickBehavior === 'paste') {
|
|
onPaste?.();
|
|
} else if (rightClickBehavior === 'select-word') {
|
|
onSelectWord?.();
|
|
}
|
|
},
|
|
[rightClickBehavior, onPaste, onSelectWord, isAlternateScreen],
|
|
);
|
|
|
|
// Always use ContextMenu wrapper to maintain consistent React tree structure
|
|
// This prevents terminal from unmounting when rightClickBehavior changes
|
|
return (
|
|
<ContextMenu>
|
|
<ContextMenuTrigger
|
|
asChild
|
|
onContextMenu={handleRightClick}
|
|
>
|
|
{children}
|
|
</ContextMenuTrigger>
|
|
{!isAlternateScreen && (
|
|
<ContextMenuContent className="w-56">
|
|
<ContextMenuItem onClick={onCopy} disabled={!hasSelection}>
|
|
<Copy size={14} className="mr-2" />
|
|
{t('terminal.menu.copy')}
|
|
<ContextMenuShortcut>{copyShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
<ContextMenuItem onClick={onPaste}>
|
|
<ClipboardPaste size={14} className="mr-2" />
|
|
{t('terminal.menu.paste')}
|
|
<ContextMenuShortcut>{pasteShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
<ContextMenuItem onClick={onSelectAll}>
|
|
<TerminalIcon size={14} className="mr-2" />
|
|
{t('terminal.menu.selectAll')}
|
|
<ContextMenuShortcut>{selectAllShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
|
|
<ContextMenuSeparator />
|
|
|
|
<ContextMenuItem onClick={onSplitVertical}>
|
|
<SplitSquareHorizontal size={14} className="mr-2" />
|
|
{t('terminal.menu.splitHorizontal')}
|
|
<ContextMenuShortcut>{splitVShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
<ContextMenuItem onClick={onSplitHorizontal}>
|
|
<SplitSquareVertical size={14} className="mr-2" />
|
|
{t('terminal.menu.splitVertical')}
|
|
<ContextMenuShortcut>{splitHShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
|
|
<ContextMenuSeparator />
|
|
|
|
<ContextMenuItem onClick={onClear}>
|
|
<Trash2 size={14} className="mr-2" />
|
|
{t('terminal.menu.clearBuffer')}
|
|
<ContextMenuShortcut>{clearShortcut}</ContextMenuShortcut>
|
|
</ContextMenuItem>
|
|
|
|
{onClose && (
|
|
<>
|
|
<ContextMenuSeparator />
|
|
<ContextMenuItem
|
|
onClick={onClose}
|
|
className="text-destructive focus:text-destructive"
|
|
>
|
|
<Trash2 size={14} className="mr-2" />
|
|
{t('terminal.menu.closeTerminal')}
|
|
</ContextMenuItem>
|
|
</>
|
|
)}
|
|
</ContextMenuContent>
|
|
)}
|
|
</ContextMenu>
|
|
);
|
|
};
|
|
|
|
export default TerminalContextMenu;
|