Files
Netcatty/components/terminalLayerMemo.ts
T
bincxz da831c053f perf(terminal): harden store isolation after multi-agent review
Address correctness and residual jank found in review:

- Expand pane session equality for connect/startup fields (pendingInitialCwd,
  startupCommand, pending scripts, serial/local shell, etc.).
- Cache coding-CLI provider in the signal controller so memo-skipped
  TerminalLayer renders cannot clear titles via a stale sessionsRef.
- Heal terminalCwdStore drift when the renderer ref already has the path.
- Publish shell history synchronously on write/load and via useLayoutEffect.
- Move script runs to scriptRunsStore; Scripts slot subscribes so automation
  ticks no longer re-render TerminalLayerInner.
- TerminalLayerView equal uses stable side-panel keys only (cwd/theme live
  via sidePanelLiveStore, not chrome re-renders).
- Compare terminalFontFamilyId / session log props; stabilize HostTreeView
  callbacks and end-session-drag handler.
2026-07-30 16:32:42 +08:00

84 lines
4.2 KiB
TypeScript

import { terminalPaneSessionsEqual } from '../domain/terminalPaneSessionsEqual';
export const terminalLayerAreEqual = (
prev: Record<string, unknown>,
next: Record<string, unknown>,
): boolean => (
prev.hosts === next.hosts &&
prev.customGroups === next.customGroups &&
prev.groupConfigs === next.groupConfigs &&
prev.proxyProfiles === next.proxyProfiles &&
prev.portForwardingRules === next.portForwardingRules &&
prev.keys === next.keys &&
prev.snippets === next.snippets &&
prev.snippetPackages === next.snippetPackages &&
prev.notes === next.notes &&
prev.noteGroups === next.noteGroups &&
prev.openNoteRequest === next.openNoteRequest &&
prev.onOpenVaultNoteFromChat === next.onOpenVaultNoteFromChat &&
prev.onOpenVaultHostFromChat === next.onOpenVaultHostFromChat &&
prev.onOpenVaultSectionFromChat === next.onOpenVaultSectionFromChat &&
prev.onOpenVaultSnippetFromChat === next.onOpenVaultSnippetFromChat &&
// Ignore TopTabs-only presentation fields (dynamicTitle / codingCliProviderId).
terminalPaneSessionsEqual(
prev.sessions as never,
next.sessions as never,
) &&
prev.workspaces === next.workspaces &&
prev.knownHosts === next.knownHosts &&
prev.draggingSessionId === next.draggingSessionId &&
prev.terminalTheme === next.terminalTheme &&
prev.terminalThemeId === next.terminalThemeId &&
prev.followAppTerminalTheme === next.followAppTerminalTheme &&
prev.pickTerminalTheme === next.pickTerminalTheme &&
prev.resolveSessionAppearance === next.resolveSessionAppearance &&
prev.accentMode === next.accentMode &&
prev.customAccent === next.customAccent &&
prev.terminalSettings === next.terminalSettings &&
prev.fontSize === next.fontSize &&
prev.terminalFontFamilyId === next.terminalFontFamilyId &&
prev.sessionLogsEnabled === next.sessionLogsEnabled &&
prev.sessionLogsDir === next.sessionLogsDir &&
prev.sessionLogsFormat === next.sessionLogsFormat &&
prev.sessionLogsTimestampsEnabled === next.sessionLogsTimestampsEnabled &&
prev.hotkeyScheme === next.hotkeyScheme &&
prev.disableTerminalFontZoom === next.disableTerminalFontZoom &&
prev.restoreTerminalCwd === next.restoreTerminalCwd &&
prev.keyBindings === next.keyBindings &&
prev.sftpDefaultViewMode === next.sftpDefaultViewMode &&
prev.sftpDoubleClickBehavior === next.sftpDoubleClickBehavior &&
prev.sftpAutoSync === next.sftpAutoSync &&
prev.sftpShowHiddenFiles === next.sftpShowHiddenFiles &&
prev.sftpUseCompressedUpload === next.sftpUseCompressedUpload &&
prev.sftpAutoOpenSidebar === next.sftpAutoOpenSidebar &&
prev.terminalSidePanelAutoOpen === next.terminalSidePanelAutoOpen &&
prev.terminalSidePanelAutoOpenTab === next.terminalSidePanelAutoOpenTab &&
prev.sftpFollowTerminalCwd === next.sftpFollowTerminalCwd &&
prev.setSftpFollowTerminalCwd === next.setSftpFollowTerminalCwd &&
prev.editorWordWrap === next.editorWordWrap &&
prev.sshDebugLogsEnabled === next.sshDebugLogsEnabled &&
prev.showHostTreeSidebar === next.showHostTreeSidebar &&
prev.setEditorWordWrap === next.setEditorWordWrap &&
prev.onHotkeyAction === next.onHotkeyAction &&
prev.onUpdateSessionRestoreCwd === next.onUpdateSessionRestoreCwd &&
prev.onUpdateHost === next.onUpdateHost &&
prev.onAddKnownHost === next.onAddKnownHost &&
prev.onToggleWorkspaceViewMode === next.onToggleWorkspaceViewMode &&
prev.onSetWorkspaceFocusedSession === next.onSetWorkspaceFocusedSession &&
prev.onReorderWorkspaceSessions === next.onReorderWorkspaceSessions &&
prev.onReorderTabs === next.onReorderTabs &&
prev.onSplitSession === next.onSplitSession &&
prev.onConnectToHost === next.onConnectToHost &&
prev.onCreateLocalTerminal === next.onCreateLocalTerminal &&
prev.isBroadcastEnabled === next.isBroadcastEnabled &&
prev.onToggleBroadcast === next.onToggleBroadcast &&
prev.updateSnippets === next.updateSnippets &&
prev.updateSnippetPackages === next.updateSnippetPackages &&
prev.updateNotes === next.updateNotes &&
prev.updateNoteGroups === next.updateNoteGroups &&
prev.toggleScriptsSidePanelRef === next.toggleScriptsSidePanelRef &&
prev.toggleSidePanelRef === next.toggleSidePanelRef &&
prev.identities === next.identities
// shellHistory intentionally omitted — History panel reads shellHistoryStore.
);