mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
Address correctness and residual jank found in review: - Expand pane session equality for connect/startup fields (pendingInitialCwd, startupCommand, pending scripts, serial/local shell, etc.). - Cache coding-CLI provider in the signal controller so memo-skipped TerminalLayer renders cannot clear titles via a stale sessionsRef. - Heal terminalCwdStore drift when the renderer ref already has the path. - Publish shell history synchronously on write/load and via useLayoutEffect. - Move script runs to scriptRunsStore; Scripts slot subscribes so automation ticks no longer re-render TerminalLayerInner. - TerminalLayerView equal uses stable side-panel keys only (cwd/theme live via sidePanelLiveStore, not chrome re-renders). - Compare terminalFontFamilyId / session log props; stabilize HostTreeView callbacks and end-session-drag handler.
263 lines
6.3 KiB
TypeScript
263 lines
6.3 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { terminalLayerAreEqual } from "./terminalLayerMemo.ts";
|
|
|
|
const baseProps = {
|
|
hosts: [],
|
|
customGroups: [],
|
|
groupConfigs: [],
|
|
proxyProfiles: [],
|
|
keys: [],
|
|
identities: [],
|
|
snippets: [],
|
|
snippetPackages: [],
|
|
sessions: [],
|
|
workspaces: [],
|
|
knownHosts: [],
|
|
draggingSessionId: null,
|
|
terminalTheme: {},
|
|
terminalThemeId: "midnight",
|
|
followAppTerminalTheme: false,
|
|
accentMode: "theme",
|
|
customAccent: null,
|
|
terminalSettings: {},
|
|
fontSize: 14,
|
|
hotkeyScheme: "default",
|
|
keyBindings: [],
|
|
sftpDefaultViewMode: "list",
|
|
sftpDoubleClickBehavior: "open",
|
|
sftpAutoSync: false,
|
|
sftpShowHiddenFiles: false,
|
|
sftpUseCompressedUpload: false,
|
|
sftpAutoOpenSidebar: false,
|
|
terminalSidePanelAutoOpen: false,
|
|
terminalSidePanelAutoOpenTab: "scripts",
|
|
sftpFollowTerminalCwd: false,
|
|
setSftpFollowTerminalCwd: () => {},
|
|
editorWordWrap: false,
|
|
sshDebugLogsEnabled: false,
|
|
setEditorWordWrap: () => {},
|
|
onHotkeyAction: () => {},
|
|
onUpdateHost: () => {},
|
|
onUpdateFollowAppTerminalThemeId: () => {},
|
|
onAddKnownHost: () => {},
|
|
onToggleWorkspaceViewMode: () => {},
|
|
onSetWorkspaceFocusedSession: () => {},
|
|
isBroadcastEnabled: () => false,
|
|
onToggleBroadcast: () => {},
|
|
updateSnippets: () => {},
|
|
updateSnippetPackages: () => {},
|
|
onSplitSession: () => {},
|
|
onConnectToHost: () => {},
|
|
toggleScriptsSidePanelRef: { current: null },
|
|
};
|
|
|
|
test("TerminalLayer re-renders when group configs change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, groupConfigs: [{ path: "prod", proxyProfileId: "proxy-1" }] } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when known hosts change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{
|
|
...baseProps,
|
|
knownHosts: [{
|
|
id: "kh-1",
|
|
hostname: "switch.local",
|
|
port: 22,
|
|
keyType: "ssh-ed25519",
|
|
fingerprint: "fingerprint",
|
|
discoveredAt: 1,
|
|
}],
|
|
} as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when the known host save handler changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, onAddKnownHost: () => {} } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when proxy profiles change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{
|
|
...baseProps,
|
|
proxyProfiles: [{
|
|
id: "proxy-1",
|
|
label: "Office Proxy",
|
|
config: { type: "http", host: "proxy.example.com", port: 3128 },
|
|
createdAt: 1,
|
|
}],
|
|
} as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when broadcast state changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, isBroadcastEnabled: () => true } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when terminal side panel auto-open settings change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, terminalSidePanelAutoOpen: true } as never,
|
|
),
|
|
false,
|
|
);
|
|
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, terminalSidePanelAutoOpenTab: "history" } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when broadcast toggle handler changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, onToggleBroadcast: () => {} } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when snippet save handlers change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, updateSnippets: () => {} } as never,
|
|
),
|
|
false,
|
|
);
|
|
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, updateSnippetPackages: () => {} } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when SSH debug logging changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, sshDebugLogsEnabled: true } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when follow-app terminal theme mode changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, followAppTerminalTheme: true } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when the visible terminal theme id changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, terminalThemeId: "snow" } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when a note open request changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, openNoteRequest: { tabId: "session-1", noteId: "note-1", requestId: 1 } } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer ignores shellHistory prop churn (reads shellHistoryStore instead)", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, shellHistory: [{ id: "1", command: "ls", hostId: "h", hostLabel: "h", sessionId: "s", timestamp: 1 }] } as never,
|
|
),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer ignores sessions dynamicTitle-only updates", () => {
|
|
const sessionsA = [{
|
|
id: "s1",
|
|
hostId: "h1",
|
|
hostLabel: "host",
|
|
username: "root",
|
|
hostname: "example.test",
|
|
status: "connected",
|
|
dynamicTitle: "old",
|
|
}];
|
|
const sessionsB = [{
|
|
...sessionsA[0],
|
|
dynamicTitle: "new",
|
|
codingCliProviderId: "claude",
|
|
}];
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
{ ...baseProps, sessions: sessionsA } as never,
|
|
{ ...baseProps, sessions: sessionsB } as never,
|
|
),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when portForwardingRules change", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
baseProps as never,
|
|
{ ...baseProps, portForwardingRules: [{ id: "pf-1" }] } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("TerminalLayer re-renders when terminalFontFamilyId changes", () => {
|
|
assert.equal(
|
|
terminalLayerAreEqual(
|
|
{ ...baseProps, terminalFontFamilyId: "jetbrain-mono" } as never,
|
|
{ ...baseProps, terminalFontFamilyId: "sf-mono" } as never,
|
|
),
|
|
false,
|
|
);
|
|
});
|