mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-20 23:20:46 +00:00
* feat: add web search and URL fetch tools for AI agent Add web_search and url_fetch tools to Catty Agent, allowing the AI to search the internet for current information and fetch webpage content. - Support 5 search providers: Tavily, Exa, Bocha, Zhipu, SearXNG - Settings UI with provider selection, API key encryption, and config - web_search is conditional on config; url_fetch is always available - Both tools are read-only and work in all permission modes (incl. observer) - aiFetch skipHostCheck for AI tool requests to arbitrary URLs - System prompt guidelines for when to use search/fetch - i18n support (en + zh-CN) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address code review findings (SSRF, key exposure, state race) - P1: Restore SSRF protection when skipHostCheck is true — still block localhost, RFC1918, link-local, and cloud metadata endpoints; only skip the domain allowlist for public HTTPS hosts - P2: Move web search API key decryption to main process via dedicated IPC handler, matching the existing provider key security model - P2: Use configRef to avoid stale closure in async settings callbacks that could overwrite newer user changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address second review — DNS rebinding, url_fetch approval, maxResults - P1: url_fetch now requires approval in confirm mode (outbound GET is a side effect that could exfiltrate data via query strings) - P1: Add DNS resolution check when skipHostCheck is set — resolve hostname and reject if any IP is private/loopback/link-local, blocking DNS rebinding attacks against internal services - P2: Slice search results after provider call to enforce maxResults consistently (Zhipu and SearXNG ignore the limit parameter) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address third review — localhost/IPv6 SSRF, API key blur race - P1: Block localhost/loopback when skipHostCheck is enabled — restructure isAllowedFetchUrl to check private hosts first in the skipHostCheck path, preventing access to local services on allowlisted ports - P1: Handle IPv6 private ranges (fc00::/7, fe80::/10, ::ffff: mapped), strip brackets from URL.hostname, block [::1] and fd00:: addresses - P2: Guard handleApiKeyBlur against provider change during async encryption — skip stale write if provider switched while encrypting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address fourth review — main-process key isolation, SearXNG compat - P1: Replace aiWebSearchDecryptKey IPC with __WEB_SEARCH_KEY__ placeholder pattern — renderer never sees plaintext keys; main process replaces placeholder in headers before HTTP request, matching provider key flow - P1: Search API requests use normal allowlist path (not skipHostCheck), so SearXNG on localhost/HTTP/private networks works via aiSyncWebSearch; only url_fetch uses skipHostCheck for arbitrary public HTTPS URLs - P2: Remove needsApproval from url_fetch — treat as read-only like sftp_read_file, consistent with observer mode allowlist Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address fifth review — private LAN providers, maxResults default - P1: Allow private-IP hosts that are explicitly in the provider/search allowlist (e.g. https://192.168.x.x model providers or SearXNG) - P2: Remove .default(5) from web_search maxResults schema so the user's configured maxResults setting is used when the model omits the param Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address sixth review — HTTPS scope, config gate, redirects - P2: Scope HTTP exception to private/LAN IPs only — remote allowlisted hosts still require HTTPS to protect API keys in transit - P2: Gate web_search tool on complete config (API key for providers that require it, apiHost for SearXNG) to avoid advertising a broken tool - P2: Add redirect following (up to 5 hops) to aiFetch for url_fetch — handles 301/302/307 for short links, www canonicalization, etc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address seventh review — redirect SSRF, decrypt race, HTTPS-only - P1: Revalidate each redirect hop against SSRF guards (allowlist check + DNS resolution) before following, preventing open-redirect SSRF - P2: Add sequence counter to API key decryption effect — stale promise results from a previous provider are discarded on provider switch - P3: Restrict url_fetch to HTTPS-only URLs, matching the skipHostCheck policy that already rejects HTTP in the bridge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address eighth review — OS resolver, allowlisted HTTP hosts - P1: Use dns.lookup (OS resolver) instead of dns.resolve4/6 for private IP checks — matches what http.request actually connects to, respects /etc/hosts, mDNS, and other local resolver sources - P2: Allow HTTP for any explicitly allowlisted host (not just literal private IPs), so self-hosted SearXNG at http://searxng.lan works Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address ninth review — HTTP scope, blur ordering, decrypt flag - P1: Narrow HTTP exception to web search apiHost only — AI provider endpoints remain HTTPS-only to protect credentials in transit - P2: Add blur sequence counter to prevent out-of-order encryption results from overwriting newer API key saves - P2: Reset isDecrypting flag when cancelling decrypt on provider switch, preventing permanently disabled API key input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address tenth review — DNS pinning, prompt/tool alignment - P1: Pin validated DNS result to the HTTP request via custom lookup function, preventing TOCTOU/DNS-rebinding between validation and actual connection - P2: Extract isWebSearchReady() helper and use it consistently in both tool registration and system prompt, so the model isn't told web search is available when config is incomplete Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address eleventh review — single DNS lookup, redirect pinning, CGNAT - P1: Combine DNS validation and pinning into a single lookup call, eliminating the TOCTOU window between hasPrivateResolution and pinnedLookup - P1: Pin DNS for redirect targets too — resolve/validate/pin in one step before following each redirect hop - P2: Add 100.64.0.0/10 (CGNAT) to private IP ranges for Tailscale and similar CGNAT-addressed internal services Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address twelfth review — apiHost validation, sync on enable - P2: Validate apiHost is a well-formed URL in isWebSearchReady(), preventing tool exposure when user enters a malformed host - P2: Add webSearchConfig.enabled to sync effect deps so the main process gets updated immediately when the toggle changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove DNS-level SSRF checks that break fakedns/proxy environments DNS resolution validation (dns.lookup + IP pinning) breaks in proxy environments where fakedns resolves all domains to LAN addresses. Revert to hostname-level checks only (blocking localhost, 127.0.0.1, metadata endpoints, etc.) which are sufficient without false positives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve empty catch block lint warning Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
338 lines
16 KiB
TypeScript
338 lines
16 KiB
TypeScript
/**
|
|
* Settings Page - Standalone settings window content
|
|
* This component is rendered in a separate Electron window
|
|
*/
|
|
import { AppWindow, Cloud, FileType, HardDrive, Keyboard, Palette, Sparkles, TerminalSquare, X } from "lucide-react";
|
|
import React, { useCallback, useEffect, useMemo, useState } from "react";
|
|
import { useSettingsState } from "../application/state/useSettingsState";
|
|
import { usePortForwardingState } from "../application/state/usePortForwardingState";
|
|
import { useVaultState } from "../application/state/useVaultState";
|
|
import { useWindowControls } from "../application/state/useWindowControls";
|
|
import { useUpdateCheck } from "../application/state/useUpdateCheck";
|
|
import { useAIState } from "../application/state/useAIState";
|
|
import { I18nProvider, useI18n } from "../application/i18n/I18nProvider";
|
|
import SettingsApplicationTab from "./SettingsApplicationTab";
|
|
import SettingsAppearanceTab from "./settings/tabs/SettingsAppearanceTab";
|
|
import SettingsFileAssociationsTab from "./settings/tabs/SettingsFileAssociationsTab";
|
|
import SettingsShortcutsTab from "./settings/tabs/SettingsShortcutsTab";
|
|
import SettingsTerminalTab from "./settings/tabs/SettingsTerminalTab";
|
|
import SettingsSystemTab from "./settings/tabs/SettingsSystemTab";
|
|
const SettingsAITab = React.lazy(() => import("./settings/tabs/SettingsAITab"));
|
|
import { Tabs, TabsList, TabsTrigger } from "./ui/tabs";
|
|
import type { TerminalFont } from "../infrastructure/config/fonts";
|
|
|
|
const isMac = typeof navigator !== "undefined" && /Mac|iPhone|iPad/.test(navigator.platform);
|
|
|
|
class AITabErrorBoundary extends React.Component<
|
|
{ children: React.ReactNode },
|
|
{ error: Error | null }
|
|
> {
|
|
state: { error: Error | null } = { error: null };
|
|
static getDerivedStateFromError(error: Error) {
|
|
return { error };
|
|
}
|
|
render() {
|
|
if (this.state.error) {
|
|
return (
|
|
<div style={{ padding: 32, color: "#f87171", fontFamily: "monospace", whiteSpace: "pre-wrap" }}>
|
|
<h3 style={{ marginBottom: 8 }}>AI Settings Error</h3>
|
|
<div>{this.state.error.message}</div>
|
|
<div style={{ marginTop: 8, fontSize: 12, color: "#888" }}>{this.state.error.stack}</div>
|
|
</div>
|
|
);
|
|
}
|
|
return this.props.children;
|
|
}
|
|
}
|
|
|
|
type SettingsState = ReturnType<typeof useSettingsState> & {
|
|
availableFonts: TerminalFont[];
|
|
};
|
|
|
|
const SettingsSyncTab = React.lazy(() => import("./settings/tabs/SettingsSyncTab"));
|
|
|
|
const SettingsSyncTabWithVault: React.FC<{ onSettingsApplied?: () => void }> = ({ onSettingsApplied }) => {
|
|
const {
|
|
hosts,
|
|
keys,
|
|
identities,
|
|
snippets,
|
|
customGroups,
|
|
snippetPackages,
|
|
knownHosts,
|
|
importDataFromString,
|
|
clearVaultData,
|
|
} = useVaultState();
|
|
|
|
const { rules: portForwardingRules, importRules: importPortForwardingRules } = usePortForwardingState();
|
|
|
|
// Strip transient runtime fields before passing to sync
|
|
const portForwardingRulesForSync = useMemo(
|
|
() =>
|
|
portForwardingRules.map((rule) => ({
|
|
...rule,
|
|
status: "inactive" as const,
|
|
error: undefined,
|
|
lastUsedAt: undefined,
|
|
})),
|
|
[portForwardingRules],
|
|
);
|
|
|
|
const vault = useMemo(
|
|
() => ({ hosts, keys, identities, snippets, customGroups, snippetPackages, knownHosts }),
|
|
[hosts, keys, identities, snippets, customGroups, snippetPackages, knownHosts],
|
|
);
|
|
|
|
return (
|
|
<SettingsSyncTab
|
|
vault={vault}
|
|
portForwardingRules={portForwardingRulesForSync}
|
|
importDataFromString={importDataFromString}
|
|
importPortForwardingRules={importPortForwardingRules}
|
|
clearVaultData={clearVaultData}
|
|
onSettingsApplied={onSettingsApplied}
|
|
/>
|
|
);
|
|
};
|
|
|
|
const SettingsPageContent: React.FC<{ settings: SettingsState }> = ({ settings }) => {
|
|
const { t } = useI18n();
|
|
const { notifyRendererReady, closeSettingsWindow } = useWindowControls();
|
|
const { updateState, checkNow, installUpdate, openReleasePage } = useUpdateCheck({ autoUpdateEnabled: settings.autoUpdateEnabled });
|
|
const aiState = useAIState();
|
|
const [activeTab, setActiveTab] = useState("application");
|
|
const [mountedTabs, setMountedTabs] = useState(() => new Set(["application"]));
|
|
|
|
useEffect(() => {
|
|
notifyRendererReady();
|
|
}, [notifyRendererReady]);
|
|
|
|
useEffect(() => {
|
|
setMountedTabs((prev) => {
|
|
if (prev.has(activeTab)) return prev;
|
|
const next = new Set(prev);
|
|
next.add(activeTab);
|
|
return next;
|
|
});
|
|
}, [activeTab]);
|
|
|
|
const handleClose = useCallback(() => {
|
|
closeSettingsWindow();
|
|
}, [closeSettingsWindow]);
|
|
|
|
return (
|
|
<div className="h-screen flex flex-col bg-background text-foreground font-sans">
|
|
<div className="shrink-0 border-b border-border app-drag">
|
|
<div className="flex items-center justify-between px-4 pt-3">
|
|
{isMac && <div className="h-6" />}
|
|
</div>
|
|
<div className="flex items-center justify-between px-4 py-2">
|
|
<h1 className="text-lg font-semibold">{t("settings.title")}</h1>
|
|
{!isMac && (
|
|
<button
|
|
onClick={handleClose}
|
|
className="app-no-drag w-8 h-8 flex items-center justify-center rounded-md hover:bg-destructive/20 hover:text-destructive transition-colors text-muted-foreground"
|
|
title={t("common.close")}
|
|
>
|
|
<X size={16} />
|
|
</button>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
<Tabs
|
|
value={activeTab}
|
|
onValueChange={setActiveTab}
|
|
orientation="vertical"
|
|
className="flex-1 flex overflow-hidden"
|
|
>
|
|
<div className="w-56 border-r border-border flex flex-col shrink-0 px-3 py-3">
|
|
<TabsList className="flex flex-col h-auto bg-transparent gap-1 p-0 justify-start">
|
|
<TabsTrigger
|
|
value="application"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<AppWindow size={14} /> {t("settings.tab.application")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="appearance"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<Palette size={14} /> {t("settings.tab.appearance")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="terminal"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<TerminalSquare size={14} /> {t("settings.tab.terminal")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="shortcuts"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<Keyboard size={14} /> {t("settings.tab.shortcuts")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="file-associations"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<FileType size={14} /> {t("settings.tab.sftpFileAssociations")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="ai"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<Sparkles size={14} /> AI
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="sync"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<Cloud size={14} /> {t("settings.tab.syncCloud")}
|
|
</TabsTrigger>
|
|
<TabsTrigger
|
|
value="system"
|
|
className="w-full justify-start gap-2 px-3 py-2 text-sm data-[state=active]:bg-background hover:bg-background/60 rounded-md transition-colors"
|
|
>
|
|
<HardDrive size={14} /> {t("settings.tab.system")}
|
|
</TabsTrigger>
|
|
</TabsList>
|
|
</div>
|
|
|
|
<div className="flex-1 h-full flex flex-col min-h-0 bg-muted/10">
|
|
{mountedTabs.has("application") && (
|
|
<SettingsApplicationTab
|
|
updateState={updateState}
|
|
checkNow={checkNow}
|
|
openReleasePage={openReleasePage}
|
|
installUpdate={installUpdate}
|
|
/>
|
|
)}
|
|
|
|
{mountedTabs.has("appearance") && (
|
|
<SettingsAppearanceTab
|
|
theme={settings.theme}
|
|
setTheme={settings.setTheme}
|
|
lightUiThemeId={settings.lightUiThemeId}
|
|
setLightUiThemeId={settings.setLightUiThemeId}
|
|
darkUiThemeId={settings.darkUiThemeId}
|
|
setDarkUiThemeId={settings.setDarkUiThemeId}
|
|
accentMode={settings.accentMode}
|
|
setAccentMode={settings.setAccentMode}
|
|
customAccent={settings.customAccent}
|
|
setCustomAccent={settings.setCustomAccent}
|
|
uiFontFamilyId={settings.uiFontFamilyId}
|
|
setUiFontFamilyId={settings.setUiFontFamilyId}
|
|
uiLanguage={settings.uiLanguage}
|
|
setUiLanguage={settings.setUiLanguage}
|
|
customCSS={settings.customCSS}
|
|
setCustomCSS={settings.setCustomCSS}
|
|
/>
|
|
)}
|
|
|
|
{mountedTabs.has("terminal") && (
|
|
<SettingsTerminalTab
|
|
terminalThemeId={settings.terminalThemeId}
|
|
setTerminalThemeId={settings.setTerminalThemeId}
|
|
terminalFontFamilyId={settings.terminalFontFamilyId}
|
|
setTerminalFontFamilyId={settings.setTerminalFontFamilyId}
|
|
terminalFontSize={settings.terminalFontSize}
|
|
setTerminalFontSize={settings.setTerminalFontSize}
|
|
terminalSettings={settings.terminalSettings}
|
|
updateTerminalSetting={settings.updateTerminalSetting}
|
|
availableFonts={settings.availableFonts}
|
|
/>
|
|
)}
|
|
|
|
{mountedTabs.has("shortcuts") && (
|
|
<SettingsShortcutsTab
|
|
hotkeyScheme={settings.hotkeyScheme}
|
|
setHotkeyScheme={settings.setHotkeyScheme}
|
|
keyBindings={settings.keyBindings}
|
|
updateKeyBinding={settings.updateKeyBinding}
|
|
resetKeyBinding={settings.resetKeyBinding}
|
|
resetAllKeyBindings={settings.resetAllKeyBindings}
|
|
setIsHotkeyRecording={settings.setIsHotkeyRecording}
|
|
/>
|
|
)}
|
|
|
|
{mountedTabs.has("file-associations") && (
|
|
<SettingsFileAssociationsTab />
|
|
)}
|
|
|
|
{mountedTabs.has("ai") && (
|
|
<AITabErrorBoundary>
|
|
<React.Suspense fallback={null}>
|
|
<SettingsAITab
|
|
providers={aiState.providers}
|
|
addProvider={aiState.addProvider}
|
|
updateProvider={aiState.updateProvider}
|
|
removeProvider={aiState.removeProvider}
|
|
activeProviderId={aiState.activeProviderId}
|
|
setActiveProviderId={aiState.setActiveProviderId}
|
|
activeModelId={aiState.activeModelId}
|
|
setActiveModelId={aiState.setActiveModelId}
|
|
globalPermissionMode={aiState.globalPermissionMode}
|
|
setGlobalPermissionMode={aiState.setGlobalPermissionMode}
|
|
externalAgents={aiState.externalAgents}
|
|
setExternalAgents={aiState.setExternalAgents}
|
|
defaultAgentId={aiState.defaultAgentId}
|
|
setDefaultAgentId={aiState.setDefaultAgentId}
|
|
commandBlocklist={aiState.commandBlocklist}
|
|
setCommandBlocklist={aiState.setCommandBlocklist}
|
|
commandTimeout={aiState.commandTimeout}
|
|
setCommandTimeout={aiState.setCommandTimeout}
|
|
maxIterations={aiState.maxIterations}
|
|
setMaxIterations={aiState.setMaxIterations}
|
|
webSearchConfig={aiState.webSearchConfig}
|
|
setWebSearchConfig={aiState.setWebSearchConfig}
|
|
/>
|
|
</React.Suspense>
|
|
</AITabErrorBoundary>
|
|
)}
|
|
|
|
{mountedTabs.has("sync") && (
|
|
<React.Suspense fallback={null}>
|
|
<SettingsSyncTabWithVault onSettingsApplied={settings.rehydrateAllFromStorage} />
|
|
</React.Suspense>
|
|
)}
|
|
|
|
{mountedTabs.has("system") && (
|
|
<SettingsSystemTab
|
|
sessionLogsEnabled={settings.sessionLogsEnabled}
|
|
setSessionLogsEnabled={settings.setSessionLogsEnabled}
|
|
sessionLogsDir={settings.sessionLogsDir}
|
|
setSessionLogsDir={settings.setSessionLogsDir}
|
|
sessionLogsFormat={settings.sessionLogsFormat}
|
|
setSessionLogsFormat={settings.setSessionLogsFormat}
|
|
toggleWindowHotkey={settings.toggleWindowHotkey}
|
|
setToggleWindowHotkey={settings.setToggleWindowHotkey}
|
|
closeToTray={settings.closeToTray}
|
|
setCloseToTray={settings.setCloseToTray}
|
|
hotkeyRegistrationError={settings.hotkeyRegistrationError}
|
|
globalHotkeyEnabled={settings.globalHotkeyEnabled}
|
|
setGlobalHotkeyEnabled={settings.setGlobalHotkeyEnabled}
|
|
autoUpdateEnabled={settings.autoUpdateEnabled}
|
|
setAutoUpdateEnabled={settings.setAutoUpdateEnabled}
|
|
updateState={updateState}
|
|
checkNow={checkNow}
|
|
installUpdate={installUpdate}
|
|
openReleasePage={openReleasePage}
|
|
/>
|
|
)}
|
|
</div>
|
|
</Tabs>
|
|
</div>
|
|
);
|
|
};
|
|
|
|
export default function SettingsPage() {
|
|
const settings = useSettingsState();
|
|
|
|
return (
|
|
<I18nProvider locale={settings.uiLanguage}>
|
|
<SettingsPageContent settings={settings} />
|
|
</I18nProvider>
|
|
);
|
|
}
|