mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-21 07:32:54 +00:00
* fix(transfer): keep SSH alive when canceling mid-transfer (#4134) Cancel of a large isolated SFTP upload/download used to call sftp.end() mid-WRITE on a channel that shares the terminal SSH transport. That CHANNEL_CLOSE with in-flight traffic can make the remote drop the whole connection, so the shell shows [session closed by remote (no exit status)]. Abort now drains like the shared browse path (no mid-flight end); dispose only after settle. Cancel returns { cancelled: true } so the pool does not treat channel-closed as session loss. * fix(transfer): deferred-dispose soft-cancelled isolated SFTP (#4134) Codex P2 on 88b4890: softDispose dropped cancelled isolated download channels from the pool without ending them, leaking remote subsystems. Schedule sftp.end() after a ~2s quiet settle instead of abandoning forever or ending mid-flight on the shared SSH transport. Aligned cheap fix for isolated fastPut cancel: after force-settle, defer end of the disposable channel the same way. Stopping ssh2 fastXfer internal scheduling still needs invasive hooks — left as documented residual; deferred end after quiet is the minimal leak fix. Tests cover mid-flight isolated upload/download cancel (no end while held) and eventual deferred end after settle. * Revert "fix(transfer): deferred-dispose soft-cancelled isolated SFTP (#4134)" This reverts commit5b85ee70c0. * fix(transfer): dispose soft-cancelled SFTP only after request drain (#4134) Codex 4475686359 on5b85ee70: fixed 2s deferred sftp.end() still fired while READs were pending and could recreate the shared-SSH drop. Poll sftp._requests for quiescence before ending; if still pending past the hard max, skip end (abandon until session close) rather than ending mid-flight. Tests: held isolated download READs past 2s must not end until released; fastPut gate cancel still deferred-ends after drain. * Revert "fix(transfer): dispose soft-cancelled SFTP only after request drain (#4134)" This reverts commit7e9934cd7e. * chore: retrigger CI after lint-and-test runner cancel (#4135) --------- Co-authored-by: binaricat <binaricat@users.noreply.github.com>