mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
* fix(plugins): backfill sync provider bindings after schema upgrade Promote legacy sync-provider-map secrets into the host binding table on open, and infer plugin ownership from sync-credential rows so disconnect still cleans credentials when bindings were never written. Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com> * fix(plugins): infer sync provider owners only via pluginId. namespace Exact pluginId===providerId is not ownership for contribution provider ids; prefer the longest pluginId. prefix when backfilling disconnect cleanup. Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com> * fix(plugins): stop inferring sync owner from credential prefixes Parent plugin ids can namespace-prefix another plugin's provider id. Guessing ownership from sync-credential rows would let disconnect wipe the wrong secrets. Keep host bindings and legacy map backfill as the only ownership sources when no live contribution is present. * fix(plugins): do not overwrite existing sync provider bindings on backfill Legacy sync-provider-map rows from a parent plugin must not steal a provider that already has a host binding. Skip upsert when a binding exists; still delete the stale map secret. * fix(plugins): pick longest owner when legacy map rows conflict Group sync-provider-map rows by provider before binding so a shorter parent plugin cannot win just because SQLite returned it first. Still preserve existing host bindings and delete all leftover map secrets. * fix(plugins): never delete secrets during sync-provider-map backfill The map key prefix is not reserved for host internals; plugins may store ordinary secrets under the same shape. Only seed missing host bindings from candidate rows and leave plugin_secrets untouched. * fix(plugins): seed sync bindings from live provider metadata Schema-2 installs only stored sync-credential* rows. After upgrade, seed missing provider bindings from the host contribution catalog when those credentials exist, instead of guessing from secret key prefixes. * fix(plugins): seed sync bindings from installed manifests, not only enabled listProviders skips disabled/quarantined plugins. Walk installed plugin manifests at host init so schema-2 credential rows under disabled plugins still get provider bindings for disconnect cleanup. * fix(plugins): seed sync bindings from all installed version manifests Active-only listPlugins() misses providers removed/renamed on upgrade while credentials remain under the plugin. Walk every plugin_versions manifest so disconnect can still resolve ownership after schema upgrade. * fix(plugins): only auto-bind single-provider plugins from credentials Plugin-scoped sync-credential* rows are shared across providers. Binding every historical provider would let disconnect of a stale one wipe the active provider's secrets. Seed bindings only when exactly one sync provider is known for that plugin. * fix: address Codex review on PR #2752 * fix(plugins): stop resurrecting sync bindings after unbind Consume promoted sync-provider-map markers and leave an unbound tombstone on disconnect so constructor backfill cannot re-bind a provider the user already disconnected. * fix(plugins): prefer credential-backed owners for legacy map backfill Longest sync-provider-map namespace alone could bind a nested plugin over a parent that still owns sync-credential* secrets. Only promote candidates with credentials; pick the longest among those, and skip when none or ambiguous. * fix(plugins): skip ambiguous multi-credential legacy map backfill Only auto-bind when exactly one credential-backed map candidate exists. When parent and nested plugins both hold credentials for the same provider, longest pluginId is not a reliable owner signal — leave unbound. * fix(plugins): skip cross-plugin provider conflicts in live backfill When multiple credential-backed plugins declare the same providerId via nested namespaces, do not bind the first writer. A later missing-provider disconnect would otherwise delete the wrong sync-credential rows. * fix(plugins): use full installed catalog for enable-time sync backfill Enable-time binding must see the same active+inactive manifest catalog as startup so cross-plugin nested provider ambiguity is not missed when only the newly enabled plugin's live providers would be passed. * fix(plugins): count non-credential manifest claims in backfill conflicts Live nested plugins without credentials yet must still block binding a credential-backed legacy parent to the same providerId, or disconnect can prefer the live owner while the stale binding remains. * fix(plugins): skip legacy map promote on installed-manifest conflicts Constructor-time map backfill must not bind a sole credential-backed parent when another installed package also declares the same sync provider, or later disconnect cannot clear the stale binding. * fix(plugins): require single-provider maps for legacy-map promotion A plugin with one sync-credential row and maps for multiple historical providers must not bind all of them — disconnecting a stale provider would delete the live credentials via the shared prefix. * fix(plugins): count installed manifest providers in legacy-map guard A sole stale map row must not promote when the credential owner's live manifest also declares another sync provider under the same credentials. * fix(plugins): backfill sync bindings before startup activation Seed installed-manifest bindings before contributionService.initialize so an early syncDeleteSecrets cannot miss ownership and leave orphan credentials. * fix(plugins): seed sync bindings at host construction Run installed-manifest backfill when the plugin host is created, before async manager.initialize, so early syncDeleteSecrets can resolve ownership. * fix(plugins): re-seed sync bindings after package store recovery PackageStore.recover can add installed versions after the constructor seed; re-run the catalog backfill when package initialize finishes. * fix(plugins): await manager init before syncDeleteSecrets ownership Block secret cleanup until package recovery and binding seed finish so early disconnect cannot miss retained sync-credential rows. * fix(plugins): re-run legacy-map backfill after package recovery After PackageStore.recover repopulates versions, re-run legacy-map promote so recovered manifests participate in ownership conflict checks. * fix(plugins): defer legacy-map backfill until after package recovery Constructor no longer promotes sole map candidates before recovered manifests are visible. hostService re-runs backfill after package init. * fix(plugins): defer live binding seed until after package recovery Construction-time live-provider backfill can bind a stale owner against an incomplete catalog before PackageStore.recover() restores plugin_versions. Seed only after recovery; syncDeleteSecrets already awaits manager init. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com> Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>