mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-17 21:10:48 +00:00
* feat(scripts): add terminal script automation, recording, and side panel Introduce nct script runtime in the main process with terminal-side recording, execution overlay, Monaco editor, connect-script queues, and scripts side panel integration. Fix recording to wire scriptRecorderRef into xterm, use waitForPrompt for root/user shells, and save recorded scripts through the global editor dialog. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): address Bugbot review findings for recording and side panel Refresh script run state in side panel memo, guard toolbar recording against multi-session conflicts, reset connect scripts on reconnect, resolve focused session via getActiveTerminalSessionId, and avoid wiping host edit form when snippets list updates. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): prevent pending script re-run and improve workspace run feedback Track one-shot pendingScript execution separately from onConnect queue so reconnects do not replay Run-now scripts. Fall back to focused session when running on all tabs outside a workspace, and toast when every tab is still connecting. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): consume connect-script window once and filter serial hosts Mark the onConnect script evaluation as consumed even when the queue is empty so later snippet/host edits do not rerun automation mid-session. Restore serial-host filtering in SelectHostPanel confirm handler. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): grace period before giving up on connect-script queue Only mark onConnect automation as consumed after scripts run or a short post-connect grace window expires, so late-loading snippets still trigger while mid-session Vault edits do not. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): gate connect-script consumption on vault hydration Replace the grace timer with vault-init and unresolved host script binding checks so late-loading snippets still run onConnect automation while mid-session edits stay suppressed. Clear pending script run state on disconnect so reconnect retries workspace pending scripts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): honor run targets and retry failed connect automation Route QuickScriptEditorDialog Run through onRunSnippet for multi-host workspaces. Defer connect/pending script completion markers until each script succeeds and retry the queue after failures. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): stabilize pending runs and global connect queue sync Keep pending script run state across reconnects, run onConnect scripts before one-shot workspace pending scripts, and strip per-host queue entries when an onConnect script targets all hosts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): defer host queue snippet sync and guard connect runs Persist snippet target links only when the host panel is saved, block duplicate connect-script scheduling while a batch is running, and require runnable hosts before showing Run in the snippets editor footer. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): retry connect failures and surface output-trigger errors Use a retry tick in connect-script effect deps, toast automation failures from output triggers, and require runnable hosts before QuickScript Run. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): track id-less pending runs and re-arm output triggers Remember anonymous pendingScript objects after first run and allow onOutput triggers to fire again when new terminal output arrives. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): unblock paused connect runs and pass session meta Resolve waitForScriptRun on pause, run workspace scripts per session with hostname context, defer output-trigger arming until runs start, and add noRunnableHosts i18n for QuickScript Run. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): serialize output triggers and defer empty connect finalize Fire at most one onOutput trigger per scan while a run is active, and only finalize an empty connect queue after vault snippets are loaded. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): guard output launch race and script run waits Block overlapping onOutput launches, timeout stuck waitForScriptRun promises, and disable vault Run when no connectable targets exist. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): match output triggers on new chunks only Scan onOutput patterns against recent terminal output instead of buffer length dedupe, and restore overflow-visible on SelectHostPanel new-host flow. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): await sequential workspace runs and output launch Wait for each tab script to finish in sequential workspace mode, and hold output-trigger launch guard until the session run becomes active. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): wait through pause and hold output trigger until done Keep connect and sequential workspace queues blocked until scripts complete or fail, and retain output-trigger guard until the launched run finishes. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): harden output trigger wait helpers Add explicit timeouts to output-trigger wait helpers and stop rescanning the buffer after script completion to avoid sticky-match rerun loops. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): allow empty connect queue and match output in new chunks Treat an empty connectScriptIds array as an explicit cleared queue instead of re-migrating from snippet targets, and only fire onOutput triggers when the latest terminal output contains the pattern. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): require fresh output overlap for onOutput triggers Only fire output-matched scripts when the regex match extends into the latest terminal chunk, preventing reruns from stale buffer text. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): promote manual scripts added to host connect queue Diff connect queue changes from raw connectScriptIds so saving a host updates manual scripts to onConnect when they are newly queued. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): dedupe output triggers by match position Track the buffer end offset of each output trigger match and ignore stale re-scans, with a longer wait for run registration before retry. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): record output trigger matches only after run starts Propagate automation launch failures to output triggers and commit match dedupe only once the session run is registered as active. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): address Codex review on wait cursor and sensitive codegen Track scan offset so waitFor/waitForAny only match output after the previous wait, and emit sendLine after sensitive prompt in recorded scripts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): harden onOutput triggers against PTY echo and local input Filter server output before pattern matching so onOutput fires only after Enter on real stdout, not on keystroke/paste echo, OSC/SGR sequences, or alternate-screen apps. Add dev diagnostics and scope triggers to the active session when no explicit host targets are configured. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(scripts): remove onOutput trigger debug logging Drop temporary diagnostics module and console traces now that PTY echo filtering is verified; keep the production trigger pipeline unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
205 lines
8.1 KiB
TypeScript
205 lines
8.1 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import { readFileSync } from 'node:fs';
|
|
import test from 'node:test';
|
|
import type { Host } from '../../types';
|
|
|
|
const storage = new Map<string, string>();
|
|
Object.defineProperty(globalThis, 'localStorage', {
|
|
configurable: true,
|
|
value: {
|
|
getItem: (key: string) => storage.get(key) ?? null,
|
|
setItem: (key: string, value: string) => storage.set(key, value),
|
|
removeItem: (key: string) => storage.delete(key),
|
|
},
|
|
});
|
|
|
|
const {
|
|
applyTerminalHostTreeHostRename,
|
|
shouldShowTerminalHostHoverCard,
|
|
getTerminalHostTreeHiddenSurfaceShellWidth,
|
|
getTerminalHostTreeInitialLayoutWidth,
|
|
getTerminalHostTreeLayoutTargetWidth,
|
|
getTerminalHostTreeMeasuredLayoutWidth,
|
|
getTerminalHostTreeSidebarPanelStyle,
|
|
getTerminalHostTreeSidebarShellStyle,
|
|
isTerminalHostTreeSidebarVisible,
|
|
} = await import('./TerminalHostTreeSidebar.tsx');
|
|
const { TERMINAL_HOST_TREE_WIDTH_TRANSITION } = await import('../../application/state/terminalHostTreeAnimation.ts');
|
|
|
|
const host: Host = {
|
|
id: 'host-1',
|
|
label: 'Ubuntu',
|
|
hostname: '10.2.0.124',
|
|
username: 'root',
|
|
port: 22,
|
|
protocol: 'ssh',
|
|
tags: [],
|
|
os: 'linux',
|
|
createdAt: 1,
|
|
};
|
|
|
|
test('host tree sidebar is visually hidden when disabled even if it remains open', () => {
|
|
assert.equal(isTerminalHostTreeSidebarVisible(true, false), false);
|
|
});
|
|
|
|
test('host tree sidebar visibility still follows open state when enabled', () => {
|
|
assert.equal(isTerminalHostTreeSidebarVisible(true, true), true);
|
|
assert.equal(isTerminalHostTreeSidebarVisible(false, true), false);
|
|
});
|
|
|
|
test('host tree sidebar stays collapsed behind root pages', () => {
|
|
assert.equal(isTerminalHostTreeSidebarVisible(true, true, false), false);
|
|
});
|
|
|
|
test('host tree layout target follows visible surface state', () => {
|
|
assert.equal(getTerminalHostTreeLayoutTargetWidth(true, 240), 240);
|
|
assert.equal(getTerminalHostTreeLayoutTargetWidth(false, 240), 0);
|
|
});
|
|
|
|
test('host tree hidden surface shell keeps the open width for return navigation', () => {
|
|
assert.equal(getTerminalHostTreeHiddenSurfaceShellWidth(true, true, 240), 240);
|
|
assert.equal(getTerminalHostTreeHiddenSurfaceShellWidth(false, true, 240), 0);
|
|
assert.equal(getTerminalHostTreeHiddenSurfaceShellWidth(true, false, 240), 0);
|
|
});
|
|
|
|
test('host tree layout starts collapsed so first mount can animate open', () => {
|
|
assert.equal(getTerminalHostTreeInitialLayoutWidth(), 0);
|
|
});
|
|
|
|
test('host tree layout sync can sample the current shell width before targeting', () => {
|
|
assert.equal(getTerminalHostTreeMeasuredLayoutWidth({
|
|
getBoundingClientRect: () => ({ width: 84 }),
|
|
} as unknown as HTMLElement, 240), 84);
|
|
assert.equal(getTerminalHostTreeMeasuredLayoutWidth({
|
|
getBoundingClientRect: () => ({ width: -12 }),
|
|
} as unknown as HTMLElement, 240), 0);
|
|
assert.equal(getTerminalHostTreeMeasuredLayoutWidth(null, 240), 240);
|
|
});
|
|
|
|
test('host tree layout width follows the animated shell via ResizeObserver', () => {
|
|
const source = readFileSync(new URL('./TerminalHostTreeSidebar.tsx', import.meta.url), 'utf8');
|
|
|
|
assert.match(source, /new ResizeObserver/);
|
|
assert.match(source, /syncLayoutWidthFromShell/);
|
|
assert.doesNotMatch(source, /performance\.now\(\)/);
|
|
});
|
|
|
|
test('host tree keeps shell width while hidden behind root pages', () => {
|
|
const source = readFileSync(new URL('./TerminalHostTreeSidebar.tsx', import.meta.url), 'utf8');
|
|
|
|
assert.match(source, /isResizing \|\| !surfaceVisible/);
|
|
assert.match(source, /const hiddenSurfaceShellWidth = getTerminalHostTreeHiddenSurfaceShellWidth/);
|
|
assert.match(source, /if \(!surfaceVisible\) \{\s*setShellWidth\(hiddenSurfaceShellWidth\);\s*terminalHostTreeStore\.setLayoutWidth\(0\);/);
|
|
assert.doesNotMatch(source, /if \(!surfaceVisible\) \{\s*setShellWidth\(0\);/);
|
|
});
|
|
|
|
test('host tree sidebar memo tracks surface visibility and theme changes', () => {
|
|
const source = readFileSync(new URL('./TerminalHostTreeSidebar.tsx', import.meta.url), 'utf8');
|
|
|
|
assert.match(source, /prev\.surfaceVisible === next\.surfaceVisible/);
|
|
assert.match(source, /themeFingerprint\(prev\.resolvedPreviewTheme\) === themeFingerprint\(next\.resolvedPreviewTheme\)/);
|
|
});
|
|
|
|
test('host tree sidebar clips the panel instead of fading it out while closing', () => {
|
|
const theme = {
|
|
termBg: '#000000',
|
|
termFg: '#ffffff',
|
|
mutedFg: '#999999',
|
|
separator: '#333333',
|
|
rowHoverBg: '#111111',
|
|
rowActiveBg: '#222222',
|
|
rowDropBg: '#444444',
|
|
folderFg: '#cccccc',
|
|
};
|
|
|
|
assert.deepEqual(getTerminalHostTreeSidebarShellStyle(false, 0, TERMINAL_HOST_TREE_WIDTH_TRANSITION), {
|
|
width: 0,
|
|
transition: TERMINAL_HOST_TREE_WIDTH_TRANSITION,
|
|
pointerEvents: 'none',
|
|
});
|
|
assert.equal(getTerminalHostTreeSidebarPanelStyle({
|
|
isVisible: false,
|
|
displayWidth: 240,
|
|
panelTransition: 'border-color 220ms ease-out',
|
|
theme,
|
|
}).width, 240);
|
|
assert.equal(getTerminalHostTreeSidebarPanelStyle({
|
|
isVisible: false,
|
|
displayWidth: 240,
|
|
panelTransition: 'border-color 220ms ease-out',
|
|
theme,
|
|
}).opacity, 1);
|
|
});
|
|
|
|
test('host tree sidebar colors can be overridden by immediate preview styles', () => {
|
|
const theme = {
|
|
termBg: 'var(--terminal-host-tree-bg, #000000)',
|
|
termFg: 'var(--terminal-host-tree-fg, #ffffff)',
|
|
mutedFg: 'var(--terminal-host-tree-muted, #999999)',
|
|
separator: 'var(--terminal-host-tree-separator, #333333)',
|
|
rowHoverBg: 'var(--terminal-host-tree-hover-bg, #111111)',
|
|
rowActiveBg: 'var(--terminal-host-tree-active-bg, #222222)',
|
|
rowDropBg: 'var(--terminal-host-tree-drop-bg, #444444)',
|
|
folderFg: 'var(--terminal-host-tree-folder-fg, #cccccc)',
|
|
};
|
|
|
|
const style = getTerminalHostTreeSidebarPanelStyle({
|
|
isVisible: true,
|
|
displayWidth: 240,
|
|
panelTransition: 'border-color 220ms ease-out',
|
|
theme,
|
|
});
|
|
|
|
assert.equal(style.backgroundColor, theme.termBg);
|
|
assert.equal(style.color, theme.termFg);
|
|
assert.equal(style.borderRight, `1px solid ${theme.separator}`);
|
|
});
|
|
|
|
test('host tree host inline rename trims and updates the matching host label', () => {
|
|
const result = applyTerminalHostTreeHostRename([host], 'host-1', ' web-01 ');
|
|
|
|
assert.equal(result.changed, true);
|
|
assert.equal(result.hosts[0].label, 'web-01');
|
|
});
|
|
|
|
test('host tree host inline rename rejects empty names without changing hosts', () => {
|
|
const hosts = [host];
|
|
const result = applyTerminalHostTreeHostRename(hosts, 'host-1', ' ');
|
|
|
|
assert.equal(result.changed, false);
|
|
assert.equal(result.reason, 'required');
|
|
assert.equal(result.hosts, hosts);
|
|
});
|
|
|
|
test('host tree hover card is hidden while the same host is inline editing', () => {
|
|
assert.equal(shouldShowTerminalHostHoverCard('host-1', null), true);
|
|
assert.equal(shouldShowTerminalHostHoverCard('host-1', 'host-2'), true);
|
|
assert.equal(shouldShowTerminalHostHoverCard('host-1', 'host-1'), false);
|
|
});
|
|
|
|
test('host tree hover card renders markdown notes and keeps host details out of the header subtitle', () => {
|
|
const source = readFileSync(new URL('./TerminalHostTreeSidebar.tsx', import.meta.url), 'utf8');
|
|
|
|
assert.match(source, /<LazyMessageResponse/);
|
|
assert.match(source, /size="sm"/);
|
|
assert.match(source, /items-center gap-2/);
|
|
assert.match(source, /flex h-5 min-w-0 items-center/);
|
|
assert.match(source, /translate-y-px truncate text-\[15px\] font-semibold leading-none/);
|
|
assert.match(source, /details\.host/);
|
|
assert.doesNotMatch(source, /text-muted-foreground">\{host\.hostname\}/);
|
|
assert.match(source, /host-tree-notes-scroll/);
|
|
assert.match(source, /overflow-y-auto/);
|
|
assert.doesNotMatch(source, /details\.lastConnected/);
|
|
});
|
|
|
|
test('host tree row icons, labels, and protocol badges share centered line boxes', () => {
|
|
const source = readFileSync(new URL('./TerminalHostTreeSidebar.tsx', import.meta.url), 'utf8');
|
|
|
|
assert.match(source, /flex h-5 shrink-0 items-center justify-center">\s*<DistroAvatar/);
|
|
assert.match(source, /flex min-w-0 flex-1 items-center truncate leading-none/);
|
|
assert.match(source, /flex shrink-0 items-center text-\[10px\] leading-none uppercase/);
|
|
assert.match(source, /flex h-5 w-4 shrink-0 items-center/);
|
|
assert.match(source, /flex h-5 shrink-0 items-center">\s*\{isExpanded/);
|
|
assert.match(source, /flex min-w-0 flex-1 items-center truncate leading-none">\{node\.name\}/);
|
|
});
|