mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-17 13:01:24 +00:00
* fix: allow settings window as trusted IPC sender The settings window runs in a separate BrowserWindow with its own webContents id. validateSender() only checked the main window id, causing "Unauthorized IPC sender" errors when fetching AI model lists from the settings page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add validateSender to all remaining AI IPC handlers 15 handlers in aiBridge were missing sender validation, allowing potential unauthorized IPC calls. Now every netcatty:ai:* handler consistently validates the sender against trusted windows. Affected handlers: chat:cancel, agents:discover, resolve-cli, codex:get-integration, codex:start-login, codex:get-login-session, codex:cancel-login, codex:logout, mcp:update-sessions, mcp:set-command-blocklist, mcp:set-command-timeout, mcp:set-max-iterations, mcp:set-permission-mode, acp:cancel, acp:cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: scope settings window trust to config-only IPC handlers Per code review feedback: the previous commit allowed the settings window to access ALL AI IPC handlers including high-risk ones like exec, terminal:write, and agent:spawn. Split into two validators: - validateSender(): main window only (exec, terminal, agent, stream) - validateSenderOrSettings(): main + settings (fetch, sync, codex login, MCP config, agent discovery) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: refresh main window id on recreation and allow settings fetch Two fixes from code review: 1. Always resolve mainWebContentsId from windowManager instead of caching it once, so a recreated main window is recognized. 2. Skip static host allowlist for settings window ai:fetch calls, since the settings UI lets users configure custom provider URLs that haven't been synced to providerFetchHosts yet. Basic URL safety (HTTPS-only, no file:// schemes) is still enforced. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: enforce HTTPS/port safety for settings window fetch requests Per review: previous commit skipped isAllowedFetchUrl entirely for settings window, which removed SSRF protection. Now settings window fetches still bypass the static host allowlist (since the user is configuring new providers) but enforce the same safety rules: - Remote hosts must use HTTPS - Localhost must use known ports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: sync provider config before fetching models in settings Instead of bypassing the URL allowlist for settings window fetches (which weakens SSRF protection), have ModelSelector sync the current provider's baseURL to the backend allowlist before fetching models. This keeps the full URL safety checks intact while allowing settings to test custom provider endpoints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use dedicated allowlist handler instead of syncing providers Replace the approach of calling aiSyncProviders (which overwrites the shared providerConfigs) with a new lightweight IPC handler netcatty:ai:allowlist:add-host that only adds a host to the fetch allowlist without affecting provider configs or API key resolution. This preserves the SSRF protection while allowing settings to test custom provider URLs that haven't been synced from the main window. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: auto-expire temporary allowlist entries after 30 seconds Temporary hosts added via allowlist:add-host now auto-remove after 30s to prevent permanently expanding the SSRF boundary. Built-in ports and hosts re-added by provider sync are preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: prevent temp allowlist cleanup from removing synced providers The setTimeout cleanup now checks whether the host/port belongs to a currently synced provider config before removing it. This prevents the scenario where a user saves a provider within the 30s TTL window and then loses access when the timer fires. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve temp allowlist entries across provider sync rebuilds rebuildProviderFetchHosts() clears and rebuilds the allowlist from providerConfigs, which would wipe temporary entries added by allowlist:add-host. Now re-adds active temp entries after rebuild to prevent race conditions between settings model listing and provider sync from the main window. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>