Files
Netcatty/application/AppHandlers.connect.test.ts
T
bincxz 9a0956595c fix(ssh): drop host MFA switch; password-first with automatic KI fallback
Always try password before keyboard-interactive for the first factor. After
any partial success, prefer keyboard-interactive when the server still allows
it so multi-factor/EDR second factors work without a per-host switch. Remove
the requiresMfa UI and "remember MFA" checkbox; keep secondary-prompt
protections and hostId-aware password save.
2026-07-15 23:51:46 +08:00

268 lines
7.0 KiB
TypeScript

import assert from 'node:assert/strict';
import test from 'node:test';
import {
flushQueuedTrayPanelConnectHostsImpl,
handleConnectToHostImpl,
handleKeyboardInteractiveSubmitImpl,
handleTrayPanelConnectRequestImpl,
} from './app/AppHandlers.ts';
import type { Host } from '../types';
const baseHost: Host = {
id: 'host-1',
label: '10.2.0.32',
hostname: '10.2.0.32',
username: 'root',
tags: [],
os: 'linux',
protocol: 'ssh',
};
test('connect host handler returns the created terminal tab id', () => {
const logs: unknown[] = [];
const connectedHosts: Host[] = [];
const result = handleConnectToHostImpl(
() => ({
addConnectionLog: (entry: unknown) => logs.push(entry),
connectToHost: (host: Host) => {
connectedHosts.push(host);
return 'session-from-connect';
},
identities: [],
keys: [],
resolveEffectiveHost: (host: Host) => host,
resolveHostAuth: () => ({ username: 'root' }),
systemInfoRef: { current: { username: 'local-user', hostname: 'local-host' } },
}),
baseHost,
);
assert.equal(result, 'session-from-connect');
assert.equal(connectedHosts.length, 1);
assert.equal(logs.length, 1);
});
test('connect serial host handler returns the created terminal tab id', () => {
const serialHost: Host = {
...baseHost,
id: 'serial-1',
label: '',
hostname: '/dev/tty.usbserial',
protocol: 'serial',
};
const result = handleConnectToHostImpl(
() => ({
addConnectionLog: () => {},
connectToHost: () => 'serial-session',
identities: [],
keys: [],
resolveEffectiveHost: (host: Host) => host,
resolveHostAuth: () => ({ username: 'root' }),
systemInfoRef: { current: { username: 'local-user', hostname: 'local-host' } },
}),
serialHost,
);
assert.equal(result, 'serial-session');
});
test('tray panel connect request queues until the vault is initialized', () => {
const queuedHostIds: string[] = [];
const connectedHostIds: string[] = [];
handleTrayPanelConnectRequestImpl(
() => ({
connectNow: (hostId: string) => connectedHostIds.push(hostId),
isVaultInitialized: false,
queueConnect: (hostId: string) => queuedHostIds.push(hostId),
}),
'host-1',
);
assert.deepEqual(queuedHostIds, ['host-1']);
assert.deepEqual(connectedHostIds, []);
});
test('tray panel connect request runs immediately after the vault is initialized', () => {
const queuedHostIds: string[] = [];
const connectedHostIds: string[] = [];
handleTrayPanelConnectRequestImpl(
() => ({
connectNow: (hostId: string) => connectedHostIds.push(hostId),
isVaultInitialized: true,
queueConnect: (hostId: string) => queuedHostIds.push(hostId),
}),
'host-1',
);
assert.deepEqual(queuedHostIds, []);
assert.deepEqual(connectedHostIds, ['host-1']);
});
test('queued tray panel connects flush in order', () => {
const connectedHostIds: string[] = [];
let pendingHostIds = ['host-1', 'host-2'];
flushQueuedTrayPanelConnectHostsImpl(() => ({
connectNow: (hostId: string) => connectedHostIds.push(hostId),
pendingHostIds,
setPendingHostIds: (nextHostIds: string[]) => {
pendingHostIds = nextHostIds;
},
}));
assert.deepEqual(connectedHostIds, ['host-1', 'host-2']);
assert.deepEqual(pendingHostIds, []);
});
test('keyboard-interactive submit can save login password for the session host', () => {
let hosts: Host[] = [{
...baseHost,
password: 'old-password',
savePassword: false,
}];
let queue = [{
requestId: 'ki-1',
sessionId: 'session-1',
hostname: baseHost.hostname,
allowSavePassword: true,
}];
const bridgeResponses: unknown[] = [];
const hostUpdates: Host[][] = [];
handleKeyboardInteractiveSubmitImpl(
() => ({
hosts,
keyboardInteractiveQueue: queue,
netcattyBridge: {
get: () => ({
respondKeyboardInteractive: (...args: unknown[]) => {
bridgeResponses.push(args);
},
}),
},
sessions: [{
id: 'session-1',
hostId: baseHost.id,
hostname: baseHost.hostname,
}],
setKeyboardInteractiveQueue: (updater: (items: typeof queue) => typeof queue) => {
queue = updater(queue);
},
updateHosts: (nextHosts: Host[]) => {
hostUpdates.push(nextHosts);
hosts = nextHosts;
},
}),
'ki-1',
['login-password', 'otp-code'],
'new-login-password',
);
assert.equal(hostUpdates.length, 1);
assert.deepEqual(hosts[0], {
...baseHost,
password: 'new-login-password',
savePassword: true,
});
assert.deepEqual(queue, []);
assert.equal(bridgeResponses.length, 1);
});
test('keyboard-interactive submit does not save secondary password when allowSavePassword is false', () => {
let hosts: Host[] = [{
...baseHost,
password: 'login-password',
}];
let queue = [{
requestId: 'ki-external',
sessionId: 'sftp-connection-1',
hostId: baseHost.id,
scope: 'external',
hostname: baseHost.hostname,
allowSavePassword: false,
}];
let hostUpdates = 0;
handleKeyboardInteractiveSubmitImpl(
() => ({
hosts,
keyboardInteractiveQueue: queue,
netcattyBridge: {
get: () => ({
respondKeyboardInteractive: () => {},
}),
},
sessions: [],
setKeyboardInteractiveQueue: (updater: (items: typeof queue) => typeof queue) => {
queue = updater(queue);
},
updateHosts: (nextHosts: Host[]) => {
hostUpdates += 1;
hosts = nextHosts;
},
}),
'ki-external',
['secondary-password'],
'should-not-save',
);
assert.equal(hostUpdates, 0);
assert.equal(hosts[0].password, 'login-password');
assert.deepEqual(queue, []);
});
test('keyboard-interactive submit uses explicit hostId when saving password', () => {
const jumpHost: Host = {
...baseHost,
id: 'jump-1',
label: 'Jump',
hostname: 'jump.example.com',
password: 'old-jump-password',
};
let hosts: Host[] = [{
...baseHost,
password: 'target-password',
}, jumpHost];
let queue = [{
requestId: 'ki-jump',
sessionId: 'terminal-session-1',
hostId: jumpHost.id,
scope: 'terminal',
hostname: jumpHost.hostname,
allowSavePassword: true,
}];
handleKeyboardInteractiveSubmitImpl(
() => ({
hosts,
keyboardInteractiveQueue: queue,
netcattyBridge: {
get: () => ({
respondKeyboardInteractive: () => {},
}),
},
sessions: [{
id: 'terminal-session-1',
hostId: baseHost.id,
hostname: baseHost.hostname,
}],
setKeyboardInteractiveQueue: (updater: (items: typeof queue) => typeof queue) => {
queue = updater(queue);
},
updateHosts: (nextHosts: Host[]) => {
hosts = nextHosts;
},
}),
'ki-jump',
['jump-login-password'],
'new-jump-password',
);
assert.equal(hosts.find((host) => host.id === baseHost.id)?.password, 'target-password');
assert.equal(hosts.find((host) => host.id === jumpHost.id)?.password, 'new-jump-password');
});