mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-17 21:10:48 +00:00
* fix(sftp): update currentPath immediately on navigation to prevent stale upload target When navigating directories without a cache hit, currentPath was only updated after the async file listing completed. If a drag-and-drop upload occurred during or shortly after this window, getActivePane would return the old currentPath, causing files to upload to the previous directory. Now currentPath is updated immediately when loading begins, ensuring upload operations always target the correct directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): revert currentPath to previous value when navigation fails Address review feedback: if the directory listing throws a non-session error, restore currentPath to its previous value so later operations (e.g. uploads) don't target a path that was never successfully loaded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): clear files when entering loading state to prevent stale interactions Address P1 review: the loading overlay is pointer-events-none, so users could still interact with old files during navigation. Since currentPath is now updated immediately, actions like delete/rename would resolve against the new path but display old files. Clear files and selection when loading begins to eliminate this inconsistency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): restore previous files when reverting path on navigation error Address P2 review: since files are now cleared when loading begins, a failed navigation would leave the pane with the old path but an empty file list. Save and restore the previous files alongside the previous path in the error handler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): restore selected files when reverting on navigation error Address P2 review: save and restore selectedFiles alongside path and files in the error handler so users don't lose their selection when a navigation attempt fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): restore tab state when navigation is superseded by another request Address P1 review: navSeqRef is tracked per-side not per-tab, so a navigation from a different tab on the same side can invalidate this request. When the sequence check causes an early return, restore this tab's previous path, files, and selection instead of leaving it with cleared files and a stale loading state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): avoid overwriting newer navigation state when superseded When a navigation request is superseded by a newer one on the same tab (e.g., fast A→B→C), the completing request should not blindly restore its previous state, as that would overwrite the latest navigation's optimistic update. Now we check if the tab's current path still matches what this request set before restoring. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): use per-tab request ID to guard superseded navigation restores Replace the ambiguous currentPath equality check with a per-tab navigation request ID (tabNavSeqRef). The old check failed when refresh() triggered a navigation to the same path — the stale request would incorrectly match and restore previous state. The new approach tracks the latest requestId per tab, so: - Same-tab superseded navigations (including same-path refreshes) correctly skip the restore. - Cross-tab superseded navigations (different tab on the same side) correctly restore the orphaned tab's state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): track per-tab nav sequence to prevent cache-hit state overwrite When a cache-miss request (A) is pending and a cache-hit request (B) runs on the same tab, A's superseded handler could overwrite B's result because it only checked path equality. Add tabNavSeqRef to track the latest requestId per tab, so superseded requests correctly skip restore when a newer navigation (including cache hits) has already handled the tab. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: remove leftover merge conflict markers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): restore to last confirmed state instead of optimistic state When multiple navigations are in flight (A→B→C), the second navigation would snapshot the optimistic state (path=B, files=[]) as its "previous" state. If it then failed or was superseded, it would restore to an empty file list instead of the last successfully loaded directory. Introduce lastConfirmedRef to track the last known-good state per tab, updated only on successful navigation (cache hit or listing success). Restore-on-error and restore-on-supersede now always revert to this confirmed state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): guard restores against stale connection after reconnect/disconnect connect() and disconnect() reuse the same tab ID but bump navSeqRef without updating tabNavSeqRef, so a pending navigation could restore stale state from a previous host into a freshly reconnected tab. Fix by: - Capturing connectionId at navigation start and checking it in every updateTab restore callback (prev.connection?.id !== connectionId) - Storing connectionId in lastConfirmedRef and re-seeding confirmed state when the connection changes, preventing old host data from being used as the restore target Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): keep files visible during loading and re-seed confirmed state Two UI regressions fixed: 1. After a file mutation (delete/create/rename), lastConfirmedRef still held the pre-mutation snapshot. If the subsequent refresh failed, the error handler would restore stale files (e.g. resurrecting deleted items). Fix: re-seed confirmed state from the pane whenever it is settled (not loading), capturing any optimistic mutation updates. 2. Clearing files to [] on navigation start left a tab blank when superseded by another tab navigating on the same side. Fix: keep existing files visible during loading — the loading overlay already has pointer-events-none to prevent interaction. Files are replaced on success or restored from lastConfirmedRef on error/supersede. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(sftp): block interaction with stale files during directory loading The loading overlay used pointer-events-none, allowing clicks to pass through to stale file rows underneath. Since currentPath is updated immediately on navigation, interacting with old filenames during a slow load would resolve paths against the new directory. Remove pointer-events-none from the loading overlay so it properly blocks all interaction with the stale file list while loading. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore: ignore .claude/ directory in eslint config The .claude/worktrees/ directory contains full repo copies from agent worktrees. ESLint was scanning these, causing 621 pre-existing errors (no-undef for Node.js globals in .cjs files) that blocked npm run dev. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>