mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
Fixes #1952. When restore-terminal-cwd is on, local POSIX shells probe the PTY process cwd (/proc on Linux, lsof on macOS) and re-probe when the prompt returns so slow commands like `sleep 1; cd /tmp` land correctly. SSH restore path unchanged.
134 lines
4.6 KiB
TypeScript
134 lines
4.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { readFileSync } from "node:fs";
|
|
|
|
import { canScheduleCommandCwdProbe, shouldProbeCommandCwd } from "./commandCwdProbe";
|
|
|
|
test("probes command cwd for session restore even when the SFTP panel is not visible", () => {
|
|
assert.equal(
|
|
shouldProbeCommandCwd({
|
|
restoreTerminalCwd: true,
|
|
visibleSftpHost: null,
|
|
sessionHost: { sftpFollowTerminalCwd: false },
|
|
globalSftpFollowTerminalCwd: false,
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("does not probe command cwd when neither session restore nor SFTP follow cwd needs it", () => {
|
|
assert.equal(
|
|
shouldProbeCommandCwd({
|
|
restoreTerminalCwd: false,
|
|
visibleSftpHost: null,
|
|
sessionHost: { sftpFollowTerminalCwd: true },
|
|
globalSftpFollowTerminalCwd: true,
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("probes command cwd for visible SFTP follow cwd using host override", () => {
|
|
assert.equal(
|
|
shouldProbeCommandCwd({
|
|
restoreTerminalCwd: false,
|
|
visibleSftpHost: { sftpFollowTerminalCwd: true },
|
|
sessionHost: { sftpFollowTerminalCwd: false },
|
|
globalSftpFollowTerminalCwd: false,
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("visible SFTP host override can disable command cwd probing", () => {
|
|
assert.equal(
|
|
shouldProbeCommandCwd({
|
|
restoreTerminalCwd: false,
|
|
visibleSftpHost: { sftpFollowTerminalCwd: false },
|
|
sessionHost: { sftpFollowTerminalCwd: true },
|
|
globalSftpFollowTerminalCwd: true,
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("schedules the post-command cwd probe for a connected local POSIX shell", () => {
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "local", status: "connected", shellType: "posix" }),
|
|
true,
|
|
);
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "local", status: "connected" }),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("does not schedule a local cwd probe for Windows shells or a disconnected shell", () => {
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "local", status: "connected", shellType: "powershell" }),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "local", status: "connected", shellType: "cmd" }),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "local", status: "connecting", shellType: "posix" }),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("keeps the SSH post-command probe on reusable connections only", () => {
|
|
assert.equal(canScheduleCommandCwdProbe({ protocol: "ssh", status: "connected" }), true);
|
|
assert.equal(canScheduleCommandCwdProbe({ protocol: "ssh", status: "disconnected" }), false);
|
|
assert.equal(
|
|
canScheduleCommandCwdProbe({ protocol: "ssh", status: "connected", moshEnabled: true }),
|
|
false,
|
|
);
|
|
assert.equal(canScheduleCommandCwdProbe({ protocol: "telnet", status: "connected" }), false);
|
|
});
|
|
|
|
test("local command submission uses the shared cwd probe gate", () => {
|
|
const source = readFileSync(new URL("../TerminalLayer.tsx", import.meta.url), "utf8");
|
|
const start = source.indexOf("const handleCommandSubmitted = useCallback");
|
|
const end = source.indexOf("const handleCommandExecuted = useCallback", start);
|
|
const body = source.slice(start, end);
|
|
assert.match(body, /canScheduleCommandCwdProbe\(session\)/);
|
|
assert.match(body, /session\.protocol === "local"\) return true/);
|
|
});
|
|
|
|
test("local prompt return re-runs the cwd probe after the command finishes", () => {
|
|
const effects = readFileSync(new URL("../terminal/useTerminalEffects.ts", import.meta.url), "utf8");
|
|
const completed = effects.slice(
|
|
effects.indexOf("const pluginAwareOnCommandCompleted"),
|
|
effects.indexOf("const isRendererActive ="),
|
|
);
|
|
assert.match(completed, /if \(isLocalConnection\)/);
|
|
assert.match(completed, /onCommandSettledRef\.current\?\.\("", host\.id, host\.label, sessionId\)/);
|
|
|
|
const terminal = readFileSync(new URL("../Terminal.tsx", import.meta.url), "utf8");
|
|
const wakeCompleted = terminal.slice(
|
|
terminal.indexOf("const pluginAwareOnCommandCompleted = useCallback"),
|
|
terminal.indexOf("const pluginAwareOnTerminalCwdChange"),
|
|
);
|
|
assert.match(wakeCompleted, /host\.protocol === "local"/);
|
|
assert.match(wakeCompleted, /onCommandSubmitted\?\.\("", host\.id, host\.label, sessionId\)/);
|
|
assert.match(
|
|
terminal,
|
|
/onCommandSubmitted: cwdAwareOnCommandSubmitted, onCommandSettled: onCommandSubmitted/,
|
|
);
|
|
});
|
|
|
|
test("does not probe command cwd on single-channel SSH hosts", () => {
|
|
assert.equal(
|
|
shouldProbeCommandCwd({
|
|
restoreTerminalCwd: true,
|
|
visibleSftpHost: { sftpFollowTerminalCwd: true },
|
|
sessionHost: { sftpFollowTerminalCwd: true },
|
|
globalSftpFollowTerminalCwd: true,
|
|
restrictExtraSshChannels: true,
|
|
}),
|
|
false,
|
|
);
|
|
});
|