mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-11 08:42:45 +00:00
* fix(#3335): automated AI fix * fix: address Codex review on PR #3336 * fix: address Codex review on PR #3336 --------- Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
139 lines
4.4 KiB
TypeScript
139 lines
4.4 KiB
TypeScript
import { describe, it } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import {
|
|
isBoldWeightDistinctWithContext,
|
|
pickNearestBundledWeight,
|
|
resolveFontWeightBold,
|
|
} from './fontWeightAvailability';
|
|
|
|
function makeWeightContext(weightsByFamily: Record<string, Partial<Record<number, number>>>) {
|
|
return {
|
|
measureText: (font: string, text: string) => {
|
|
const match = font.match(/^(\d+)\s+\d+px\s+"?([^",]+)"?,/);
|
|
const weight = match ? Number(match[1]) : 400;
|
|
const family = match?.[2] ?? '';
|
|
const width = weightsByFamily[family]?.[weight] ?? weightsByFamily[family]?.[400] ?? 100;
|
|
return {
|
|
width: width * text.length,
|
|
actualBoundingBoxAscent: 10,
|
|
actualBoundingBoxDescent: 2,
|
|
} as TextMetrics;
|
|
},
|
|
};
|
|
}
|
|
|
|
describe('pickNearestBundledWeight', () => {
|
|
it('returns the desired weight when bundled', () => {
|
|
assert.equal(pickNearestBundledWeight([400, 500, 600], 600, 400), 600);
|
|
});
|
|
|
|
it('falls back to the nearest heavier bundled weight', () => {
|
|
assert.equal(pickNearestBundledWeight([400, 500, 600], 700, 400), 600);
|
|
});
|
|
|
|
it('returns normal weight when nothing heavier is bundled', () => {
|
|
assert.equal(pickNearestBundledWeight([400], 700, 400), 400);
|
|
});
|
|
});
|
|
|
|
describe('isBoldWeightDistinctWithContext', () => {
|
|
it('detects a real bold face via width differences', () => {
|
|
const ctx = makeWeightContext({
|
|
Menlo: { 400: 10, 700: 12 },
|
|
});
|
|
assert.equal(isBoldWeightDistinctWithContext('Menlo', 400, 700, 14, ctx), true);
|
|
});
|
|
|
|
it('detects a real bold face via ascent differences', () => {
|
|
const ctx = {
|
|
measureText: (font: string, text: string) => {
|
|
const isBold = font.startsWith('700 ');
|
|
return {
|
|
width: text.length * 10,
|
|
actualBoundingBoxAscent: isBold ? 12 : 10,
|
|
actualBoundingBoxDescent: 2,
|
|
} as TextMetrics;
|
|
},
|
|
};
|
|
assert.equal(isBoldWeightDistinctWithContext('Menlo', 400, 700, 14, ctx), true);
|
|
});
|
|
|
|
it('rejects unavailable bold weights that collapse to the normal face', () => {
|
|
const ctx = makeWeightContext({
|
|
Menlo: { 400: 10, 700: 10 },
|
|
});
|
|
assert.equal(isBoldWeightDistinctWithContext('Menlo', 400, 700, 14, ctx), false);
|
|
});
|
|
|
|
it('detects metric-aligned variable-font bold via ink coverage (#3335)', () => {
|
|
// Roboto Mono VF: identical width/ascent/descent across wght, but real
|
|
// weights carry proportionally more ink (measured ~1.25x for 700/400).
|
|
const inkByWeight: Partial<Record<number, number>> = { 400: 1000, 700: 1252 };
|
|
const ctx = {
|
|
measureText: () =>
|
|
({
|
|
width: 117.6191,
|
|
actualBoundingBoxAscent: 10.0967,
|
|
actualBoundingBoxDescent: 0.1367,
|
|
}) as TextMetrics,
|
|
measureTextInk: (font: string) => {
|
|
const weight = Number(font.match(/^(\d+)\s/)?.[1] ?? 400);
|
|
return inkByWeight[weight] ?? 1000;
|
|
},
|
|
};
|
|
assert.equal(isBoldWeightDistinctWithContext('Roboto Mono', 400, 700, 14, ctx), true);
|
|
});
|
|
|
|
it('keeps rejecting a bold weight whose ink matches the normal weight', () => {
|
|
const ctx = {
|
|
measureText: () =>
|
|
({
|
|
width: 117.6191,
|
|
actualBoundingBoxAscent: 10.0967,
|
|
actualBoundingBoxDescent: 0.1367,
|
|
}) as TextMetrics,
|
|
measureTextInk: () => 1000,
|
|
};
|
|
assert.equal(isBoldWeightDistinctWithContext('Roboto Mono', 400, 700, 14, ctx), false);
|
|
});
|
|
|
|
it('ignores sub-threshold ink jitter between weights', () => {
|
|
const ctx = {
|
|
measureText: () =>
|
|
({
|
|
width: 117.6191,
|
|
actualBoundingBoxAscent: 10.0967,
|
|
actualBoundingBoxDescent: 0.1367,
|
|
}) as TextMetrics,
|
|
measureTextInk: (font: string) => (font.startsWith('700 ') ? 1005 : 1000),
|
|
};
|
|
assert.equal(isBoldWeightDistinctWithContext('Roboto Mono', 400, 700, 14, ctx), false);
|
|
});
|
|
});
|
|
|
|
describe('resolveFontWeightBold', () => {
|
|
it('caps bundled JetBrains Mono bold at 600 when 700 is requested', () => {
|
|
assert.equal(
|
|
resolveFontWeightBold({
|
|
fontFamilyCss: '"JetBrains Mono", monospace',
|
|
normalWeight: 400,
|
|
desiredBoldWeight: 700,
|
|
fontSize: 14,
|
|
}),
|
|
600,
|
|
);
|
|
});
|
|
|
|
it('returns normal weight when bold is not heavier than normal', () => {
|
|
assert.equal(
|
|
resolveFontWeightBold({
|
|
fontFamilyCss: '"JetBrains Mono", monospace',
|
|
normalWeight: 600,
|
|
desiredBoldWeight: 500,
|
|
fontSize: 14,
|
|
}),
|
|
600,
|
|
);
|
|
});
|
|
});
|