Commit Graph
11 Commits
Author SHA1 Message Date
bincxzandClaude a3380d26e8 fix: base raw-paste splitting on the sanitized payload
Co-Authored-By: Claude <noreply@anthropic.com>
2026-08-27 15:58:21 +08:00
bincxz 5dbede1368 Merge commit '08044ee98' into pr-3156-resolve
# Conflicts:
#	components/terminal/runtime/createXTermRuntime.ts
#	components/terminal/runtime/shiftEnterText.test.ts
#	components/terminal/runtime/terminalImeTextInput.test.ts
2026-08-27 15:43:24 +08:00
bincxzandClaude d809b6c3fa fix(terminal): send IME commits and short pastes per character
Strict bastion prompts (QAX/奇安信) treat one SSH channel write as a single keystroke and silently drop every multi-character chunk, so an IME commit of two or more hanzi and a Chinese paste both reach the bastion's search prompt as nothing at all. Single characters work, which is why typing them one at a time is the only path that works today.

Split plain multi-character text at the send boundary instead of adding a setting: the write side of handleTerminalInputData now iterates one chunk per Unicode code point, and all bookkeeping (command buffer, script recorder, autocomplete, sudo autofill, broadcast, scroll) still sees the original payload exactly once. IME commits split whenever the committed text has more than one code point; raw (non-bracketed) onData splits up to 32 characters and longer pastes keep the single write. Anything containing an escape sequence - bracketed paste wrappers, CSI-u composition, forwarded Kitty key sequences, cursor reports - is never split, and broadcast peers still receive the original string once.

Each chunk carries the same writeToSession options as the original single write, so the sensitive marker and automation flags are kept per character. Bridge writes stay one channel write per IPC call, which reproduces what Xshell sends on the same bastion (#3077).

Co-Authored-By: Claude <noreply@anthropic.com>
2026-08-27 14:35:27 +08:00
keroroyuki 08044ee987 fix: address codex review — preserve ZWNJ/ZWJ and sanitize before Kitty encoding
Two changes based on Codex bot review feedback on PR #3156:

1. Preserve ZWNJ (U+200C) and ZWJ (U+200D) in terminal input.
   These carry meaning in Persian orthography and emoji sequences;
   PTYs can process the raw bytes, so stripping them could corrupt
   filenames, args, and passwords that legitimately contain them.

2. Sanitize composition text before Kitty encoding.
   When Kitty report-all + associated-text mode is negotiated,
   encodeKittyCompositionText converts U+200B into an escape sequence
   (e.g. ESC[0;;8203u) BEFORE reaching the handleTerminalInputData
   guard. Sanitize the raw text in both composition paths
   (commitImeTextInput remap path and onData handler) so zero-width
   artifacts are stripped before encoding, not after.

Update pattern-matching tests to reflect the new variable names
(sanitizedText / sanitizedData) in the Kitty composition paths.
2026-08-26 18:29:25 +08:00
bincxz 697758e440 fix(terminal): skip sudo autofill on Shift+Enter broadcast targets
Key-chord fan-out now delivers remapped LF through handleTerminalInputData
on each peer. handlingKittyBroadcast already blocks re-broadcast, but that
made canBroadcastInput false and armed password assistance on the target.
Keep the re-fan-out guard and only arm autofill for locally originated
submits.
2026-08-14 16:07:58 +08:00
bincxz 0eff48410b fix(terminal): keep sudo autofill off during Shift+Enter broadcast
skipBroadcast only stops the raw-string fan-out so peers can re-resolve
the chord from their own buffer. Sudo autofill still has to treat that
key as a broadcast, or a main-buffer sudo/su submit arms password
assistance on the source session.
2026-08-14 15:56:06 +08:00
netcatty-bot 193e88689a fix: address Codex review on PR #2975 2026-08-14 06:04:55 +00:00
netcatty-bot a254acbc75 fix: address Codex review on PR #2975 2026-08-14 05:27:01 +00:00
netcatty-bot 5b7af4414b fix(#2974): automated Cursor CLI fix 2026-08-14 05:01:34 +00:00
陈大猫 7db654d751 [codex] complete Kitty keyboard protocol (#2389)
* feat: complete Kitty keyboard protocol

* test: document Kitty text release behavior
2026-07-22 11:56:53 +08:00
陈大猫 b18f2bc447 feat: support Shift+Enter terminal newlines (#2005)
* feat: support Shift+Enter terminal newlines

* fix: harden Shift+Enter terminal handling

* fix: echo serial Shift+Enter newlines
2026-07-07 22:32:30 +08:00