Commit Graph
14 Commits
Author SHA1 Message Date
bincxz 7a0443d39a fix(terminal): keep wrap-boundary spaces when copying
Closes #3023

A long line that wraps exactly on a space loses that space on copy
(hbase shell becomes hbaseshell). xterm.js 6 may serve a no-endColumn
translateToString(true) from its string cache via String.trimEnd(),
which cannot tell a real last-column space from empty-cell padding.
Prompt detection and similar callers populate that cache first, so
both the normalizer and raw getSelection drop the space.

Always pass an exclusive end column so the copy path uses
getTrimmedLength() instead of trimEnd().
2026-08-17 21:21:46 +08:00
bincxz 42f2905063 feat(terminal): add normalizeTextOnCopy setting for selection cleanup
Expose Settings > Terminal > Normalize terminal text on copy (default on).
When off, all copy paths use raw xterm getSelection(); when on, strip
display padding and join soft wraps as before.
2026-07-14 00:08:42 +08:00
bincxz 7cafe7872e fix(terminal): do not glue words after complete URLs or CLI flags
Drop ambiguous mid-token alnum continuation for padded wraps. Keep strong
continuations (path punctuation, hyphen at split, CJK) and treat multi-space
padding after a finished token as a word boundary.
2026-07-13 23:30:41 +08:00
bincxz e991507fac fix(terminal): keep hyphenated wraps and Windows CRLF on normalized copy
- Treat trailing hyphens and CLI-flag tokens as continuations
- Emit CRLF on Windows to match xterm selectionText
2026-07-13 23:24:31 +08:00
bincxz 8eb78d6278 fix(terminal): prefer prose word boundaries for padded soft wraps (#2162)
Collapse multi-space TUI padding between ordinary words to a single space so
Pi-style wrapped prose stays readable. Keep strong token continuations (CJK,
path punctuation, URL query) tight, and only treat URL mid-token alnum joins
as tight when padding is multi-space (not a single separator after a URL).
2026-07-13 23:14:15 +08:00
bincxz e77a5a027b fix(terminal): only reinsert space after sentence punctuation on padded wraps
Multi-space padding joins tightly by default. Reinsert a separator only when
the previous row ends with sentence punctuation (. ! ? …).
2026-07-13 23:05:51 +08:00
bincxz 48a5834c52 fix(terminal): handle Windows paths, URL queries, and post-URL sentences on wrap
- Detect backslash paths for soft-wrap joins
- Keep ? # & attached to URL/path tokens
- Do not glue the next sentence onto a URL that ends with '.'
2026-07-13 22:58:13 +08:00
bincxz 6f44c5b9ac fix(terminal): tighten soft-wrap token continuation heuristics
- Do not treat sentence punctuation as path continuations
- Scope URL/path detection to the trailing token only
- Cover Hangul and CJK punctuation on both sides of the wrap
2026-07-13 22:51:21 +08:00
bincxz 8bb7d261e1 fix(terminal): use public cell widths and snapshot copy-on-select text
- Measure content end via getCell column widths (public API only)
- Capture normalized selection before the copy-on-select debounce
2026-07-13 22:46:17 +08:00
bincxz 62cf5365f7 fix(terminal): harden soft-wrap join for CJK, URLs, and wide cells
- Prefer getTrimmedLength() columns when deciding full-row vs partial selection
- Apply token-continuation checks before single-space word-boundary handling
- Detect URL/path context so mid-token wraps do not gain spaces
2026-07-13 22:38:34 +08:00
bincxz 238d3d0bc6 fix(terminal): refine soft-wrap join and selection-boundary space handling
- Do not invent spaces for URL/path/CJK token continuations across padding
- Keep a single space only for clear word-boundary soft wraps
- Preserve explicitly selected trailing spaces on partial last rows and column selections
2026-07-13 22:32:28 +08:00
bincxz 000bc9fd27 fix(terminal): preserve word spaces on soft-wrap join and normalize native copy
- Collapse soft-wrap padding to a single word separator (no CJK space insert)
- Intercept the native copy event so Edit>Copy uses the same normalization
2026-07-13 22:25:32 +08:00
bincxz 672528d3e9 fix(terminal): strip written padding and preserve column selections on copy
Address Codex review on #2162:
- xterm trimRight only drops empty cells; explicitly rtrim written TUI padding spaces
- Detect column (rectangular) selection mode and keep per-row column bounds
- Convert U+00A0 to regular spaces like xterm selectionText
- Tests fake empty-cell vs written-space trim correctly
2026-07-13 22:15:45 +08:00
bincxz e060e818d0 fix(terminal): normalize soft wraps and padding when copying selection
xterm getSelection() turns every physical buffer row into a hard newline, so
soft-wrapped TUI output (e.g. Pi agent responses) pastes with broken wraps and
display padding. Rebuild clipboard text from buffer coordinates: trim row
padding, join isWrapped rows, keep real hard breaks.

Use the helper on copy-on-select, context/hotkey copy, paste-selection, and
add-selection-to-AI paths.

Fixes #2162
2026-07-13 22:07:12 +08:00