Commit Graph
27 Commits
Author SHA1 Message Date
bincxz f4ff04897e fix(terminal): treat history preview as a selection for Ctrl+C
#3026

Urgent interrupt still asked only xterm for a selection. With history
preview text selected, Ctrl+C therefore sent SIGINT into vim before the
copy path ran. Use the same copyable-selection flag for interrupt,
shortcut passthrough, and Kitty broadcast.
2026-08-17 20:28:11 +08:00
bincxz b6b433dc88 fix(terminal): copy history preview while vim owns the screen
#3026

Shift+scroll already overlays the normal-buffer history on the
alternate screen, but the overlay ignored pointer events and any
mousedown or copy chord dismissed it. Selection now stays on the
preview so the usual copy shortcuts, context menu, and copy-on-select
can take that text without leaving vi.
2026-08-17 19:26:59 +08:00
netcatty-bot e60db5e08a fix: address Codex review on PR #2854 2026-08-10 05:03:56 +00:00
bincxzandCursor 593da6f52d fix(terminal): strip style-divergent autosuggest tails
Drop zsh ghost text past the cursor when cell fg/dim differs from the
accepted input, so mid-line history edits still record full commands
without absorbing unaccepted cross-token suggestions.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-10 12:21:09 +08:00
bincxzandCursor 63278d5d40 fix(terminal): ignore autosuggest tails after history recall
Only prefer the full painted line for mid-line edits when the keystroke
buffer is already a whole token there, and keep the cursor-visible
command when an unaccepted zsh ghost continues past the cursor.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-10 12:08:27 +08:00
netcatty-bot e96a51bfe4 fix(#2850): automated Cursor CLI fix 2026-08-10 03:56:35 +00:00
ryan-wong-coder 7b8256155f fix(plugins): harden terminal provider lifecycle 2026-07-21 00:04:30 +08:00
bincxz 460ed1daa3 fix(terminal): record peeled su and recover no-space first recall
Accept resolved trailing privilege commands in shouldRecordShellHistory so
themed multi-word dirs still arm. Scan no-space prompts without a cache,
and do not peel echo/ls prefixes as directory chrome (#2191).
2026-07-14 23:34:12 +08:00
bincxz 4b6d8e820a fix(terminal): block same-token autosuggest and widen themed dirs
Never promote painted same-token tails over a non-empty keystroke buffer
(g + git status stays g); only prefer the full line when history yields a
privilege command the buffer does not. Accept unicode/punctuated themed
directory names before su/sudo, and keep double-space glyph first words.
2026-07-14 23:25:39 +08:00
bincxz 634cec633c fix(terminal): peel privilege commands off themed path chrome
Prefer trailing su/sudo/doas when the themed prefix looks like a path
(including multi-word dirs). Avoid over-peeling double-space glyph prompts
and do not treat a trailing-padded cwd token named su as a command (#2191).
2026-07-14 23:16:55 +08:00
bincxz 9ab4f46492 fix(terminal): ignore autosuggest tails and trust incomplete echo
Do not absorb post-cursor paint when it looks like a space-prefixed
suggestion (git + status). Prefer the keystroke buffer for single-word
incomplete echo (su→sudo), while still using the live line when history
shortens a multi-word typed buffer (#2191).
2026-07-14 23:10:00 +08:00
bincxz afc04924ff fix(terminal): validate themed history fallbacks and mid-line align
Reject decoration-only cached remainders and single cwd tokens on prefixed
themed prompts. When an aligned buffer is only a mid-line prefix of the
full recalled command, prefer the expanded live line (#2191).
2026-07-14 22:41:30 +08:00
bincxz 67cc864af4 fix(terminal): recover no-space prompts and wrapped submit lines
Use lastPromptText when boundary detection fails for prompts without a
trailing space, and expand submitted input across wrapped rows so mid-line
Enter still sees the full history-recalled command (#2191).
2026-07-14 22:33:45 +08:00
bincxz c58332ab00 fix(terminal): keep one-word su history and full-line submit
Allow glyph-only one-word su/sudo/doas history to arm password assist,
limit path decoration filtering to bare themed prompts, and expand past
the cursor so mid-line Enter still resolves the full recalled command.
2026-07-14 22:27:24 +08:00
bincxz 5211fe1d58 fix(terminal): ignore empty themed prompt chrome on Enter
Empty Enter on ➜/git-status decorations must not record cwd tokens or
status glyphs as commands, which would pollute history and false-arm
password assist (#2191).
2026-07-14 22:19:14 +08:00
bincxz c99eff6080 fix(terminal): harden themed/Powerline history command resolution
Validate cached prompt remainders against the live detector split so a
partial cache cannot yield git-status chrome as the command. Accept
multiword userInput on complete Powerline prompts, and allow history
recording when themed chrome reconciles away from the command.
2026-07-14 22:13:08 +08:00
bincxz 9dc60485fa fix(terminal): resolve history recall when buffer and themed prompt disagree
Prefer the live line when ↑/Ctrl+R replace a typed prefix, while still
keeping the keystroke buffer for direct-send and echo lag. Peel themed
prompt decorations via reconcile when lastPromptText is missing or stale
after cd so su/sudo still arm (#2191).
2026-07-14 22:05:15 +08:00
bincxz 65811a9f63 fix(terminal): address codex review on password-assist history
- Strip themed prompt chrome via lastPromptText before falling back to
  live userInput; reuse getCommandToRecordOnEnter so decoration pollution
  is never armed or recorded (#806/#2191).
- Soft-dismiss password assist on all printable keys except plain Ctrl+C
  so AltGr/Option characters still switch to manual entry.
2026-07-14 21:58:59 +08:00
bincxz 44807273bc fix(terminal): re-arm su password assist after history and Ctrl+C (#2191)
Shell history (↑) redraws the line remotely without updating commandBuffer,
so Enter never armed su/sudo assist. Resolve the submitted command from the
live prompt line when the keystroke buffer is empty.

Ctrl+C was soft-dismissing the picker (same path as typing a password),
leaving dismissedWhileArmed and blocking the next bare Password: line.
Hard-abort on interrupt and ignore Ctrl/Meta/Alt keys for soft-dismiss.
2026-07-14 21:46:39 +08:00
bincxz 094f0abe4a fix(sftp): follow terminal cwd after submitted commands 2026-06-09 03:51:33 +08:00
陈大猫 80d9b33c59 feat(terminal): confirm-to-fill sudo password hint (#1281)
Rework sudo password autofill from auto-fill to a Tabby-style hint + Enter to confirm. When a sudo command is armed and a password prompt appears, show a dimmed inline hint instead of sending the password; Enter pastes the saved password and submits, any other key dismisses it.

Confirmation removes the credential-leak class (nothing is sent without the user pressing Enter at a visible hint), so detection is relaxed to a broad match (Ubuntu/PAM bare "Password:", "[sudo] password for…", localized prompts) and the per-host toggle is removed — always available when the host has a saved password.

Safety guards:
- don't arm when the hint can't render (no overlay) so Enter isn't silently intercepted;
- swallow Escape/Backspace so the byte never reaches the no-echo prompt;
- clear the pending hint once output moves past the prompt (sudo timeout/failure/returns to shell) so a later Enter can't leak the password to the shell.

Implementation ~140 lines; full suite green; manually verified on a real Linux host.
2026-06-07 12:39:06 +08:00
陈大猫 3be3c14912 fix(terminal): simplify sudo password autofill, scoped to real sudo prompts (#1281)
Replace the command-rewriting scheme (inject sudo -p marker, sanitize the echo, Ctrl-U retype) with passive observation: arm a short window on a sudo command and fill the password when a real sudo prompt appears.

- Fixes the Ubuntu/PAM no-fill, the cursor jump below the prompt, and the typed-vs-autocomplete discrepancy from #1281.
- Detection requires the [sudo] tag, or a whole-line bare "Password:" / "密码:"; prefixed prompts (mysql -p "Enter password:", ssh "x@h's password:", psql "Password for user x:") are rejected so the sudo password can't leak to a child program when sudo's creds are warm.
- Disarms when a non-sudo command follows, so a stale window can't fill a later prompt.

Implementation: 322 -> ~140 lines.
2026-06-07 03:11:25 +08:00
bincxz ada55ab461 Fix sudo autofill prompt verification 2026-06-06 21:26:01 +08:00
bincxz 2867262e4d Add per-host sudo password autofill 2026-06-06 20:47:16 +08:00
6084e8e94f fix(terminal): handle forced prompt newline (#1025)
* fix(terminal): handle forced prompt newline

* fix review issue

* fix(terminal): harden prompt newline handling

---------

Co-authored-by: yuzifu <yuzifu@TB16PGen5.Info>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-05-20 23:08:42 +08:00
yuzifu 3e8965f9a9 Fix pr987 (#1010) 2026-05-19 20:13:16 +08:00
88732040aa fix(terminal): separate prompt after unterminated command output (#987)
* fix(terminal): separate prompt after unterminated command output
Add a display-layer prompt line break handler so recognized shell prompts move to the next visual line when the final command output line is not newline terminated.

Also add a terminal setting to toggle the behavior, sync support, i18n copy, and focused tests for prompt insertion.

* fix review issue

* Fix prompt cache initialization

* Serialize terminal output writes for prompt breaks

* Keep terminal status lines ordered with output

* Fix prompt arming without command callback

* Keep prompt display breaks out of session logs

* Avoid prompt breaks for output suffix matches

---------

Co-authored-by: yuzifu <yuzifu@TB16PGen5.Info>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-05-18 18:45:41 +08:00