Commit Graph
29 Commits
Author SHA1 Message Date
陈大猫 2638d199f2 fix(terminal): keep mid-line snippet inserts and offer snippets at program prompts (#3769)
Mid-line snippet accept deletes only the current word (DEL on POSIX, backspace on Windows), and program prompts like Email:/Username: offer snippet candidates while password/passphrase prompts stay blocked.

Fixes #3622
2026-10-20 14:19:59 +08:00
cb06857480 feat(terminal): confirm before pasting multiple lines (#3398) (#3400)
* fix(#3398): automated AI fix

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix: address Codex review on PR #3400

* fix(terminal): protect popup and sanitized multiline pastes

* fix(terminal): preserve input state across paste confirmation

* fix(terminal): retain serial character-mode paste echo

* test(terminal): cover paced input write options

* fix(terminal): retain telnet echo for paced pastes

* test(terminal): scope serial buffer assertion to serial sessions

* fix(terminal): align runtime write options with bridge contract

* fix(terminal): preserve bookkeeping for all paced pastes

* fix(terminal): record confirmed paste lines in order

* fix: record paced paste commands after transport writes

* fix: omit paste receipts for filtered input

* fix: cancel superseded paste batches across input paths

* fix: classify each acknowledged paste line before recording

* fix: stop paced paste when editing buffered serial input

* fix: preserve recording pause boundaries and serial edit cancellation

* fix: treat paced terminal pastes as user input

* fix: preserve paste drafts until write and snippet broadcast origin

* fix: retain filtered paste drafts and invalidate urgent input ownership

* fix: broadcast paced user paste only on guarded line receipts

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-09-18 15:19:34 +08:00
netcatty-bot e60db5e08a fix: address Codex review on PR #2854 2026-08-10 05:03:56 +00:00
bincxzandCursor 593da6f52d fix(terminal): strip style-divergent autosuggest tails
Drop zsh ghost text past the cursor when cell fg/dim differs from the
accepted input, so mid-line history edits still record full commands
without absorbing unaccepted cross-token suggestions.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-10 12:21:09 +08:00
bincxzandCursor 63278d5d40 fix(terminal): ignore autosuggest tails after history recall
Only prefer the full painted line for mid-line edits when the keystroke
buffer is already a whole token there, and keep the cursor-visible
command when an unaccepted zsh ghost continues past the cursor.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-08-10 12:08:27 +08:00
netcatty-bot e96a51bfe4 fix(#2850): automated Cursor CLI fix 2026-08-10 03:56:35 +00:00
ryan-wong-coder 2a31e7c409 fix(plugins): close terminal provider lifecycle gaps 2026-07-21 01:52:34 +08:00
ryan-wong-coder fec9252019 fix(plugin): close terminal provider lifecycle gaps 2026-07-21 01:06:12 +08:00
ryan-wong-coder 7b8256155f fix(plugins): harden terminal provider lifecycle 2026-07-21 00:04:30 +08:00
bincxz 1749515060 fix(terminal): tighten themed path vs command peeling
Do not treat shell verbs after git-status markers as directory chrome, and
only strip multi-word path prefixes for privilege commands or clear path
sigils so `git status` and `My Project ls` stay correct (#2191).
2026-07-14 23:42:41 +08:00
bincxz 460ed1daa3 fix(terminal): record peeled su and recover no-space first recall
Accept resolved trailing privilege commands in shouldRecordShellHistory so
themed multi-word dirs still arm. Scan no-space prompts without a cache,
and do not peel echo/ls prefixes as directory chrome (#2191).
2026-07-14 23:34:12 +08:00
bincxz 4b6d8e820a fix(terminal): block same-token autosuggest and widen themed dirs
Never promote painted same-token tails over a non-empty keystroke buffer
(g + git status stays g); only prefer the full line when history yields a
privilege command the buffer does not. Accept unicode/punctuated themed
directory names before su/sudo, and keep double-space glyph first words.
2026-07-14 23:25:39 +08:00
bincxz 634cec633c fix(terminal): peel privilege commands off themed path chrome
Prefer trailing su/sudo/doas when the themed prefix looks like a path
(including multi-word dirs). Avoid over-peeling double-space glyph prompts
and do not treat a trailing-padded cwd token named su as a command (#2191).
2026-07-14 23:16:55 +08:00
bincxz 9ab4f46492 fix(terminal): ignore autosuggest tails and trust incomplete echo
Do not absorb post-cursor paint when it looks like a space-prefixed
suggestion (git + status). Prefer the keystroke buffer for single-word
incomplete echo (su→sudo), while still using the live line when history
shortens a multi-word typed buffer (#2191).
2026-07-14 23:10:00 +08:00
bincxz 90bc307074 fix(terminal): prefer live for history-grown sudo and cache multi-word dirs
When typed text is only a trailing argv of a recalled sudo/su command,
prefer the full live line. Apply lastPromptText before peel so multi-word
directory themes resolve the real command first (#2191).
2026-07-14 22:57:17 +08:00
bincxz 502161038b fix(terminal): peel prefixed themes and tighten buffer/live arbitration
Peel path chrome on prefixed themed prompts (⚡ ➜  ~ su -). Prefer live
when history shortens a typed command (sudo→su), and prefer the typed
buffer when live still ends with chrome+command (#2191).
2026-07-14 22:49:48 +08:00
bincxz afc04924ff fix(terminal): validate themed history fallbacks and mid-line align
Reject decoration-only cached remainders and single cwd tokens on prefixed
themed prompts. When an aligned buffer is only a mid-line prefix of the
full recalled command, prefer the expanded live line (#2191).
2026-07-14 22:41:30 +08:00
bincxz 67cc864af4 fix(terminal): recover no-space prompts and wrapped submit lines
Use lastPromptText when boundary detection fails for prompts without a
trailing space, and expand submitted input across wrapped rows so mid-line
Enter still sees the full history-recalled command (#2191).
2026-07-14 22:33:45 +08:00
bincxz c58332ab00 fix(terminal): keep one-word su history and full-line submit
Allow glyph-only one-word su/sudo/doas history to arm password assist,
limit path decoration filtering to bare themed prompts, and expand past
the cursor so mid-line Enter still resolves the full recalled command.
2026-07-14 22:27:24 +08:00
bincxz 5211fe1d58 fix(terminal): ignore empty themed prompt chrome on Enter
Empty Enter on ➜/git-status decorations must not record cwd tokens or
status glyphs as commands, which would pollute history and false-arm
password assist (#2191).
2026-07-14 22:19:14 +08:00
bincxz c99eff6080 fix(terminal): harden themed/Powerline history command resolution
Validate cached prompt remainders against the live detector split so a
partial cache cannot yield git-status chrome as the command. Accept
multiword userInput on complete Powerline prompts, and allow history
recording when themed chrome reconciles away from the command.
2026-07-14 22:13:08 +08:00
bincxz 9dc60485fa fix(terminal): resolve history recall when buffer and themed prompt disagree
Prefer the live line when ↑/Ctrl+R replace a typed prefix, while still
keeping the keystroke buffer for direct-send and echo lag. Peel themed
prompt decorations via reconcile when lastPromptText is missing or stale
after cd so su/sudo still arm (#2191).
2026-07-14 22:05:15 +08:00
bincxz 65811a9f63 fix(terminal): address codex review on password-assist history
- Strip themed prompt chrome via lastPromptText before falling back to
  live userInput; reuse getCommandToRecordOnEnter so decoration pollution
  is never armed or recorded (#806/#2191).
- Soft-dismiss password assist on all printable keys except plain Ctrl+C
  so AltGr/Option characters still switch to manual entry.
2026-07-14 21:58:59 +08:00
bincxz 44807273bc fix(terminal): re-arm su password assist after history and Ctrl+C (#2191)
Shell history (↑) redraws the line remotely without updating commandBuffer,
so Enter never armed su/sudo assist. Resolve the submitted command from the
live prompt line when the keystroke buffer is empty.

Ctrl+C was soft-dismissing the picker (same path as typing a password),
leaving dismissedWhileArmed and blocking the next bare Password: line.
Hard-abort on interrupt and ignore Ctrl/Meta/Alt keys for soft-dismiss.
2026-07-14 21:46:39 +08:00
bincxz 094f0abe4a fix(sftp): follow terminal cwd after submitted commands 2026-06-09 03:51:33 +08:00
bincxz 2867262e4d Add per-host sudo password autofill 2026-06-06 20:47:16 +08:00
6084e8e94f fix(terminal): handle forced prompt newline (#1025)
* fix(terminal): handle forced prompt newline

* fix review issue

* fix(terminal): harden prompt newline handling

---------

Co-authored-by: yuzifu <yuzifu@TB16PGen5.Info>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-05-20 23:08:42 +08:00
yuzifu 3e8965f9a9 Fix pr987 (#1010) 2026-05-19 20:13:16 +08:00
88732040aa fix(terminal): separate prompt after unterminated command output (#987)
* fix(terminal): separate prompt after unterminated command output
Add a display-layer prompt line break handler so recognized shell prompts move to the next visual line when the final command output line is not newline terminated.

Also add a terminal setting to toggle the behavior, sync support, i18n copy, and focused tests for prompt insertion.

* fix review issue

* Fix prompt cache initialization

* Serialize terminal output writes for prompt breaks

* Keep terminal status lines ordered with output

* Fix prompt arming without command callback

* Keep prompt display breaks out of session logs

* Avoid prompt breaks for output suffix matches

---------

Co-authored-by: yuzifu <yuzifu@TB16PGen5.Info>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-05-18 18:45:41 +08:00