Commit Graph
3 Commits
Author SHA1 Message Date
e9e4ae576f fix(terminal): soft-hide the tab that just left when hibernate keep is full (#3900)
* fix(terminal): soft-hide the tab that just left when hibernate keep is full

Evict the oldest soft-hidden session to a full snapshot, and keep the
session the user just left on hideRuntimeOnly. Disconnected sessions,
alternate screen, and inline images keep their existing branches. Wake
replay order is unchanged.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(terminal): full-hibernate when keep-count eviction is refused

A soft-hidden session with inline images consumes the eviction request
and stays mounted. Soft-hiding the tab that just left anyway let that
protected session pin the oldest slot, so every later tab was retained
too. Walk oldest-first, keep the leaving tab soft-hidden only after one
victim actually leaves the set, and full-hibernate it when none can.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(terminal): retain a leaving tab only after eviction hibernates

Waking a soft-hidden victim clears its marker before fullHibernateRuntime
finishes. Treating that as success soft-hid the tab that just left even
when drain, snapshot, or alternate-screen failure restored the victim.
Await hibernate completion outside the pure keep-count helper, and put a
failed victim back in the soft-hidden set so it stays a candidate.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(terminal): reserve hibernate slots outside domain policy

Keep the keep-count decision pure. The application walk reserves the
leaving tab before awaiting a victim, rechecks that slot before
soft-hide, and does not restore a victim that became visible or had
hibernate turned off while the upgrade was in flight.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>
2026-10-24 19:24:39 +08:00
bincxz 2f321d580c fix(terminal): close hibernate lifecycle races 2026-07-29 14:54:20 +08:00
LynricsyandWine Fox fc7287e328 feat(terminal): render Kitty/SIXEL/iTerm inline images
Load @xterm/addon-image in the shared xterm runtime so remote programs can
draw real raster images (kitten icat, chafa --format kitty, image previews
in file managers and TUIs) instead of ANSI approximations.

- domain/terminalInlineImages.ts owns the limits and turns TerminalSettings
  into addon options; disabled settings resolve to null so the addon is not
  loaded at all and the terminal keeps advertising no graphics capability.
- The addon is loaded right after term.open, before the WebGL renderer, so it
  patches IRenderService.setRenderer first and its canvas layers survive every
  DOM <-> WebGL swap (deferred WebGL, soft-hide suspend, context-loss rebuild).
  It is disposed before term.dispose so bitmaps never outlive their terminal.
- Hibernate restores a tab from a text-only snapshot, which cannot carry image
  data. XTermRuntime.hasInlineImages reads the live image cache, and Terminal
  degrades such a session to soft-hide: hibernateRuntime takes the soft-hide
  branch, canFinishHibernate re-checks after every async step, and an eviction
  request leaves the session soft-hidden. The block lifts by itself once the
  cache is emptied by a terminal reset or FIFO eviction.
- Settings > Terminal > Inline Images exposes the master switch, per-protocol
  switches (Kitty / SIXEL / iTerm IIP) and the memory limits, translated for
  en, zh-CN, zh-TW and ru. Protocol switches cloud-sync; the memory limits stay
  local like the other per-device renderer tuning.

Co-authored-by: Wine Fox <fox@ling.plus>
2026-07-26 19:13:51 +08:00