Commit Graph
44 Commits
Author SHA1 Message Date
陈大猫 857d20db88 fix(sftp): retain completed uploads with backup cleanup warnings (#3895)
* fix(sftp): preserve successful uploads with backup cleanup warnings

Warn only on confirmed backup cleanup permission refusal after final publication. Preserve actionable warnings across transfer events, history restoration and completion ordering without masking deletion or commit failures.

Narrow follow-up to #3830; related #3879.

* fix(sftp): retain folder cleanup warnings before child completion
2026-10-24 13:20:45 +08:00
ea376bd0ca fix(sftp): Retry after a dropped connection resumes from the checkpoint (#3823)
* fix(sftp): Retry after a dropped connection resumes from the staged checkpoint

Retry on a failed live task always cloned it under a fresh transfer id with
checkpoint 0. After a connection drop that throws away the uploaded bytes, and
because the remote stage path is derived from the transfer id, the new attempt
stages a new .part while the old one stays orphaned on the server (cleanup runs
against the dead session).

When a top-level file failed with a session-loss error and has a checkpoint,
Retry now demotes it to interrupted/reconnectRequired and goes through the same
dedicated reconnect-resume path a restored task uses: same id, same stage,
truncated to the checkpoint. Content errors and orphaned rows keep the existing
restart-from-0 contract.

* fix(sftp): resume a dropped upload from the verified stage checkpoint

A failed upload never pauses, so Retry has a checkpoint and no SHA-256.
The bridge treated that as an unproven resume and restarted at byte 0,
truncating the same .part. Stat and trim the stage on the new connection
instead, and still restart when the .part does not cover the checkpoint.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): trim a resumed upload stage with SFTP setstat

ssh2 has no ftruncate and ssh2-sftp-client has no truncate, so a longer
.part after a reset always failed the checkpoint trim. SETSTAT {size},
or FSETSTAT on an r+ handle, shortens the stage on the live channel.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): require a stable local source before an unfingerprinted resume

A dropped upload has a checkpoint and no SHA-256. Retry kept that
checkpoint even after the local file was rewritten at the same size, and
the same predicate also resumed downloads and remote copies.

Remember size and mtimeMs when the local upload starts. On retry, keep
the checkpoint only when both still match; otherwise restart from 0.
Limit same-id resume to local-to-remote uploads.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): reject an unfingerprinted resume when prefix bytes changed

Size and mtime can both be restored after a same-size rewrite, so Retry
was appending the new suffix onto the old staged prefix. Keep the head
content sample, and a 64 KiB window ending at the published checkpoint
when that sample does not cover it. Resume only when those still match.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): resume an unfingerprinted upload only when the prefix digest matches

Hash the bytes actually acknowledged on the remote .part, in order, and
store that SHA-256 with the checkpoint offset. Retry re-reads the local
prefix and restarts when the digest or size differs, including a same-size
rewrite the head sample and checkpoint window both missed.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): cancel prefix verification and drop unused upload digests

Pass the transfer abort signal into the retry prefix re-hash so Cancel
stops the read and the task ends cancelled. Drop the in-memory digest
when an upload is cancelled, fails without a resumable checkpoint, or
the task is cleaned up.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

---------

Co-authored-by: campaign <campaign@local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>
2026-10-21 21:00:07 +08:00
1ec954b424 perf(sftp): coalesce transfer lifecycle repaints to one per frame (#3815)
* perf(sftp): coalesce transfer lifecycle repaints to one per frame

* test(sftp): settle coalesced lifecycle paints before asserting

Wait one animation frame before reading transfer rows, and cover the final
completion, pause, cancel, and error paint plus unmount cancellation.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

* fix(sftp): do not let a stale coalesced snapshot reopen a latched pause

Pause all could leave the folder row transferring while its children
were paused. A child lifecycle publish still carried the pre-pause
parent at the same lifecycle epoch, and the store treated that equal
epoch as Resume.

Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>

---------

Co-authored-by: campaign <campaign@local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: 陈大猫 <binaricat@users.noreply.github.com>
2026-10-21 16:49:36 +08:00
陈大猫 6a7c883337 fix(sftp): keep expanded folder transfer lists responsive (#3722)
* fix(sftp): keep expanded folder transfer lists responsive

* fix(sftp): refresh batch eligibility on capability updates

* fix(sftp): publish repaired hierarchy before ignoring progress

* fix(sftp): persist repaired background transfer hierarchy
2026-10-18 13:37:45 +08:00
陈大猫andnetcatty-bot 4cd6a7191d feat(sftp): add Cancel all action to transfer center (#3574)
* feat(sftp): add cancel all to transfer center

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix: address Codex review on PR #3574

* fix(sftp): settle cancelled walks before directory recovery

* fix(sftp): report failed cancel attempts without blocking retries

* fix(sftp): batch pending cancel cleanup for large queues

* fix(sftp): preserve settled children during cancel recovery

* fix(sftp): release skipped cancel-all pre-latches

* fix(sftp): satisfy cancellation result and fixture types

* fix(sftp): dispatch cancel batches before walk settlement

* fix(sftp): distinguish live compression recovery from restored attention

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-10-08 17:50:41 +08:00
陈大猫 bf9fa571ee fix(sftp): preserve complete folder recovery after ownership changes (#3436)
* fix(sftp): preserve folder recovery completion and ownership

* fix(sftp): discard displaced updates before batch flush

* fix(sftp): bind recovery admission to reset and owner state

* fix(sftp): preserve replacement owners on rejected invocations

* fix(sftp): expire initial identity exemptions on activation

* fix(sftp): preserve recovery ownership through deferred writes
2026-09-18 14:09:34 +08:00
陈大猫 aaac962179 fix(sftp): share pending resume feedback across transfer views (#3305) 2026-09-07 10:30:42 +08:00
陈大猫 c9d22b3b4d fix(sftp): preserve latest pause across delayed transfer controls (#3284)
* fix(sftp): preserve newer pause decisions across delayed transfer controls

* fix(sftp): stop obsolete recovery after held transfers settle

* fix(sftp): treat superseded cross-window controls as no-ops

* fix(sftp): preserve latest folder control in pause watcher

* fix(sftp): reconcile superseded controls across windows

* test(sftp): expect authoritative action on superseded pause

* fix(sftp): distinguish mixed resume outcomes and IPC failures

* docs(sftp): publish audit findings and validation boundaries

* docs(sftp): record final publication and restart validation

* fix(sftp): reflect partial resumes and reconcile remote watcher controls

* fix(sftp): preserve resolved resume failures in partial folders
2026-09-06 14:13:49 +08:00
陈大猫 446e82180b fix(sftp): settle folder children before history compaction removes their rows (#3287)
* fix(sftp): observe folder child completion before history compaction

* fix(sftp): carry current child identity through recovery events

* fix(sftp): admit recovered children before waiting for completion

* test(sftp): keep independent audit regressions mergeable

* fix(sftp): resume retained pauses without bypassing newer controls
2026-09-06 13:29:05 +08:00
bincxz 8991d1faaf fix(sftp): repair pause/resume soft-control and hard reconnect reuse
Pause then resume was flaky: soft resume cleared lifecycle epochs so stale
paused events re-applied, soft failures always rehomed to dedicated-resume
(panel queue vanished, "reconnecting" then stuck paused), and concurrent
range soft-drain only waited 1.5s before "still finishing".

Soft resume now stamps bridge lifecycle epochs, only hard-reconnects when
the live stream is gone, dedicated resume reuses terminal/parked transports
(including ephemeral hosts), and deferred sparse settle runs in the
background with a longer resume wait for in-flight ranges.
2026-07-31 01:00:49 +08:00
bincxz ef7b552d78 fix(sftp): keep background transfers alive across UI lifecycle 2026-07-29 11:14:11 +08:00
bincxz fe737ec555 fix(perf): unify SFTP lifecycles and bound runtime resources 2026-07-29 03:33:00 +08:00
bincxz 49918fd54a fix(sftp): remove legacy transfer event path 2026-07-28 18:57:15 +08:00
bincxz 1dfc898366 fix(sftp): persist history deletions immediately 2026-07-27 12:15:52 +08:00
bincxz 8d8abb4956 fix(sftp): preserve pruned cleanup data 2026-07-27 11:43:52 +08:00
bincxz ba8dea5cae fix(sftp): prevent large folder upload renderer stalls 2026-07-27 11:34:02 +08:00
bincxz d165e158f7 fix(sftp): unify transfer control under process-level TransferRuntime
Pause and resume now go through one process-level control plane that survives
panel/terminal close: TransferRuntime + soft latches/epochs/walk registry,
soft-then-hard resume, dual-epoch-safe progress, and no-owner soft control.
2026-07-26 21:27:01 +08:00
bincxz 3d140c2f8e fix(sftp): harden folder pause/resume, delete, and root reconnect
Make folder pause latch-first with barriers and a child pause watchdog so
workers stop claiming files after soft-drain; soft-resume live walks instead
of full rewalks. Surface path conflicts with toasts, keep pause progress
visible, and show a resume spinner. Restore verified shell rm -rf with SFTP
confirmation for fast directory delete, and prefer reconnect over wiping the
pane to the host picker when listing fails on some hosts.
2026-07-26 00:10:22 +08:00
netcatty-bot bf15405092 fix: address Codex review on PR #2486 2026-07-25 14:27:03 +00:00
bincxz 9a1b3e83e0 fix(sftp): stop ghost resume and same-path transfer races
Do not paint transferring when every backend resume misses after restart.
Refuse starting or resuming a second job with the same source and target
while another is still active, matching FileZilla-style single-writer
destination handling.
2026-07-25 22:14:59 +08:00
bincxz 8a97e3c555 fix(sftp): make panel pause feel immediate
Paint paused optimistically, stop counting paused rows as "active", freeze
visible progress while paused, and soft-drain concurrent pause in ~50ms
without long writeStream waits on the contiguous-range path.
2026-07-25 21:55:47 +08:00
bincxz 07d326fde7 fix(sftp): make transfer pause responsive and visible
Pause felt stuck because the panel hid the pausing state, and the
backend waited for every in-flight range plus a full source fingerprint
hash. Soft-drain concurrent ranges, skip blocking fingerprint work, and
show clear pausing feedback in the panel and transfer center.
2026-07-25 20:37:56 +08:00
bincxz 0b89acb088 fix(sftp): clear sticky pendingCancel before dedicated directory startFresh
Cancel wind-down can leave child transferIds latched when they are not in
activeTransfers; clearPendingTransferCancel before reusing those ids so
startStreamTransfer does not abort immediately. Regression test models the
sticky latch.
2026-07-24 00:26:58 +08:00
bincxz 4165c738e8 fix(sftp): close multi-agent review findings on dedicated resume
Soft-unpause only live streams; directory dedicated pause winds down then
startFresh. Resume replace-mode under stagedTargetPath and promote on full
success. Refuse pre-stream pause, force R2R progress without corrupting stage
offsets, and cover the directory pause-resume path with a regression test.
2026-07-24 00:12:45 +08:00
bincxz ed6ed76c21 feat(sftp): harden global transfer center pause/resume and open-folder UX
Keep browse sessions independent of pool transfers, complete dedicated resume
for files/folders after restart, roll back partial pause safely, clamp crash
checkpoints to durable .part size, and open upload targets by connecting the
host when no terminal tab is active.
2026-07-23 23:46:49 +08:00
bincxz 9c390786eb fix(sftp): clear child cancel latches on resume and proxy clear-pending to worker
Parent resume clears sticky per-child cancelledTasksRef entries so directory
re-walk can retry cancelled files. Route clearPendingCancel to the terminal
worker (where skipAdmission latches live), re-check cancel on live resume,
and clean per-child stage artifacts on parent cancel.
2026-07-23 19:25:19 +08:00
bincxz b1178b78d8 fix(sftp): harden download cancel finalizer and clear resume cancel latch
Re-check cancel inside setTransfers so late cancels are not overwritten,
keep partial progress on cancelled directory downloads, and clear the
pre-start cancel latch on intentional resume/retry.
2026-07-23 19:17:27 +08:00
bincxz 75f0704886 fix(sftp): retain directory child checkpoints across history prune
Never prune or clear-completed terminal children of unfinished parents so
large folder resume can still skip already-completed files after restart.
2026-07-23 18:18:44 +08:00
bincxz 92f6d3883f fix(sftp): rehome directory children in store and avoid cancel latch poison
Reassign parent+children together on adopt, stop spurious cancelTransfer
after failed dedicated reconnect, and clear pending-cancel when a queued
job is cancelled so same-id resume is not permanently poisoned.
2026-07-23 18:12:42 +08:00
bincxz db8e0aacc3 fix(sftp): adopt on S2S soft-fail and resume only top-level tasks
Server-to-server dedicated soft-fail rehomes via adopt instead of a no-op
resume, Resume/Pause All skip child rows, and orphaned failed tasks remain
controllable with a clean Retry from byte zero.
2026-07-23 17:55:16 +08:00
bincxz 9b752501c9 fix(sftp): restore panel resume for S2S and do not cancel on quit pause
Server-to-server soft-fail from dedicated resume rehomes ownership so a
live panel can resume; pause during dedicated reconnect no longer cancels
(so quit confirmation does not destroy in-flight resume).
2026-07-23 17:50:11 +08:00
bincxz b2f752c4d8 fix(sftp): stop dedicated pause no-op, cancel-safe conflict resolve, admit agent resume
Pause on dedicated reconnect cancels the open, resolveConflict never
resurrects cancelled rows after async duplicate naming, and background
agent restart admits before opening session-backed SFTP handles.
2026-07-23 17:43:56 +08:00
bincxz b4315fe8bf fix(sftp): harden conflict pause/cancel and same-turn resolve safety
No-op pause on conflict rows, keep transfer/conflict refs in sync on cancel,
eagerly clear conflictsRef on resolve to stop double processTransfer, and
surface adoption failures when resolving orphan conflicts.
2026-07-23 17:18:02 +08:00
bincxz fd55f04105 fix(sftp): sync conflict adopt for same-turn resolve and gate conflict actions
Keep conflictsRef updated during adopt so global conflict resolution applies
immediately, re-check cancel after adopt, gate replace/merge like the panel
dialog, and ignore dedicated progress while paused/cancelled.
2026-07-23 17:10:29 +08:00
bincxz 854b198517 fix(sftp): close dual-control, conflict-adopt, and orphan cancel gaps
Drop panel-local rows reassigned to dedicated-resume, seed conflicts on
adopt without auto-resume, cancel directory children on orphan cancel,
gate dedicated resume on !conflict, and hide invalid global merge actions.
2026-07-23 17:00:35 +08:00
bincxz 857d48a6b2 fix(sftp): never resume conflict rows via dedicated reconnect
Exclude conflict-pending transfers from dedicated resume and Resume All so
users cannot overwrite targets without resolving Replace/Skip/Duplicate.
Also skip Pause All on dedicated reconnect spinner rows.
2026-07-23 16:52:42 +08:00
bincxz f651900199 fix(sftp): isolate dedicated resume ownership and admit before SSH open
Reassign store ownership to dedicated-resume before reconnect work so
panel publishOwner cannot clobber progress, and open vault SFTP sessions
only after the renderer admission pool grants a slot.
2026-07-23 16:44:38 +08:00
bincxz d7ad6e256c fix(sftp): latch pre-start cancels and stop cancel/pause races
Remember cancels before startTransferNow registers the id, cancel the
renderer scheduler on orphan cancel, avoid pause completion resurrecting
cancelled rows, forward skipAdmission for temp downloads, and persist
progress checkpoints on background events.
2026-07-23 16:28:20 +08:00
bincxz 56e83d69a7 fix(sftp): harden resume admission, checkpoints, and terminal events
Share dedicated resume with the renderer admission pool, preserve queued
pause checkpoints, refuse to resurrect cancelled agent rows, and complete
dedicated resumes that finish after a reconnect-spinner pause.
2026-07-23 16:20:02 +08:00
bincxz e493e9615c fix(sftp): close remaining transfer lifecycle races
Settle directory streams on cancel return values, detach idle pool slots
before close, make force hard-close lease-aware, honor skipAdmission on
the worker IPC path, fix MCP non-worker admission, and block dedicated
resume from resurrecting cancelled/paused rows.
2026-07-23 16:10:50 +08:00
bincxz 3a282c06ba fix(sftp): address transfer review findings (leases, pool, resume)
Keep soft-close sticky across re-acquire, re-check before hard-close,
holder-aware pool discard, admit-then-lease for uploads, directory/cancel
resume edge cases, MCP skipAdmission, and vault-based reconnect identity.
2026-07-23 16:00:49 +08:00
bincxz b31bc0bec8 feat(sftp): harden global transfer center with FileZilla-style pool
Add dedicated transfer connections (1–2 per host) so bulk uploads/downloads
no longer block browse sessions. Also cover session leases, resume after
restart, auto-reconnect, skipAdmission, and transfer-center UX fixes for #2396.
2026-07-23 15:47:26 +08:00
bincxz c2bcfcb53e fix(sftp): refine global transfer controls 2026-07-23 14:18:07 +08:00
bincxz 0a8fa06112 feat(sftp): add global transfer center 2026-07-23 12:39:56 +08:00