Commit Graph
2208 Commits
Author SHA1 Message Date
bincxz ef7b552d78 fix(sftp): keep background transfers alive across UI lifecycle 2026-07-29 11:14:11 +08:00
bincxz fe737ec555 fix(perf): unify SFTP lifecycles and bound runtime resources 2026-07-29 03:33:00 +08:00
bincxz 49918fd54a fix(sftp): remove legacy transfer event path 2026-07-28 18:57:15 +08:00
bincxz 67e639c639 fix(ssh): resolve transfer source across multi-tab same hostId sessions
Add resolveSftpTransferSourceSessionId that walks all reusable terminal
sessions instead of the picker one-per-hostId list, so transfers can still
borrow a live transport when another tab for the same hostId has a different
endpoint.
2026-07-28 18:57:14 +08:00
bincxz 990bbe5f50 fix(ssh): match transfer source by endpoint and await late unforward
Transfer pool source sessions now require hostname/user/port parity so
multi-tab or overridden endpoints do not borrow the wrong shared transport.
Remote forward cancel-during-forwardIn and stop paths share one timed
unforward helper that discards the transport when the server listen stalls.
2026-07-28 18:57:14 +08:00
bincxz 3f706abfeb feat(ssh): unify transport leases and converge transfer keep-alive
Introduce a main-process SSH transport registry (borrow/return leases,
ControlPersist-style idle park) shared by shell, SFTP, transfer, and
port-forward. Transfer pool becomes channel concurrency only; remove the
separate transfer-pool idle TTL UI in favor of a single SSH keep-alive
setting. Register dedicated SFTP dials, reuse parked transports, and fix
TTL 0 (park until quit), jump-host endpoint keys, and remote unforwardIn.
2026-07-28 18:57:14 +08:00
陈大猫andClaude b77f0d97db fix(terminal): suppress autocomplete on alternate screen (#2530) (#2565)
* fix(terminal): suppress autocomplete popup on alternate screen (#2530)

Codex CLI's TUI (and other full-screen apps like vim/htop/less) render
their own input UI on the alternate screen buffer. Netcatty's autocomplete
only gated on its shell-prompt heuristic, which codex's composer line
matches — so typing "/" inside codex popped up Netcatty's path/command
list on top of codex's slash-command menu.

Bail out of fetchSuggestions (the single query path for both popup and
ghost text) when term.buffer.active is the alternate buffer. Reuses the
existing isTerminalAlternateScreenActive helper already used by hibernate.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(terminal): keep simple alt-screen autocomplete ban (#2530)

Drop the bloated TUI-vs-multiplexer heuristics from the codex auto-fix loop.
Disable autocomplete unconditionally on the alternate screen buffer — same
simple tradeoff as other hosts; tmux/screen attach has no Netcatty completions.

* fix(terminal): drop alt-screen completions after async lookup too

Same unconditional policy as the entry gate: if the buffer switched to
alternate while getCompletions was in flight, discard results so popup/ghost
cannot paint over a TUI. #2530

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-07-28 13:49:13 +08:00
Eric ChanandCursor 64148a1d8b fix(ai): route auto-detected network devices to raw PTY exec (#2367) (#2564)
* fix(ai): route auto-detected network devices to raw PTY exec (#2367)

AI exec paths (Catty, worker, MCP) decide whether to send commands raw
(no shell wrapping) based on meta.deviceType === "network". That field
only reflected the manual Network Device Mode toggle (host.deviceType),
so auto-detected switches (Huawei VRP, Cisco IOS, …) still went through
the POSIX shell wrapper. Their vendor CLIs reject the wrapped command,
the start marker never arrives, and the call stalls until the startup
timeout.

Report deviceType: "network" when the detected distro/vendor classifies
as a network device too, mirroring the terminal's own gating. This also
gives the AI system prompt vendor-CLI guidance before the user manually
flips the toggle. Mosh/ET sessions stay suppressed since they require a
shell-backed PTY.

Extract the pure buildAITerminalSessionInfo helper into its own module
for testability and add unit coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(ai): guard network-device classification against substring false positives

Address Codex review: replace non-ASCII ellipsis with ASCII per the
ASCII-only convention, and add a regression test proving classification
is exact-match against the vendor id list (so a custom distro that merely
embeds "cisco"/"huawei" is not treated as a network device).

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-28 13:11:53 +08:00
Netcatty-Botandnetcatty-bot 141c790921 fix(#2562): automated Cursor CLI fix (#2563)
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 11:57:44 +08:00
陈大猫andnetcatty-bot aaff0edc7f perf(vault): virtualize host pickers for large inventories (#2553)
* perf(vault): virtualize host pickers for large inventories

Virtualize Select Host, Quick Switcher, SFTP host picker, and workspace
dialogs so thousands of hosts only mount a viewport window. Shared scroll
and keyboard clamp helpers keep selection and filter-while-scrolled paths
stable under virtualization.

* fix: address Codex review on PR #2553

* fix(vault): plugin row heights and Select Host keyboard types

Give Quick Switcher plugin command/view rows a taller virtual slot so
two-line chrome does not overflow into the next absolute row. Narrow
Select Host navigable rows to group|host so Enter keyboard activation
typechecks cleanly.

* fix(vault): finish host-picker review feedback

Clip and truncate fixed-height Quick Switcher / workspace rows so long
labels never overlap the next virtual slot. Wire Select Host listbox
aria-activedescendant to stable option ids for keyboard AT feedback.

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix: address Codex review on PR #2553

* fix(vault): clear remaining host-picker codex findings

Declare multi-select listboxes, drop empty SFTP Hosts headers when only
connected rows remain, size the SFTP list to content under a 360px cap,
and give Quick Switcher / workspace pickers a definite max scroll height
so large inventories remain reachable.

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 11:48:01 +08:00
陈大猫andnetcatty-bot 3b51079c51 feat(snippets): open quick add/edit as a centered modal (#2552)
* feat(snippets): open quick add/edit as a centered modal

Replace the scripts side-panel AsidePanel drawer with a Dialog so
snippet create/edit no longer slides over the terminal workspace, while
keeping the same form fields and shortkey capture behavior.

* fix: address Codex review on PR #2552

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 01:39:02 +08:00
陈大猫 8cdc887383 [Feature] Optimize large Vault imports and group management (#2540)
* feat(vault): optimize large imports and vault rendering (#2526)

* fix(vault): address import review findings

* fix(vault): preserve filtered selection and import consistency

* fix(vault): complete import review fixes

* fix(vault): make import cancellation concurrency-safe

* fix(vault): preserve concurrent edits during import rollback

* fix(vault): handle concurrent saves and reset import target

* fix(vault): drop empty source groups after targeted import

* fix(vault): preserve sidebar accessibility check

* fix(vault): correct group counts and selection semantics

* fix(vault): preserve imports across concurrent saves

* fix(vault): preserve concurrent group changes during import

* fix(vault): close concurrent import edge cases

* fix(vault): retry rollback and enable tree keyboard selection

* fix(vault): retain concurrent sources and visible selections

* fix(vault): merge imported sources with persisted state

* fix(vault): serialize duplicate managed imports

* fix(vault): keep imports non-blocking and grouped views responsive

* fix(vault): preserve concurrent managed sessions

* fix(vault): preserve concurrent groups and keyboard access

* fix(vault): serialize cross-window import commits

* fix(vault): make import commits atomic

* fix(vault): surface import rollback failures

* fix(vault): recover import transactions safely

* fix(vault): commit imported hosts atomically

* fix(vault): preserve unfinished import recovery

* fix(vault): wait for edits and preserve keyboard focus

* fix(vault): protect group settings and lock fallback

* fix(vault): keep virtual focus aligned

* fix(vault): complete keyboard navigation semantics

* fix(vault): finish keyboard navigation

* fix(vault): close large-vault concurrency gaps

* fix(vault): finish large-vault interaction safety

* fix(vault): harden filtered large-vault flows

* fix(vault): keep managed deletion atomic

* fix(vault): coordinate managed file deletion

* fix(vault): close cross-window managed races

* fix(vault): refresh persisted managed state

* fix(vault): preserve distinct imported sessions

* fix(vault): keep failed progress accurate

* fix(vault): keep search tree collapsible

* fix(vault): close final review gaps

* fix(vault): reveal filtered tree matches

* fix(vault): close final review edge cases

* fix(vault): preserve concurrent import changes

* fix(vault): serialize all vault saves under one cross-window lock

Hold the shared import lock for ordinary host/group/key writes and the
full import commit path so check-then-write can no longer interleave
across windows. Make the lock re-entrant in-window to avoid nested
deadlocks, and announce large tree item positions for screen readers.

* fix(vault): keep concurrent saves serialized and fix tree ARIA siblings

Stop treating same-window concurrent work as nested lock re-entry; nested
helpers skip re-acquire only when the outer critical section already owns
the lock. Announce treeitem position among true siblings at each level.

* fix(vault): require explicit lock handle for nested saves

Independent concurrent vault writes always queue on the shared lock.
Nested import/deletion helpers continue only when they pass the active
lock handle from their outer critical section.

* fix(vault): avoid lock deadlocks with encrypt-then-write saves

Encrypt outside the shared lock and only acquire it for the final write so
importers waiting on pending work cannot deadlock on lock acquisition.
Retry plugin commits outside the lock when concurrent edits intervene, and
rebase imports onto in-memory host edits when disk is still stale.

* fix(vault): release import lock before concurrent-edit retries

Drain encrypt work under the lock and full disk writes only outside it.
When an import or group deletion is superseded by a concurrent edit, release
the shared lock so that edit can finish, then retry. Functional group updates
now base on the latest in-memory snapshot while a write is still pending.

* fix(vault): tidy import dialog destination and SecureCRT prompts

Move import destination settings behind a bottom-left control with its own
step, and keep SecureCRT guidance in a dedicated chooser instead of inside
the format tile.

* test(vault): fix import dialog layout guard test under ESM

* fix(vault): simplify import destination footer control

Replace the heavy two-line destination card with a single quiet text link
that shows the current placement choice.

* fix(vault): simplify import destination settings page

Drop the nested card and duplicate headings. Show only the three placement
choices, finish immediately for preserve, and keep Done only when a group
name is needed.

* fix(vault): simplify SecureCRT chooser and iconify destination options

Remove redundant SecureCRT prompt copy while keeping the two source cards
with icons. Add small folder icons to the import-location choices so that
page is less plain.

* fix(vault): use SecureCRT logo in import chooser header

* fix(vault): drop border around SecureCRT import logo

* fix(vault): clarify import location footer with icon and label

Show a folder icon plus "Import location · current choice" so the control
is recognizable without becoming a heavy card again.

* fix(vault): remove border from import progress status icon
2026-07-28 00:54:03 +08:00
陈大猫andnetcatty-bot d6efb6a313 fix(terminal): keep Enter reconnect working after disconnect (#2550)
* fix(terminal): keep Enter reconnect working after disconnect

Disconnected sessions advertised "Press Enter to reconnect" but often
swallowed the key when focus left xterm (body blur or dialog controls),
and an open terminal search bar globally hid the hint and disabled the
shortcut. Give the disconnected overlay a focus sink + local Enter
handler, and stop treating search-open as a global reconnect gate while
still leaving real buttons/inputs alone.

Closes #2544
Closes #2546

* fix(terminal): stop disconnected dialog focus theft

Only claim Enter-reconnect focus when it is already lost or still inside
this session tree, and restore xterm focus when the overlay unmounts.
Avoid stealing focus from other panes/side panels on disconnect.

* fix(terminal): restore dialog focus only when overlay leaves

Split claim/restore effects so showLogs/error rerenders no longer
yank focus off dialog buttons onto xterm mid-interaction.

* fix(terminal): restore Enter-reconnect focus in popup terminals

Popup Terminal windows lack data-session-id ancestors. Walk up from
the dialog to the local xterm root so claim/restore still work there.

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

* fix: address Codex review on PR #2550

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-28 00:20:02 +08:00
陈大猫 9eb83d7bce Merge pull request #2537 from binaricat/codex/issue-2506-font-search
feat(settings): add searchable font pickers
2026-07-27 19:37:38 +08:00
bincxz 2d5590a84c fix: reselect restored font value after closing search 2026-07-27 19:26:20 +08:00
bincxz 2e9491a86f fix(settings): scope font picker focus behavior 2026-07-27 19:01:50 +08:00
bincxz ccef87a938 fix terminal signal cleanup lifecycle 2026-07-27 18:58:34 +08:00
bincxz 07fc46a27c refactor terminal session signal state 2026-07-27 18:58:34 +08:00
netcatty-bot 98f131dcbf fix: address Codex review on PR #2536 2026-07-27 18:58:34 +08:00
bincxz a8ae4b680f fix terminal coding CLI icon detection 2026-07-27 18:58:34 +08:00
陈大猫 9de3b0b80d Merge pull request #2535 from binaricat/codex/fix-osc8-external-links
fix: open OSC 8 terminal links after confirmation
2026-07-27 18:51:38 +08:00
bincxz 7c635fb724 fix: retain link errors after hibernate 2026-07-27 18:19:28 +08:00
bincxz 5c50311f35 fix(settings): block disabled font picker interactions 2026-07-27 18:10:18 +08:00
bincxz cb20ee1ccc fix: avoid false link-open failure 2026-07-27 18:08:45 +08:00
netcatty-bot 78bfa01fec fix: address Codex review on PR #2537 2026-07-27 10:00:03 +00:00
netcatty-bot 39df1d2a96 fix: address Codex review on PR #2537 2026-07-27 09:47:52 +00:00
bincxz 8f246670e4 feat(settings): add searchable font pickers 2026-07-27 17:30:56 +08:00
bincxz aa98d6d34a feat: add system theme to quick controls 2026-07-27 17:25:47 +08:00
bincxz b0add81f91 fix terminal OSC 8 link opening 2026-07-27 17:15:45 +08:00
陈大猫 7d7c57be99 Merge pull request #2525 from binaricat/feat/scripts-sidepanel-ux
feat(scripts): improve terminal scripts side panel UX
2026-07-27 16:52:55 +08:00
陈大猫 8acc99b8be Merge pull request #2533 from binaricat/codex/fix-2528-editor-save
fix: preserve SFTP editor saves after maximize
2026-07-27 16:37:14 +08:00
bincxz 72ffc0ee31 fix(sftp): avoid retaining remotes for local editors 2026-07-27 16:31:04 +08:00
bincxz 22d0e5e5e8 fix(sftp): keep promoted editor save session alive 2026-07-27 16:05:03 +08:00
bincxz 821953cee8 fix(plugins): hide ineffective provider port control 2026-07-27 15:41:08 +08:00
bincxz 7f57bfb35f fix(scripts): skip multi-tab snippet write if wake surfaces password prompt
Check passwordPromptActive after hibernate wake inside the executor so the
command is not injected into a sensitive prompt before the caller rechecks.
2026-07-27 14:44:39 +08:00
bincxz 9549bbd51b fix(scripts): recheck sensitive after wake and re-arm hibernate
After multi-tab snippet wake, recheck sensitive/password prompts before
writing, and reschedule hibernation for peers that remain hidden.
2026-07-27 14:43:51 +08:00
bincxz e7d4b254cc fix(scripts): wake hibernated multi-tab peers via connected path
Use sessionConnected:true reattach wake for snippet fan-out so recreated
terminals keep session listeners, instead of the reconnect-only wake path.
2026-07-27 14:38:39 +08:00
bincxz f161296b6a fix(scripts): wake hibernated panes before multi-tab snippet write
Prefer waking the terminal runtime so executor encoding (including
bracketed-paste mode checks) is used, instead of inventing paste markers
on a blind backend fallback path.
2026-07-27 14:30:39 +08:00
bincxz eef6be9f86 fix(scripts): bracketed-paste hibernated multi-tab snippet fallback
When multi-tab fan-out falls back to a direct backend write (hibernated
pane), wrap multi-line paste/noAutoRun payloads so newlines do not submit
as Enter.
2026-07-27 14:24:47 +08:00
bincxz 7fc8fbb451 fix(scripts): fall back when hibernated snippet executor cannot write
Make executeSnippetCommand report success/failure so multi-tab fan-out can
use a direct backend write when a registered executor has no live termRef.
2026-07-27 14:17:51 +08:00
bincxz 9203ce69c0 fix(scripts): address Codex P1 sensitive skip and package focus trap
Guard standalone no-workspace run-on-all against sensitive prompts, and keep
Tab focus inside the new-package dialog overlay.
2026-07-27 14:12:31 +08:00
bincxz 1ff64ff07b fix(scripts): address Codex focus and modal review feedback
Skip terminal focus steal during multi-tab snippet fan-out and restore the
original pane afterward. Trap Tab focus inside the quick-add drawer and
restore the opener element on close.
2026-07-27 14:05:00 +08:00
bincxz ad72ca9dee Merge remote-tracking branch 'origin/main' into codex/pr-2413-finish 2026-07-27 13:55:58 +08:00
bincxz ac8ef5de38 fix(plugins): complete provider contract and lifecycle handling 2026-07-27 13:55:43 +08:00
bincxz dd53521e25 fix(scripts): clarify no-session toasts for multi-tab runs
Avoid labeling all-sensitive workspaces as no-session, and surface a toast
when an automation script is run with no focused terminal.
2026-07-27 13:53:51 +08:00
bincxz 7540dd1b86 fix(scripts): polish dialog Escape and sensitive multi-tab runs
Package dialog exposes data-dialog-close for Cmd/Ctrl+W; quick-add Escape
uses bubble phase so nested selects can dismiss first; automation multi-tab
runs skip sensitive sessions like plain snippets.
2026-07-27 13:49:58 +08:00
bincxz 7884524afa fix(scripts): address multi-agent review on side panel UX
Restore modal dialog contract for quick-add (role/data-state/escape),
harden package path validation, skip sensitive sessions on multi-tab
snippet sends, and show a single run-on-all-tabs action for plain snippets.
2026-07-27 13:44:40 +08:00
bincxz 074724eb68 feat(scripts): improve terminal scripts side panel UX
Address #2502: bind shortkeys when quick-adding snippets, add package
creation via a split + menu, convert quick-add to a right-side drawer,
and let code snippets run on all workspace tabs from the context menu.
2026-07-27 13:37:50 +08:00
bincxz 51394a00f6 fix(sftp): resolve hook dependency warnings 2026-07-26 23:35:52 +08:00
netcatty-bot 361b4952d2 fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00