mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
e6dd68b209b4b3e45175a9db6ba71488f0abb047
16
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
43d714b73c |
feat(serial): support local Windows named pipe consoles (#3894)
* feat(serial): support local Windows named pipe consoles * test(serial): synchronize pipe acceptance and cover saved-host form * fix(serial): preserve named-pipe paths with spaces when editing hosts * test(serial): verify Windows pipes through native Electron IPC * test(serial): keep Electron listener callbacks in renderer context * test(serial): cover busy pipe cancellation and bounded slow-reader writes * test(serial): construct single-instance fixture pipe path correctly |
||
|
|
15b16ab7b2 |
fix: serial backspace leaves hidden chars for multi-byte CJK input (#3325)
* fix: serial backspace leaves hidden chars for multi-byte CJK input
Serial terminals process backspace at the byte level: one 0x7F removes
one byte from the device input buffer. For multi-byte CJK characters
(UTF-8: 3 bytes, GB18030: 2 bytes), a single backspace leaves orphan
bytes that render as hidden or garbled characters.
Fixes three layers of the problem:
1. Character mode (createXTermRuntime.ts): when backspace is received
and the command-buffer's last character is wider than one byte,
send as many backspace bytes as the character occupies on the wire
so the device deletes the whole character.
2. Local echo (serialLocalEcho.ts): formatSerialLocalEcho now accepts
a backspaceCells parameter so CJK ideographs (2 terminal cells)
erase both cells instead of just one.
3. Line mode (serialLineInput.ts, Terminal.tsx): backspace local echo
now erases the correct number of cells based on the deleted
character's display width.
Adds serialCharMetrics.ts with getCharDisplayWidth (East Asian Width)
and getCharByteLength (UTF-8 / GB18030) utilities.
39 new and updated tests all pass.
* fix: address codex review — surrogate pairs, effective encoding, cursor guard, broadcast
Address all 5 P2 Codex review comments on PR #3325:
1. GB18030 4-byte supplementary chars: CJK Extension B+ (cp > 0xFFFF)
now returns 4 bytes instead of 2, matching iconv-lite's GB18030
encoder.
2. Effective session encoding: add currentEncodingRef to runtime
context so toolbar encoding changes propagate to backspace byte
length calculation (not just the saved host.charset).
3. Cursor-movement guard: track lastInputWasPrintable so backspace
byte expansion only fires when the cursor is at the end of the
typed buffer, not after arrow-key escape sequences.
4. Surrogate-pair-safe slicing: getLastChar/removeLastChar helpers
handle UTF-16 surrogate pairs (emoji, CJK Extension B) so slice(0, -1)
never leaves an orphan high surrogate.
5. Broadcast expansion: when backspace is expanded for the source
serial session, the same expanded data is sent to broadcast peers
instead of the original single-byte backspace.
Adds isPrintableInput, getLastChar, removeLastChar helpers.
56 tests pass.
* fix: address codex review — scope, bracketed paste, cursor confidence
Address 3 new Codex review comments on PR #3325:
1. P1: isExpanded/outData were declared inside the character-mode else
block but referenced after it (ReferenceError in serial line mode).
Moved declarations before the if/else so both branches share scope.
2. P2: Bracketed paste (\x1b[200~...\x1b[201~) starts with ESC so
isPrintableInput returned false, losing tail confidence. Now detected
and lastInputWasPrintable set to true.
3. P2: Printable input after a cursor movement reset lastInputWasPrintable
to true even though the cursor was not at the buffer end. Now the flag
is kept as-is when printable text is typed — only escape sequences
reset it to false.
* fix: establish cursor-tail confidence for initial and post-submission typing
Address Codex review: lastInputWasPrintable started false, so the first
printable input after session start or line submission would keep it
false, defeating the backspace byte expansion guard.
- Initialize to true: cursor is at the end of an empty buffer at
session start and after each line submission.
- Reset to true after Enter (handledSubmittedInput), Ctrl+C, and
Ctrl+U — all three clear the command buffer, placing the cursor
at the beginning of a fresh line.
This restores the original fix for the common case: type 你, press
Backspace, device receives 3 bytes and deletes the whole character.
* fix: address codex review — broadcast safety, paste cursor state, hibernation wake
Address 3 new Codex review comments on PR #3325:
1. Broadcast safety: stop forwarding expanded backspaces to broadcast
peers. Each peer has its own protocol, encoding, and command buffer,
so the source's repeated DELs can over-delete on non-serial peers
(SSH character-level) or on serial peers with different encodings
(GB18030 needs 2 DELs, not 3). The source session still receives
the expanded data; broadcast peers get the original single DEL.
2. Bracketed paste cursor state: no longer unconditionally set
lastInputWasPrintable=true on paste. After a cursor movement the
paste inserts at the moved cursor, not the buffer tail, so the
flag is now preserved as-is (false stays false).
3. Hibernation wake: initialize lastInputWasPrintable conservatively
when commandBufferRef is nonempty. A hibernated session retains
its buffer but the pre-hibernation cursor may have been moved,
so we start with false instead of true.
* fix: grapheme-safe backspace + gate expansion behind byteOrientedBackspace
Address 2 new Codex review comments on PR #3325:
1. Remove the whole grapheme on backspace (P2):
getLastChar/removeLastChar only handled UTF-16 surrogate pairs, so a
decomposed grapheme like e + U+0301 returned only the combining mark
and left the base. Rewrite both with Intl.Segmenter (grapheme
granularity) so surrogate pairs, combining marks, variation
selectors, and ZWJ sequences are removed as one unit. getCharByteLength
and getCharDisplayWidth already compose correctly for graphemes.
2. Gate byte expansion on byte-oriented line editing (P2):
Character-aware serial endpoints (e.g. a UTF-8 Linux console with
readline) delete one whole character per DEL, so repeating the
backspace 3x for a 3-byte char over-deletes. Add an explicit
serialConfig.byteOrientedBackspace flag (default true, preserving the
original fix) that users can disable for character-aware editors.
Wired through the serial connect modal and host details panel, with
i18n in en/zh-CN/zh-TW/ru/es, vault host validation, and session
restore/snapshot preservation.
170 tests pass.
* fix: xterm grapheme width for local echo + always compute cell width
Address 2 new Codex review comments on PR #3325:
1. Use xterm's grapheme width for local-echo erasure (P2):
getCharDisplayWidth returned 1 for emoji-presentation graphemes
(e.g. ❤️, 1️⃣, ©️) whose base characters fall outside the standard
emoji range. The 15-graphemes Unicode provider active in
createXTermRuntime renders these as 2 cells. Now import
stringCellWidth from terminalStringCellWidth.ts (which uses
_core.unicodeService.getStringCellWidth when available) in both
character mode (createXTermRuntime) and line mode (Terminal.tsx,
serialLineInput). Add VS16 (U+FE0F) detection to both the xterm
fallback and the domain getCharDisplayWidth so emoji-presentation
graphemes are correctly 2 cells even without xterm.
2. Compute local-echo width when byte deletion is disabled (P2):
When byteOrientedBackspace is false, the entire backspace block was
skipped, leaving backspaceCells at 1 and erasing only half of a
2-cell CJK/emoji glyph in local echo. Restructured the condition:
display width is now always computed when backspacing a non-empty
buffer, while wire-byte expansion is independently gated on
byteOrientedBackspace.
182 tests pass.
* fix: read byteOrientedBackspace from session snapshot, not live host
Address Codex review (P2): a restored or hibernated session's
snapshotted serialConfig.byteOrientedBackspace can differ from the
current vault host (e.g. session saved false, host later changed to
true). The runtime read the live host instead of the snapshot, so
after recreation a character-aware session could start expanding DEL
and over-delete again.
Add serialByteOrientedBackspace to the runtime context (mirroring
serialLineMode and serialLocalEcho) and pass it from the session
snapshot in useTerminalEffects. Default true preserves the existing
fix for byte-oriented devices.
182 tests pass.
* fix: carry serialByteOrientedBackspace and currentEncodingRef into hibernation wake context
Address Codex review (P2): xTermRuntimeContextRef.current in Terminal.tsx
omitted serialByteOrientedBackspace and currentEncodingRef, so when
hibernateHiddenTabs woke a serial tab the runtime fell back to default
values (byte-oriented=true, host charset). A session snapshot with
byteOrientedBackspace=false would re-enable byte expansion after waking,
and a toolbar-selected encoding would be lost.
Added both fields to the wake context alongside serialLocalEcho and
serialLineMode, mirroring the useTerminalEffects mount path.
182 tests pass.
* fix: tail confidence after line submission, GB18030 4-byte BMP, free-form encodings
Address 3 Codex review comments (all P2):
1. Preserve tail confidence after line submission:
After Enter submission sets lastInputWasPrintable = true, the same
\r/\n went through the generic control-char branch and immediately
reset it to false. This disabled byte expansion and correct local-echo
width for every subsequent command. Now skip the reset when
handledSubmittedInput is true.
2. Measure GB18030 bytes with the backend encoder:
getCharByteLength assumed every BMP non-ASCII character is 2 bytes.
But BMP characters outside the GBK character set (e.g. U+0100 'Ā')
encode to 4 bytes in GB18030. Added isGbkCharacter() to check the
GBK character set ranges; non-GBK BMP characters now return 4.
3. Use the backend charset for free-form serial encodings:
currentEncodingRef is now always present (hibernation wake fix), so
the ?? fallback to host.charset never triggered. For a Shift_JIS host
with no toolbar override, currentEncodingRef.current is 'utf-8' (the
default), causing UTF-8 byte lengths (3 for あ) instead of Shift_JIS
(2). Now prefer host.charset when it's non-UTF-8 and the toolbar
encoding is the default. Also added Shift_JIS support to
resolveWireEncoding and getCharByteLength (1 byte ASCII, 2 bytes
non-ASCII).
182 tests pass.
* fix: honor remembered UTF-8 when counting serial bytes
Address Codex review (P2): the previous fix treated every
toolbarEnc === 'utf-8' as an unselected default and overrode it with
the host charset. But a GB18030 host with a remembered UTF-8 preference
has its backend session synced to UTF-8 (via shouldSyncTerminalEncodingOnAttach),
so using the host's GB18030 charset for byte counting is wrong.
Now use resolveTerminalEncodingFromCharset to check if the host charset
is recognized by the toolbar system (UTF-8 or GB18030). For recognized
charsets, the toolbar encoding is authoritative (it may reflect a
remembered override). For unrecognized charsets (e.g. Shift_JIS), the
toolbar encoding falls back to the default (utf-8), so the host charset
is the correct wire encoding.
193 tests pass (including terminalEncodingPreference.test.ts).
* fix: honor toolbar changes for free-form charsets + GB18030 4-byte CJK Ext A
Address 2 Codex review comments (both P2):
1. Honor toolbar changes for free-form serial charsets:
When a Shift_JIS session starts and the user later selects UTF-8 in
the toolbar, setSessionEncoding switches the backend to UTF-8, but
the runtime continued using host.charset because it is outside the
two-option resolver. Now pass userPickedEncodingRef to the runtime
context (mirroring existing use in shouldSyncTerminalEncodingOnAttach).
The effective encoding logic:
- Non-utf-8 toolbar → trust toolbar (explicit selection)
- utf-8 toolbar + userPickedEncoding → trust toolbar (explicit utf-8)
- utf-8 toolbar + recognized charset → trust toolbar (remembered override)
- utf-8 toolbar + unrecognized charset → use host.charset (backend default)
2. GB18030 4-byte for CJK Extension A:
isGbkCharacter classified U+3400–U+4DBF (CJK Extension A) as 2-byte
GBK characters, but iconv-lite encodes this block as 4 bytes in
GB18030. Removed the range; these characters now correctly return 4.
193 tests pass.
* fix: simplify effective encoding logic with backendSynced flag
Follow-up to previous fix: the 4-level decision tree had an edge case
where a Shift_JIS host with remembered UTF-8 would use host.charset
instead of the synced toolbar encoding. Simplified to a 3-level logic
using backendSynced = userPicked || hasRemembered:
- backendSynced OR recognized charset → trust toolbar encoding
- NOT synced AND unrecognized charset → use host.charset (backend default)
Added hasRememberedEncodingRef to runtime context (alongside existing
userPickedEncodingRef) so the logic mirrors shouldSyncTerminalEncodingOnAttach.
193 tests pass.
* fix: sum grapheme code points, remove Latin-1 from GBK, generic multi-byte fallback
Address 3 Codex review comments (all P2):
1. Sum every code point in non-UTF-8 graphemes:
GB18030 and Shift_JIS returned after the first non-ASCII code point
instead of counting the complete grapheme that getLastChar returns.
❤️ (U+2764 U+FE0F) is 8 GB18030 bytes, but the old code returned 4.
Now accumulate byte lengths for all code points, like the UTF-8 path.
2. Stop classifying Latin-1 as two-byte GBK:
U+00A1–U+00FE was in isGbkCharacter, but iconv-lite encodes these
as 4 bytes in GB18030. Removed the range; these characters now
correctly return 4 bytes.
3. Count bytes for every backend-supported serial charset:
Unknown encodings fell back to UTF-8 byte length, but the backend
uses iconv-lite for Big5, EUC-JP, Johab, etc. (2 bytes for CJK).
Changed fallback to 1 byte ASCII + 2 bytes non-ASCII, matching
iconv-lite's multi-byte encoding for common serial charsets.
Comment 4 (remembered override for free-form charsets) was already
fixed in commit
|
||
|
|
5074e255b5 | fix saved serial backspace inheritance | ||
|
|
b386cb07d3 | fix preserve serial backspace session setting | ||
|
|
11695f0ec9 | fix serial backspace compatibility | ||
|
|
ea5320d94a |
Fix #954: unify Tooltip styling + replace native selects (#961)
* Fix #954: unify Tooltip styling + replace native selects Replace native HTML title= tooltips and native <select> dropdowns with the existing Radix-based Tooltip / Select components so they share the app's rounded styling, theme tokens and i18n pipeline. Adds a global TooltipProvider in AppWithProviders so every descendant Tooltip works without a per-file Provider wrapper. Scope (driven by the issue #954 examples and "全部都处理" follow-up): - TerminalLayer toolbar: Add Terminal / Split View / SFTP / Scripts / Theme / AI Chat / Move panel / Close panel. - TopTabs middle bar: quick switcher, more tabs, AI assistant, theme toggle, settings; window-control buttons (min/max/close), tray close and hotkey reset/disable have their native title dropped per the user's explicit opt-out ("可以不用Tooltip,直接全局禁用 原生title 属性"). - AI panels: AIChatSidePanel session history / new chat / delete, ConversationExport, AgentSelector, ChatInput attach / expand / permission, ModelSelector, ProviderCard, ai-elements/tool-call. - SFTP: SftpSidePanel header, SftpBreadcrumb, SftpFileRow, SftpPaneToolbar, SftpTabBar, SftpTransferQueue. - Settings: SettingsPage close, SettingsAppearanceTab theme/accent swatches, SettingsFileAssociationsTab edit/remove, SettingsSystemTab crash-log paths and global hotkey reset. - Host vault: HostDetailsPanel (clear / suggestions / show-password / key path / browse key), GroupDetailsPanel, KnownHostsManager, ConnectionLogsManager, KeychainManager, SyncStatusButton, CloudSyncSettings, LogView, QuickSwitcher, ScriptsSidePanel, Terminal status bar copy-host + broadcast/focus, ZmodemProgressIndicator. - Terminal subcomponents: HostKeywordHighlightPopover, TerminalComposeBar, TerminalConnectionDialog, TerminalSearchBar. - Editor: TextEditorPane (subtitle, search, wrap, promote-to-tab). - TrayPanel session rows and port-forwarding rows. Native <select> migrated to custom Select component: - SerialConnectModal (data bits, stop bits, parity, flow control) - SerialHostDetailsPanel (same four fields) - HostDetailsPanel backspace behavior - GroupDetailsPanel backspace behavior - SettingsTerminalTab local shell picker - terminal/ThemeSidePanel font weight Hardcoded English strings extracted to i18n. New keys for both en and zh-CN: terminal.layer.*, topTabs.*, ai.chat.* (sessionHistory, attach, collapse, expand, enableAgent), zmodem.*, settings.shortcuts. resetToDefault. Inline help text on SnippetsManager package-name input removed because the same hint is already shown in a visible <p> below the input. Existing per-file <TooltipProvider> wrappers (SnippetsManager, ScriptsSidePanel, SelectHostPanel, RuleCard, HostDetailsPanel proxy section) are left in place — they nest harmlessly under the global provider and stay self-sufficient for component tests. Tests: - tsc clean for changed files (pre-existing repo-wide errors unrelated to this PR). - All 802 tests pass (3 skipped pre-existing). - HostDetailsPanel.proxyProfile.test and TextEditorPane.test updated to wrap with TooltipProvider, matching the runtime context now needed by the migrated components. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fix #954: wrap Settings + Tray windows with TooltipProvider Settings and the tray panel mount as separate Electron windows with their own React root in index.tsx, so they do not inherit the global TooltipProvider added under AppWithProviders. After the unified Tooltip migration, any settings tab that used a Tooltip (Appearance, Application, FileAssociations, System, Shortcuts, Terminal, AI ProviderCard, AI ModelSelector) — and TrayPanel — threw "Tooltip must be used within TooltipProvider" and rendered nothing. Wrap both branches with TooltipProvider at the same level as ToastProvider in index.tsx. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|
|
c3224d30c6 |
feat: network device mode for SSH + serial charset encoding support (#540)
* feat: add deviceType field to Host model for network device support Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: pass deviceType through session metadata pipeline Thread deviceType from Host model through AITerminalSessionInfo, IPC types, and mcpServerBridge so AI agents can inspect device type per session. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: route network device SSH sessions to raw PTY execution When deviceType === 'network', handleExec now uses execViaRawPty instead of execViaPty so vendor CLIs (Huawei VRP, Cisco IOS, etc.) receive commands as-is without POSIX shell wrapping or markers. The command blocklist is also skipped for network devices, consistent with the existing serial session bypass. AI context description updated to document the raw-execution behaviour for network device sessions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add network device mode toggle to host settings UI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add network device awareness to Catty Agent system prompt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: extend network device mode to Catty Agent exec path and host context - Add network device detection and raw execution routing to aiBridge.cjs (the primary Catty Agent command path), not just the MCP bridge - Export getSessionMeta from mcpServerBridge for reuse in aiBridge - Surface deviceType in Catty Agent system prompt host list so the AI can identify which sessions are network devices - Pass deviceType through buildSystemPrompt context Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: exempt network device sessions from client-side blocklist and update ACP context - Add deviceType to ExecutorContext sessions type - Skip renderer-side command blocklist for deviceType=network sessions in shared toolExecutors.ts (not just main-process side) - Update ACP agent context hint to mention network device sessions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: only show network device mode toggle for SSH hosts Telnet and local hosts don't support the network device execution path, so hiding the toggle prevents users from enabling a broken configuration. Serial hosts already use raw mode by default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: exclude Mosh sessions from network device raw execution path Mosh uses a shell-backed PTY and cannot connect to vendor CLIs, so network device mode should only apply to SSH and serial sessions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: prefer session.protocol over metadata for Mosh detection Mosh tabs report protocol:"ssh" in renderer metadata but "mosh" in the main-process session object. Prioritize session.protocol (runtime truth) to correctly exclude Mosh from network device raw execution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: suppress deviceType metadata for Mosh sessions Mosh requires a shell-backed PTY and cannot connect to vendor CLIs, so omit deviceType from AI-facing metadata when session is Mosh-backed. This prevents the AI from being told to use vendor CLI syntax when the actual execution path uses normal shell wrapping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use exit code 0 for network device sessions and hide toggle for Mosh - Network device / serial sessions return exitCode: null from vendor CLIs. Default to 0 instead of -1 so the AI doesn't misinterpret successful commands as failures. - Hide the network device mode toggle when Mosh is enabled, since the setting is suppressed at runtime for Mosh sessions anyway. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve null exit codes and restrict raw mode to SSH/serial - Preserve exitCode: null for network device sessions instead of coercing to 0, so the AI knows exit status is unavailable rather than seeing a misleading success code. - Explicitly whitelist SSH/serial protocols for network device mode instead of just excluding mosh, preventing local/telnet sessions from accidentally entering raw execution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use UTF-8 encoding for SSH network device raw execution execViaRawPty hardcodes latin1 for serial port data decoding. Add an encoding option (default: latin1) and pass utf8 from SSH network device call sites so multi-byte characters aren't corrupted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use host charset for serial port decoding instead of hardcoded latin1 - Extract charsetToNodeEncoding() to module scope in terminalBridge - Serial sessions now read options.charset (from Host.charset) for both terminal display decoding and AI command output - Store serialEncoding on session object so exec paths can use it - Pass encoding through all execViaRawPty call sites - Default encoding changed from latin1 to utf8 (matches most modern network equipment and is the safer default for CJK environments) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: move serialEncoding declaration before session object creation serialEncoding was referenced in the session object literal before its const declaration, causing a TDZ ReferenceError that would crash every serial connection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: tighten isNetworkDevice logic and clean up edge cases - Align toolExecutors isNetworkDevice check with bridge logic: require explicit SSH/serial protocol match instead of trusting deviceType alone - Remove empty-string protocol match from isSshOrSerial in both bridges to prevent local/unknown sessions from being treated as network devices - Widen exitCode return type to `number | null` to match actual behavior - Clear deviceType when enabling Mosh (incompatible combination) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update MCP server tool descriptions for network device sessions The get_environment and terminal_execute tool descriptions only mentioned serial/raw sessions for network devices. Updated to also reference deviceType: network SSH sessions so external AI agents (Claude, Codex) know about the new execution mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: include deviceType in get_environment and guard execViaChannel fallback - Add deviceType to executeWorkspaceGetInfo session mapping and return type so Catty Agent's get_environment tool matches MCP bridge output - Guard both aiBridge and mcpServerBridge against falling through to execViaChannel for network device sessions — network devices require an interactive PTY and exec channels would produce broken behavior Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add charset setting to serial host configuration UI Serial hosts now have a charset input in the Advanced section, defaulting to UTF-8. The value is saved to Host.charset and used by the serial decoder in terminalBridge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add charset to serial quick-connect modal with full pipeline - Add charset input to SerialConnectModal (Advanced section) - Thread charset through onConnect callback → handleConnectSerial → createSerialSession → TerminalSession.charset - Add charset field to TerminalSession interface - Include charset in fallback host builder for quick-connect sessions so createTerminalSessionStarters can pass it to startSerialSession - Saved hosts also store charset via onSaveHost Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: constrain serial connect modal height with scrollable content Modal content could overflow the viewport when Advanced section was expanded. Add max-h-[85vh] to DialogContent with flex layout so the content area scrolls while header and footer buttons stay visible. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: propagate charset through all serial session creation paths - Add charset to startSerialSession type in global.d.ts - Copy host.charset to TerminalSession in connectToHost serial path - Copy host.charset in createWorkspaceWithHosts serial path - Propagate session.charset in splitSession (both workspace and standalone) - Propagate session.charset in copySession Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: propagate charset in remaining session creation paths Add host.charset to connectToHost (non-serial), createWorkspaceWithHosts (non-serial), and runSnippet session creation for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
9e57f2eb90 |
Address code review: fix substr deprecation and improve comments
- Replace deprecated substr() with substring() - Add clearer documentation about port field usage for serial hosts Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |
||
|
|
8cf6e9243d |
Support connecting saved serial hosts and add visual indicators
- Add serialConfig field to Host interface for storing full serial configuration - Update connectToHost to handle serial hosts and create proper serial sessions - Update handleConnectToHost to log serial connections properly - Update DistroAvatar to show USB icon for serial hosts Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |
||
|
|
7a32aa0743 |
Add custom baud rate support, serial config saving, and connection logging
- Changed baud rate input from fixed select to combobox with preset options + custom input - Added "Save Configuration" checkbox to save serial port settings as a host entry - Added connection logging for serial connections (similar to SSH/local terminals) - Updated ConnectionLog type to include 'serial' protocol - Updated ConnectionLogsManager to display serial connections with USB icon - Added i18n translations for new UI elements (en, zh-CN) Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |
||
|
|
035b22b467 |
Add stop‑bits warning, binary SFTP read support
- Introduces a user warning for 1.5 stop‑bits, which may be unsupported on some Windows devices, and updates both English and Chinese locales. - Extends serial port validation to recognize Windows UNC COM paths and displays the new warning when 1.5 stop‑bits are selected. - Improves SFTP modal behavior by re‑initializing when the initial path changes, using a ref to track the previous path. - Refactors terminal logic to obtain the current working directory via stream markers, applies `flushSync` to commit the path before opening the SFTP modal, ensuring correct initialization. - Adds a binary SFTP read API (`readSftpBinary`) on the Electron side and exposes it through the preload script, enabling proper handling of binary files. - Updates local Claude settings to allow linting via `npm run lint:*`. - Minor code clean‑ups and whitespace fixes across several bridge modules. |
||
|
|
6d973f9bc8 |
Fix Windows serial port validation to accept COM ports
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |
||
|
|
7acd9b3b8d |
Improves formatting and indentation in UI components
Refactors whitespace and indentation for better code readability and consistency in modal and terminal components. No logic or functional changes are introduced. |
||
|
|
05345d1ac7 |
Adds serial local echo and line mode terminal options
Enhances serial terminal usability by introducing configurable options for forced local echo and line mode (buffer input, send on Enter). Improves cross-platform compatibility by handling newlines to avoid display artifacts, and updates UI to allow manual port entry and clearer feedback for serial connections. |
||
|
|
8abba4bc7d |
Improve serial port validation based on code review
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |
||
|
|
ccf707df5a |
Add serial port connection support
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com> |