Commit Graph
866 Commits
Author SHA1 Message Date
陈大猫 da219f5b1e Merge pull request #2580 from tces1/fix/sftp-editor-maximize-save-2576
fix(sftp): restore editor tab saves after maximize
2026-07-29 16:38:21 +08:00
Eric ChanandCursor a3f8acd4e0 fix(sftp): remap editor sessions before pane cleanup runs
Reconnect can replace browse connection ids before save completes, so close
handlers that only matched sessionId skipped dirty editors and tore down their
writer. Remap as soon as reconnect is detected and match owners by sftpTabId.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 15:45:13 +08:00
Eric ChanandCursor 2e2cee08cf fix(sftp): track editor ownership by stable pane tab id
Reconnect during save changes the browse connection id before remapSessionId
runs, so session-id-only ownership briefly reports no owned editor and parks
the channel mid-write. Match promoted editors by sftpTabId as well.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 15:25:15 +08:00
Eric ChanandCursor bcca5ee028 fix(sftp): return post-reconnect connection id from editor save
Re-resolve the pinned pane after ensureRemoteSftpId so editorTabSave
remaps session ownership to the regenerated connection id.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 15:08:54 +08:00
Eric ChanandCursor 87facbae84 fix(sftp): keep promoted editor saves stable across reconnect
Track sftpTabId on editor tabs, remap sessionId after reconnect, and
subscribe SFTP side panels to editor presence only so typing does not
rerender every mounted panel.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 12:47:23 +08:00
Eric ChanandCursor b46a088dc8 fix(sftp): scope editor save recovery to owning connection
Drop hostId-based pane fallback so non-owning SFTP writers keep throwing
"connection is no longer available" and editorSftpBridge can dispatch to the
correct owner when multiple useSftpState instances are mounted.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 12:00:00 +08:00
bincxz a632030162 fix(sftp): mirror canonical completion state 2026-07-29 11:51:44 +08:00
bincxz cb5cd2cf16 fix(sftp): flush final progress before completion 2026-07-29 11:48:42 +08:00
Eric ChanandCursor a8cf5ffdd0 fix(sftp): restore editor tab saves after maximize
Keep browse sessions alive when promoting the built-in editor to a tab, and
reconnect the SFTP session on save when the browse mapping is missing.

Closes #2576

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 11:46:29 +08:00
bincxz 1e56f41fb3 test(sftp): cover completion during active walk 2026-07-29 11:44:29 +08:00
bincxz dfade4eb28 fix(sftp): publish directory completion through runtime 2026-07-29 11:40:16 +08:00
bincxz 75d4d6d1e4 Merge remote-tracking branch 'origin/main' into cursor/issue-2568-30346413686
# Conflicts:
#	application/state/sftpTransferCenterStore.test.ts
2026-07-29 11:34:49 +08:00
陈大猫 bdb6216c50 Merge pull request #2555 from binaricat/worktree/lucky-stone-3374
feat(ssh): unify transport leases and converge transfer keep-alive
2026-07-29 11:16:15 +08:00
bincxz ef7b552d78 fix(sftp): keep background transfers alive across UI lifecycle 2026-07-29 11:14:11 +08:00
Eric ChanandCursor a859af6c62 feat(terminal): suggest Network Device Mode via a session-header tip (#2566)
* feat(terminal): suggest Network Device Mode via a session-header tip

When a connected host is classified as a network device (auto-detected
vendor banner/os-release, or a manual distro-icon override) but Network
Device Mode is off, show a non-blocking one-line tip at the top of the
session. The user can enable the mode (persisted to the host) or dismiss
it; we only suggest once per host.

Driven by the host's effective distro so it also previews without real
hardware: set a host's device icon to a network vendor and reconnect.

- domain: shouldSuggestNetworkDeviceMode (exact vendor match, once-per-host)
- application/state: networkDeviceModeSuggestion persistence boundary
- TerminalView: header tip + reserve top offset so it never covers output
- i18n: terminal.networkDevice.tip.* for en/zh-CN/zh-TW/ru

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): gate network device mode tip to plain SSH sessions

Codex review: the suggestion tip used the host's effective distro (incl.
manual icon override), so a Mosh/ET/serial/telnet session with a
network-vendor classification would still offer it and persist a
host-level deviceType:'network'. The Host Details toggle is exposed only
for plain SSH hosts, so this could set a hidden mode that surprises later
SSH reconnects. Add an effectiveProtocol gate to shouldSuggestNetworkDeviceMode
and pass effectiveTerminalProtocol from TerminalView. (#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): make network device tip gate effective and popup/multi-pane safe

Addresses Codex re-review on the tip:
- The effectiveProtocol gate was dead: ctx never carried
  effectiveTerminalProtocol, so it was always undefined (unrestricted).
  Derive it from the host via resolveEffectiveTerminalProtocol instead.
- Suppress the tip when host updates are unavailable (detached popup has no
  onUpdateHost) so Enable can't silently no-op; plumb canUpdateHost through ctx.
- Sync dismiss/enable across panes/windows for the same host via an in-process
  subscription in the suggestion persistence module. (#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): make network device tip once-per-host, ephemeral- and multi-window-safe

Addresses Codex re-review round 3 on the tip:
- Exclude ephemeral deep-link/quick-connect hosts (isSavedVaultHost): they are
  not in the persisted vault array, so Enable would silently no-op even though
  canUpdateHost is true.
- Track first display separately from user interaction: record "shown" silently
  on first display so simply closing the session no longer re-nags on every
  reconnect, while the showing instance keeps the tip until the user acts.
- Propagate resolve/dismiss across separate BrowserWindows (#/session-window)
  via a native storage-event listener that diffs newly handled host ids.
(#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): don't touch localStorage at import; keep network tip clear of speed dial

Addresses Codex re-review round 4:
- P1: networkDeviceModeSuggestion read localStorage at module scope
  (knownHandledIds initializer), which threw ReferenceError under the Node
  test runner and broke `npm test`. Initialize it lazily inside the existing
  browser-only window guard instead.
- P2: when the host info bar is hidden and search is closed the full-width tip
  strip overlapped the compact speed-dial toggle (top-right) and swallowed its
  clicks. Reserve right-side clearance for the toggle via a pure
  resolveNetworkDeviceTipRightInset helper (with unit test).
(#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): drop network tip once the host is classified elsewhere

Addresses Codex re-review round 5: while the tip is latched open, enabling
Network Device Mode from Host Details or a synced pane updates the host to
deviceType:'network', but the eligibility effect's early return kept the tip
(and its now-redundant Enable action) visible. Clear the latch whenever
host.deviceType becomes 'network'. (#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(terminal): persist only the deviceType override, not the effective host

Addresses Codex re-review round 5 (P1): the tip's Enable spread the *effective*
session host (group defaults / proxy profile already materialized) into
onUpdateHost, so mergeTerminalHostUpdate froze every inherited field
(credentials, appearance, proxyConfig) as host-level overrides and later
group/profile changes stopped propagating. Send a sparse
{ id, deviceType: 'network' } update instead. (#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(terminal): move network device tip lifecycle into a state hook; per-host keys

Addresses Codex re-review round 6:
- P1 (architecture): TerminalView no longer imports the persistence API or owns
  the handled-state subscription/eligibility/writes. Extract
  useNetworkDeviceModeSuggestion under application/state; the component consumes
  { visible, enable, dismiss } and keeps only view glue (sparse host update +
  toast), per AGENTS.md's layer boundaries.
- P2 (cross-window clobber): persist one key per host instead of a single shared
  array. localStorage has no atomic read-modify-write, so concurrent appends
  from two windows could drop a marker; independent keys never clobber, and the
  storage event recovers the host id directly from the key.
(#2367)

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-29 11:11:14 +08:00
bincxz ae33bddc5d fix(sftp): bound deep directory traversal state 2026-07-29 05:14:51 +08:00
netcatty-bot f4091c149b fix: address Codex review on PR #2555 2026-07-28 21:02:57 +00:00
bincxz a2b9477c11 fix(runtime): close final auth and recorder races 2026-07-29 04:12:14 +08:00
bincxz 208191ed93 fix(sftp): close final transfer review gaps 2026-07-29 03:57:15 +08:00
bincxz 9a7b1b42ae fix(sftp): address current-head review findings 2026-07-29 03:45:13 +08:00
bincxz fe737ec555 fix(perf): unify SFTP lifecycles and bound runtime resources 2026-07-29 03:33:00 +08:00
bincxz 49918fd54a fix(sftp): remove legacy transfer event path 2026-07-28 18:57:15 +08:00
bincxz 2766896207 fix(sftp): throttle transfer progress UI to stop renderer freezes
Main-process progress IPC was ~10 Hz and each tick remapped the full
transfer list plus published the global center, pegging the main window
renderer at 100%+ CPU during large copies. Raise IPC throttle to 250ms/1MB
and coalesce progress-only React/store patches to one paint per frame.
2026-07-28 18:57:15 +08:00
bincxz 7aa3a0c81d fix(sftp): keep dedicated transfer opens off parked transport leases
Restart resume and bulk dedicated opens were still calling openSftp, which
silently borrowed a parked/shared terminal transport. That reattached
checkpoint resume to a lease-bound conn instead of an independent dial.
Dedicated transfer sessions now pass reuseTransport:false so they always
open a fresh vault SSH connection.
2026-07-28 18:57:15 +08:00
bincxz 990bbe5f50 fix(ssh): match transfer source by endpoint and await late unforward
Transfer pool source sessions now require hostname/user/port parity so
multi-tab or overridden endpoints do not borrow the wrong shared transport.
Remote forward cancel-during-forwardIn and stop paths share one timed
unforward helper that discards the transport when the server listen stalls.
2026-07-28 18:57:14 +08:00
bincxz aaf597eb64 fix(ssh): include auth policy in transport keys and migrate TTL
Fingerprint auth type, key id, MFA, agent, and host-key verification so
parked transports cannot bypass profile security edits. Migrate legacy
transfer-pool idle TTL into the SSH keep-alive setting on upgrade.
2026-07-28 18:57:14 +08:00
bincxz 3f706abfeb feat(ssh): unify transport leases and converge transfer keep-alive
Introduce a main-process SSH transport registry (borrow/return leases,
ControlPersist-style idle park) shared by shell, SFTP, transfer, and
port-forward. Transfer pool becomes channel concurrency only; remove the
separate transfer-pool idle TTL UI in favor of a single SSH keep-alive
setting. Register dedicated SFTP dials, reuse parked transports, and fix
TTL 0 (park until quit), jump-host endpoint keys, and remote unforwardIn.
2026-07-28 18:57:14 +08:00
netcatty-bot f4bdf4fc75 fix: address Codex review on PR #2569 2026-07-28 10:13:33 +00:00
netcatty-bot 03a6afef60 fix: address Codex review on PR #2569 2026-07-28 10:01:41 +00:00
netcatty-bot 16eae0d4e1 fix: address Codex review on PR #2569 2026-07-28 09:50:44 +00:00
netcatty-bot 44b87a815b fix(#2568): automated Cursor CLI fix 2026-07-28 09:38:46 +00:00
陈大猫 8cdc887383 [Feature] Optimize large Vault imports and group management (#2540)
* feat(vault): optimize large imports and vault rendering (#2526)

* fix(vault): address import review findings

* fix(vault): preserve filtered selection and import consistency

* fix(vault): complete import review fixes

* fix(vault): make import cancellation concurrency-safe

* fix(vault): preserve concurrent edits during import rollback

* fix(vault): handle concurrent saves and reset import target

* fix(vault): drop empty source groups after targeted import

* fix(vault): preserve sidebar accessibility check

* fix(vault): correct group counts and selection semantics

* fix(vault): preserve imports across concurrent saves

* fix(vault): preserve concurrent group changes during import

* fix(vault): close concurrent import edge cases

* fix(vault): retry rollback and enable tree keyboard selection

* fix(vault): retain concurrent sources and visible selections

* fix(vault): merge imported sources with persisted state

* fix(vault): serialize duplicate managed imports

* fix(vault): keep imports non-blocking and grouped views responsive

* fix(vault): preserve concurrent managed sessions

* fix(vault): preserve concurrent groups and keyboard access

* fix(vault): serialize cross-window import commits

* fix(vault): make import commits atomic

* fix(vault): surface import rollback failures

* fix(vault): recover import transactions safely

* fix(vault): commit imported hosts atomically

* fix(vault): preserve unfinished import recovery

* fix(vault): wait for edits and preserve keyboard focus

* fix(vault): protect group settings and lock fallback

* fix(vault): keep virtual focus aligned

* fix(vault): complete keyboard navigation semantics

* fix(vault): finish keyboard navigation

* fix(vault): close large-vault concurrency gaps

* fix(vault): finish large-vault interaction safety

* fix(vault): harden filtered large-vault flows

* fix(vault): keep managed deletion atomic

* fix(vault): coordinate managed file deletion

* fix(vault): close cross-window managed races

* fix(vault): refresh persisted managed state

* fix(vault): preserve distinct imported sessions

* fix(vault): keep failed progress accurate

* fix(vault): keep search tree collapsible

* fix(vault): close final review gaps

* fix(vault): reveal filtered tree matches

* fix(vault): close final review edge cases

* fix(vault): preserve concurrent import changes

* fix(vault): serialize all vault saves under one cross-window lock

Hold the shared import lock for ordinary host/group/key writes and the
full import commit path so check-then-write can no longer interleave
across windows. Make the lock re-entrant in-window to avoid nested
deadlocks, and announce large tree item positions for screen readers.

* fix(vault): keep concurrent saves serialized and fix tree ARIA siblings

Stop treating same-window concurrent work as nested lock re-entry; nested
helpers skip re-acquire only when the outer critical section already owns
the lock. Announce treeitem position among true siblings at each level.

* fix(vault): require explicit lock handle for nested saves

Independent concurrent vault writes always queue on the shared lock.
Nested import/deletion helpers continue only when they pass the active
lock handle from their outer critical section.

* fix(vault): avoid lock deadlocks with encrypt-then-write saves

Encrypt outside the shared lock and only acquire it for the final write so
importers waiting on pending work cannot deadlock on lock acquisition.
Retry plugin commits outside the lock when concurrent edits intervene, and
rebase imports onto in-memory host edits when disk is still stale.

* fix(vault): release import lock before concurrent-edit retries

Drain encrypt work under the lock and full disk writes only outside it.
When an import or group deletion is superseded by a concurrent edit, release
the shared lock so that edit can finish, then retry. Functional group updates
now base on the latest in-memory snapshot while a write is still pending.

* fix(vault): tidy import dialog destination and SecureCRT prompts

Move import destination settings behind a bottom-left control with its own
step, and keep SecureCRT guidance in a dedicated chooser instead of inside
the format tile.

* test(vault): fix import dialog layout guard test under ESM

* fix(vault): simplify import destination footer control

Replace the heavy two-line destination card with a single quiet text link
that shows the current placement choice.

* fix(vault): simplify import destination settings page

Drop the nested card and duplicate headings. Show only the three placement
choices, finish immediately for preserve, and keep Done only when a group
name is needed.

* fix(vault): simplify SecureCRT chooser and iconify destination options

Remove redundant SecureCRT prompt copy while keeping the two source cards
with icons. Add small folder icons to the import-location choices so that
page is less plain.

* fix(vault): use SecureCRT logo in import chooser header

* fix(vault): drop border around SecureCRT import logo

* fix(vault): clarify import location footer with icon and label

Show a folder icon plus "Import location · current choice" so the control
is recognizable without becoming a heavy card again.

* fix(vault): remove border from import progress status icon
2026-07-28 00:54:03 +08:00
bincxz 0378028de7 fix stale terminal output cleanup 2026-07-27 18:58:34 +08:00
bincxz ccef87a938 fix terminal signal cleanup lifecycle 2026-07-27 18:58:34 +08:00
bincxz 07fc46a27c refactor terminal session signal state 2026-07-27 18:58:34 +08:00
bincxz aa98d6d34a feat: add system theme to quick controls 2026-07-27 17:25:47 +08:00
陈大猫 28ba165c3e Merge pull request #2532 from binaricat/codex/fix-stuck-lint-test
fix(ci): prevent lint-and-test hangs
2026-07-27 16:50:41 +08:00
bincxz 3f1e22ce43 fix(sftp): keep resume verification responsive 2026-07-27 16:41:47 +08:00
陈大猫 8acc99b8be Merge pull request #2533 from binaricat/codex/fix-2528-editor-save
fix: preserve SFTP editor saves after maximize
2026-07-27 16:37:14 +08:00
bincxz 72ffc0ee31 fix(sftp): avoid retaining remotes for local editors 2026-07-27 16:31:04 +08:00
bincxz 22d0e5e5e8 fix(sftp): keep promoted editor save session alive 2026-07-27 16:05:03 +08:00
bincxz 0716820ce9 fix(plugins): close remaining provider lifecycle gaps 2026-07-27 14:50:26 +08:00
bincxz ad72ca9dee Merge remote-tracking branch 'origin/main' into codex/pr-2413-finish 2026-07-27 13:55:58 +08:00
bincxz ac8ef5de38 fix(plugins): complete provider contract and lifecycle handling 2026-07-27 13:55:43 +08:00
bincxz 1dfc898366 fix(sftp): persist history deletions immediately 2026-07-27 12:15:52 +08:00
bincxz 8d8abb4956 fix(sftp): preserve pruned cleanup data 2026-07-27 11:43:52 +08:00
bincxz ba8dea5cae fix(sftp): prevent large folder upload renderer stalls 2026-07-27 11:34:02 +08:00
netcatty-bot c7ce544c55 fix: address Codex review on PR #2494 2026-07-26 23:02:53 +08:00
netcatty-bot efbdf84308 fix: address Codex review on PR #2494 2026-07-26 23:02:28 +08:00
netcatty-bot ccb54952db fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00