mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-16 20:11:08 +00:00
b8d0a2f891e502cae6b735acdf2b13fced7fc6df
8
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
67f8108713 |
feat(plugins): add reviewed privileged terminal data pipeline (#2402)
* feat(plugins): add privileged terminal data pipeline * fix(plugins): harden terminal interceptor lifecycle * fix(plugins): close terminal interceptor lifecycle gaps * fix(plugins): preserve terminal interceptor state transitions * fix(plugin): close terminal pipeline lifecycle gaps * fix(plugin): harden terminal interceptor startup * fix(plugin): isolate terminal output route attempts * fix(plugin): isolate reused terminal sessions * fix(plugin): harden terminal interceptor boundaries * fix(plugin): harden terminal replay metadata * fix(plugin): preserve terminal replay provenance * fix(plugin): close terminal pipeline lifecycle races * fix(plugin): harden terminal route handoff * fix(plugin): contain terminal handoff failures * fix(plugin): route terminal attachment through RPC * fix(plugin): validate terminal attachment RPC * fix(plugin): close unexpected runtime ports * fix(plugin): canonicalize terminal data frames * fix(plugin): close terminal pipeline lifecycle gaps * fix(plugin): close terminal interceptor review gaps * fix(plugin): harden terminal interceptor protocol handling * fix(plugin): preserve terminal flow compatibility * fix(plugin): preserve terminal protocol accounting * fix(plugin): bound terminal interceptor lifecycle * fix(plugin): close terminal interceptor review gaps --------- Co-authored-by: ryan-wong-coder <wangsiyuan19990317@gmail.com> |
||
|
|
1428e9754c |
fix: let script waits match the visible startup screen (#2035)
* fix: let script waits match the visible startup screen Auto-login scripts that wait for bastion menus already on screen were timing out because startup snapshot sync marked the whole buffer as consumed. Replace the script buffer with the current viewport so waits can match visible text while still ignoring scrolled-off scrollback. Fixes #1960 Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep startup viewport waitable across sync races Address Codex review on #2035: merge the visible snapshot with any output that arrives during the snapshot IPC (e.g. bastion BEL), and seed the whole viewport as fresh so waitFor* can match headers beyond the 512-byte tail slack on long menus. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: do not seed buffer-fallback scrollback as visible screen When the renderer misses the snapshot request, requestScreenSnapshot returns the full script buffer, not the viewport. Mark that path and keep the consumed baseline so scrolled-off keywords cannot rematch. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: preserve live output during fallback snapshot sync Baseline only the pre-sync buffer length on empty/fallback snapshots so bytes that arrive while waiting for the snapshot stay matchable, matching the viewport path's trailingFresh behavior. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep waitForPrompt scoped to the live tail after seeding Seeded full-viewport freshness is for waitFor/waitForText/waitForRegex only. waitForAny still uses the 512-byte tail window so an older prompt still visible above long-running output cannot satisfy waitForPrompt. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: advance scan offset when consuming a preserved startup prompt waitForPrompt could resolve a seeded live-tail prompt without consuming the viewport above it, so a later waitForText rematched older visible lines. Advance scanOffset through the preserved prompt end. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: consume the full seeded viewport after startup prompt When waitForPrompt resolves a preserved live-tail prompt, advance scanOffset through the entire seeded snapshot — not just the prompt — so later waitForText cannot rematch older visible text after the prompt. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep sync-race trailingFresh outside seeded viewport seededLength must end at the visible snapshot so waitForPrompt does not consume bytes that arrived during the snapshot IPC. Those trailingFresh bytes stay matchable for later waitForText/waitForRegex. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: dedupe trailingFresh against blank-padded viewport snapshots Full-viewport snapshots often end with blank rows after live content, so a plain endsWith check missed sync-race duplicates. Compare after stripping trailing blank lines before appending trailingFresh. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: let generic waitForAny match the full seeded viewport Tail-only freshness is for waitForPrompt (allowPreservedTailMatch). Generic waitForAny must still see menu labels near the top of a long seeded startup screen, matching waitForText/waitForRegex. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: trim partial overlap from sync-race trailingFresh When the viewport snapshot already contains a prefix of trailingFresh, append only the non-overlapping suffix so waitForText cannot rematch a phantom duplicate of the overlapped text. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: match partial trailingFresh overlap against full viewport Use the unstripped viewport when trimming sync-race prefixes so an overlapped trailing newline is not left behind as a phantom blank line. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep waitForPrompt from rematching short seeded prompts After live output clears preservedTailMatch, currentTailFreshBoundary must start at seededLength so a short startup prompt cannot satisfy waitForPrompt through the normal 512-byte window. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: invalidate preserved prompts once scanOffset passes them If waitForText/waitForRegex already consumed output after a preserved startup prompt, clear that prompt via advanceScanOffset so waitForPrompt cannot reuse it. markOutputConsumedThrough still keeps the one-shot startup prompt for waitForPrompt. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: trim blank-padded overlap without dropping duplicate sync markers Use syncStartText to keep genuinely new duplicate suffixes during snapshot sync, while still trimming blank-padded and partial overlaps from trailingFresh. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: treat scrollback-backed stale viewports as pre-sync When syncStart has scrollback above the visible suffix, a stale snapshot can still equal that suffix without matching syncStart exactly — keep trailingFresh so duplicate markers printed during the IPC round-trip are not trimmed away. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: invalidate startup seed after automated script input sendLine/send must not leave the seeded viewport or preserved prompt matchable, or common send-then-wait scripts can complete against pre-command output. Keep sync-race trailingFresh beyond seededLength still waitable. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: keep long sync-race output waitable after startup prompt After waitForPrompt consumes the preserved prompt, re-seed remaining trailingFresh so markers ahead of a >512-byte burst stay matchable. Also consume all buffered bytes on automated input, including pre-input trailingFresh. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> |
||
|
|
965c1c581a | Fix script waits misjudging fresh multi-line output as stale (#1964) | ||
|
|
a46c3321db | Fix explicit script wait APIs (#1885) | ||
|
|
d534b80532 | fix script waits ignoring stale output | ||
|
|
1d18ca9761 |
Address bugbot findings for script wait and connect lifecycle.
Use tail-fresh matching instead of script-start baseline so waitForPrompt still works while stale scrollback no longer satisfies waitFor (#1776). Defer subscribeScriptRuns notifications, pre-check terminal runs, and run pending connect scripts when an earlier connect batch fails without retry. Co-authored-by: Cursor <cursoragent@cursor.com> |
||
|
|
b310ec7a25 |
Fix waitFor matching stale terminal scrollback at script start.
Mark the session output scan baseline after syncing the screen snapshot so waitFor/waitForAny only match output that arrives after the run begins. Fixes interactive prompts firing sendLine before the server asks (#1776). Co-authored-by: Cursor <cursoragent@cursor.com> |
||
|
|
6b9b71ac8a |
feat(scripts): terminal script automation, recording, and side panel (#1763)
* feat(scripts): add terminal script automation, recording, and side panel Introduce nct script runtime in the main process with terminal-side recording, execution overlay, Monaco editor, connect-script queues, and scripts side panel integration. Fix recording to wire scriptRecorderRef into xterm, use waitForPrompt for root/user shells, and save recorded scripts through the global editor dialog. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): address Bugbot review findings for recording and side panel Refresh script run state in side panel memo, guard toolbar recording against multi-session conflicts, reset connect scripts on reconnect, resolve focused session via getActiveTerminalSessionId, and avoid wiping host edit form when snippets list updates. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): prevent pending script re-run and improve workspace run feedback Track one-shot pendingScript execution separately from onConnect queue so reconnects do not replay Run-now scripts. Fall back to focused session when running on all tabs outside a workspace, and toast when every tab is still connecting. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): consume connect-script window once and filter serial hosts Mark the onConnect script evaluation as consumed even when the queue is empty so later snippet/host edits do not rerun automation mid-session. Restore serial-host filtering in SelectHostPanel confirm handler. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): grace period before giving up on connect-script queue Only mark onConnect automation as consumed after scripts run or a short post-connect grace window expires, so late-loading snippets still trigger while mid-session Vault edits do not. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): gate connect-script consumption on vault hydration Replace the grace timer with vault-init and unresolved host script binding checks so late-loading snippets still run onConnect automation while mid-session edits stay suppressed. Clear pending script run state on disconnect so reconnect retries workspace pending scripts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): honor run targets and retry failed connect automation Route QuickScriptEditorDialog Run through onRunSnippet for multi-host workspaces. Defer connect/pending script completion markers until each script succeeds and retry the queue after failures. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): stabilize pending runs and global connect queue sync Keep pending script run state across reconnects, run onConnect scripts before one-shot workspace pending scripts, and strip per-host queue entries when an onConnect script targets all hosts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): defer host queue snippet sync and guard connect runs Persist snippet target links only when the host panel is saved, block duplicate connect-script scheduling while a batch is running, and require runnable hosts before showing Run in the snippets editor footer. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): retry connect failures and surface output-trigger errors Use a retry tick in connect-script effect deps, toast automation failures from output triggers, and require runnable hosts before QuickScript Run. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): track id-less pending runs and re-arm output triggers Remember anonymous pendingScript objects after first run and allow onOutput triggers to fire again when new terminal output arrives. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): unblock paused connect runs and pass session meta Resolve waitForScriptRun on pause, run workspace scripts per session with hostname context, defer output-trigger arming until runs start, and add noRunnableHosts i18n for QuickScript Run. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): serialize output triggers and defer empty connect finalize Fire at most one onOutput trigger per scan while a run is active, and only finalize an empty connect queue after vault snippets are loaded. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): guard output launch race and script run waits Block overlapping onOutput launches, timeout stuck waitForScriptRun promises, and disable vault Run when no connectable targets exist. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): match output triggers on new chunks only Scan onOutput patterns against recent terminal output instead of buffer length dedupe, and restore overflow-visible on SelectHostPanel new-host flow. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): await sequential workspace runs and output launch Wait for each tab script to finish in sequential workspace mode, and hold output-trigger launch guard until the session run becomes active. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): wait through pause and hold output trigger until done Keep connect and sequential workspace queues blocked until scripts complete or fail, and retain output-trigger guard until the launched run finishes. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): harden output trigger wait helpers Add explicit timeouts to output-trigger wait helpers and stop rescanning the buffer after script completion to avoid sticky-match rerun loops. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): allow empty connect queue and match output in new chunks Treat an empty connectScriptIds array as an explicit cleared queue instead of re-migrating from snippet targets, and only fire onOutput triggers when the latest terminal output contains the pattern. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): require fresh output overlap for onOutput triggers Only fire output-matched scripts when the regex match extends into the latest terminal chunk, preventing reruns from stale buffer text. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): promote manual scripts added to host connect queue Diff connect queue changes from raw connectScriptIds so saving a host updates manual scripts to onConnect when they are newly queued. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): dedupe output triggers by match position Track the buffer end offset of each output trigger match and ignore stale re-scans, with a longer wait for run registration before retry. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): record output trigger matches only after run starts Propagate automation launch failures to output triggers and commit match dedupe only once the session run is registered as active. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): address Codex review on wait cursor and sensitive codegen Track scan offset so waitFor/waitForAny only match output after the previous wait, and emit sendLine after sensitive prompt in recorded scripts. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(scripts): harden onOutput triggers against PTY echo and local input Filter server output before pattern matching so onOutput fires only after Enter on real stdout, not on keystroke/paste echo, OSC/SGR sequences, or alternate-screen apps. Add dev diagnostics and scope triggers to the active session when no explicit host targets are configured. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(scripts): remove onOutput trigger debug logging Drop temporary diagnostics module and console traces now that PTY echo filtering is verified; keep the production trigger pipeline unchanged. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> |