Commit Graph
193 Commits
Author SHA1 Message Date
bincxz 51394a00f6 fix(sftp): resolve hook dependency warnings 2026-07-26 23:35:52 +08:00
netcatty-bot 361b4952d2 fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 18f6a89adf fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
bincxz c89522f014 fix(sftp): pin clipboard uploads to originating tab endpoint
Capture tabId/connectionId at paste time and resolve external folder/entry
uploads against that pane after awaits so mid-transfer tab switches cannot
retarget remaining multi-folder items to another host. Prefer the pinned
pane host when reconnecting and reconnect by tab id without clobbering the
active tab's lastConnectedHost.
2026-07-26 23:00:43 +08:00
bincxz e42893b25e fix(sftp): restore cancel-by-task, clipboard confirm, and browse stay-alive
PR #2509's TransferRuntime unify accidentally regressed per-task external
upload cancel (#2495), clipboard confirm close-before-upload (#2478), and
main SftpView interactive browse sessions (#2498). Restore those behaviors
on top of the process-level control plane, keep Pausing copy, and gate
broadcastGlobalTransferEvent so bare Node unit tests do not download Electron.
2026-07-26 22:47:36 +08:00
bincxz d165e158f7 fix(sftp): unify transfer control under process-level TransferRuntime
Pause and resume now go through one process-level control plane that survives
panel/terminal close: TransferRuntime + soft latches/epochs/walk registry,
soft-then-hard resume, dual-epoch-safe progress, and no-owner soft control.
2026-07-26 21:27:01 +08:00
陈大猫 5e5c98a682 Merge pull request #2486 from binaricat/fix/sftp-transfer-pause-responsiveness
fix(sftp): make transfer pause responsive and visible
2026-07-26 00:10:47 +08:00
bincxz 3d140c2f8e fix(sftp): harden folder pause/resume, delete, and root reconnect
Make folder pause latch-first with barriers and a child pause watchdog so
workers stop claiming files after soft-drain; soft-resume live walks instead
of full rewalks. Surface path conflicts with toasts, keep pause progress
visible, and show a resume spinner. Restore verified shell rm -rf with SFTP
confirmation for fast directory delete, and prefer reconnect over wiping the
pane to the host picker when listing fails on some hosts.
2026-07-26 00:10:22 +08:00
netcatty-bot b9e699d436 fix: address Codex review on PR #2486 2026-07-25 14:42:32 +00:00
netcatty-bot 48421c6f2e fix: address Codex review on PR #2486 2026-07-25 14:14:51 +00:00
陈大猫 12d9913537 fix(sftp): cancel external uploads by transfer task id (#2495)
Track UploadController instances per transfer task so queue cancel of one
external upload does not abort another concurrent paste/drop upload.
Scope pending conflict prompts to the owning controller as well.
2026-07-25 22:05:37 +08:00
bincxz 95c53da338 fix(sftp): wire panel pause through the same center control path
SFTP queue pause/resume/cancel now call sftpTransferCenterStore (same as the
global transfer center), harden action-button pointer handling, retry
"cannot be paused yet", and keep progress updates from undoing a paused row.
2026-07-25 22:03:05 +08:00
陈大猫 779d553d31 fix(sftp): close clipboard upload dialog before transfer (#2493)
* fix(sftp): close clipboard upload dialog before transfer

Clear the confirmation request before awaiting the upload so the modal
overlay no longer blocks side-panel and standalone SFTP during large
clipboard transfers (issue #2478). Keep the existing background transfer
path and post-upload refresh; guard double-clicks and skip refresh on
transfer failure.

* fix(sftp): scope clipboard confirm guard to request identity

Only block double-clicks on the same confirmation request so a later paste
can still Upload while an earlier background transfer is in flight.
2026-07-25 21:54:04 +08:00
bincxz 07d326fde7 fix(sftp): make transfer pause responsive and visible
Pause felt stuck because the panel hid the pausing state, and the
backend waited for every in-flight range plus a full source fingerprint
hash. Soft-drain concurrent ranges, skip blocking fingerprint work, and
show clear pausing feedback in the panel and transfer center.
2026-07-25 20:37:56 +08:00
bincxz ed6ed76c21 feat(sftp): harden global transfer center pause/resume and open-folder UX
Keep browse sessions independent of pool transfers, complete dedicated resume
for files/folders after restart, roll back partial pause safely, clamp crash
checkpoints to durable .part size, and open upload targets by connecting the
host when no terminal tab is active.
2026-07-23 23:46:49 +08:00
bincxz b31bc0bec8 feat(sftp): harden global transfer center with FileZilla-style pool
Add dedicated transfer connections (1–2 per host) so bulk uploads/downloads
no longer block browse sessions. Also cover session leases, resume after
restart, auto-reconnect, skipAdmission, and transfer-center UX fixes for #2396.
2026-07-23 15:47:26 +08:00
bincxz c2bcfcb53e fix(sftp): refine global transfer controls 2026-07-23 14:18:07 +08:00
bincxz 0a8fa06112 feat(sftp): add global transfer center 2026-07-23 12:39:56 +08:00
f4bc94eadc fix(sftp): follow terminal cwd on macOS/BSD remotes and first open (#2388)
* fix(sftp): follow terminal cwd on macOS/BSD remotes and first open

The "follow terminal directory" probe read the interactive shell's cwd
only via /proc, which does not exist on macOS/BSD remotes, so
getSessionPwd fell back to the home directory (or failed) and the SFTP
panel never tracked the terminal. Add an lsof fallback (read_shell_cwd)
so the probe works on non-Linux remotes; Linux keeps using /proc.

Also fix the first open: while the panel is closed the per-command cwd
probe does not run, so activeTerminalCwd can be stale (login home) even
after the terminal cd-ed elsewhere. On that stale value the follow sync
saw currentPath === terminalCwd and did nothing, leaving the panel at
home. Force one fresh backend probe when the panel first becomes visible
for a connected remote, and re-sync on reopen.

Fixes #2335

Co-authored-by: Cursor Agent <cursor-agent@cursor.com>

* fix(sftp): keep first-open follow from snapping back to stale cwd

Addresses PR review: the first-open resync navigated to the freshly
probed terminal cwd but left the stale `activeTerminalCwd` cache (login
home) in place. Because the one-shot ref was already set, a later
dependency change that re-runs the normal follow sync (e.g. closing an
editor toggles hasActiveWork) would navigate the pane back to that stale
home. Mark the stale cached cwd as already handled before navigating so
the normal sync no-ops until the live cwd catches up;
invalidateInFlightFollowSync clears the guard once activeTerminalCwd
actually changes, letting follow resume.

Co-authored-by: Cursor Agent <cursor-agent@cursor.com>

* fix(sftp): re-check follow eligibility before first-open navigation

Addresses PR review: the first-open resync awaited a fresh terminal-cwd
probe but only re-validated the connection afterward. If the panel was
hidden or interactive work started (editor/dialog) while the probe was
in flight, it still navigated, moving the pane while the follow feature's
own visible/work guards say it should be paused.

Add a live followStillEligible() check (generation, follow enabled/
allowed, visible, no active work, same connection) that gates both the
post-probe continuation and the navigateTo call via shouldApply, matching
the normal follow path. Reset the one-shot guard when bailing mid-probe
so the resync can retry once follow is eligible again.

Co-authored-by: Cursor Agent <cursor-agent@cursor.com>

* test(host-details): align auth row assertion with unified row height

The HostDetailsSection row was unified to `flex h-12 ... px-3` (#2378)
but HostDetailsConnectionSections.test still expected the old
`min-h-12 ... px-3 py-2` class, failing lint-and-test on main. Update the
regex to match the shipped markup.

Co-authored-by: Cursor Agent <cursor-agent@cursor.com>

* fix(sftp): harden terminal cwd resync

---------

Co-authored-by: Cursor Agent <cursor-agent@cursor.com>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
2026-07-22 11:58:55 +08:00
陈大猫 5ed3dbc557 align SFTP host picker rows with quick switcher (#2376)
* align SFTP host picker rows with quick switcher

* include SFTP host picker test in npm test

* preserve keyboard selection during pointer hover
2026-07-22 00:41:48 +08:00
陈大猫 4b4b7d4449 Improve SFTP sorting and keyboard navigation (#2314)
* improve SFTP sorting and keyboard navigation

* fix SFTP keyboard actions for empty views

* fix SFTP file row context menu

* fix folders-first kind sorting
2026-07-19 11:34:47 +08:00
bincxz da6881079c fix(sftp): rebind to focused terminal session on focus change
Do not reuse a healthy same-endpoint SFTP tab across terminal session focus
changes — proxy/jump can differ while host keys match. Capture the visible
path first and reconnect in place with remembered initialPath + new
sourceSessionId so the directory stays sticky without stacking tabs.
2026-07-15 01:11:48 +08:00
bincxz 7f1eb9654e fix(sftp): rebind SFTP on terminal session change, keep path
Session switches can share a saved host key while live credentials/endpoints
differ, so always rebind to the focused session. Restore the last browsed path
on that reconnect so multi-terminal use no longer drops back to $HOME.
2026-07-15 00:27:08 +08:00
bincxz f807650bc0 fix(sftp): key sticky paths by live connect-time endpoint
Use the connect-time connection cache key for skip/reuse and path memory so
same-hostId endpoint switches are not mis-attributed. Only restore previous
path on reconnect when the target host matches the prior connection.
2026-07-15 00:15:50 +08:00
bincxz 6133d0c610 fix(sftp): verify active tab endpoint before sticky skip
Require the active tab's mapped connection key to match the focused host
before skipping auto-connect, and re-key last-browsed paths from the live
connection so host-picker switches do not poison another host's memory.
2026-07-15 00:08:08 +08:00
bincxz 530738a485 fix(sftp): keep sidebar path sticky across terminal focus and reconnect
Closing follow mode still dropped back to $HOME when switching terminals or
after SFTP reconnect. Reuse a healthy same-host tab and restore the last
browsed path on rebind/reconnect.

Fixes #2193
2026-07-15 00:01:14 +08:00
陈大猫 fa4d0d5348 feat(ui): customizable dense toolbars (show / collapse / hide) (#2183)
* feat(ui): customizable dense toolbars with show/collapse/hide

Add a shared toolbar layout model so terminal, SFTP, and side-panel
action strips can right-click customize placement, overflow collapsed
items into the more menu, and persist order plus placement.

* fix(ui): harden toolbar layout placement after review

Address review findings: availability-aware reachability, skip
unavailable reorder neighbors, Popover overflow for nested SFTP menus,
path chrome outside customize context menu, and side-panel hide close.

* fix(ui): only close side panel when hide placement sticks

Return the next layout from setPlacement so hide-of-last-reachable
does not tear down the panel, keep an active hidden tab chip visible,
and rebuild terminal shown order with highlight collapse coercion.

* fix(ui): narrow SFTP overflow spill and close ⋮ after leaf actions

Respect user show/collapse/hide, then temporarily move non-pinned shown
actions into ⋮ when the SFTP toolbar is narrow. Close overflow after
leaf clicks while keeping nested bookmark/encoding panels usable.
2026-07-14 17:11:03 +08:00
bincxz 857dc789fc clean up deferred UI timers 2026-07-12 23:57:10 +08:00
bincxz 8b104a6813 Keep SFTP column settings consistent 2026-07-12 12:34:51 +08:00
bincxz 4b3bdfb033 Allow hiding SFTP file columns 2026-07-12 12:25:15 +08:00
陈大猫 b17bc15c48 Fix silent SFTP copy when destination pane is unavailable (#2123)
* fix SFTP copy feedback without target pane

* handle inactive SFTP copy destinations

* block SFTP copy during reconnect
2026-07-11 22:52:21 +08:00
bincxzandCursor 48157f56a8 fix: keep edited saved hosts visible next to Connected rows
Only hide a vault host when its endpoint matches the live Connected
entry, so post-connect host edits still offer the new saved target.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-09 15:16:03 +08:00
bincxzandCursor 82af11f26e fix: only list reusable SSH sessions in SFTP Connected picker
Exclude connecting and Mosh/ET sessions so Connected rows always map
to a live ssh2 shell that SFTP can reuse without a fresh login.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-09 13:49:00 +08:00
bincxzandCursor a90a681cf0 feat: show live terminal hosts in SFTP picker
Let users pick currently connected SSH sessions from the SFTP host
picker and reuse the existing connection, including ephemeral deep-link
hosts.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-07-09 11:52:38 +08:00
陈大猫 205f266441 [codex] Fix delete dialog overflow (#1987)
* Fix delete dialog overflow

* Cover group delete dialog overflow
2026-07-07 10:25:35 +08:00
陈大猫 e430a42dbe Fix SFTP follow cwd manual navigation (#1922) 2026-07-04 15:03:01 +08:00
陈大猫andCursor 0ceec3d45c fix(sftp): stop follow-terminal-cwd retry loop on unreachable paths (#1629)
* fix(sftp): stop follow-terminal-cwd retry loop on unreachable paths

When per-host follow navigates to a terminal cwd that SFTP cannot reach, stop retrying and allow the toolbar toggle to update immediately.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sftp): address Codex review on follow-terminal-cwd blocking

Return navigateTo success explicitly and scope blocked follow paths per connection so successful navigations and host switches are not misclassified.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sftp): clear follow block after manual go-to-terminal-cwd

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sftp): honor cleared follow-cwd overrides from vault sync

Use an explicit pending toggle override instead of stale session host values when the vault clears per-host follow settings back to inherit-global.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sftp): ignore stale follow navigation when follow is disabled mid-flight

Bump a follow-sync generation when follow is turned off so pending navigateTo failures cannot restore a blocked cwd after the user disables and re-enables follow.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 19:27:20 +08:00
陈大猫andCursor 6fad3f0b76 fix(sftp): reconnect terminal side panel after SSH session loss (#1608) (#1621)
* fix(sftp): reconnect terminal side panel after SSH session loss

When SSH disconnects while the terminal SFTP side panel is browsing a stale
path, auto-connect reused a dead tab and left the pane stuck on loading.
Rebind SFTP when the terminal session changes and skip reuse unless the
backend session is healthy; also stop follow-terminal-cwd retry loops to
missing directories.

Fixes #1608

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sftp): address review findings for side panel reconnect

Harden auto-connect after bugbot review: skip tab reuse on SSH session
change, move follow-cwd backoff ref into the interactive body, and make
navigateTo return reached/failed/aborted so follow mode only backs off on
real path failures.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 14:31:23 +08:00
bincxzandCursor 4b874410f9 fix(opencode): harden SDK streaming, model list, and Windows shim path
Route Netcatty context through body.system, filter echoed user parts,
keep OpenCode env/shim alive for server lifetime, and cap model preset dropdown height.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-23 18:56:46 +08:00
bincxz a7cc2cbee3 Refresh SFTP follow toggle from latest host 2026-06-23 14:52:26 +08:00
bincxz 6554f7bc8f Persist SFTP follow toggle for visible host 2026-06-23 14:34:50 +08:00
bincxz f53d359d38 Bind SFTP follow cwd to hosts 2026-06-23 14:24:22 +08:00
bincxz 8741d683ba Address smoothness review findings 2026-06-23 01:49:57 +08:00
bincxz affe197f26 Improve Netcatty responsiveness 2026-06-23 01:26:12 +08:00
Ryanisgood 46755465f9 feat: add SFTP current path copy action (#1506) 2026-06-17 23:31:54 +08:00
陈大猫 b9e88cd99d Simplify SFTP conflict dialog
Simplify the SFTP file conflict dialog and reduce visual noise.
2026-06-12 18:12:28 +08:00
陈大猫 32afade4f9 Fix SFTP type-mismatch upload conflicts (#1449) 2026-06-12 17:46:32 +08:00
陈大猫 910ef72205 [codex] Fix known host fingerprint coverage (#1442)
* Fix known host fingerprint coverage

* Tighten SFTP host key verification
2026-06-12 16:09:29 +08:00
陈大猫 36724a3abd Add SFTP tab duplication menu
Fixes #1423
2026-06-12 14:40:22 +08:00
bincxz e67012654a Improve SFTP bookmark list accessibility 2026-06-10 10:25:19 +08:00