90ab87efcc
feat(editor): detached multi-tab window with acknowledged content handoff ( #3606 )
...
Add a detached multi-tab editor window with acknowledged content ownership, focused Monaco shortcuts, and shared close/save confirmation. Preserve source contents until handoff acknowledgement and block edits or incoming transfers during ownership changes.
Continuation of #3439 . Original implementation by pplulee.
Co-authored-by: pplulee <hi@pplulee.me >
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-10-08 18:11:23 +08:00
陈大猫 and netcatty-bot
4cd6a7191d
feat(sftp): add Cancel all action to transfer center ( #3574 )
...
* feat(sftp): add cancel all to transfer center
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix: address Codex review on PR #3574
* fix(sftp): settle cancelled walks before directory recovery
* fix(sftp): report failed cancel attempts without blocking retries
* fix(sftp): batch pending cancel cleanup for large queues
* fix(sftp): preserve settled children during cancel recovery
* fix(sftp): release skipped cancel-all pre-latches
* fix(sftp): satisfy cancellation result and fixture types
* fix(sftp): dispatch cancel batches before walk settlement
* fix(sftp): distinguish live compression recovery from restored attention
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
2026-10-08 17:50:41 +08:00
Yohann and yangheng
75c155b748
feat(vault): add host connection test to the host editor ( #2984 )
...
* feat(vault): add host connection test to the host editor
Add a 'Test' button next to Save in the host editor that opens a dialog reusing the terminal's connection progress/auth/host-key UI, and runs a headless connection probe:
- Main process: netcatty:test-connection reuses startSSHSession in a testMode that authenticates then tears down without opening a shell, reports via netcatty:test:result, and supports cancellation (netcatty:test-connection:cancel).
- Renderer: useHostConnectionTest hook + HostConnectionTestDialog component; single-credential auth (no agent/default-key fallback) with short test timeouts (8s TCP / 15s auth).
- Reuses terminal chain progress, host-key verification, and auth prompts; success keeps the same dialog with retry/close.
* fix(ssh): cancel test connections during chain/proxy dial
Register the headless test-connection transport before connectThroughChain / createProxySocket runs, and update its pendingConn / chainConnections as hops and proxy sockets are established. This lets cancelTestConnection abort a slow/unreachable bastion or proxy dial instead of leaving it running until timeout.
* fix(ssh): address host connection test review feedback
- Route jump-host keyboard-interactive prompts through the external scope in test mode
- Always offer keyboard-interactive for requiresMfa hosts in test mode, including key/certificate-only auth
- Derive the renderer test deadline from the probe options and cancel the attempt on timeout
- Run the macOS Local Network preflight before connection tests
- Add regression tests for jump-host MFA, MFA auth order, test deadline, and macOS preflight
Author: yangheng
Model: claude-opus-5
---------
Co-authored-by: yangheng <492238647@qq.com >
2026-10-08 14:42:18 +08:00
b2ed83ae51
fix(tray): add independent persisted show-tray-icon setting ( #3572 )
...
* fix(#3553 ): automated AI fix
* fix(tray): keep icon visible independently of close behavior
* docs(settings): clarify background close behavior
* fix(settings): preserve tray visibility for existing users
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: binaricat <16399091+binaricat@users.noreply.github.com >
2026-09-30 15:11:23 +08:00
icelee123
e7202f392a
feat(cli): preserve launcher-provided terminal tab names ( #3473 )
...
Carry PuTTY -newtab and SecureCRT /N names through the launch queue so the new terminal tab uses the requested name.
2026-09-29 20:40:37 +08:00
又是一条懒汉
5805d15746
feat(ssh): add single-channel SSH option for bastion hosts ( #3458 )
...
Add a host and group toggle for bastions that allow one session channel per TCP connection. After the handshake, BHostSSH, TERM-SSHD, and CLOUDBILITY take that path automatically. File transfer uses a separate SFTP login, and the interactive terminal is not given another exec, SFTP, copy/split, or port-forward channel.
The manual toggle remains for bastions that still advertise OpenSSH.
2026-09-29 18:01:04 +08:00
cb06857480
feat(terminal): confirm before pasting multiple lines ( #3398 ) ( #3400 )
...
* fix(#3398 ): automated AI fix
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix: address Codex review on PR #3400
* fix(terminal): protect popup and sanitized multiline pastes
* fix(terminal): preserve input state across paste confirmation
* fix(terminal): retain serial character-mode paste echo
* test(terminal): cover paced input write options
* fix(terminal): retain telnet echo for paced pastes
* test(terminal): scope serial buffer assertion to serial sessions
* fix(terminal): align runtime write options with bridge contract
* fix(terminal): preserve bookkeeping for all paced pastes
* fix(terminal): record confirmed paste lines in order
* fix: record paced paste commands after transport writes
* fix: omit paste receipts for filtered input
* fix: cancel superseded paste batches across input paths
* fix: classify each acknowledged paste line before recording
* fix: stop paced paste when editing buffered serial input
* fix: preserve recording pause boundaries and serial edit cancellation
* fix: treat paced terminal pastes as user input
* fix: preserve paste drafts until write and snippet broadcast origin
* fix: retain filtered paste drafts and invalidate urgent input ownership
* fix: broadcast paced user paste only on guarded line receipts
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-18 15:19:34 +08:00
9082aa08a4
fix(serial): auto-login on serial consoles with saved host credentials ( #3418 )
...
* fix(#3417 ): automated AI fix
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: address Codex review on PR #3418
* fix: guard serial quick login and reconnect startup commands
* fix: preserve serial startup while tabs sleep
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-18 14:10:58 +08:00
nervi0s
ec2f0d0bce
fix: support native file dragging from local filesystem panes ( #3377 )
...
* fix: support native file dragging from local filesystem panes
* fix: preserve symlink-aware paths during native file drag
2026-09-18 14:10:26 +08:00
Ryanisgood and bincxz
3738565b1b
feat(mcp): improve external agent discovery and setup ( #3407 )
...
* fix(ai): expose renamed terminal session labels
* feat(mcp): guide agents toward Netcatty tools
* feat(mcp): load Netcatty toolsets on demand
* feat(codex): install Netcatty skill with external MCP
* feat(mcp): install skills for Claude Code and Grok
* feat(mcp): add universal client setup prompt
* fix(mcp): keep Cursor in client setup tabs
* chore(ai): refresh generated tool specs
* fix(mcp): honor Claude skill config root and run MCP tests in CI
---------
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-18 14:10:20 +08:00
08009d4ce0
feat(terminal): show GPU utilization next to CPU in server stats strip ( #3411 )
...
* fix(#3410 ): automated AI fix
* fix(terminal): bound GPU stats queries and complete Chinese labels
* fix(terminal): declare optional GPU fields on stats bridge
* test(terminal): keep GPU fixtures in managed temporary storage
* fix(terminal): preserve unknown GPU memory totals
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-18 14:10:06 +08:00
bincxz
d8761c156e
feat(terminal): save the current rendered screen
2026-09-12 16:55:18 +08:00
86d8c5279d
fix(port-forwarding): add per-rule auto-reconnect on disconnect ( #3328 )
...
* fix(#3326 ): automated AI fix
* fix: address Codex review on PR #3328
* fix: address Codex review on PR #3328
* fix(port-forwarding): honor explicit reconnect preference
* fix(port-forwarding): save auto-start alongside reconnect preference
* fix(port-forwarding): coordinate tray starts in main window
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-12 13:47:34 +08:00
e0cb6034fe
fix(ai): surface Codex config.toml third-party models in chat picker ( #3345 )
...
* fix(#3344 ): automated AI fix
* fix: address Codex review on PR #3345
* fix: address Codex review on PR #3345
* fix(ai): honor Codex config models before sends in both runtimes
* fix(ai): use managed Codex environment for login actions
* fix(ai): reuse Codex auth checks within the effective environment
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-12 13:45:19 +08:00
keroroyuki and bincxz
15b16ab7b2
fix: serial backspace leaves hidden chars for multi-byte CJK input ( #3325 )
...
* fix: serial backspace leaves hidden chars for multi-byte CJK input
Serial terminals process backspace at the byte level: one 0x7F removes
one byte from the device input buffer. For multi-byte CJK characters
(UTF-8: 3 bytes, GB18030: 2 bytes), a single backspace leaves orphan
bytes that render as hidden or garbled characters.
Fixes three layers of the problem:
1. Character mode (createXTermRuntime.ts): when backspace is received
and the command-buffer's last character is wider than one byte,
send as many backspace bytes as the character occupies on the wire
so the device deletes the whole character.
2. Local echo (serialLocalEcho.ts): formatSerialLocalEcho now accepts
a backspaceCells parameter so CJK ideographs (2 terminal cells)
erase both cells instead of just one.
3. Line mode (serialLineInput.ts, Terminal.tsx): backspace local echo
now erases the correct number of cells based on the deleted
character's display width.
Adds serialCharMetrics.ts with getCharDisplayWidth (East Asian Width)
and getCharByteLength (UTF-8 / GB18030) utilities.
39 new and updated tests all pass.
* fix: address codex review — surrogate pairs, effective encoding, cursor guard, broadcast
Address all 5 P2 Codex review comments on PR #3325 :
1. GB18030 4-byte supplementary chars: CJK Extension B+ (cp > 0xFFFF)
now returns 4 bytes instead of 2, matching iconv-lite's GB18030
encoder.
2. Effective session encoding: add currentEncodingRef to runtime
context so toolbar encoding changes propagate to backspace byte
length calculation (not just the saved host.charset).
3. Cursor-movement guard: track lastInputWasPrintable so backspace
byte expansion only fires when the cursor is at the end of the
typed buffer, not after arrow-key escape sequences.
4. Surrogate-pair-safe slicing: getLastChar/removeLastChar helpers
handle UTF-16 surrogate pairs (emoji, CJK Extension B) so slice(0, -1)
never leaves an orphan high surrogate.
5. Broadcast expansion: when backspace is expanded for the source
serial session, the same expanded data is sent to broadcast peers
instead of the original single-byte backspace.
Adds isPrintableInput, getLastChar, removeLastChar helpers.
56 tests pass.
* fix: address codex review — scope, bracketed paste, cursor confidence
Address 3 new Codex review comments on PR #3325 :
1. P1: isExpanded/outData were declared inside the character-mode else
block but referenced after it (ReferenceError in serial line mode).
Moved declarations before the if/else so both branches share scope.
2. P2: Bracketed paste (\x1b[200~...\x1b[201~) starts with ESC so
isPrintableInput returned false, losing tail confidence. Now detected
and lastInputWasPrintable set to true.
3. P2: Printable input after a cursor movement reset lastInputWasPrintable
to true even though the cursor was not at the buffer end. Now the flag
is kept as-is when printable text is typed — only escape sequences
reset it to false.
* fix: establish cursor-tail confidence for initial and post-submission typing
Address Codex review: lastInputWasPrintable started false, so the first
printable input after session start or line submission would keep it
false, defeating the backspace byte expansion guard.
- Initialize to true: cursor is at the end of an empty buffer at
session start and after each line submission.
- Reset to true after Enter (handledSubmittedInput), Ctrl+C, and
Ctrl+U — all three clear the command buffer, placing the cursor
at the beginning of a fresh line.
This restores the original fix for the common case: type 你, press
Backspace, device receives 3 bytes and deletes the whole character.
* fix: address codex review — broadcast safety, paste cursor state, hibernation wake
Address 3 new Codex review comments on PR #3325 :
1. Broadcast safety: stop forwarding expanded backspaces to broadcast
peers. Each peer has its own protocol, encoding, and command buffer,
so the source's repeated DELs can over-delete on non-serial peers
(SSH character-level) or on serial peers with different encodings
(GB18030 needs 2 DELs, not 3). The source session still receives
the expanded data; broadcast peers get the original single DEL.
2. Bracketed paste cursor state: no longer unconditionally set
lastInputWasPrintable=true on paste. After a cursor movement the
paste inserts at the moved cursor, not the buffer tail, so the
flag is now preserved as-is (false stays false).
3. Hibernation wake: initialize lastInputWasPrintable conservatively
when commandBufferRef is nonempty. A hibernated session retains
its buffer but the pre-hibernation cursor may have been moved,
so we start with false instead of true.
* fix: grapheme-safe backspace + gate expansion behind byteOrientedBackspace
Address 2 new Codex review comments on PR #3325 :
1. Remove the whole grapheme on backspace (P2):
getLastChar/removeLastChar only handled UTF-16 surrogate pairs, so a
decomposed grapheme like e + U+0301 returned only the combining mark
and left the base. Rewrite both with Intl.Segmenter (grapheme
granularity) so surrogate pairs, combining marks, variation
selectors, and ZWJ sequences are removed as one unit. getCharByteLength
and getCharDisplayWidth already compose correctly for graphemes.
2. Gate byte expansion on byte-oriented line editing (P2):
Character-aware serial endpoints (e.g. a UTF-8 Linux console with
readline) delete one whole character per DEL, so repeating the
backspace 3x for a 3-byte char over-deletes. Add an explicit
serialConfig.byteOrientedBackspace flag (default true, preserving the
original fix) that users can disable for character-aware editors.
Wired through the serial connect modal and host details panel, with
i18n in en/zh-CN/zh-TW/ru/es, vault host validation, and session
restore/snapshot preservation.
170 tests pass.
* fix: xterm grapheme width for local echo + always compute cell width
Address 2 new Codex review comments on PR #3325 :
1. Use xterm's grapheme width for local-echo erasure (P2):
getCharDisplayWidth returned 1 for emoji-presentation graphemes
(e.g. ❤️ , 1️⃣ , ©️ ) whose base characters fall outside the standard
emoji range. The 15-graphemes Unicode provider active in
createXTermRuntime renders these as 2 cells. Now import
stringCellWidth from terminalStringCellWidth.ts (which uses
_core.unicodeService.getStringCellWidth when available) in both
character mode (createXTermRuntime) and line mode (Terminal.tsx,
serialLineInput). Add VS16 (U+FE0F) detection to both the xterm
fallback and the domain getCharDisplayWidth so emoji-presentation
graphemes are correctly 2 cells even without xterm.
2. Compute local-echo width when byte deletion is disabled (P2):
When byteOrientedBackspace is false, the entire backspace block was
skipped, leaving backspaceCells at 1 and erasing only half of a
2-cell CJK/emoji glyph in local echo. Restructured the condition:
display width is now always computed when backspacing a non-empty
buffer, while wire-byte expansion is independently gated on
byteOrientedBackspace.
182 tests pass.
* fix: read byteOrientedBackspace from session snapshot, not live host
Address Codex review (P2): a restored or hibernated session's
snapshotted serialConfig.byteOrientedBackspace can differ from the
current vault host (e.g. session saved false, host later changed to
true). The runtime read the live host instead of the snapshot, so
after recreation a character-aware session could start expanding DEL
and over-delete again.
Add serialByteOrientedBackspace to the runtime context (mirroring
serialLineMode and serialLocalEcho) and pass it from the session
snapshot in useTerminalEffects. Default true preserves the existing
fix for byte-oriented devices.
182 tests pass.
* fix: carry serialByteOrientedBackspace and currentEncodingRef into hibernation wake context
Address Codex review (P2): xTermRuntimeContextRef.current in Terminal.tsx
omitted serialByteOrientedBackspace and currentEncodingRef, so when
hibernateHiddenTabs woke a serial tab the runtime fell back to default
values (byte-oriented=true, host charset). A session snapshot with
byteOrientedBackspace=false would re-enable byte expansion after waking,
and a toolbar-selected encoding would be lost.
Added both fields to the wake context alongside serialLocalEcho and
serialLineMode, mirroring the useTerminalEffects mount path.
182 tests pass.
* fix: tail confidence after line submission, GB18030 4-byte BMP, free-form encodings
Address 3 Codex review comments (all P2):
1. Preserve tail confidence after line submission:
After Enter submission sets lastInputWasPrintable = true, the same
\r/\n went through the generic control-char branch and immediately
reset it to false. This disabled byte expansion and correct local-echo
width for every subsequent command. Now skip the reset when
handledSubmittedInput is true.
2. Measure GB18030 bytes with the backend encoder:
getCharByteLength assumed every BMP non-ASCII character is 2 bytes.
But BMP characters outside the GBK character set (e.g. U+0100 'Ā')
encode to 4 bytes in GB18030. Added isGbkCharacter() to check the
GBK character set ranges; non-GBK BMP characters now return 4.
3. Use the backend charset for free-form serial encodings:
currentEncodingRef is now always present (hibernation wake fix), so
the ?? fallback to host.charset never triggered. For a Shift_JIS host
with no toolbar override, currentEncodingRef.current is 'utf-8' (the
default), causing UTF-8 byte lengths (3 for あ) instead of Shift_JIS
(2). Now prefer host.charset when it's non-UTF-8 and the toolbar
encoding is the default. Also added Shift_JIS support to
resolveWireEncoding and getCharByteLength (1 byte ASCII, 2 bytes
non-ASCII).
182 tests pass.
* fix: honor remembered UTF-8 when counting serial bytes
Address Codex review (P2): the previous fix treated every
toolbarEnc === 'utf-8' as an unselected default and overrode it with
the host charset. But a GB18030 host with a remembered UTF-8 preference
has its backend session synced to UTF-8 (via shouldSyncTerminalEncodingOnAttach),
so using the host's GB18030 charset for byte counting is wrong.
Now use resolveTerminalEncodingFromCharset to check if the host charset
is recognized by the toolbar system (UTF-8 or GB18030). For recognized
charsets, the toolbar encoding is authoritative (it may reflect a
remembered override). For unrecognized charsets (e.g. Shift_JIS), the
toolbar encoding falls back to the default (utf-8), so the host charset
is the correct wire encoding.
193 tests pass (including terminalEncodingPreference.test.ts).
* fix: honor toolbar changes for free-form charsets + GB18030 4-byte CJK Ext A
Address 2 Codex review comments (both P2):
1. Honor toolbar changes for free-form serial charsets:
When a Shift_JIS session starts and the user later selects UTF-8 in
the toolbar, setSessionEncoding switches the backend to UTF-8, but
the runtime continued using host.charset because it is outside the
two-option resolver. Now pass userPickedEncodingRef to the runtime
context (mirroring existing use in shouldSyncTerminalEncodingOnAttach).
The effective encoding logic:
- Non-utf-8 toolbar → trust toolbar (explicit selection)
- utf-8 toolbar + userPickedEncoding → trust toolbar (explicit utf-8)
- utf-8 toolbar + recognized charset → trust toolbar (remembered override)
- utf-8 toolbar + unrecognized charset → use host.charset (backend default)
2. GB18030 4-byte for CJK Extension A:
isGbkCharacter classified U+3400–U+4DBF (CJK Extension A) as 2-byte
GBK characters, but iconv-lite encodes this block as 4 bytes in
GB18030. Removed the range; these characters now correctly return 4.
193 tests pass.
* fix: simplify effective encoding logic with backendSynced flag
Follow-up to previous fix: the 4-level decision tree had an edge case
where a Shift_JIS host with remembered UTF-8 would use host.charset
instead of the synced toolbar encoding. Simplified to a 3-level logic
using backendSynced = userPicked || hasRemembered:
- backendSynced OR recognized charset → trust toolbar encoding
- NOT synced AND unrecognized charset → use host.charset (backend default)
Added hasRememberedEncodingRef to runtime context (alongside existing
userPickedEncodingRef) so the logic mirrors shouldSyncTerminalEncodingOnAttach.
193 tests pass.
* fix: sum grapheme code points, remove Latin-1 from GBK, generic multi-byte fallback
Address 3 Codex review comments (all P2):
1. Sum every code point in non-UTF-8 graphemes:
GB18030 and Shift_JIS returned after the first non-ASCII code point
instead of counting the complete grapheme that getLastChar returns.
❤️ (U+2764 U+FE0F) is 8 GB18030 bytes, but the old code returned 4.
Now accumulate byte lengths for all code points, like the UTF-8 path.
2. Stop classifying Latin-1 as two-byte GBK:
U+00A1–U+00FE was in isGbkCharacter, but iconv-lite encodes these
as 4 bytes in GB18030. Removed the range; these characters now
correctly return 4 bytes.
3. Count bytes for every backend-supported serial charset:
Unknown encodings fell back to UTF-8 byte length, but the backend
uses iconv-lite for Big5, EUC-JP, Johab, etc. (2 bytes for CJK).
Changed fallback to 1 byte ASCII + 2 bytes non-ASCII, matching
iconv-lite's multi-byte encoding for common serial charsets.
Comment 4 (remembered override for free-form charsets) was already
fixed in commit fca4e7c0 : backendSynced = userPicked || hasRemembered.
193 tests pass.
* fix: Shift_JIS half-width Katakana as 1 byte (iconv-lite 0xA1-0xDF)
Address Codex review (P2): half-width Katakana characters like ア
(U+FF71) are encoded as single bytes (0xB1) in Shift_JIS by iconv-lite,
but the previous code counted every non-ASCII character as 2 bytes.
Backspace sent 2 DELs, deleting the character and one preceding byte.
Now handle the three 1-byte non-ASCII cases in Shift_JIS:
- Half-width Katakana (U+FF61-U+FF9F, mapped to 0xA1-0xDF) → 1 byte
- ¥ (U+00A5, mapped to 0x5C) → 1 byte
- All other non-ASCII → 2 bytes
Self-review: traced all 4 encoding paths (UTF-8, GB18030, Shift_JIS,
unknown fallback) × all edge cases (single/multi-code-point graphemes,
ASCII/BMP/supplementary, GBK/non-GBK ranges). All paths verified correct.
193 tests pass.
* fix: deduplicate terminal width import after main merge
* test: retain input safety checks with serial erase metadata
* fix: restore serial editing after paste and document byte mode
* fix: keep pending serial input on its original encoding
* fix: restore serial backspace after urgent interruption
* fix: retain editable serial snippet input for backspace
* fix(serial): synchronize pending snippet tail state
* fix(serial): unify empty-line input state across text sources
* fix(serial): track editable startup snippets
* fix(serial): share pending-tail tracking for multiline input
---------
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-12 13:10:52 +08:00
f83b5f6693
fix(sftp): allow copy and paste within the same pane ( #3318 )
...
* fix(#3317 ): automated AI fix
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix: address Codex review on PR #3318
* fix(sftp): preserve source links during same-pane replacement
* fix(sftp): leave self-directory merge and replace unchanged
* fix(sftp): scope local traversal limits to same-pane copies
* refactor(sftp): centralize same-pane paste filesystem checks
* fix(sftp): preserve source links through bind-mounted parents
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-09-12 12:25:18 +08:00
陈大猫 and netcatty-bot
1babda6fa9
fix(sync): resume auto-sync after first master-key setup ( #3302 )
...
* fix(sync): retry peer unlock when the shared password becomes available
* fix(sync): retain deliberate locks after availability notifications
* fix(sync): preserve deliberate locks after peer password events
* fix(sync): retain deliberate locks across consumer remounts
* fix: address Codex review on PR #3302
* fix: address Codex review on PR #3302
* fix: address Codex review on PR #3302
* fix: address Codex review on PR #3302
* test(sync): cover pending unlock owner handoff
* fix(sync): distinguish stale unlocks from invalid passwords
* fix(sync): retry completed auto unlock after consumers remount
* fix(sync): share auto unlock retry generation across consumers
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
2026-09-07 10:30:30 +08:00
陈大猫
c9d22b3b4d
fix(sftp): preserve latest pause across delayed transfer controls ( #3284 )
...
* fix(sftp): preserve newer pause decisions across delayed transfer controls
* fix(sftp): stop obsolete recovery after held transfers settle
* fix(sftp): treat superseded cross-window controls as no-ops
* fix(sftp): preserve latest folder control in pause watcher
* fix(sftp): reconcile superseded controls across windows
* test(sftp): expect authoritative action on superseded pause
* fix(sftp): distinguish mixed resume outcomes and IPC failures
* docs(sftp): publish audit findings and validation boundaries
* docs(sftp): record final publication and restart validation
* fix(sftp): reflect partial resumes and reconcile remote watcher controls
* fix(sftp): preserve resolved resume failures in partial folders
2026-09-06 14:13:49 +08:00
axe006 and Claude Sonnet 5
e6df190b98
fix(auto-launch): 隐藏启动的崩溃保护与读取失败状态误覆盖问题
...
针对 PR #3238 的 2 条 Codex review 意见修复:
- electron/main.cjs:隐藏启动成功后不再传 windowShown: !startHidden,
改为固定传 true。processErrorGuards.cjs 的 hasShownMainWindow 是
一次性锁存标志,只要传 false 就会让运行时保护在整个进程生命周期
内永远处于"启动期严格模式"——任何非网络类未捕获异常都会被判定
为致命错误并可能杀掉进程。隐藏启动时 createWindow() 已经成功
创建窗口并加载完页面,是一次完整的启动,不是失败,理应解除
严格模式。新增结构断言测试覆盖成功/失败两条分支。
- electron/autoLaunch.cjs:getAutoLaunchEnabled 读取失败时新增
success: false 字段,区分"确认关闭"与"状态未知"。此前失败时
返回的 { enabled: false, supported: true } 与正常读到关闭状态
完全无法区分,渲染进程挂载时读取一次失败就会把本地缓存的
true 覆盖成 false,并触发相邻的推送 effect 把这个"假关闭"
写回操作系统,可能误删一个原本有效的登录项。
- application/state/systemSettingsEffects.ts:挂载水合与推送两个
effect 都改为通过新导出的纯函数 isAutoLaunchResultTrustworthy
判断,success:false 时保留原状态、不发起写入。该函数已用普通
单测覆盖(react-test-renderer 在当前环境未安装,无法测试完整
hook 生命周期,故将判断逻辑抽成不依赖 React 的纯函数单独验证)。
新增/更新单测覆盖上述场景,177 项相关测试通过。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 19:01:30 +08:00
axe006
0068180204
Merge branch 'main' of https://github.com/binaricat/Netcatty into feat/auto-launch-at-login
2026-09-01 18:24:53 +08:00
axe006 and Claude Sonnet 5
513b2d66af
feat(settings): 支持开机自启动并最小化到系统托盘
...
在「设置 → 系统 → 网络代理」卡片上方新增开机自启动开关,开启后
系统启动时自动运行 Netcatty,并隐藏到系统托盘(不占用任务栏)。
- 新增 electron/autoLaunch.cjs 封装 app.setLoginItemSettings,
通过 --hidden 启动参数标记本次是登录项冷启动;开发环境
(process.defaultApp)下判定为不支持,避免误操作系统登录项。
- 主窗口首次冷启动读取该标志后跳过 win.show(),并在托管桥注册
完成后强制创建托盘图标(不依赖用户是否开启「关闭时最小化到
托盘」),确保隐藏窗口始终可被找到;后续任何窗口复用/深链接/
托盘点击路径不受影响。
- 开关真实状态以主进程 app.getLoginItemSettings() 为准,设置页
挂载时向主进程查询校准,而非只信任本地缓存。
- 新增单测覆盖 autoLaunch 纯逻辑及 startHidden 透传/托盘保底
行为,过程中发现并修复一处因未走依赖注入直接 require 模块
导致的隐患。
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com >
2026-09-01 18:16:42 +08:00
netcatty-bot
53e46323ed
fix( #3188 ): automated AI fix
2026-08-28 10:04:46 +00:00
bincxz
1d633431c1
fix(terminal): distinguish interactive Mosh prompts
2026-08-24 10:56:24 +08:00
bincxz
79aafcdb1a
feat(ai): make response wait configurable
2026-08-21 15:39:01 +08:00
bincxz
e6c46f8198
fix(app-lock): defer protected actions until unlock
2026-08-18 20:45:29 +08:00
bincxz and Cursor
d422a27715
Merge origin/main into feature/app-lock-screen
...
Reconcile the app-lock feature with main's refactored renderer
architecture (publishers/hosts/AppShell) and main-process changes:
- index.tsx/App.tsx: AppLockGate keeps ownership of useSettingsState and
useAppLockState; new AppLockRuntimePublisher publishes the runtime via
appRuntimeBridge; SettingsPublisher now binds the gate-owned settings.
- AppSideEffects: defer deep links, tray port-forward toggles, global
hotkeys and window close commands while locked; flush on unlock.
- main.cjs: keep fresh-session re-lock before main's reusable-window
fast path; before-quit guard delegates to handleBeforeQuit with main's
async plugin-shutdown commitQuit and pending-update cancellation.
- globalShortcutBridge: keep locked-state tray redaction on top of
main's deferred tray panel show logic.
- preload: adopt main's lastPayload replay for terminal popup config
(superset of the gate-delay replay fix).
- vite config: keep dev CSP plugin, adopt main's warn-only stale
optimize-dep handling; electron-builder: keep Windows Hello helper
extraResource with main's CLI-controlled arch targets.
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-18 16:30:30 +08:00
陈大猫 and Cursor
074acc3bed
feat(sftp): add right-click extract for archives ( #3042 )
...
* feat(sftp): add right-click extract for archives
Let SFTP list and tree views unpack zip/tar/gz archives in place via remote SSH exec (or local tar/unzip), so users do not need to switch to another file manager.
Co-authored-by: Cursor <cursoragent@cursor.com >
* fix(sftp): keep extract from clobbering files or dying on unzip output
Write gzip/bzip2/xz results to a staging path and replace the destination only after a zero exit. Drain unzip progress instead of treating routine stdout as a hard failure.
Co-authored-by: Cursor <cursoragent@cursor.com >
* fix(sftp): quote extract cleanup trap and use unique staging files
Remote gzip/bzip2/xz nested a quoted path inside trap, so names with spaces failed before decode. Staging now exclusively creates a unique sibling, and local .gz uses Node zlib.
Co-authored-by: Cursor <cursoragent@cursor.com >
* fix(sftp): refuse single-file extract onto an existing directory
Remote mv would otherwise drop the staging file inside that directory and still report success.
Co-authored-by: Cursor <cursoragent@cursor.com >
* fix(sftp): restore the previous file if Windows extract replace fails
Rename the destination aside before publishing the staging file, instead of deleting it first.
Co-authored-by: Cursor <cursoragent@cursor.com >
---------
Co-authored-by: Cursor <cursoragent@cursor.com >
2026-08-18 12:00:16 +08:00
bincxz
2a52837657
feat(terminal): show desktop notifications for OSC 9/777/99
...
Closes #3019
Codex and other agents emit OSC 9 when a turn completes or approval
is needed, but Netcatty ignored those sequences. Register OSC 9, 777
notify, and kitty OSC 99 handlers, map them to Electron notifications,
and reuse tray focus so a click jumps back to the emitting session.
Ignore ConEmu OSC 9;n progress sequences so they do not become toasts.
2026-08-18 09:28:11 +08:00
bincxz
8fe69f6101
fix(sftp): return null from lstat when the remote path is absent
...
ipcRenderer.invoke strips ssh2's status code. A server that says
"File not found" instead of "No such file" still uses code 2, so
classify absence in the main-process handler and return null.
2026-08-14 20:29:48 +08:00
陈大猫
40f4e29833
Merge pull request #2965 from binaricat/cursor/issue-2963-31683461693
...
feat(settings): add startup landing preference for local terminal
2026-08-14 16:57:54 +08:00
bincxz
54e3601426
fix(sftp): complete safe permission-preserving replace
2026-08-14 10:46:11 +08:00
netcatty-bot
bbc1a08848
fix: address Codex review on PR #2965
2026-08-13 09:40:27 +00:00
netcatty-bot
3064a9d39c
fix: address Codex review on PR #2955
2026-08-13 06:07:13 +00:00
netcatty-bot
dbfd5b5758
fix: address Codex review on PR #2955
2026-08-13 05:29:48 +00:00
ydm
01102e2d66
merge: 同步 main 并解决 SFTP 复用冲突
2026-08-12 18:19:45 +08:00
ydm
dfc9ed7f61
fix(sftp): 复用 SSH 会话打开 sudo SFTP
2026-08-12 17:58:45 +08:00
netcatty-bot
f2b3facd9f
fix: address Codex review on PR #2925
2026-08-12 09:32:41 +00:00
bincxz
7f08bec0b9
Merge remote-tracking branch 'origin/main' into codex/pr-2925-review
...
# Conflicts:
# electron/bridges/terminalBridge.sessionActivity.test.cjs
2026-08-12 16:50:25 +08:00
bincxz
bbd4c698a5
fix(ai): harden host_open session lifecycle
2026-08-12 16:42:43 +08:00
bincxz
e65af2fd7b
fix(terminal): safely rerun connect scripts on manual reconnect
2026-08-12 16:14:43 +08:00
bincxz
df045bf144
Revert "fix: address Codex review on PR #2906 "
...
This reverts commit a1b7f3708a .
2026-08-11 23:57:57 +08:00
bincxz
32447885d9
Revert "fix: complete terminal shortcut routing"
...
This reverts commit c921e7d9a4 .
2026-08-11 23:57:57 +08:00
bincxz
25224cef7b
Revert "fix: match physical shortcut keys"
...
This reverts commit e3b9e71d8f .
2026-08-11 23:57:57 +08:00
bincxz
e3b9e71d8f
fix: match physical shortcut keys
2026-08-11 23:44:04 +08:00
bincxz
c921e7d9a4
fix: complete terminal shortcut routing
2026-08-11 23:01:32 +08:00
netcatty-bot
a1b7f3708a
fix: address Codex review on PR #2906
2026-08-11 14:47:01 +00:00
bincxz
105107755b
fix: route terminal font shortcuts by focus
2026-08-11 22:14:06 +08:00
bincxz
87b4089812
fix(system): detect FUSE filesystem types in disk stats
2026-08-11 16:58:22 +08:00
netcatty-bot
b9702b043a
fix( #2886 ): automated Cursor CLI fix
2026-08-11 06:27:49 +00:00
a965a94f0d
fix(session-logs): omit alternate-screen TUI paint from logs ( #2875 )
...
* fix(#2872 ): automated Cursor CLI fix
* fix: address Codex review on PR #2875
* fix: address Codex review on PR #2875
* fix(session-logs): sample alternate-screen state after save dialog
Manual session log start previously snapshotted alternate-screen mode
and the initial line before showSaveDialog resolved. Split path selection
from stream start so the renderer re-samples buffer state at activation,
avoiding stale omission/leak if the user enters or leaves a TUI while the
dialog is open.
* fix(session-logs): honor C1 CSI alternate-screen modes in text renderer
8-bit CSI (U+009B) is a valid alternate form of ESC[. Recognize it in
TerminalTextRenderer so DECSET 47/1047/1049 enter/leave still omits TUI
paint from txt/HTML session logs when remotes use the C1 encoding.
* fix(session-logs): apply log-safe RIS reset in text renderer
RIS now leaves alternate-screen mode, resets SGR to defaults, and starts
post-reset shell text on a new log line when needed so mid-line TUI
exits do not glue onto prior output or keep pre-entry colors. History is
preserved because session logs are not live screen wipes.
* fix(session-logs): token-bind dialog path and rebase after RIS
- chooseManualSessionLogPath stores the selected path in main and returns
an opaque selectionToken; startManualSessionLog redeems that token and
rejects renderer-supplied filePath so the save dialog cannot be bypassed.
- RIS rebases screenBaseRow onto a fresh log screen (history preserved)
so post-reset CSI H cannot overwrite pre-RIS text.
* fix(session-logs): seed replay sanitizer on observe attach mid-TUI
When an observe popup restores a snapshot while vim/less is already on
the alternate buffer, re-seed the connection-log sanitizer from the
restored xterm active-buffer type so subsequent TUI redraws are omitted
until leave.
---------
Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com >
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com >
2026-08-10 23:35:56 +08:00