Commit Graph
1910 Commits
Author SHA1 Message Date
陈大猫 87dc2c2f8c Merge pull request #2200 from binaricat/fix/sudo-assist-paste-dismiss-2198
fix(terminal): dismiss sudo password assist on clipboard paste
2026-07-14 23:46:22 +08:00
bincxz 0a073d10f2 fix(terminal): dismiss sudo password assist on clipboard paste
When password-prompt assist is open, Enter is hijacked to paste the
session host password. Clipboard paste did not clear that pending state,
so after pasting a different password (e.g. nested SSH via jump host)
Enter could append the wrong secret and fail sudo (#2198).

Dismiss the assist on paste/typed content input so Enter submits what
the user actually provided.
2026-07-14 23:28:31 +08:00
bincxz d8a0463e94 fix(ai): harden desktop CLI discovery and copyable commands
Skip non-executable desktop CLI candidates, keep Claude on the macOS
app-bundle path, and surface desktop-resolved absolute paths in the
External MCP copyable setup command without breaking PATH installs.
2026-07-14 22:27:30 +08:00
陈大猫 2280664ac9 fix(ai): stop OpenCode process spawn storms when unused (#2184) (#2185)
* fix(ai): stop OpenCode process spawn storms when unused (#2184)

OpenCode model catalog loads were spawning full servers for discovered
agents, skipping main-process cache, and not aborting on timeout—so
idle Netcatty could accumulate many opencode processes.

Only load catalogs for the selected agent, cache/coalesce list-models,
abort and tear down on timeout, and share a short-lived list-models
server pool per binary.

* fix(ai): address OpenCode list-models review findings

Restore the main-process env immediately after spawning OpenCode so an
idle list-models server cannot leave PATH/OPENCODE_BIN on a temp shim.
Key model caches and the list-models pool by catalog-affecting env so
profiles that share a binary do not receive each other's catalogs.

* fix(ai): tighten OpenCode model-cache invalidation

Include profile-affecting env in the renderer runtime model cache key so
OpenCode config switches do not reuse a stale catalog. Skip caching empty
list-models results in the main process so transient OpenCode failures can
recover before TTL expiry.
2026-07-14 18:06:29 +08:00
陈大猫 69ccedb62d fix(terminal): prevent osc7_cwd errors after su (#2181)
* fix(terminal): prevent osc7_cwd errors after su

OSC 7 setup installed a bare osc7_cwd PROMPT_COMMAND entry. After
non-login su, that string could be inherited without the function
definition, printing "osc7_cwd: command not found".

Use a guarded prompt hook, unexport PROMPT_COMMAND, and upgrade
existing v1 rc snippets in place when setup is re-run.

* fix(terminal): safe OSC7 rc upgrade when markers are incomplete

Do not rewrite/truncate shell rc files when the Netcatty OSC 7 block is
missing an end marker or markers are unbalanced. Append a complete v2
snippet instead so setup still installs tracking without dropping user
config after an open start marker.

* fix(terminal): harden OSC7 rc upgrade safety

Address Codex review findings for OSC 7 setup upgrades:

- Never truncate incomplete/unbalanced marker regions; append v2 only
- Detect a complete v2 block for idempotent recovery
- Resolve full symlink chains; atomic same-dir replace with mode preserve
- Build stripped+v2 content in one temp write so read-only configs cannot
  lose the legacy block without receiving the replacement

* fix(terminal): replace OSC7 v1 blocks in place

Upgrade complete legacy OSC 7 blocks by substituting the marked region
at its original location instead of stripping and appending at EOF. This
keeps surrounding control flow (if/fi wrappers) valid and still writes
the full result atomically with mode preservation.

* fix(terminal): match OSC7 markers as whole lines only

Use trimmed whole-line equality for start/end markers so echo statements
that embed the marker text are not treated as block boundaries during
legacy upgrades.

* fix(terminal): preserve ownership on OSC7 rc atomic replace

When upgrading a legacy block via temp+mv, restore the original
uid:gid on the temp file before replacing so a root-run setup against
another user's HOME cannot leave a root-owned bashrc.

* fix(terminal): harden OSC7 PROMPT_COMMAND array and chown

Process every PROMPT_COMMAND array element when installing the guarded
hook so leftover osc7_cwd entries cannot duplicate OSC 7. Abort the
atomic rc replace when ownership cannot be restored, leaving the
original file untouched.

* fix(terminal): fix exported array PROMPT_COMMAND handling

Detect array PROMPT_COMMAND via the -a attribute even when combined with
-x, and stop force-unexporting PROMPT_COMMAND now that the guarded hook
is safe to inherit across su.

* test(terminal): update OSC7 assertions for export-preserving hook

* fix(terminal): fall back when OSC7 upgrade temp dir is not writable

If same-directory mktemp fails (writable file in a non-writable managed
home directory), leave the original config intact and fall back to the
append path instead of aborting setup with set -e.
2026-07-14 17:18:11 +08:00
陈大猫 fa4d0d5348 feat(ui): customizable dense toolbars (show / collapse / hide) (#2183)
* feat(ui): customizable dense toolbars with show/collapse/hide

Add a shared toolbar layout model so terminal, SFTP, and side-panel
action strips can right-click customize placement, overflow collapsed
items into the more menu, and persist order plus placement.

* fix(ui): harden toolbar layout placement after review

Address review findings: availability-aware reachability, skip
unavailable reorder neighbors, Popover overflow for nested SFTP menus,
path chrome outside customize context menu, and side-panel hide close.

* fix(ui): only close side panel when hide placement sticks

Return the next layout from setPlacement so hide-of-last-reachable
does not tear down the panel, keep an active hidden tab chip visible,
and rebuild terminal shown order with highlight collapse coercion.

* fix(ui): narrow SFTP overflow spill and close ⋮ after leaf actions

Respect user show/collapse/hide, then temporarily move non-pinned shown
actions into ⋮ when the SFTP toolbar is narrow. Close overflow after
leaf clicks while keeping nested bookmark/encoding panels usable.
2026-07-14 17:11:03 +08:00
陈大猫 18b2f435bc feat(terminal): configurable su/sudo password prompt assist (#2156) (#2176)
* feat(terminal): configurable su/sudo password prompt assist (#2156)

Extend the existing confirm-to-fill sudo assist to arm on su as well, and
add a Terminal setting for off / quick Enter fill / WindTerm-like credential
picker. Picker candidates come from the host password plus keychain password
identities; secrets are never shown in the list or sent without confirmation.

* fix(terminal): tighten password prompt assist after codex review

- Hint mode only uses the session host password, never an arbitrary
  keychain identity as a silent Enter target.
- Build autofill candidates from the effective session host so group-
  inherited passwords participate.
- Clear a stale credential picker when the session disconnects.

* fix(terminal): more password-assist polish from codex review

- Do not swallow arrow keys while the quick-fill hint is pending; only the
  multi-credential picker consumes them.
- Clear the picker overlay on hibernate and wake so it cannot outlive the
  autofill controller.
- Show the resolved auth username on the host candidate row (identityId /
  group identity), not a stale host.username after password dedupe.

* fix(terminal): keep password picker select callback stable

Avoid forcing TerminalView memo invalidation on every Terminal render by
using a stable useCallback for credential selection.

* fix(terminal): do not offer full keychain on unarmed sudo prompts

Picker mode only lists all password identities after a real su/sudo
command was armed. Unarmed explicit [sudo] lines still get host-password
quick-fill only, blocking remote prompt phishing of other credentials.

* fix(terminal): fix picker mode switch and armed picker test

Arm before inspecting the picker payload, and when switching settings
mid-prompt recompute whether the command arm is still valid so picker
mode can open the full list.

* fix(terminal): reopen password picker after a wrong credential

Keep the su/sudo arm active after confirm-to-fill so a rejected password
re-prompt can offer the full credential list again instead of falling
back to host-only unarmed assist.

* fix(terminal): only re-assist real auth retries after fill

Keep a short post-fill arm for wrong-password re-prompts, but require an
explicit [sudo] line or authentication-failure text before reopening
assist. Prevents sending the host password into child prompts after a
successful sudo (e.g. sudo mysql -p).

* fix(terminal): scope sudo assist away from child password prompts

Track whether the armed command was sudo or su. su still accepts bare
Password: lines; sudo only assists on [sudo] tags or user-scoped prompts
(password for … / 输入密码), not generic Enter password when sudo is cached.

* fix(terminal): tighten when the full credential picker may open

Exclude child-program prompts (Enter password, Password for user …).
Full keychain picker only for explicit [sudo] lines or armed su Password:
prompts; Kylin-style sudo bare prompts still get host-password hint only.

* fix(terminal): limit full credential picker to armed su only

Multi-identity picker is the WindTerm-style su workflow (#2156). Sudo
keeps host-password quick-fill only, so a cached sudo child cannot open
the full keychain list via a forged or nested password prompt.

* fix(terminal): derive password assist candidates in Terminal + mode gate

- Standalone Terminal popups without TerminalLayer now resolve candidates
  from host/keys/identities so su picker mode still works.
- When switching to picker mid-prompt, keep the su-only full-list gate
  (do not open multi-identity list for an armed sudo prompt).

* fix(terminal): reject SSH-style prompts for su assist and drop dupe keys

- su bare matching only accepts short Password:/密码 lines, not user@host
  SSH password prompts after passwordless su -c.
- Remove duplicate sudoAutofillCandidates keys that failed eslint.

* fix(terminal): cursor-anchor password picker and soft-dismiss Esc

Position the su credential picker with the same cursor-relative layout
helpers as autocomplete instead of fixed bottom-center. Esc only closes
the UI while keeping the arm so Esc/arrows can reopen the list on the
same Password: prompt.
2026-07-14 15:19:16 +08:00
陈大猫 67b40cd89e Merge pull request #2175 from binaricat/feat/2116-select-before-connect
feat(vault): optional select-before-connect host click (#2116)
2026-07-14 13:58:01 +08:00
bincxz 39ee27d181 fix(settings): move Custom CSS docs into a help modal
Replace the long inline data-section description with a short blurb and a
scrollable Markdown help dialog so Appearance settings stay readable.
2026-07-14 13:56:33 +08:00
bincxz 2a58bb8def fix(vault): restore list/tree select as background fill
List mode border/ring looked wrong; use hover-like bg-secondary fill
again. Grid still recolors the soft-card border to the accent color.
2026-07-14 13:44:08 +08:00
bincxz a80b1bfbaa fix(vault): tighten list padding and use inset ring for focus
Selected list borders were eating into content and looking like extra
left padding. Use inset primary ring (no layout shift) and reduce list
row horizontal padding from px-3 to px-2.
2026-07-14 13:43:16 +08:00
bincxz f578b1dbe3 fix(vault): selected focus is accent border only, no fill
Unselected rows keep hover-only chrome with no extra border/bg.
Selected list/tree add a primary border; grid only recolors the
existing soft-card border to the accent color.
2026-07-14 13:41:29 +08:00
bincxz 9b5fe7af86 fix(vault): make select-before-connect focus use solid accent border
Selection was easy to miss because list mode reused hover glass fill.
Use full primary border, light primary wash, and ring so focus reads
clearly in grid, list, and tree.
2026-07-14 13:39:18 +08:00
bincxz 326c30e4a6 fix(vault): address select-before-connect review findings
Include hostClickBehavior in VaultView memo equality so the settings
toggle applies immediately, clear focus when the mode changes, and
apply select-then-expand to tree group rows with focus highlighting.
2026-07-14 13:29:56 +08:00
bincxz dd135ff568 feat(vault): optional select-before-connect host click behavior (#2116)
Add a Settings > Appearance vault option that defaults to single-click
connect, but can switch to select-then-click-again to connect. Grid mode
shows an accent ring on focus; list/tree reuse the hover fill. Groups
follow the same pattern when the option is enabled.
2026-07-14 13:24:15 +08:00
陈大猫 94f9a5f37c Merge pull request #2170 from binaricat/fix/2169-codex-gpt-5.6-models
fix(ai): add Codex GPT-5.6 models and upgrade codex-sdk
2026-07-14 12:19:42 +08:00
bincxz c1d88b2c8b fix(ai): persist Codex CLI version for custom-path installs
Store probed --version on ExternalAgentConfig from settings resolve-cli
and discovery enable, and prefer that when gating GPT-5.6 so custom
paths not on PATH still unlock Sol/Terra/Luna when compatible.
2026-07-14 12:06:41 +08:00
bincxz ae2a7803fb fix(ai): gate GPT-5.6 Codex presets on installed CLI version
Netcatty is BYO-CLI: upgrading codex-sdk does not replace the user's
binary. Hide Sol/Terra/Luna when discovery reports Codex CLI < 0.144.0
so old installs do not auto-default to an unsupported model.
2026-07-14 11:57:12 +08:00
bincxz d64adce10a fix(ai): use Codex catalog default efforts and keep gpt-5.2
Address PR #2170 Codex review: stop auto-selecting the last thinking
level (which defaulted Sol to ultra), add defaultThinkingLevel from the
official catalog, and keep gpt-5.2 selectable so stored model IDs do not
silently fall back to Sol.
2026-07-14 11:51:03 +08:00
bincxz 982a252edf fix(terminal): keep paste bookkeeping on bulk-plain write path
Always run filter, erase-scrollback, and paste prepare/cleanup so long
multi-line pastes still clear residual cells under large-output pressure.
Bulk-plain only skips prompt cosmetics when the post-paste stream is plain.
2026-07-14 10:58:37 +08:00
bincxz 88032e57fb fix(terminal): bulk path uses filtered data; time-budget merged drains
Decide bulk-plain shortcut after the stateful filter so retained CSI
prefixes still get erase/prompt transforms. Yield inside flood-merged
steps on hop count or WRITE_QUEUE_TURN_BUDGET_MS wall time.
2026-07-14 10:53:46 +08:00
bincxz 5edd683351 fix(terminal): keep sync filter on bulk path; bound merged queue stack
Always run stateful filterTerminalSessionData before bulk-plain shortcuts so
split CSI continuations are not emitted as text. Cap synchronous recursion
inside flood-merged write steps to avoid Maximum call stack size exceeded.
2026-07-14 10:45:06 +08:00
bincxz 46422b574d fix(terminal): keep prompt path under bulk; end long-line highlight catch-up
Do not skip forcePromptNewLine preparation when bulk-plain degrade is active.
Bulk highlight catch-up only waits on time-bounded largeOutput, not sticky
longLine, so a single long line cannot leave a permanent 50ms poll.
2026-07-14 10:35:53 +08:00
bincxz 77352bbb69 fix(terminal): restore per-line timestamps outside true floods
Split timestamp skip from general bulk degrade. Full-scrollback multi-line
output (docker ps) no longer drops gutter markers; only high-rate floods
(>=64KB/100ms) or long lines suppress registerMarker storms.
2026-07-14 10:24:54 +08:00
bincxz d19aa89caa perf(terminal): Tabby-like bulk write path and highlight quiet
Under large-output pressure, plain batches skip paste/prompt/filter prep and
go straight to xterm (bytes unchanged). Keyword highlighting no longer
schedules per-write scans during bulk — one quiet catch-up after pressure
drops. Sizable bulk queue items also yield after the write callback so paint
and input can interleave, matching Tabby FlowControl intent.
2026-07-14 10:18:32 +08:00
bincxz c991f16079 perf(terminal): arm bulk pressure earlier on full scrollback
Lower the high-rate threshold to 16KB/100ms and treat multi-line writes on
a near-full scrollback as large-output immediately so second dumps skip
timestamp/highlight work. Extend the quiet window while saturated so
prompt gaps do not reopen the expensive path between seq runs.
2026-07-14 10:13:35 +08:00
bincxz e3956d6692 perf(terminal): Tabby-sized plain write shards for multi-line floods
Cap plain xterm writes (including short-line dumps like seq) to ~128KB and
yield after each intermediate slice so the UI can paint and accept input.
Under large-output pressure use the flood coalesce cap and rAF scheduling
instead of microtask packing. Leave SSH flow high-water at 1MB for #1961.
2026-07-14 10:04:43 +08:00
bincxz d4eb971d11 fix(terminal): clear alt latch without coalescer; preserve step yields on merge
- abortTerminalWriteCoalescer always clears alt-screen schedule state so a
  direct oversized enter-alt probe cannot stick after Ctrl-C drops the batch
- flood merge no longer forces a timer after every shard; inter-step yields
  honor per-step yieldAfter (drain-budget pacing from writeLargeTerminalBatch)
2026-07-14 02:53:10 +08:00
bincxz f2b189c2ed fix(terminal): probe alt-screen schedule on gated oversize push
Call resolveScheduleMode before early-returning when pending exceeds the
byte cap while auto-flush is gated (hidden pane). Without this, enter-alt
CSI in oversized hidden batches never latched rAF for follow-up repaints
after reveal.
2026-07-14 02:44:25 +08:00
bincxz 7df9ca6f43 fix(terminal): clear alt schedule state on abort and RIS
Abort drops enter-alt CSI that never reaches xterm, so reset schedule
latches; treat ESC c (RIS) as leaving alternate so normal output returns
to the microtask path.
2026-07-14 02:38:37 +08:00
bincxz 77c34c60f8 fix(terminal): clear alt latch after observe/RIS and reparse CSI aborts
Drop enter-pending once the alternate buffer is seen or after an unobserved
exit (RIS), and reprocess ESC/C1 bytes that abort an incomplete private CSI.
2026-07-14 02:31:37 +08:00
bincxz c95d86b470 fix(terminal): process leave-alt CSI while buffer still alternate
Always run the alt-screen probe before consulting buffer.active so exit
sequences clear the rAF latch even when xterm has not yet flipped back.
2026-07-14 02:24:30 +08:00
bincxz 034fa64451 fix(terminal): robust alt-screen CSI state machine for schedule latch
Replace raw 16-char tail retention with a phase/params parser that handles
7-bit and 8-bit CSI in encounter order, long split sequences, and oversized
batches that bypass the coalescer frame arm.
2026-07-14 02:20:29 +08:00
bincxz 6794d192a0 test(terminal): fix enter-leave latch expectation 2026-07-14 02:11:41 +08:00
bincxz ee05670ad7 fix(terminal): honor last enter/leave alt-screen transition in a chunk
When one PTY batch contains enter-alt then leave-alt, clear the rAF latch
so ordinary shell output returns to the low-latency microtask path.
2026-07-14 02:11:29 +08:00
bincxz ddf770be48 chore(terminal): drop unused alt-screen helper 2026-07-14 02:07:17 +08:00
bincxz b565f6dbb6 fix(terminal): latch rAF after enter-alt CSI until buffer flips
xterm parses enter-alt-screen asynchronously, so buffer.active can stay
normal after ESC[?1049h is written. Keep frame scheduling until the
alternate buffer is observed (or leave-alt is seen).
2026-07-14 02:07:08 +08:00
bincxz 90b3238837 fix(terminal): detect 8-bit C1 CSI for alternate-screen scheduling
xterm accepts \x9b?1049h as well as ESC[?1049h; force rAF for both forms
so the first TUI repaint is not microtask-scheduled while still on the
normal buffer.
2026-07-14 02:00:06 +08:00
bincxz 07d74e0d1b fix(terminal): harden rate window and alt-screen CSI state
Keep incomplete private CSI tails across coalescer flushes without
quadratic pending joins, and measure bulk-output rate with a true rolling
sample window so high-rate bursts are not missed at window boundaries.
2026-07-14 01:50:22 +08:00
bincxz a76e4c7961 fix(terminal): resolve Codex CLI review on lint, CSI split, timestamps
Avoid control-character regex for alt-screen detection, join pending PTY
chunks so split CSI still upgrades to rAF, and reset timestamp segmenter
state when marker work is skipped under output pressure.
2026-07-14 01:38:13 +08:00
bincxz f3b899bbcb fix(terminal): address Codex review on highlight and TUI coalescing
Restore debounced keyword refresh while panes are hidden so decorations
still apply after reveal, and force rAF scheduling when output enters the
alternate screen (including the first burst before buffer.active flips).
2026-07-14 01:31:03 +08:00
bincxz 6573afc3f0 perf(terminal): smooth output pipeline closer to Tabby-style drain
Reduce stutter from tiny write shards and vsync batching while keeping flow
control, TUI rAF coalescing, and interrupt safety intact. Bulk dumps use larger
shards, fewer yields, microtask scheduling on the normal screen, and degraded
timestamp/highlight side work under output pressure.
2026-07-14 01:24:19 +08:00
陈大猫 28d91a1717 Merge pull request #2166 from binaricat/fix/workspace-pane-x-close-session
fix(terminal): restore workspace pane X to close session
2026-07-14 00:21:17 +08:00
bincxz 0a71ccfc93 fix(terminal): restore workspace pane X to close session
#2106 rewired the workspace toolbar X to detach the pane into a
standalone tab, duplicating the existing detach control. Restore X to
closeSession so it closes the pane again; detach stays on the arrow
button.
2026-07-14 00:18:10 +08:00
陈大猫 d3e77bd20f Merge pull request #2163 from binaricat/fix/2162-normalize-terminal-copy
fix(terminal): normalize soft wraps and padding when copying selection
2026-07-14 00:15:14 +08:00
陈大猫 2c0d5209b1 Merge pull request #2164 from binaricat/fix/terminal-line-timestamp-flood-prune
fix(terminal): prune line timestamps in bulk under flood output
2026-07-14 00:11:04 +08:00
bincxz 42f2905063 feat(terminal): add normalizeTextOnCopy setting for selection cleanup
Expose Settings > Terminal > Normalize terminal text on copy (default on).
When off, all copy paths use raw xterm getSelection(); when on, strip
display padding and join soft wraps as before.
2026-07-14 00:08:42 +08:00
bincxz fe494cfde2 fix(terminal): compact disposed timestamps only when dispose signals fire
Track disposedPendingCompact via lightweight marker onDispose and skip the
full-history compact scan on writes that did not dispose anything.
2026-07-13 23:57:08 +08:00
bincxz 9992575a79 fix(terminal): compact on write and retain bulk markers by visual rows
- Compact disposed timestamp entries on every write so clears cannot leave
  a huge dead store while the gutter is off.
- Select bulk markers by measured visual rowOffset window rather than
  timestamp count, so soft-wrapped floods do not pin out-of-buffer markers.
2026-07-13 23:47:42 +08:00
bincxz f0a282a7a2 fix(terminal): defer bulk timestamp prune and lighten gutter paint
- Suppress intermediate prune during bulk marker registration; prune once.
- Gutter paints only compact disposed holes (dedupe/capacity stay on write).
- Raise capacity ceiling so tall viewports still cover max settings scrollback.
2026-07-13 23:39:36 +08:00