Commit Graph
229 Commits
Author SHA1 Message Date
bincxz 4c00ec42f9 fix terminal input echo desync 2026-06-29 11:30:43 +08:00
bincxzandClaude fc30fd4b3c fix(terminal): make search hotkey robust to stale ctx capture
Codex review of the first pass found a stale-closure bug: createXTermRuntime
captures its ctx once (the effect only re-runs on host.id/sessionId change),
so the original requestSearchFocus — which branched on a captured isSearchOpen
— locked in the initial state and never bumped the focus token on later
Cmd/Ctrl+F presses.

Make requestSearchFocus state-independent: always setIsSearchOpen(true) and
bump the focus token. When closed, opening mounts the SearchBar (isOpen effect
focuses); when open, the token bump refocuses. The callback now has a stable
identity and behaves correctly regardless of when it was captured.

Also drop the now-unused setIsSearchOpen from the runtime ctx type and its
ref/construction sites.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-29 10:45:34 +08:00
bincxzandClaude 377cd2ae6f fix(terminal): refocus search box when Cmd/Ctrl+F re-fires while open
The searchTerminal hotkey called setIsSearchOpen(true), which is a no-op
when the bar is already open — React bails on the unchanged boolean, the
SearchBar's focus effect (dep [isOpen]) never re-runs, and focus stays
wherever the user moved it. Route the hotkey through a new
requestSearchFocus that bumps a focusToken when already open; the
SearchBar watches that token and refocuses its input.

Closes #1789

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-29 10:36:17 +08:00
陈大猫andCursor 6b9b71ac8a feat(scripts): terminal script automation, recording, and side panel (#1763)
* feat(scripts): add terminal script automation, recording, and side panel

Introduce nct script runtime in the main process with terminal-side recording,
execution overlay, Monaco editor, connect-script queues, and scripts side panel
integration. Fix recording to wire scriptRecorderRef into xterm, use waitForPrompt
for root/user shells, and save recorded scripts through the global editor dialog.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): address Bugbot review findings for recording and side panel

Refresh script run state in side panel memo, guard toolbar recording against
multi-session conflicts, reset connect scripts on reconnect, resolve focused
session via getActiveTerminalSessionId, and avoid wiping host edit form when
snippets list updates.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): prevent pending script re-run and improve workspace run feedback

Track one-shot pendingScript execution separately from onConnect queue so
reconnects do not replay Run-now scripts. Fall back to focused session when
running on all tabs outside a workspace, and toast when every tab is still
connecting.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): consume connect-script window once and filter serial hosts

Mark the onConnect script evaluation as consumed even when the queue is
empty so later snippet/host edits do not rerun automation mid-session.
Restore serial-host filtering in SelectHostPanel confirm handler.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): grace period before giving up on connect-script queue

Only mark onConnect automation as consumed after scripts run or a short
post-connect grace window expires, so late-loading snippets still trigger
while mid-session Vault edits do not.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): gate connect-script consumption on vault hydration

Replace the grace timer with vault-init and unresolved host script binding
checks so late-loading snippets still run onConnect automation while
mid-session edits stay suppressed. Clear pending script run state on
disconnect so reconnect retries workspace pending scripts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): honor run targets and retry failed connect automation

Route QuickScriptEditorDialog Run through onRunSnippet for multi-host
workspaces. Defer connect/pending script completion markers until each
script succeeds and retry the queue after failures.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): stabilize pending runs and global connect queue sync

Keep pending script run state across reconnects, run onConnect scripts
before one-shot workspace pending scripts, and strip per-host queue entries
when an onConnect script targets all hosts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): defer host queue snippet sync and guard connect runs

Persist snippet target links only when the host panel is saved, block
duplicate connect-script scheduling while a batch is running, and require
runnable hosts before showing Run in the snippets editor footer.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): retry connect failures and surface output-trigger errors

Use a retry tick in connect-script effect deps, toast automation failures
from output triggers, and require runnable hosts before QuickScript Run.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): track id-less pending runs and re-arm output triggers

Remember anonymous pendingScript objects after first run and allow
onOutput triggers to fire again when new terminal output arrives.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): unblock paused connect runs and pass session meta

Resolve waitForScriptRun on pause, run workspace scripts per session
with hostname context, defer output-trigger arming until runs start, and
add noRunnableHosts i18n for QuickScript Run.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): serialize output triggers and defer empty connect finalize

Fire at most one onOutput trigger per scan while a run is active, and
only finalize an empty connect queue after vault snippets are loaded.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): guard output launch race and script run waits

Block overlapping onOutput launches, timeout stuck waitForScriptRun
promises, and disable vault Run when no connectable targets exist.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): match output triggers on new chunks only

Scan onOutput patterns against recent terminal output instead of buffer
length dedupe, and restore overflow-visible on SelectHostPanel new-host flow.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): await sequential workspace runs and output launch

Wait for each tab script to finish in sequential workspace mode, and hold
output-trigger launch guard until the session run becomes active.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): wait through pause and hold output trigger until done

Keep connect and sequential workspace queues blocked until scripts
complete or fail, and retain output-trigger guard until the launched run
finishes.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): harden output trigger wait helpers

Add explicit timeouts to output-trigger wait helpers and stop rescanning
the buffer after script completion to avoid sticky-match rerun loops.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): allow empty connect queue and match output in new chunks

Treat an empty connectScriptIds array as an explicit cleared queue instead
of re-migrating from snippet targets, and only fire onOutput triggers when
the latest terminal output contains the pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): require fresh output overlap for onOutput triggers

Only fire output-matched scripts when the regex match extends into the
latest terminal chunk, preventing reruns from stale buffer text.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): promote manual scripts added to host connect queue

Diff connect queue changes from raw connectScriptIds so saving a host
updates manual scripts to onConnect when they are newly queued.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): dedupe output triggers by match position

Track the buffer end offset of each output trigger match and ignore
stale re-scans, with a longer wait for run registration before retry.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): record output trigger matches only after run starts

Propagate automation launch failures to output triggers and commit match
dedupe only once the session run is registered as active.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): address Codex review on wait cursor and sensitive codegen

Track scan offset so waitFor/waitForAny only match output after the previous wait, and emit sendLine after sensitive prompt in recorded scripts.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(scripts): harden onOutput triggers against PTY echo and local input

Filter server output before pattern matching so onOutput fires only after
Enter on real stdout, not on keystroke/paste echo, OSC/SGR sequences, or
alternate-screen apps. Add dev diagnostics and scope triggers to the active
session when no explicit host targets are configured.

Co-authored-by: Cursor <cursoragent@cursor.com>

* chore(scripts): remove onOutput trigger debug logging

Drop temporary diagnostics module and console traces now that PTY echo
filtering is verified; keep the production trigger pipeline unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 23:48:12 +08:00
bincxzandCursor 7f90896dbc fix(terminal): flush write coalescer when window loses focus
Bypass the RAF-bound output coalescer for visible unfocused panes so flow control does not pause the PTY before unfocused repaints can run.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 13:06:40 +08:00
bincxzandCursor 8c4575c0d1 fix(terminal): skip unfocused repaint for hidden panes
Only run the synchronous unfocused repaint path when the pane is visible, avoiding wasted row rendering for background tabs while the window is unfocused.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 13:02:21 +08:00
bincxzandCursor 232cbb9b67 fix(terminal): keep tmux output flowing when the window loses focus
Force synchronous xterm repaints while the app stays visible but unfocused so Windows Chromium does not stall write callbacks, output flow control, and tmux redraws until refocus.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 12:57:31 +08:00
bincxzandCursor ff298476f1 Fix interrupt priority regressions found in Bugbot review.
Keep write-queue and flow ack flushing when stale display drain is disabled for non-SSH protocols, and preserve terminal restore controls on split ^C caret echoes.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 06:30:14 +08:00
bincxz 59ea442f5c Fix Ctrl+C full-screen terminal cleanup 2026-06-28 06:10:57 +08:00
bincxzandCursor fa72bb28ff Fix close capture races found in Bugbot review.
Persist connection-log and fallback serialize payloads before teardown, defer only xterm disposal via microtask, and ignore stale async close work when the boot effect restarts.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 00:20:22 +08:00
bincxzandCursor cc511a6b43 Speed up terminal tab close by deferring close capture work.
Prefer the incremental connection log buffer on unmount, fall back to capped hibernate serialize, tear down xterm before async capture, and avoid blocking the UI on full SerializeAddon output.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-28 00:05:28 +08:00
bincxzandCursor 1263eaa31f Fix interrupt output gate edge cases found in Bugbot review.
Align main-process caret splitting and renderer prompt-candidate filtering with the display gate, and route broadcast Ctrl+C through interruptSession.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-27 23:33:52 +08:00
bincxz cb2189a2e3 Improve SSH Ctrl-C responsiveness 2026-06-27 22:36:51 +08:00
bincxz 0f85eaba8e Fix urgent interrupt input cleanup 2026-06-27 17:46:24 +08:00
bincxz 3b774ca9a1 Improve terminal interrupt responsiveness 2026-06-27 12:46:38 +08:00
bincxz 579daf8852 fix(terminal): load flow constants via JSON in renderer
createRequire() in terminalFlowConstants.ts breaks Vite/browser bundling
and caused "Terminal could not load". Share thresholds through
terminalFlowConstants.json consumed by both renderer and main process.
2026-06-27 02:45:18 +08:00
bincxz a3eae4d2ca fix(terminal): defer only IPC acks, not renderer flow.written
Deferred batching must not inflate renderer pendingBytes after xterm
has already parsed output; only main-process IPC ACKs are batched.
Flush/teardown/prioritize paths now emit deferred IPC without double
counting flow.written.
2026-06-27 02:41:46 +08:00
bincxz 7163e0e144 perf(terminal): high-ROI flood optimizations for flow control (#1711)
- Share flow thresholds via infrastructure/config/terminalFlowConstants.cjs
- Drop main-process ptyOutputBuffer data when session flow is paused
- Tighten rAF coalescer cap to 128KB during renderer flood mode
- Batch deferred flow ACKs (~100KB) for small writes; flush on input/teardown
2026-06-27 02:39:32 +08:00
bincxz a759e11066 fix(terminal): flush IPC ack remainders after drop-based recovery
Dropped coalescer/queue bytes can sit below the 5KB batch threshold;
flush immediately so main-process unackedBytes drains and the stream resumes.
2026-06-27 02:26:36 +08:00
bincxz 52b5cbc300 fix(terminal): tear down flow pipeline before hibernate and cleanup
- Release coalescer/queue backlog and clear rendererPaused before hibernate
- Flush ACK buffers and resume flow on hibernate listener setup and force-close
- Reuse releaseTerminalFlowBeforeHibernate in cleanupSession when xterm is alive
2026-06-27 02:19:24 +08:00
bincxz 490f033cfd fix(terminal): align ingress byte accounting and queue drop handlers
- Track IPC ingress bytes separately from display expansion (serial LF→CRLF)
- Bind write-queue drop handlers before the queue is first created
- Flush/clear session ACK buffers on cleanup; reset flow on input prioritize
- Add tests for ingress accounting, drop-handler binding, and constant parity
2026-06-27 02:16:12 +08:00
bincxz 1cd4f1827f fix(terminal): align flow control with VS Code and batch IPC acks
- Match VS Code watermarks (100K/5K) and CharCountAckSize (5K)
- ACK ingress bytes (not filtered length) to stay in sync with trackEmitted
- Add AckDataBufferer-style batching via terminalFlowAckBuffer
- Hibernate listeners ack buffered output so main-process backpressure works
2026-06-27 02:10:19 +08:00
bincxz b3bf566db4 fix(terminal): keep input responsive during high-output floods (#1711)
Tighten renderer output back-pressure (128KB/32KB watermarks), account
coalescer and write-queue backlog, drain output on user keystrokes, and
add main-process IPC ACK flow control so SSH floods cannot starve Ctrl+C
and other keyboard input.

Closes #1711
2026-06-27 01:53:41 +08:00
陈大猫 4e2a9ef4d1 Merge pull request #1706 from Ryanisgood/restore-terminal-cwd-debug
Fix restored terminal cwd tracking
2026-06-26 23:49:30 +08:00
shixu cff6aa2906 Fix remote macOS stats detection 2026-06-26 22:26:50 +08:00
bincxz 33dec754d5 Fix terminal startup output race 2026-06-26 15:22:52 +08:00
Zheng Liu f4ca635c1a Fix restored terminal cwd tracking 2026-06-26 10:51:59 +08:00
陈大猫 a0f7be4f2f [codex] Respect scrollback clear setting for terminal clears (#1684)
* Respect scrollback clear setting for terminal clears

* Fix scrollback clear ordering
2026-06-25 19:13:17 +08:00
bincxz 766dd36d76 Merge remote-tracking branch 'origin/main' into codex/issue-1653-port-forward-known-hosts
# Conflicts:
#	components/terminal/runtime/createTerminalSessionStarters.ts
2026-06-25 16:52:03 +08:00
bincxz 7a62acb828 Add tray host key trust prompt 2026-06-25 15:44:59 +08:00
陈大猫 0d8d68d954 fix(telnet): handle NVT newlines and echo mode (#1649)
* fix(telnet): normalize NVT newlines

* fix(telnet): handle echo negotiation

* fix(telnet): align echo negotiation
2026-06-25 14:47:17 +08:00
陈大猫 033b904982 fix(terminal): platform-aware default font + remeasure on webfont load (#1647)
Fix #1647: on Windows/Linux the macOS-only `menlo` default left terminal ASCII garbled on cold start until a manual resize, because the primary glyphs fell through to a bundled `font-display: swap` webfont (JetBrains Mono) that swapped in after xterm measured the cell grid.

- Store the terminal font default as a platform-neutral `auto` sentinel, resolved to a locally-installed font per OS at render (win32→consolas, linux→dejavu-sans-mono, darwin→menlo). Safe to persist/sync; never leaks one OS's font to another.
- Explicitly preload the bundled webfonts the terminal actually renders with and remeasure on every `document.fonts` `loadingdone`, so any late webfont swap (incl. user-chosen) recovers without a manual resize.

Reviewed by local Codex (3 adversarial passes); findings on default persistence/sync and side-panel no-op writes addressed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-06-25 13:32:12 +08:00
bincxz 3943b4869f fix: guard terminal write coalescing without raf 2026-06-25 09:52:22 +08:00
bincxzandCursor 53328ca50d feat(terminal): optimize hibernate wake for large buffers
Add chunked replay, deferred WebGL during restore, alt-screen hibernate
policies, soft-hide LRU, two-phase viewport/scrollback snapshots, and a
main-process headless xterm mirror for faster wake serialization.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 23:52:03 +08:00
陈大猫 6893b986ca Merge pull request #1633 from binaricat/fix/issue-1632-telnet-no-auth-input
fix(telnet): allow input on silent no-auth sessions (#1632)
2026-06-24 23:29:15 +08:00
bincxzandCursor 599c8ff200 fix(telnet): dismiss connection overlay for silent no-auth sessions
Mark Telnet as connected once the socket session attaches so devices
that send no banner until client input no longer leave the connecting
overlay blocking keyboard input (fixes #1632).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 23:25:45 +08:00
bincxzandCursor 12835ab0e5 fix(terminal): coalesce agent TUI writes and refine DEC 2026 redraw handling
Batch PTY output per animation frame (superset write-coalescer) so Codex
and Claude Code frames render atomically. Distinguish full H+2J redraws
from incremental sync blocks, skip preserve-before-clear inside DEC 2026,
and preserve viewport position across terminal resize.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 23:07:16 +08:00
bincxzandCursor 0913c6188f fix(terminal): harden split CSI detection for sync-block filter
Hold long incomplete private-mode sequences across chunks, terminate CSI
parsing at the real final byte, and avoid treating complete `\x1b[2J`
output as an unfinished escape prefix.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:51:15 +08:00
bincxzandCursor 9ef868f7ed fix(terminal): parse combined alternate-screen private-mode CSIs
Recognize `\x1b[?1049;1000h`-style sequences when deciding whether sync-block
clears must be preserved, without swallowing DEC 2026 markers.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:46:18 +08:00
bincxzandCursor 20b613d1bb fix(terminal): track alternate-screen transitions in sync-block filter
Parse alternate-screen enter/leave sequences in-band so bundled PTY
chunks preserve `\x1b[2J` redraws before xterm applies buffer switches.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:39:30 +08:00
bincxzandCursor 12d7d6c730 fix(terminal): guard sync-block scroll detection when buffer is missing
Minimal terminal stubs used in session-starter tests do not expose
xterm buffer state; treat that as "not scrolled up" instead of throwing.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:35:17 +08:00
bincxzandCursor 07e837b21c fix(terminal): detect scrollback via viewportY and restart block timers
Use xterm viewportY/baseY to decide when sync-block clears may be stripped,
and re-arm the abandonment timeout whenever a new DEC 2026 block starts.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:31:46 +08:00
bincxzandCursor 825bd722d1 fix(terminal): only strip sync-block clears while viewport is scrolled up
Preserve `\x1b[2J` inside DEC 2026 blocks for alternate-screen TUIs and
for normal-buffer redraws at the bottom, while still preventing xterm.js
viewport jumps when the user is reading scrollback history.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:27:54 +08:00
bincxzandCursor 51f5fd9088 fix(terminal): arm sync-block timeout once and keep pending bytes
Only start the DEC 2026 abandonment timer when entering a block, and
preserve trailing partial marker bytes when the timeout fires.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:20:39 +08:00
bincxzandCursor d9ed716b01 fix(terminal): expire abandoned DEC 2026 sync blocks after 1s
Mirror xterm.js synchronized-output safety timeout so an unclosed sync
block cannot keep stripping later clear-screen sequences in the session.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:17:23 +08:00
bincxzandCursor c1ebedcc1f test(terminal): cover split sync-end and trailing ESC chunk edges
Add regression tests for SYNC_END marker splits and for releasing a
held trailing ESC when the following chunk is ordinary terminal text.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 21:12:01 +08:00
bincxzandCursor 7c707bf3b0 fix(terminal): hold partial sync markers across PTY chunks
Address Codex review: DEC 2026 start/end and clear-screen sequences can
be split across arbitrary PTY/IPC chunk boundaries. Keep a pending suffix
between calls so the sync-block filter still strips in-block clears.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 20:45:56 +08:00
bincxzandCursor 59f70af0c3 fix(terminal): strip sync-block clear-screen for Codex/Claude Code scrollback
Filter `\x1b[2J` inside DEC 2026 synchronized-output blocks before PTY
data reaches xterm.js so full-screen coding CLI redraws no longer reset
viewportY and make earlier output appear eaten.

Fixes #1612

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 20:15:36 +08:00
mam15monandmam15mon b709417e23 Improve network device vendor detection (#1624)
* restore h3c network device detection

* ignore release build artifacts in lint

* restore h3c mpssh banner detection

* detect network device vendor banners

* Map mpSSH banners to HPE iLO

---------

Co-authored-by: mam15mon <mam15mon@gmail.com>
2026-06-24 19:37:55 +08:00
bincxzandCursor 12a513606b feat(terminal): hibernate hidden tabs to reduce renderer memory
Dispose xterm for off-screen tabs while keeping SSH connected, with configurable delay, file-transfer exemptions, and wake replay for alternate-screen apps.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-24 00:40:16 +08:00