mirror of
https://github.com/binaricat/Netcatty.git
synced 2026-11-20 15:19:16 +00:00
2b4f8d33c9dcdbbd5d6e87fc8eb296ea4fc46138
302
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
2b4f8d33c9 |
fix: address codex review — re-throw unhandled rejections, early crash capture
- P1: Re-throw in unhandledRejection handler to preserve default fatal
semantics instead of silently swallowing rejections.
- P2: Fall back to require('electron').app.getPath('userData') in
ensureLogDir() so crash logs work even before init() is called,
catching early startup failures.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|
|
bc6c0a2ef6 |
feat: add crash log capture and viewer in Settings > System
Capture main-process errors (uncaughtException, unhandledRejection, render-process-gone) to JSONL log files in userData/crash-logs/ with 30-day auto-rotation. Users can view, expand, and clear crash logs from Settings > System to help diagnose issues like #452. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
f5b745ec63 |
fix: resolve SFTP tab connection key race in workspace mode (#443)
* fix: resolve SFTP tab connection key race condition in workspace mode When rapidly switching focus between workspace panes, the single pendingConnectionKeyRef could be overwritten before the tracking effect mapped it to the created tab. This left tabs unmapped in tabConnectionKeyMapRef, causing duplicate tabs on subsequent switches. Replace the two-step async mechanism (pendingConnectionKeyRef + deferred tracking effect) with a synchronous onTabCreated callback on connect(). The callback fires immediately after the tab ID is determined, before any async SSH work begins, eliminating the race window entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: scope SFTP transfers to active connection and prevent stale session lookups Two fixes for workspace focus-switching issues: 1. Transfer queue now filters by the active connection's host, so switching focus between workspace panes only shows transfers relevant to the currently displayed SFTP tab. 2. Move sftpSessionsRef.delete() before the async closeSftp() call to close the race window where concurrent code could look up a stale sftpId that the backend has already removed, causing "SFTP session not found" errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: allow SFTP focus switching during file transfers Active transfers should not block workspace focus-following. Transfers run on their own sftpId independent of the active tab, and forceNewTab preserves old connections, so switching focus is safe. Only interactive operations (text editor, permissions dialog, file opener, file watches) still block host switching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: refresh correct SFTP tab after transfer completes during focus switch When a transfer completes while focus has switched to a different host, refresh was targeting the currently active pane instead of the pane that initiated the transfer. Add optional tabId parameter to navigateTo() and refresh() so callers can target a specific tab. Capture the tab ID at transfer start and use it for the post-transfer refresh, ensuring the correct tab's file list is updated regardless of which tab is currently focused. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: auto-reconnect SFTP when session is lost during navigation When navigateTo() detected a missing or expired SFTP session, it cleared the connection to null, showing the empty "Select a host" state. Now it delegates to handleSessionError(), which triggers the existing reconnection mechanism — keeping files visible while reconnecting in the background. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * perf: eliminate redundant stat calls before file transfers Before this change, each file transfer performed 3-4 stat calls over the network before the progress bar started moving: 1. startTransfer: stat to get file size (~100ms) 2. processTransfer: stat again if size was 0 (~100ms) 3. Conflict check: stat source file for mtime (~100ms) 4. Backend: stat again if totalBytes missing (~100ms) Now: - Use the source pane's cached file list for size and mtime (zero network cost) instead of stat calls in startTransfer - Store sourceLastModified on TransferTask so the conflict check can use it directly instead of a redundant source stat - Backend already skips stat when totalBytes is provided This saves ~200-300ms of network round-trips per file before the progress bar starts moving. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * perf: show immediate progress feedback during transfer setup The progress bar previously stayed at 0% for ~500ms-1s while the backend acquired an isolated SFTP channel and waited for the first data chunk. Users perceived this as the transfer being "sluggish". Now start simulated progress immediately for all single-file transfers (not just non-streaming ones). When the first real progress update arrives from the backend, the simulation is stopped and real progress takes over seamlessly. This gives instant visual feedback that the transfer is in progress. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: show accurate transfer progress instead of simulated values The progress system had fundamental issues: 1. Simulated progress ran for ALL transfers including streaming ones, creating fake progress that could reach 95% while real progress was at 60%. The Math.max ratchet prevented regression, so users saw inflated numbers. 2. Speed and remaining time were based on simulated data during the setup phase, giving misleading estimates. Changes: - Only use simulated progress for non-streaming transfers (no real progress callback available). Streaming transfers get real data. - Remove the double ratchet (Math.max) from onProgress — the backend already enforces monotonic progress, so the frontend should trust the reported values directly. - Show an indeterminate "preparing..." state during the setup phase (channel acquisition, conflict check) instead of fake progress. This honestly communicates that the transfer is starting. - Hide speed and remaining time during the indeterminate phase since no real data is available yet. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove dead progress simulation and non-streaming transfer code startStreamTransfer is always available in Electron, so: - Remove the non-streaming fallback path in transferFile() that read entire files into memory with no progress reporting - Remove startProgressSimulation / stopProgressSimulation and all related refs (progressIntervalsRef, useSimulatedProgress, hasStreamingTransfer) - Remove the cleanup effect for progress intervals All transfers now use the streaming path with real backend-reported progress. The indeterminate "preparing..." state covers the setup phase until the first real progress arrives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * perf: reduce SFTP transfer concurrency from 64 to 4 64 parallel SFTP read/write requests overwhelmed servers, causing the first chunk response to be delayed by 46+ seconds. Reducing to 4 concurrent requests provides a responsive first progress update (~1-2s) while still offering significant speedup over sequential streaming. Also adds timing logs to the transfer pipeline (processTransfer, transferFile, downloadFile, uploadFile) to aid future diagnostics. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address review findings from PR #443 Critical fixes: - Fix refresh/navigateTo type signatures to include the tabId option parameter — previously it was silently ignored, making tab-targeted refresh non-functional - Fix handleSessionError/reconnection in navigateTo for background tabs: when called with explicit tabId, update that specific tab instead of the active tab (which could be a different host) - Fix uploadExternalFiles to capture and pass tabId for post-upload refresh (was missing, only uploadExternalEntries was fixed) Medium fixes: - Restore Math.max monotonic ratchet on single-file onProgress to guard against any non-monotonic backend values - Add stat fallback in processTransfer to populate sourceLastModified when file is not in the pane's visible file list (filtered/search) - Adjust TRANSFER_CONCURRENCY from 4 to 8 as a better throughput/ responsiveness balance Cleanup: - Remove all debug timing logs (console.log with Transfer/downloadFile/ uploadFile prefixes) from both frontend and backend Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: prevent background tab navigation from rolling back active tab Two P1 fixes from automated review: 1. navSeqRef race: navigateTo uses a per-side sequence counter, so a background tab refresh would bump it and cause the active tab's concurrent navigation to think it was superseded, restoring previousPath instead of applying the fetched files. Now when navSeqRef is superseded but tabNavSeqRef still matches, the fetched result is applied (it's valid for this tab — only a different tab bumped the counter). 2. Auto-follow tear down: needsNewTab only checked hostId, so same host with different session-time overrides (port/protocol) would reuse the tab and close the old SFTP session, aborting any in-flight transfer. Now needsNewTab is true whenever the current connection is alive, always preserving it with forceNewTab. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
66b4908686 |
fix: PowerShell AI exec markers visible and results not captured (#432)
* Add dismiss option for disconnected terminal dialog * Refine terminal connection dialog visuals * Polish terminal connection dialog layout * fix: PowerShell AI exec markers visible and results not captured PowerShell wrapped command was sent as 8 separate lines, causing: 1. Markers visible — PS echoes each line with prompt prefix, ^-anchored filter regexes couldn't match 2. Line-by-line input — 8 \r\n = 8 Enter keypresses displayed sequentially 3. AI couldn't get results — end marker Write-Output format mismatch between generation (format string) and filter (single-quote regex) Combine into 2 lines (like posix) and use inline regex matching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use whole-line deletion to strip PowerShell __NCMCP_ marker echoes PowerShell echoes each input line with the PS prompt prefix (e.g. `PS C:\...> Write-Output '__NCMCP_..._S'; $env:PAGER=...`), so the previous per-fragment substitutions left residual content visible in the terminal after partial replacement. Replace all PowerShell-specific fragment regexes with a single whole-line regex that deletes any line containing __NCMCP_, regardless of leading PS prompt or shell variant. * fix: apply whole-line deletion to stripMarkers in ptyExec for Catty Agent Same root cause as preload.cjs: PowerShell echoes the entire wrapper line with PS prompt prefix (e.g. `PS C:\...> $__NCMCP_rc = if ...`). The previous regex only stripped from __NCMCP_ onwards, leaving the PS prompt and partial variable name visible in the AI's stdout capture. Use the same ^[^\r\n]*__NCMCP_[^\r\n]* whole-line pattern so Catty Agent also receives clean output without PS wrapper residue. * fix: use compact if/elseif/else syntax in PowerShell wrapper to prevent >> continuation prompt PowerShell interactive PTY parses `if (cond) { } elseif ...` with spaces around braces as a multi-line block, causing >> continuation prompt after line 2 is submitted. Switch to compact no-space form `if(cond){...}elseif(...){...}else{...}` which PowerShell evaluates as a complete expression on a single line. Also remove the $global:LASTEXITCODE=0 reset on line 1 since it clobbers $? before line 2 runs, making the -not $? fallback unreliable. * fix: proper line-level buffering for PowerShell marker filter + remove >> trigger preload.cjs: - Replace chunk-based filterMcpMarkers with per-session filterMcpChunk that buffers trailing fragments across PTY data events. Previously, if __NCMCP_ was split across two IPC chunks (e.g. chunk1 ends with '__N', chunk2 starts with 'CMCP_...'), neither chunk matched the guard and both leaked to xterm.js. Now the tail of each chunk is held and prepended to the next chunk before line-level filtering. - Clean up per-session buffers on netcatty:exit to prevent memory leaks. ptyExec.cjs: - Replace if($LASTEXITCODE){...}elseif...else{...} with a brace-free arithmetic expression: [int](-not $?) -bor [Math]::Abs([int]$LASTEXITCODE) This eliminates the >> PowerShell continuation prompt that was triggered by the interactive parser treating the if-block as an incomplete statement. * fix: simplify PowerShell Line 2 to bare Write-Output to eliminate >> prompt Any expression with operators, method calls, or variable assignment can trigger PowerShell interactive continuation mode (>> prompt). Use the absolute minimum: just Write-Output with $LASTEXITCODE interpolated directly. This cannot trigger >>. Null $LASTEXITCODE is handled gracefully by the execViaPty receiver (defaults to exit code 0). --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
9e6e9eab87 |
fix: log file name and use local time (#416)
* fix: log file name and use local time * fix: improve SSH txt log sanitization with ANSI/OSC * fix: log file name and use local time(update) --------- Co-authored-by: yuzifu <yuzifu@TB16PGen5.Info> |
||
|
|
a0dce5d4a6 |
feat: support downloading SFTP folders from the new view (#427)
* feat: support SFTP folder downloads in the new view * refactor: remove unused legacy SFTP modal * fix: use directory picker for SFTP folder downloads * fix: wire folder downloads through SFTP side panel * fix: pre-scan SFTP folders for stable download progress * feat: show hybrid progress for SFTP folder downloads * feat: parallelize SFTP folder downloads * feat: adapt SFTP folder download concurrency by file size * feat: pool isolated channels for fast SFTP downloads * fix: address SFTP download review findings * fix: wait for in-flight fast download channels * fix: unblock fast channel waiters on cancel |
||
|
|
dcaf25ae57 |
feat: inline approval gate for tool execution (#423)
* feat: inline approval gate for tool execution
Replace SDK-level needsApproval with Promise-based approval gate inside
tool execute functions. The SDK stream stays alive while the UI shows
inline approve/reject buttons on ToolCall blocks.
Changes:
- Add approvalGate.ts: Promise-based approval system with event listeners
- tools.ts: requestApproval() inside execute for confirm mode
- tool-call.tsx: inline approval buttons and keyboard shortcuts
- ChatMessageList.tsx: subscribe to approval events, render approval UI
- useAIChatStreaming.ts: remove old useToolApproval hook integration
- AIChatSidePanel.tsx: remove old approval hook, clean up unused destructuring
- systemPrompt.ts: update confirm mode to not ask for text confirmation
- preload.cjs: filter pager env var prefixes from terminal display
- mcpServerBridge.cjs: add approval gate for ACP/MCP write operations
- aiBridge.cjs: wire IPC for MCP approval response and main window getter
- preload.cjs: add onMcpApprovalRequest/respondMcpApproval APIs
* fix: scope approval gate by chatSessionId and replay for late subscribers
Address Codex PR review comments:
- Add chatSessionId to ApprovalRequest for session isolation
- Scope clearAllPendingApprovals(chatSessionId?) to only clear
approvals belonging to the target session
- Add replayPendingApprovals() so late-mounting ChatMessageList
picks up approvals that fired while unmounted
- Scope MCP clearPendingApprovals in aiBridge cancel handler to
effectiveChatSessionId instead of clearing all
- Pass chatSessionId through MCP approval IPC flow
* chore: remove old approval flow code
- Delete useToolApproval.ts (unused hook)
- Delete InlineApprovalCard.tsx (replaced by ToolCall inline buttons)
- Remove stale comments referencing old hook in AIChatSidePanel
- Remove unused ai.chat.toolApprovalTitle i18n key from en/zh-CN
* fix: session-scoped approval gate and MCP replay survival
- handleStop passes activeSessionId to clearAllPendingApprovals
- setupMcpApprovalBridge stores MCP approvals in pendingApprovals map
so they survive ChatMessageList unmount/remount cycles
- ChatMessageList accepts activeSessionId prop and filters standalone
MCP approval blocks to the current session only
- AIChatSidePanel passes activeSessionId to ChatMessageList
* fix: filter PTY exec marker echoes and exit code lines from terminal
Extend filterMcpMarkers in preload.cjs to strip all shell-visible
artifacts from AI command execution:
- Echoed printf start marker: printf '%s\n' '__NCMCP_..._S'
- Echoed exit code restoration: (exit $__nc)
- PowerShell: Write-Output, $global:LASTEXITCODE, $__nc assignment
- Fish: set __nc $status
- Cmd: echo __NCMCP_...
- Widen guard to also trigger on __nc and PAGER=cat strings
* fix: scope SDK approvals, deny MCP on no renderer, fix memo comparator
- createCattyTools accepts chatSessionId and passes it to
requestApproval so SDK approvals can be matched by
clearAllPendingApprovals(activeSessionId) on stop
- useAIChatStreaming passes sessionId to createCattyTools
- mcpServerBridge: deny (resolve false) when no renderer window is
available instead of auto-approving, preserving confirm mode safety
- ChatMessageList: add activeSessionId to React.memo comparator so
switching sessions triggers re-render for correct MCP approval filter
* fix: MCP listener lifecycle, approval timeout, and UI sync on stop
- Move setupMcpApprovalBridge from ChatMessageList to AIChatSidePanel
so the IPC listener survives tab/panel switches
- Add 5-minute auto-deny timeout to requestApproval to prevent
indefinite isStreaming hangs when user walks away
- Add onApprovalCleared listener system: clearAllPendingApprovals now
notifies UI subscribers so ChatMessageList removes stale cards
- ChatMessageList subscribes to onApprovalCleared to sync local state
* fix: main-process approval timeout and full tool args in payload
- Add 5-minute auto-deny timeout to requestApprovalFromRenderer
matching the renderer-side requestApproval behavior
- Forward all tool params (excluding chatSessionId) to approval UI
instead of cherry-picking command/input/path, so sftpRename
oldPath/newPath and other tool-specific args are visible
* fix: move MCP bridge to TerminalLayer, narrow terminal filter guard
- Move setupMcpApprovalBridge from AIChatSidePanel to TerminalLayer
so the IPC listener stays alive regardless of side panel tab.
AIChatSidePanel only mounts when activeSidePanelTab==='ai'.
- Narrow preload.cjs filter guard back to __NCMCP_ only, preventing
false-positive stripping of user scripts containing __nc or PAGER=cat
* fix: eliminate PTY wrapper echo leakage and duplicate prompts
- Posix wrapper now emits 2 lines instead of 4: start marker + command
on line 1 (joined with ;), end marker + exit on line 2. This
eliminates the duplicate prompt echo from the separate start marker.
- Rename __nc to __NCMCP_rc in all shell variants (posix/fish/powershell)
so every wrapper variable contains the __NCMCP_ prefix. The preload
guard `data.includes("__NCMCP_")` now reliably catches ALL wrapper
artifacts regardless of chunk boundaries.
- Update all filterMcpMarkers regex patterns to match the restructured
wrapper format and renamed variable.
* fix: sync main-process approval timeout with renderer UI cleanup
- When requestApprovalFromRenderer times out, send IPC event
netcatty:ai:mcp:approval-cleared to renderer so stale approval
cards are removed
- Add onMcpApprovalCleared preload bridge for the new IPC channel
- setupMcpApprovalBridge now subscribes to cleared events, removes
timed-out entries from pendingApprovals and notifies clearedListeners
so ChatMessageList drops the stale card
* fix: surface denied inline approvals as errors in UI
- Detect error or denial payloads ("error" string or "ok: false")
returned by tools when the user denies an execution
- Set isError: true on the tool-result message so the ToolCall UI
renders it as a failure (red/rejected) instead of a success (green)
|
||
|
|
3fd5e1128b |
Merge pull request #422 from binaricat/codex/fix-windows-codex-cli-login
Fix Windows Codex CLI resolution and login startup |
||
|
|
cb8c06e152 | Avoid shell expansion in agent spawn | ||
|
|
cabc82e1df | Fix Windows Codex CLI resolution | ||
|
|
17e98090ad |
Add AI support for local terminal sessions (#419)
* Add AI support for local terminal sessions * Fix local AI session metadata and shell safety * Fix local session cloning and multi-exec errors * Refactor local shell detection helpers * Fix local shell helper import path * Fix CJS imports in renderer * Use ESM local shell helpers in renderer * Normalize local shell paths and platform metadata |
||
|
|
56a4fe905d |
fix: handle Windows spawn for Claude ACP bundled JS binary (#405)
* fix: handle Windows spawn for Claude ACP bundled JS binary
On Windows, child_process.spawn does not interpret shebangs, so spawning
a .js file directly (like claude-agent-acp's dist/index.js) fails with
ENOENT. The @mcpc-tech/acp-ai-provider uses raw spawn() internally.
Change resolveClaudeAcpBinaryPath to return { command, prependArgs } so
that on Windows the resolved .js script is invoked via process.execPath
(Node) with the script path prepended to args. On macOS/Linux the
shebang works natively so the script is spawned directly as before.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: use system Node instead of process.execPath on Windows
In packaged Electron builds, process.execPath points to the app binary
(e.g. Netcatty.exe), not a Node runtime. Additionally, main.cjs deletes
ELECTRON_RUN_AS_NODE at startup and the agent spawn handler blocks it
in DANGEROUS_ENV_KEYS.
Resolve the real `node` from PATH instead. If Node is not installed,
fall back to the bare `claude-agent-acp` command name so the system
can find the npm-generated .cmd wrapper.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: use script path for display and probe version correctly on Windows
In discovery, when resolveClaudeAcpBinaryPath returns { command: node,
prependArgs: [scriptPath] }, use the script path for UI display and
dedup, and probe version with the full command (node script --version)
instead of running node --version.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|
|
b17775307f |
fix: bundle claude-code-acp to prevent crash when binary is missing (#404)
* fix: bundle claude-code-acp to prevent crash when binary is missing (#400) When users select Claude Code in the AI module, the app spawns `claude-code-acp` via ACP. Previously only the `claude` CLI was checked during agent discovery, so if `claude-code-acp` was not on PATH the spawn would fail with ENOENT and crash the Electron main process. - Add `@zed-industries/claude-code-acp` as a bundled dependency - Add `resolveClaudeAcpBinaryPath()` that checks PATH first, then falls back to the npm-bundled binary (mirrors Codex pattern) - Use the resolver in both the primary and fallback ACP provider paths - Update agent discovery to detect agents via bundled ACP binary when the standalone CLI is not installed Closes #400 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add claude-code-acp and its deps to asarUnpack In packaged Electron builds, files inside app.asar cannot be executed by child_process.spawn. Add claude-code-acp and its runtime dependencies to asarUnpack so the binary is accessible in production. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: migrate from deprecated claude-code-acp to claude-agent-acp The @zed-industries/claude-code-acp package has been renamed to @zed-industries/claude-agent-acp (bin: claude-agent-acp). Update all references across the codebase: - package.json: replace dep with @zed-industries/claude-agent-acp@0.22.2 - electron-builder.config.cjs: update asarUnpack entries, remove stale deps (diff, minimatch) no longer needed by the new package - shellUtils.cjs: update binary name and require.resolve path - aiBridge.cjs: update acpCommand, ALLOWED_AGENT_COMMANDS, isClaudeAgent - settings types, i18n locales: update command references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
f4872099bd |
fix: real-time session logging via main process streams (#403)
* fix: implement real-time session logging via main process streams Fixes #394. Session logs previously only captured ~55 lines (the xterm serialize buffer) and were written only on session close. This change intercepts terminal data in the main process and writes it to a file stream in real-time, capturing the complete session output. - Add sessionLogStreamManager.cjs: manages per-session write streams with 500ms/64KB flush, supports txt/raw/html formats - sshBridge: start stream on shell open, append on data, stop on close - terminalBridge: same for local, telnet, mosh, serial sessions - Thread sessionLog config from renderer settings through IPC options - Skip old renderer-side auto-save when streaming is active - Cleanup all streams on app quit Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove stale renderer-side auto-save and async HTML finalization - Remove dead renderer-side auto-save code (main process handles it) - Make stopStream async, await writeStream finish before HTML conversion - Use fs.promises for HTML read/write/unlink Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
4e26852482 |
feat: support multimodal attachments in AI chat (#397)
* feat: support multimodal attachments (images, PDFs, files) in AI chat Previously uploaded images were displayed in the UI but never sent to the AI model, and non-image files (PDF, text) were silently rejected. - Rename useImageUpload → useFileUpload; accept image/*, PDF, and text/* - Rename ChatMessageImage → ChatMessageAttachment with filePath support - Build multimodal SDK messages (ImagePart/FilePart) for Catty Agent - Fix ACP agent path: images inline, non-image files via local path hint so ACP agents (Claude Code, etc.) read them with native file access - Use Electron webUtils.getPathForFile() for reliable file path capture - Compact user message bubble padding Closes #294 (AI file upload issues) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: show real tool names in AI chat instead of ACP wrapper names - Unwrap ACP dynamic tool calls in serializeStreamChunk to extract real tool name, args, and toolCallId from chunk.input - Simplify MCP tool name prefixes (mcp__server__tool → tool) - Pass toolCallId from ACP tool-call events to match tool results - Prevent onToolResult from overwriting correct names with wrapper name - Build toolCallNames map in ChatMessageList for tool result display Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: backward-compatible fallback for legacy `images` field in chat messages Persisted sessions may still have `images` instead of `attachments`. Add `?? m.images` fallback in SDK message builder and renderer so historical image attachments are not silently dropped after upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: broaden file type support and handle pasted files without path - Accept all file types except video/audio (instead of allowlist) so .json, .yaml, .sh, etc. are not silently rejected - For ACP agents, save pasted/virtual files (no filePath) to temp directory so the agent can still read them Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use managed temp dir for pasted ACP attachments Use tempDirBridge.getTempFilePath() instead of manual os.tmpdir() path so pasted file attachments are tracked by the app's cleanup system. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
63558b5301 |
Remove HTTP localhost-only restriction for AI requests (#393)
Remove the restriction that blocked non-localhost HTTP URLs for AI provider requests. Users with HTTP-based AI services on internal networks can now configure http:// provider base URLs. Security measures: - Only providers explicitly configured with http:// are allowed over HTTP - HTTPS-configured providers cannot be silently downgraded - Temporary HTTP permissions expire after 30s TTL - Non-http/https schemes are explicitly rejected - webSearchApiHost entries preserved from accidental expiry Fixes #392 |
||
|
|
4d5c0eed69 |
Fix SFTP download failing on Windows drive root paths
On Windows, `fs.promises.mkdir("E:\", { recursive: true })` throws
EPERM for drive root directories. When users save SFTP downloads to a
drive root (e.g. E:\file.txt), `path.dirname` returns "E:\" and the
subsequent mkdir fails. Fix by catching the error and verifying the
directory already exists before re-throwing.
Fixes #390
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|
|
3d4fbf8763 |
fix: keep workspace MCP scope in sync (#385)
* fix: keep workspace MCP scope in sync * fix: refresh catty workspace tool context * fix: preserve AI stream state across tab switches * fix: align ACP stop and resume with 1code semantics * fix: harden ACP resume fallback for unsupported agents |
||
|
|
9387590696 |
Fix ACP stop cleanup and cancel state (#384)
* Fix ACP stop cleanup and cancel state * Block ACP tool writes after stop * Kill ACP child processes on cleanup * Cleanup ACP sessions when tabs disappear |
||
|
|
3c258b0f19 |
feat: auto-close tab when user actively exits session (#380)
* feat: auto-close tab when user actively exits a session
When a user intentionally exits a session (e.g. typing `exit`, `logout`,
or Ctrl+D), the tab is now automatically closed instead of showing the
"Start Over" disconnected page. This matches the behavior of macOS
Terminal and other popular terminal emulators.
Network errors, timeouts, and server-initiated disconnects still show
the disconnected page with the Start Over option, so users can reconnect.
In workspace mode, only the individual terminal pane is closed, not the
entire workspace.
Implementation:
- Backend bridges now include a `reason` field in exit events to
distinguish stream-level exits ("exited") from connection errors
("error"), timeouts ("timeout"), and connection closes ("closed")
- SSH bridge captures real exit code from stream "exit" event instead
of hardcoding 0
- Frontend auto-closes session only when reason is "exited"
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: address review feedback for auto-close feature
1. Pass exit event to onSessionExit in local shell path (line 757)
to prevent undefined access when checking evt.reason
2. Change Telnet socket close reason from "exited" to "closed" since
a clean socket close can also be server-initiated (idle timeout,
remote shutdown), not just user exit
3. Change Serial port close reason from "exited" to "closed" since
port close can be from device disconnect, not user action
Only SSH stream close and local/mosh process exit (node-pty onExit)
now use reason "exited", which correctly represents user-initiated exits.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: only mark SSH exit as "exited" when stream exit event fired
ssh2's stream "close" event fires whenever the channel closes, not
only on normal shell exit. If the network drops and the channel closes
without a preceding "exit" event, the reason was incorrectly set to
"exited", causing the tab to auto-close instead of showing the
disconnected/Start Over page.
Now tracks whether stream "exit" actually fired via a flag, and only
uses reason "exited" in that case. Otherwise falls back to "closed".
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: classify mosh non-zero exits as errors
Mosh process exiting with a non-zero code typically indicates a
connection or auth failure. Mark these as reason "error" so the
disconnected/Start Over UI is shown instead of auto-closing the tab.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: treat SSH signal-terminated exits as disconnects
ssh2's stream "exit" event also fires for signal terminations (e.g.
SIGHUP from server idle timeout, SIGTERM from admin kill), where code
is null and signal is set. These are not user-initiated exits and
should show the disconnected/Start Over page.
Now only sets streamExited=true when there's a numeric exit code and
no signal present.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: distinguish abnormal local PTY exits from user exits
Local shell terminated by signal or crashing on startup should show
the disconnected UI, not auto-close the tab. Now only marks as
reason "exited" when exitCode is 0 and no signal, matching the same
logic used for mosh.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: use signal presence to distinguish local shell exit reason
For local shells, non-zero exit codes are common in user-initiated
exits (e.g. typing `exit` after a failed command returns that
command's exit code). Use signal presence instead: signal means the
process was killed externally (show disconnected UI), no signal
means normal process exit (auto-close tab).
Mosh keeps exitCode-based logic since non-zero there indicates
connection/auth failure, not user exit.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|
|
ccfa2d4dd0 |
fix: non-zero exit code is not a failure, include output on real errors (#377)
* fix: treat non-zero exit code as success and include output on failure - Non-zero exit codes (e.g. grep returning 1, ls on missing file) are valid command results, not execution failures. Changed execViaPty and execViaChannel to always return ok:true when the command actually ran. - ok:false is now reserved for real failures: timeout, session gone, stream not writable, etc. - When ok:false, include any partial stdout/stderr in the error message so the user and LLM can see what happened before the failure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: return stdout+exitCode for all completed commands, clean up dead code - ptyExec: preserve original ok semantics (non-zero = ok:false) so MCP server bridge callers (handleMultiExec, stopOnError) still work - execViaChannel: null exit code (SSH disconnect) returns ok:false - toolExecutors: Catty Agent always returns stdout+exitCode to the LLM regardless of exit code, only treats real failures (timeout, disconnect) as errors — with partial output included - Remove dead code: executeTerminalSendInput, executeSftp*, executeMultiHost - Clean up unused imports, bridge interface, ExecutorContext Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
43c4d4c430 |
fix: open settings window on the same display as the main window (#367)
Use Electron's screen.getDisplayMatching() to find which display the main window is on, then center the settings window on that display's work area. Previously the settings window used Electron's default placement which could open on the primary display even when the main window was on an external monitor. Ref #294 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
835a1231a6 |
feat: add skip TLS verification option for self-hosted AI providers (#369)
* feat: add skip TLS verification option for AI providers
Self-hosted AI endpoints (vLLM, text-generation-webui, etc.) often use
self-signed TLS certificates which Node.js rejects by default, causing
502 Bad Gateway errors. Add a per-provider "Skip TLS certificate
verification" checkbox that sets rejectUnauthorized=false on both
streaming and non-streaming requests.
Ref #294
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: surface real error message instead of generic 502 Bad Gateway
- Pass the actual bridge error message in statusText so Vercel AI SDK
shows the real cause (e.g. "HTTP is only allowed for localhost",
"URL host is not in the allowed list", TLS errors)
- Show real error details for 5xx provider errors instead of generic
"The AI provider returned a server error" message
Previously all connection-level errors were masked as "Bad Gateway"
making it impossible for users to diagnose configuration issues.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: pass server error body details through to the user
- Read HTTP error response body before resolving (was resolving before
body was read, losing the error detail)
- Parse OpenAI-compatible JSON error format to extract error.message
- Return error Response with body+statusText for non-2xx instead of
empty stream, so Vercel AI SDK shows the real server error
- Now users see e.g. "502 model not loaded" instead of just "Bad Gateway"
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: widen link modifier key dropdown to prevent text wrapping
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Revert "fix: widen link modifier key dropdown to prevent text wrapping"
This reverts commit
|
||
|
|
6727248924 |
feat: add web search & URL fetch tools for AI agent (#365)
* feat: add web search and URL fetch tools for AI agent Add web_search and url_fetch tools to Catty Agent, allowing the AI to search the internet for current information and fetch webpage content. - Support 5 search providers: Tavily, Exa, Bocha, Zhipu, SearXNG - Settings UI with provider selection, API key encryption, and config - web_search is conditional on config; url_fetch is always available - Both tools are read-only and work in all permission modes (incl. observer) - aiFetch skipHostCheck for AI tool requests to arbitrary URLs - System prompt guidelines for when to use search/fetch - i18n support (en + zh-CN) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address code review findings (SSRF, key exposure, state race) - P1: Restore SSRF protection when skipHostCheck is true — still block localhost, RFC1918, link-local, and cloud metadata endpoints; only skip the domain allowlist for public HTTPS hosts - P2: Move web search API key decryption to main process via dedicated IPC handler, matching the existing provider key security model - P2: Use configRef to avoid stale closure in async settings callbacks that could overwrite newer user changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address second review — DNS rebinding, url_fetch approval, maxResults - P1: url_fetch now requires approval in confirm mode (outbound GET is a side effect that could exfiltrate data via query strings) - P1: Add DNS resolution check when skipHostCheck is set — resolve hostname and reject if any IP is private/loopback/link-local, blocking DNS rebinding attacks against internal services - P2: Slice search results after provider call to enforce maxResults consistently (Zhipu and SearXNG ignore the limit parameter) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address third review — localhost/IPv6 SSRF, API key blur race - P1: Block localhost/loopback when skipHostCheck is enabled — restructure isAllowedFetchUrl to check private hosts first in the skipHostCheck path, preventing access to local services on allowlisted ports - P1: Handle IPv6 private ranges (fc00::/7, fe80::/10, ::ffff: mapped), strip brackets from URL.hostname, block [::1] and fd00:: addresses - P2: Guard handleApiKeyBlur against provider change during async encryption — skip stale write if provider switched while encrypting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address fourth review — main-process key isolation, SearXNG compat - P1: Replace aiWebSearchDecryptKey IPC with __WEB_SEARCH_KEY__ placeholder pattern — renderer never sees plaintext keys; main process replaces placeholder in headers before HTTP request, matching provider key flow - P1: Search API requests use normal allowlist path (not skipHostCheck), so SearXNG on localhost/HTTP/private networks works via aiSyncWebSearch; only url_fetch uses skipHostCheck for arbitrary public HTTPS URLs - P2: Remove needsApproval from url_fetch — treat as read-only like sftp_read_file, consistent with observer mode allowlist Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address fifth review — private LAN providers, maxResults default - P1: Allow private-IP hosts that are explicitly in the provider/search allowlist (e.g. https://192.168.x.x model providers or SearXNG) - P2: Remove .default(5) from web_search maxResults schema so the user's configured maxResults setting is used when the model omits the param Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address sixth review — HTTPS scope, config gate, redirects - P2: Scope HTTP exception to private/LAN IPs only — remote allowlisted hosts still require HTTPS to protect API keys in transit - P2: Gate web_search tool on complete config (API key for providers that require it, apiHost for SearXNG) to avoid advertising a broken tool - P2: Add redirect following (up to 5 hops) to aiFetch for url_fetch — handles 301/302/307 for short links, www canonicalization, etc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address seventh review — redirect SSRF, decrypt race, HTTPS-only - P1: Revalidate each redirect hop against SSRF guards (allowlist check + DNS resolution) before following, preventing open-redirect SSRF - P2: Add sequence counter to API key decryption effect — stale promise results from a previous provider are discarded on provider switch - P3: Restrict url_fetch to HTTPS-only URLs, matching the skipHostCheck policy that already rejects HTTP in the bridge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address eighth review — OS resolver, allowlisted HTTP hosts - P1: Use dns.lookup (OS resolver) instead of dns.resolve4/6 for private IP checks — matches what http.request actually connects to, respects /etc/hosts, mDNS, and other local resolver sources - P2: Allow HTTP for any explicitly allowlisted host (not just literal private IPs), so self-hosted SearXNG at http://searxng.lan works Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address ninth review — HTTP scope, blur ordering, decrypt flag - P1: Narrow HTTP exception to web search apiHost only — AI provider endpoints remain HTTPS-only to protect credentials in transit - P2: Add blur sequence counter to prevent out-of-order encryption results from overwriting newer API key saves - P2: Reset isDecrypting flag when cancelling decrypt on provider switch, preventing permanently disabled API key input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address tenth review — DNS pinning, prompt/tool alignment - P1: Pin validated DNS result to the HTTP request via custom lookup function, preventing TOCTOU/DNS-rebinding between validation and actual connection - P2: Extract isWebSearchReady() helper and use it consistently in both tool registration and system prompt, so the model isn't told web search is available when config is incomplete Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address eleventh review — single DNS lookup, redirect pinning, CGNAT - P1: Combine DNS validation and pinning into a single lookup call, eliminating the TOCTOU window between hasPrivateResolution and pinnedLookup - P1: Pin DNS for redirect targets too — resolve/validate/pin in one step before following each redirect hop - P2: Add 100.64.0.0/10 (CGNAT) to private IP ranges for Tailscale and similar CGNAT-addressed internal services Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address twelfth review — apiHost validation, sync on enable - P2: Validate apiHost is a well-formed URL in isWebSearchReady(), preventing tool exposure when user enters a malformed host - P2: Add webSearchConfig.enabled to sync effect deps so the main process gets updated immediately when the toggle changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove DNS-level SSRF checks that break fakedns/proxy environments DNS resolution validation (dns.lookup + IP pinning) breaks in proxy environments where fakedns resolves all domains to LAN addresses. Revert to hostname-level checks only (blocking localhost, 127.0.0.1, metadata endpoints, etc.) which are sufficient without false positives. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve empty catch block lint warning Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
344946b096 |
fix: use net.connect() for Windows SSH agent pipe detection
fs.statSync() is unreliable for Windows named pipes — it returns EBUSY even when the pipe is fully usable, causing ssh-agent to appear unavailable. Replaced with net.connect() which is the authoritative check for named pipe connectivity. Fixes #360 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
b3d5785477 |
fix: allow settings window as trusted IPC sender (#354)
* fix: allow settings window as trusted IPC sender The settings window runs in a separate BrowserWindow with its own webContents id. validateSender() only checked the main window id, causing "Unauthorized IPC sender" errors when fetching AI model lists from the settings page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: add validateSender to all remaining AI IPC handlers 15 handlers in aiBridge were missing sender validation, allowing potential unauthorized IPC calls. Now every netcatty:ai:* handler consistently validates the sender against trusted windows. Affected handlers: chat:cancel, agents:discover, resolve-cli, codex:get-integration, codex:start-login, codex:get-login-session, codex:cancel-login, codex:logout, mcp:update-sessions, mcp:set-command-blocklist, mcp:set-command-timeout, mcp:set-max-iterations, mcp:set-permission-mode, acp:cancel, acp:cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: scope settings window trust to config-only IPC handlers Per code review feedback: the previous commit allowed the settings window to access ALL AI IPC handlers including high-risk ones like exec, terminal:write, and agent:spawn. Split into two validators: - validateSender(): main window only (exec, terminal, agent, stream) - validateSenderOrSettings(): main + settings (fetch, sync, codex login, MCP config, agent discovery) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: refresh main window id on recreation and allow settings fetch Two fixes from code review: 1. Always resolve mainWebContentsId from windowManager instead of caching it once, so a recreated main window is recognized. 2. Skip static host allowlist for settings window ai:fetch calls, since the settings UI lets users configure custom provider URLs that haven't been synced to providerFetchHosts yet. Basic URL safety (HTTPS-only, no file:// schemes) is still enforced. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: enforce HTTPS/port safety for settings window fetch requests Per review: previous commit skipped isAllowedFetchUrl entirely for settings window, which removed SSRF protection. Now settings window fetches still bypass the static host allowlist (since the user is configuring new providers) but enforce the same safety rules: - Remote hosts must use HTTPS - Localhost must use known ports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: sync provider config before fetching models in settings Instead of bypassing the URL allowlist for settings window fetches (which weakens SSRF protection), have ModelSelector sync the current provider's baseURL to the backend allowlist before fetching models. This keeps the full URL safety checks intact while allowing settings to test custom provider endpoints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use dedicated allowlist handler instead of syncing providers Replace the approach of calling aiSyncProviders (which overwrites the shared providerConfigs) with a new lightweight IPC handler netcatty:ai:allowlist:add-host that only adds a host to the fetch allowlist without affecting provider configs or API key resolution. This preserves the SSRF protection while allowing settings to test custom provider URLs that haven't been synced from the main window. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: auto-expire temporary allowlist entries after 30 seconds Temporary hosts added via allowlist:add-host now auto-remove after 30s to prevent permanently expanding the SSRF boundary. Built-in ports and hosts re-added by provider sync are preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: prevent temp allowlist cleanup from removing synced providers The setTimeout cleanup now checks whether the host/port belongs to a currently synced provider config before removing it. This prevents the scenario where a user saves a provider within the 30s TTL window and then loses access when the timer fires. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve temp allowlist entries across provider sync rebuilds rebuildProviderFetchHosts() clears and rebuilds the allowlist from providerConfigs, which would wipe temporary entries added by allowlist:add-host. Now re-adds active temp entries after rebuild to prevent race conditions between settings model listing and provider sync from the main window. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
ec35daa0dd |
feat: add auto-update toggle setting (#351)
* feat: add auto-update toggle setting (closes #346) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: re-check auto-update toggle when startup timer fires Address review feedback: the startup check effect now re-reads the toggle from localStorage when the delayed timer fires, so toggling off after launch cancels the pending check. Also avoids setting hasCheckedOnStartupRef when disabled, allowing re-enable to trigger a check without restart. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address review feedback on auto-update toggle P1: When autoDownload=false, onUpdateAvailable no longer transitions to 'downloading' status. Instead keeps autoDownloadStatus idle so the manual download link surfaces correctly. P2: Added reactive autoUpdateEnabled state (synced via storage event) as a dependency to the startup check effect. Re-enabling the toggle mid-session now re-triggers the deferred startup check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address P1/P2 review feedback on auto-update toggle P1: Main process update-available handler now checks updater.autoDownload before setting _lastStatus to 'downloading'. When autoDownload=false, status stays 'idle' so late-opened windows don't hydrate to a stuck 0% download state. P2: useUpdateCheck now accepts autoUpdateEnabled as a prop from the caller instead of relying solely on storage events (which don't fire in the same window). SettingsPage passes settings.autoUpdateEnabled directly, so toggling in the current window takes effect immediately. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve update-available info for late-opening windows When autoDownload is off, use status 'available' (instead of 'idle') in the main process snapshot so late-opening windows can hydrate version info. The renderer maps 'available' to hasUpdate=true while keeping autoDownloadStatus='idle' for the manual download path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: re-schedule auto-check on re-enable and guard startup timer - IPC handler now calls startAutoCheck(2000) when re-enabling so the user gets automatic checks without restarting the app. - startAutoCheck timer checks updater.autoDownload at fire time, so if the renderer disables auto-update via IPC before the 5s startup timer fires, the check is skipped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: deduplicate auto-check scheduling and clear error on fallback success P1: startAutoCheck now cancels any existing timer before scheduling a new one, preventing duplicate concurrent checks from multiple windows or re-enable toggles. P2: checkNow fallback now clears manualCheckStatus='error' when electron-updater successfully finds an update (res.available=true), so the UI shows 'available' instead of a stale error state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: only reschedule on actual re-enable and hydrate cache before toggle check P2: Track previous autoDownload state in IPC handler so startAutoCheck is only called on actual false→true transitions, not on every window mount that syncs the current value. P3: Move cache hydration (STORAGE_KEY_UPDATE_LATEST_RELEASE) before the auto-update toggle check so cached update info is always visible even when automatic updates are disabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: persist auto-update preference in main process across restarts Read/write auto-update preference to a JSON file in userData so the main process honors it on next launch without waiting for renderer IPC. getAutoUpdater() now initializes autoDownload from the persisted value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: suppress cached update toast when disabled and update IPC types P2: Cache hydration now gates hasUpdate on autoUpdateEnabled so the App.tsx toast doesn't fire when automatic updates are disabled. P3: Updated global.d.ts to include 'available' in getUpdateStatus status union and 'checking' in checkForUpdate return type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: preserve dismissed releases, show cached updates in Settings, guard concurrent checks P2a: Updater fallback now checks STORAGE_KEY_UPDATE_DISMISSED_VERSION before re-surfacing a release found by electron-updater. P2b: Cache hydration always sets hasUpdate truthfully so Settings shows the available update. Toast suppression for disabled auto-update moved to App.tsx (reads localStorage directly). P3: Re-enable IPC handler checks _isChecking before scheduling startAutoCheck to prevent concurrent electron-updater calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use localStorageAdapter for lint compliance, skip IPC on initial mount P1: Replace direct localStorage access with localStorageAdapter in App.tsx toast guard to fix no-restricted-globals lint error. P2: Skip setAutoUpdate IPC on initial mount to prevent overwriting the main-process preference file when renderer localStorage has been cleared (where the default would be true). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: hydrate auto-update state from main-process preference on mount Add getAutoUpdate IPC handler so the renderer can query the persisted preference from auto-update-pref.json. On mount, useSettingsState reconciles localStorage with the main-process truth, preventing the toggle from showing 'enabled' when the user had previously disabled it and localStorage was cleared. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
c000996cb4 |
fix: detect SSH agent via named pipe instead of service status on Windows
Previously, Netcatty checked if the OpenSSH Authentication Agent Windows service was running via `sc query ssh-agent`. This broke compatibility with third-party SSH agents (Bitwarden, 1Password, gpg-agent) that provide the same named pipe without running the system service. Now we probe `\\.\pipe\openssh-ssh-agent` directly with fs.statSync, which works regardless of which agent provides the pipe. Fixes #343 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
b973382f9f |
fix: return real HTTP status in streaming bridge and dynamic provider URL allowlist
- streamRequest now resolves on headers arrival with statusCode/statusText so the renderer constructs Response with the real HTTP status (e.g. 401) instead of hardcoded 200 - Provider fetch URL allowlist is now dynamically rebuilt from configured provider baseURLs on sync, supporting custom provider endpoints - Localhost port allowlist properly resets on provider sync (no stale ports) - PTY marker detection requires line-boundary match to avoid false positives - Clarify terminal_send_input vs terminal_execute usage in tool descriptions and system prompt Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
eeb300295d |
refactor: improve security, accessibility, performance, and code organization
- Security: API keys no longer transit IPC as plaintext; renderer sends providerId and main process decrypts via safeStorage. Add ReDoS protection for user-supplied blocklist regex. Sanitize error messages to strip file paths and sensitive URLs before displaying in chat. - Bug fixes: approval timeout now notifies user in chat instead of silently aborting. statusText cleared consistently across all 7 code paths. useAIState persistence race condition fixed with mountedRef guard, storage sync validated with type checks. - Accessibility: InlineApprovalCard uses role="alertdialog" with focus on approve button. ChatInput menus have proper ARIA roles, labels, and aria-expanded. ThinkingBlock toggle has aria-expanded/controls. Model selector submenu supports keyboard navigation. - UX: switching agents preserves old session and creates new one. Approval card buttons disabled immediately after click. - Performance: text-delta streaming batched via requestAnimationFrame. - Refactor: extract useAIChatStreaming, useToolApproval, and useConversationExport hooks from AIChatSidePanel (1514 → 751 lines). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
be36ccd167 |
fix: address security, correctness, and performance issues from code review
Security: add validateSender to agent IPC handlers, remove CODEX_API_KEY and NODE_PATH from SAFE_ENV_KEYS, validate URL scheme before openExternal, add backtick substitution to command blocklist, add 10MB buffer limits. Bugs: fix runExternalAgentTurn timeout hang, fix limitConcurrency undefined entries on error, treat null exitCode as failure, enforce maxBytes for SFTP reads. Performance: debounce addMessageToSession persistence, cache compiled blocklist regexes, add QuotaExceededError handling for localStorage writes. UI: use local onKeyDown for PermissionDialog, move CRITICAL_PATHS to module level. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
71b13a77a3 |
fix: address security, correctness, and performance issues from code review
Security: validate agent spawn commands against allowlist, replace execSync with execFileSync in agent discovery, restrict localhost SSRF to known ports, add observer mode enforcement at IPC layer, add IPC sender validation, expand dangerous env key blocklist, add pending approval timeout. Correctness: replace updateLastMessage with ID-based updateMessageById to fix race condition during streaming, include tool-call/tool-result messages in SDK context, flush debounced persist on unmount, fix ACP client break placement, use proper AI SDK message types. Performance: pre-compile command blocklist regexps, extract shared tool executors to deduplicate executor.ts and tools.ts (~50% reduction each). Also: i18n for hardcoded English strings, remove dead detectDoomLoop code, add bypass-resistant blocklist patterns, include permissionMode in ACP provider reuse fingerprint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
808d021ebe |
fix: address security, correctness, and performance issues from code review
- Use crypto.randomBytes for PTY markers instead of Math.random - Replace execSync with execFileSync to prevent command injection - Fix sftp_write_file missing safety check (pass path to guardWriteOperation) - Add IPC input validation for handleExec, handleSftpRead, handleMultiExec - Add maxBytes bounds validation in executor, tools, and MCP server - Fix approval race condition (clear ref after destructuring, strict messageId match) - Shorten API key plaintext lifetime in memory - Fix stream cancellation race with AbortController registered before request - Delay revokeObjectURL for download timing - Extract shared limitConcurrency to infrastructure/ai/concurrency.ts - Add execStream null check in execViaChannel Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
b192ee1764 |
fix: address security, correctness, and performance issues from code review
Security: sanitize command input in resolveCliFromPath, add host allowlist to streaming endpoint, enforce permission model in MCP server tools, add safety check to terminal:write IPC, fix broken blocklist regex, remove renderer-controlled allowedHosts parameter. Correctness: use sessionsRef for latest state in handleSend, merge add+update to avoid race condition in streaming, mark assistant message completed after tool-result, return JSON-RPC error for unhandled ACP permission requests, add finished guard in ptyExec. Performance: custom React.memo comparator for ChatMessageList, fix doom loop detection threshold. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
0b9cb86c4e |
fix: address security and correctness issues from code review
- Add command blocklist check to terminal_send_input (executor + SDK tools) - Add session scope validation to all tools in executor.ts - Fix abort handler to call aiChatCancel instead of aiChatStream - Enforce URL allowlist in fetch proxy to prevent SSRF - Wrap event.sender.send with safeSend for destroyed window check - Filter dangerous env vars (LD_PRELOAD, NODE_OPTIONS, etc.) from agent spawn - Fix stale debouncedPersistSessions closure using sessionsRef - Fix cleanupOrphanedSessions race when sessions load before workspaces - Fix limitConcurrency implementation using Set + finally pattern - Improve command blocklist regex patterns with word boundaries - Add regex validation with error feedback in SafetySettings - Add confirmation dialog for provider removal - Fix React key warning for tool-role messages in ChatMessageList - Remove debug console.warn in TerminalLayer - Remove unused nanoid dependency - Remove redundant platform-specific codex-acp binary from dependencies Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
bcd44f0177 |
refactor: remove Claude Agent SDK integration in favor of ACP
All external agents now use ACP protocol exclusively. The Claude Agent SDK flow was fully implemented but never wired into the UI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
d8d29d1709 |
fix: address code review findings for AI chat panel
Security: - Apply checkCommandSafety() in aiExec IPC handler to enforce command blocklist - Add critical path validation in handleSftpRemove (normalize + blocklist) - Change rm -rf to rm -r so permission errors surface Stream lifecycle: - Abort all active streams on component unmount (abortControllersRef cleanup) - Wrap stream reader in try/finally with releaseLock() to prevent leaks - Use refs for inputValue/images in handleSend to stabilize callback identity State persistence: - Clear debounce timer before synchronous persist in destructive operations (clearSessionMessages, deleteSession, deleteSessionsByTarget) - Add 10MB max buffer guard in ACP client and MCP server NDJSON parsing i18n: - Replace hardcoded English strings with t() calls in InlineApprovalCard, PermissionDialog, ConversationExport, ThinkingBlock, AgentSelector - Add 23 new i18n keys to en.ts and zh-CN.ts Misc: - Remove debug console.log statements in mcpServerBridge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
29fca33ffd |
fix: reduce stall timeout to 3s and show status with shimmer effect
- Reduce ACP stall detection from 15s to 3s for faster feedback - Add statusText field to ChatMessage for transient status display - Render status text with thinking-shimmer CSS animation - Clear statusText when real content arrives (onTextDelta) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
216ea7f177 |
feat: show ACP agent status messages (stall detection) in chat
- Add stall detection in ACP stream loop: if no chunk received for 15s, send a "Waiting for response..." status event to the chat panel - Add onStatus callback to AcpAgentCallbacks, render as italic text - Forward status events from main process to renderer via acp:event IPC Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
2d4f260f0b |
fix: address review findings from refactoring review
- Fix stale closure: add updateLastMessage to handleApprovalResponse deps - Use random heredoc delimiter to prevent content corruption when file contains the literal delimiter string - Remove dead ensureClaudeConfigDir function from claudeHelpers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
a55da77471 |
refactor: fix security issues, remove dead code, and split monolithic files
Security: - Fix command injection in 15+ shell interpolation sites with shellQuote() - Add token-based authentication to MCP TCP server - Fix heredoc delimiter collision in SFTP write fallbacks - Add case-insensitive flag to mcpServerBridge command blocklist - Add exhaustive default case to createModelFromConfig Architecture: - Split aiBridge.cjs (1971→1483 lines) into 4 modules: shellUtils, codexHelpers, claudeHelpers, ptyExec - Split SettingsAITab.tsx (1480→520 lines) into 10 sub-components - Extract shared processCattyStream from AIChatSidePanel.tsx (-168 lines) - Consolidate duplicate PTY execution logic into shared ptyExec.cjs - Consolidate duplicate stripAnsi/toUnpackedAsarPath utilities Code quality: - Remove ~33 debug console.log statements from production code - Remove dead code: terminal_read_output stub, checkToolPermission, isCommandAllowed, READ_ONLY_TOOLS - Unify bridge type accessor in useAIState.ts (eliminate 15 unsafe casts) - Add localStorage session pruning (50 sessions / 200 messages cap) - Fix ModelSelector onBlur race condition (setTimeout → preventDefault) - Fix duplicate getShellEnv() calls in Codex helpers - Remove unused _config param from claudeAgentAdapter - Type claudeAgentAdapter bridge parameter directly as ClaudeBridge Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
f90aa81b2c |
feat: enforce safety settings, blocklist UI, provider UX improvements, and full i18n
Safety enforcement: - Command Timeout: use user setting in MCP Server (execViaPty/execViaChannel) and Catty Agent path (aiBridge execViaPtyForCatty/execViaChannel fallback) - Max Iterations: read user setting for Catty (stepCountIs) and ACP (via IPC) - Permission Mode: observer mode hard-blocks write ops in MCP Server dispatch; Catty SDK tools wired to checkToolPermission(); all synced via IPC on change Command Blocklist UI: - Add editable regex pattern list in Settings AI Safety section - Reset to defaults button, add/remove patterns - IPC sync to MCP Server on change and on mount Provider UX: - ModelSelector rewritten as combobox: type-to-filter with suggestions dropdown - All providers use unified ModelSelector (modelsEndpoint optional) - API key passed as auth header for model fetching (Bearer / x-api-key) - Skip model fetch when no API key (except Ollama) - Provider toggle is now mutually exclusive (activating one disables others) - New providers default to disabled (switch off) - Custom provider supports editable display name - No-provider error: friendly message shown in chat i18n: - Full i18n coverage for Settings AI tab (~55 keys) - Full i18n for AI chat panel (placeholder, empty state, time, sessions) - en.ts and zh-CN.ts locale files updated Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
4a3a4b9d9b |
fix: restore agent on tab switch, i18n agent settings, icon improvements
- Restore currentAgentId from active session when switching scopes - Add i18n for "Agent Settings" label in agent selector - Add agent icons to settings page default agent dropdown - Replace catty.svg with new icon, use Settings icon for manage button - Fix lint: missing useCallback deps, no-restricted-globals, useMemo deps - Guard webContents.send against disposed render frames in windowManager Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
7e8682d10d |
fix: preserve ACP provider session when switching chat sessions
Remove chatSessionId from MCP server config env vars so it doesn't affect the fingerprint calculation. Previously, different chat sessions in the same workspace produced different fingerprints, causing the ACP provider to be recreated when switching back to a previous session, losing all conversation history. Now the fingerprint only depends on the workspace scope (host session IDs and MCP port), so providers are correctly reused when returning to a previous chat session. Each chat session still has its own provider instance (keyed by chatSessionId in the acpProviders Map). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
b2447b06d2 |
fix: per-scope AI chat isolation and workspace host discovery
- Fix workspace host discovery: use `activeWorkspace.root` instead of
non-existent `.tree` property, which caused `collectSessionIds` to
always return empty for workspaces
- Isolate AI chat state per-scope (tab/workspace): activeSessionId,
isStreaming, abortController, and inputValue are now keyed by
`${scopeType}:${scopeTargetId}` so different tabs don't interfere
- Add per-chatSession MCP scope metadata to prevent host list mixing
across workspaces, with chatSessionId passed through the full IPC chain
- Store hostname/username in SSH session objects as fallback for MCP
host info when renderer metadata is unavailable
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|
|
f0f5803a6d |
fix: enforce workspace scope isolation for MCP server sessions
The MCP server was exposing ALL terminal sessions to AI agents regardless of which workspace the agent belonged to. Fixed by: - Track scoped session IDs when updateSessionMetadata is called - buildMcpServerConfig now auto-uses current scoped IDs when no explicit scope is provided, setting NETCATTY_MCP_SESSION_IDS env var - handleGetContext falls back to sessionMetadata keys when no explicit scopedSessionIds param is passed This ensures agents only see hosts within their workspace/terminal scope. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
f53bc05cb3 |
feat: overhaul AI settings, fix Catty Agent streaming and tool execution
AI Settings: - Remove External Agents section, add dedicated Codex/Claude Code sections with auto-detection and manual path override - Add OpenRouter model list auto-fetch with searchable dropdown - Remove standalone Default Model section, integrate into provider cards - Provider toggle now acts as mutual-exclusive active selector - Add cross-window state sync via storage events - Add ErrorBoundary around AI tab for graceful error handling Catty Agent fixes: - Fix streaming: use .chat() instead of default Responses API, use getReader() pattern instead of for-await, handle text-delta/text chunk types correctly per SDK v6 - Fix API key: decrypt encrypted key before passing to SDK - Fix terminal_execute: use PTY stream (visible in terminal) with MCP markers instead of invisible SSH exec channel - Fix multi-turn: only pass user/assistant text history, skip tool messages to avoid SDK schema validation errors - Fix tool result display: create new assistant message after tool results so follow-up text renders correctly Other: - Add netcatty:ai:resolve-cli IPC handler for CLI path validation - Remove Gemini from agent discovery (only Codex + Claude Code) - Fix lint errors across ChatInput, TerminalLayer, SettingsAITab - Strip MCP markers from tool execution stdout Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
3136100514 |
feat: image attachments, model selector with thinking levels, PTY marker filtering, and UX improvements
- Add image paste/drop support with base64 encoding and chat display - Add + button popover (Files, Image, Mention Host) with @ auto-complete - Add model selector with Codex thinking level sub-menus (GPT 5.4, Codex 5.x, o3/o4-mini) - Switch Claude Code to ACP protocol; remove CLAUDE_CONFIG_DIR isolation - Filter PTY exec markers in preload data pipe (precise regex, preserves command echo) - Increase PTY exec timeout to 5min with Ctrl+C cancellation on abort - Fix tool call loading spinner (only animate during active streaming) - Reset active session on terminal/workspace switch - Add AI sparkle button in top bar to toggle AI panel - Display user-attached images in chat message list Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
847df7a023 |
feat: add MCP server for remote host access, model selector, and PTY execution
- Create netcatty-remote-hosts MCP server (TCP bridge + stdio child process) exposing terminal_execute, sftp_*, get_environment tools to ACP agents - Execute commands via PTY stream with self-erasing markers for terminal visibility; disable pagers automatically; 60s timeout fallback - Inject MCP server into both Codex (ACP) and Claude Code (ACP) sessions - Add model selector popover with hardcoded presets for Claude (Opus/Sonnet/ Haiku) and Codex (GPT 5.4, Codex 5.3/5.2/5.1, o3/o4-mini) with thinking level sub-menus - Fix multi-step tool call message flow (mutable flag instead of stale closure) - Remove CLAUDE_CONFIG_DIR isolation to fix Claude auth; switch Claude to ACP - Add startup cleanup for orphaned AI sessions - Guard collectSessionIds against undefined workspace tree - Remove permission mode chip from chat input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |
||
|
|
8949394756 |
feat: add Claude Agent SDK streaming and Codex OAuth integration
Integrate Claude Agent SDK for direct streaming chat, add Codex login/logout flow with OAuth support in settings, improve AI chat panel UI and agent discovery, and update build config for new dependencies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> |