Minimal terminal stubs used in session-starter tests do not expose
xterm buffer state; treat that as "not scrolled up" instead of throwing.
Co-authored-by: Cursor <cursoragent@cursor.com>
Use xterm viewportY/baseY to decide when sync-block clears may be stripped,
and re-arm the abandonment timeout whenever a new DEC 2026 block starts.
Co-authored-by: Cursor <cursoragent@cursor.com>
Preserve `\x1b[2J` inside DEC 2026 blocks for alternate-screen TUIs and
for normal-buffer redraws at the bottom, while still preventing xterm.js
viewport jumps when the user is reading scrollback history.
Co-authored-by: Cursor <cursoragent@cursor.com>
Only start the DEC 2026 abandonment timer when entering a block, and
preserve trailing partial marker bytes when the timeout fires.
Co-authored-by: Cursor <cursoragent@cursor.com>
Mirror xterm.js synchronized-output safety timeout so an unclosed sync
block cannot keep stripping later clear-screen sequences in the session.
Co-authored-by: Cursor <cursoragent@cursor.com>
Add regression tests for SYNC_END marker splits and for releasing a
held trailing ESC when the following chunk is ordinary terminal text.
Co-authored-by: Cursor <cursoragent@cursor.com>
Address Codex review: DEC 2026 start/end and clear-screen sequences can
be split across arbitrary PTY/IPC chunk boundaries. Keep a pending suffix
between calls so the sync-block filter still strips in-block clears.
Co-authored-by: Cursor <cursoragent@cursor.com>
Filter `\x1b[2J` inside DEC 2026 synchronized-output blocks before PTY
data reaches xterm.js so full-screen coding CLI redraws no longer reset
viewportY and make earlier output appear eaten.
Fixes#1612
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep all action buttons in the overflow row so the toolbar does not leave empty gaps beside the pinned close control.
Co-authored-by: Cursor <cursoragent@cursor.com>
Pin the collapse control outside the clipped action row and fade overflow so narrow widths stay usable without hiding the close button.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): stop follow-terminal-cwd retry loop on unreachable paths
When per-host follow navigates to a terminal cwd that SFTP cannot reach, stop retrying and allow the toolbar toggle to update immediately.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): address Codex review on follow-terminal-cwd blocking
Return navigateTo success explicitly and scope blocked follow paths per connection so successful navigations and host switches are not misclassified.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): clear follow block after manual go-to-terminal-cwd
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): honor cleared follow-cwd overrides from vault sync
Use an explicit pending toggle override instead of stale session host values when the vault clears per-host follow settings back to inherit-global.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): ignore stale follow navigation when follow is disabled mid-flight
Bump a follow-sync generation when follow is turned off so pending navigateTo failures cannot restore a blocked cwd after the user disables and re-enables follow.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): reconnect terminal side panel after SSH session loss
When SSH disconnects while the terminal SFTP side panel is browsing a stale
path, auto-connect reused a dead tab and left the pane stuck on loading.
Rebind SFTP when the terminal session changes and skip reuse unless the
backend session is healthy; also stop follow-terminal-cwd retry loops to
missing directories.
Fixes#1608
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(sftp): address review findings for side panel reconnect
Harden auto-connect after bugbot review: skip tab reuse on SSH session
change, move follow-cwd backoff ref into the interactive body, and make
navigateTo return reached/failed/aborted so follow mode only backs off on
real path failures.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* improve terminal keyword highlight refresh
* fix(terminal): address Codex review on keyword highlight refresh
Map viewport probe diffs to line numbers so off-cursor ANSI redraws mark the
rewritten line dirty without forcing full-viewport rescans on normal typing,
and cache wrapped-line context per processLineRange to avoid repeated scans.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: mam15mon <mam15mon@gmail.com>
Co-authored-by: bincxz <16399091+binaricat@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(notes): allow clearing the default note title while editing
Stop sanitizeNoteTitle from forcing empty titles back to "Untitled note", so users can delete the placeholder and type a custom title.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(notes): allow clearing titles from tree rename
Remove the empty-title guard in sidebar tree rename so it matches the main title editor behavior.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Popup and other standalone Terminal mounts do not publish paneVisibilityStore state; hibernate now respects the isVisible prop instead of treating missing entries as hidden.
Co-authored-by: Cursor <cursoragent@cursor.com>
Skip backend pwd probes after commands once the shell reports OSC 7, even when the path is unchanged, so sudo sessions no longer alternate between login-shell fallback and the interactive cwd. Also silence OSC 7 setup script status text in the terminal since the toast already confirms success.
Co-authored-by: Cursor <cursoragent@cursor.com>
Loop pending-buffer replay until caught up before stopping listeners, and re-arm hibernate when wake finishes while the pane is still off-screen.
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep hibernate listeners active during async replay, append any output that arrived mid-replay, then stop listeners immediately before reattach.
Co-authored-by: Cursor <cursoragent@cursor.com>
Stop hibernate IPC listeners before reading the wake payload so post-snapshot output is included and skipped reattach does not leave stale listeners.
Co-authored-by: Cursor <cursoragent@cursor.com>
Read pending buffer after async mount and verify connectivity before reattaching so in-flight SSH output and late disconnects are handled correctly.
Co-authored-by: Cursor <cursoragent@cursor.com>
Read live session connectivity at wake time, persist hibernated output on unmount, and skip scrollToBottom for alternate-screen resumes.
Co-authored-by: Cursor <cursoragent@cursor.com>
Route session exit to the hibernate buffer instead of a disposed xterm, and only tear down hibernate IPC listeners after a successful disconnected wake.
Co-authored-by: Cursor <cursoragent@cursor.com>
Defer clearing hibernate replay state until wake succeeds, skip reattach when the backend session is disconnected, preserve alternate-screen detection on serialize failure, and wake immediately when hibernate is disabled.
Co-authored-by: Cursor <cursoragent@cursor.com>
Dispose xterm for off-screen tabs while keeping SSH connected, with configurable delay, file-transfer exemptions, and wake replay for alternate-screen apps.
Co-authored-by: Cursor <cursoragent@cursor.com>
Include host and session in handleDetachPointerDown dependencies so drag
label stays in sync when dynamic tab titles or host settings change.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(terminal): narrow snippet terminal restore to RHEL-family hosts
Limit auto-run snippet stty protection to distros affected by #1498 and
suppress wrapper echo so Ubuntu, Rocky, and macOS users see their raw
commands again.
Fixes#1594
Co-authored-by: Cursor <cursoragent@cursor.com>
* revert(terminal): remove auto-run snippet stty protection (#1594)
The wrapper added in #1498 caused visible preamble noise for all snippet
executions. Revert to inserting the original command directly; the underlying
CentOS 7 terminal issue reproduces when running the script manually too.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
* Fix tmux detach focus regression on Windows (#1587)
Replace native confirm with an in-app dialog and restore terminal cursor/focus after detach so sidebar tmux actions keep working.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Skip terminal refocus while app dialogs are open
Avoid deferred tmux detach focus from stealing Radix modal focus when users open the new-session dialog immediately after detach.
Co-authored-by: Cursor <cursoragent@cursor.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Send auto-run multi-line snippets line-by-line with delay instead of bracketed-paste burst. Fixes#1590.
Also limit broadcast line delay to explicit snippet options so normal multi-line broadcast pastes stay byte-for-byte.
Route Netcatty context through body.system, filter echoed user parts,
keep OpenCode env/shim alive for server lifetime, and cap model preset dropdown height.
Co-authored-by: Cursor <cursoragent@cursor.com>