Commit Graph
172 Commits
Author SHA1 Message Date
陈大猫 28ba165c3e Merge pull request #2532 from binaricat/codex/fix-stuck-lint-test
fix(ci): prevent lint-and-test hangs
2026-07-27 16:50:41 +08:00
bincxz 3f1e22ce43 fix(sftp): keep resume verification responsive 2026-07-27 16:41:47 +08:00
bincxz 72ffc0ee31 fix(sftp): avoid retaining remotes for local editors 2026-07-27 16:31:04 +08:00
bincxz 22d0e5e5e8 fix(sftp): keep promoted editor save session alive 2026-07-27 16:05:03 +08:00
bincxz 8d8abb4956 fix(sftp): preserve pruned cleanup data 2026-07-27 11:43:52 +08:00
bincxz ba8dea5cae fix(sftp): prevent large folder upload renderer stalls 2026-07-27 11:34:02 +08:00
netcatty-bot c7ce544c55 fix: address Codex review on PR #2494 2026-07-26 23:02:53 +08:00
netcatty-bot efbdf84308 fix: address Codex review on PR #2494 2026-07-26 23:02:28 +08:00
netcatty-bot ccb54952db fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 361b4952d2 fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 205ff6d81c fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 0731eab9be fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
netcatty-bot 35895ec8db fix: address Codex review on PR #2494 2026-07-26 23:00:43 +08:00
bincxz c89522f014 fix(sftp): pin clipboard uploads to originating tab endpoint
Capture tabId/connectionId at paste time and resolve external folder/entry
uploads against that pane after awaits so mid-transfer tab switches cannot
retarget remaining multi-folder items to another host. Prefer the pinned
pane host when reconnecting and reconnect by tab id without clobbering the
active tab's lastConnectedHost.
2026-07-26 23:00:43 +08:00
bincxz e42893b25e fix(sftp): restore cancel-by-task, clipboard confirm, and browse stay-alive
PR #2509's TransferRuntime unify accidentally regressed per-task external
upload cancel (#2495), clipboard confirm close-before-upload (#2478), and
main SftpView interactive browse sessions (#2498). Restore those behaviors
on top of the process-level control plane, keep Pausing copy, and gate
broadcastGlobalTransferEvent so bare Node unit tests do not download Electron.
2026-07-26 22:47:36 +08:00
bincxz d165e158f7 fix(sftp): unify transfer control under process-level TransferRuntime
Pause and resume now go through one process-level control plane that survives
panel/terminal close: TransferRuntime + soft latches/epochs/walk registry,
soft-then-hard resume, dual-epoch-safe progress, and no-owner soft control.
2026-07-26 21:27:01 +08:00
陈大猫 5e5c98a682 Merge pull request #2486 from binaricat/fix/sftp-transfer-pause-responsiveness
fix(sftp): make transfer pause responsive and visible
2026-07-26 00:10:47 +08:00
bincxz 3d140c2f8e fix(sftp): harden folder pause/resume, delete, and root reconnect
Make folder pause latch-first with barriers and a child pause watchdog so
workers stop claiming files after soft-drain; soft-resume live walks instead
of full rewalks. Surface path conflicts with toasts, keep pause progress
visible, and show a resume spinner. Restore verified shell rm -rf with SFTP
confirmation for fast directory delete, and prefer reconnect over wiping the
pane to the host picker when listing fails on some hosts.
2026-07-26 00:10:22 +08:00
Netcatty-Botandnetcatty-bot 1924180c14 fix(sftp): keep browse sessions across top-tab switches (#2498)
* fix(#2496): automated Cursor CLI fix

* fix: address Codex review on PR #2498

---------

Co-authored-by: netcatty-bot <308658023+netcatty-bot@users.noreply.github.com>
2026-07-25 23:40:20 +08:00
netcatty-bot 034d3804df fix: address Codex review on PR #2486 2026-07-25 15:38:42 +00:00
netcatty-bot 2c7db21de0 fix: address Codex review on PR #2486 2026-07-25 15:14:03 +00:00
netcatty-bot b9e699d436 fix: address Codex review on PR #2486 2026-07-25 14:42:32 +00:00
netcatty-bot bf15405092 fix: address Codex review on PR #2486 2026-07-25 14:27:03 +00:00
bincxz 9a1b3e83e0 fix(sftp): stop ghost resume and same-path transfer races
Do not paint transferring when every backend resume misses after restart.
Refuse starting or resuming a second job with the same source and target
while another is still active, matching FileZilla-style single-writer
destination handling.
2026-07-25 22:14:59 +08:00
陈大猫 12d9913537 fix(sftp): cancel external uploads by transfer task id (#2495)
Track UploadController instances per transfer task so queue cancel of one
external upload does not abort another concurrent paste/drop upload.
Scope pending conflict prompts to the owning controller as well.
2026-07-25 22:05:37 +08:00
bincxz 95c53da338 fix(sftp): wire panel pause through the same center control path
SFTP queue pause/resume/cancel now call sftpTransferCenterStore (same as the
global transfer center), harden action-button pointer handling, retry
"cannot be paused yet", and keep progress updates from undoing a paused row.
2026-07-25 22:03:05 +08:00
bincxz 8a97e3c555 fix(sftp): make panel pause feel immediate
Paint paused optimistically, stop counting paused rows as "active", freeze
visible progress while paused, and soft-drain concurrent pause in ~50ms
without long writeStream waits on the contiguous-range path.
2026-07-25 21:55:47 +08:00
bincxz 962906c873 fix(sftp): close soft-drain checkpoint and remote identity gaps
Prefer contiguous bridge checkpointBytes over high-water transferred for
resume offsets, read remote modifyTime for meta pause identity, clear
deferredSparseTruncate on failed pause unpause, and forward fingerprint
fields through drag-drop upload progress.
2026-07-25 21:30:51 +08:00
bincxz 32d7591735 fix(sftp): bound soft-pause resume settle and keep upload fingerprints
Wait for in-flight concurrent ranges on resume with a deadline and cancel
checks so stalled SFTP requests cannot hang Resume forever. Propagate
sourceFingerprint through external-upload progress updates.
2026-07-25 21:10:27 +08:00
bincxz 59bd45ac6a fix(sftp): durable pause identity without full-file hashing
Confirm pause only after a cheap size+mtime source identity is recorded
and published for transfer-center persistence. Wait for in-flight
concurrent ranges before sparse-tail truncation on resume, and refuse
truncate after cancel during that wait.
2026-07-25 20:59:56 +08:00
bincxz 4165c738e8 fix(sftp): close multi-agent review findings on dedicated resume
Soft-unpause only live streams; directory dedicated pause winds down then
startFresh. Resume replace-mode under stagedTargetPath and promote on full
success. Refuse pre-stream pause, force R2R progress without corrupting stage
offsets, and cover the directory pause-resume path with a regression test.
2026-07-24 00:12:45 +08:00
bincxz ed6ed76c21 feat(sftp): harden global transfer center pause/resume and open-folder UX
Keep browse sessions independent of pool transfers, complete dedicated resume
for files/folders after restart, roll back partial pause safely, clamp crash
checkpoints to durable .part size, and open upload targets by connecting the
host when no terminal tab is active.
2026-07-23 23:46:49 +08:00
bincxz 9c390786eb fix(sftp): clear child cancel latches on resume and proxy clear-pending to worker
Parent resume clears sticky per-child cancelledTasksRef entries so directory
re-walk can retry cancelled files. Route clearPendingCancel to the terminal
worker (where skipAdmission latches live), re-check cancel on live resume,
and clean per-child stage artifacts on parent cancel.
2026-07-23 19:25:19 +08:00
bincxz b1178b78d8 fix(sftp): harden download cancel finalizer and clear resume cancel latch
Re-check cancel inside setTransfers so late cancels are not overwritten,
keep partial progress on cancelled directory downloads, and clear the
pre-start cancel latch on intentional resume/retry.
2026-07-23 19:17:27 +08:00
bincxz 5b624afb82 fix(sftp): keep cancelled directory downloads out of failed status
downloadToLocal previously treated cancelled child counts as partial
failure and overwrote the parent to failed. Cancel now wins, matching
processTransfer, with a regression test for the final-status helper.
2026-07-23 19:06:56 +08:00
bincxz 325359c4bb fix(sftp): preserve directory replace flags and cancel child cleanly
Keep replace/staging on directory adopt, skip byte size validation for
directory soft-resume, and treat per-child cancel as cancelled without
aborting sibling workers or overwriting status as failed.
2026-07-23 18:27:40 +08:00
bincxz 726925bd9b fix(sftp): keep directory checkpoints when clearing completed transfers
Panel Clear completed no longer removes completed/cancelled children of
unfinished directory parents, matching store prune/clearTerminal policy.
2026-07-23 18:22:54 +08:00
bincxz 92f6d3883f fix(sftp): rehome directory children in store and avoid cancel latch poison
Reassign parent+children together on adopt, stop spurious cancelTransfer
after failed dedicated reconnect, and clear pending-cancel when a queued
job is cancelled so same-id resume is not permanently poisoned.
2026-07-23 18:12:42 +08:00
bincxz 2bc2a16b32 fix(sftp): rehome directory children on adopt and surface interrupted badge
When a directory transfer is re-adopted after restart, pull orphaned child
rows into the new owner so completed checkpoints are honored. Show badge
count/attention for paused and interrupted work after restore.
2026-07-23 18:02:53 +08:00
bincxz b2f752c4d8 fix(sftp): stop dedicated pause no-op, cancel-safe conflict resolve, admit agent resume
Pause on dedicated reconnect cancels the open, resolveConflict never
resurrects cancelled rows after async duplicate naming, and background
agent restart admits before opening session-backed SFTP handles.
2026-07-23 17:43:56 +08:00
bincxz 4d058f9391 fix(sftp): recheck cancel after conflict and fully unwind batch Stop
Guard processTransfer against cancel after conflict stats, and make batch
Stop cancel scheduler jobs, release pause waiters, sync refs, and clean
artifacts like single-task cancel.
2026-07-23 17:31:12 +08:00
bincxz a77e41dbe6 fix(sftp): cancel full unfinished batch on conflict Stop
When the user stops a conflict batch, cancel every non-terminal sibling
(including attention conflict rows) so they do not remain stuck without
resolve UI or resume.
2026-07-23 17:25:51 +08:00
bincxz b4315fe8bf fix(sftp): harden conflict pause/cancel and same-turn resolve safety
No-op pause on conflict rows, keep transfer/conflict refs in sync on cancel,
eagerly clear conflictsRef on resolve to stop double processTransfer, and
surface adoption failures when resolving orphan conflicts.
2026-07-23 17:18:02 +08:00
bincxz fd55f04105 fix(sftp): sync conflict adopt for same-turn resolve and gate conflict actions
Keep conflictsRef updated during adopt so global conflict resolution applies
immediately, re-check cancel after adopt, gate replace/merge like the panel
dialog, and ignore dedicated progress while paused/cancelled.
2026-07-23 17:10:29 +08:00
bincxz 854b198517 fix(sftp): close dual-control, conflict-adopt, and orphan cancel gaps
Drop panel-local rows reassigned to dedicated-resume, seed conflicts on
adopt without auto-resume, cancel directory children on orphan cancel,
gate dedicated resume on !conflict, and hide invalid global merge actions.
2026-07-23 17:00:35 +08:00
bincxz f651900199 fix(sftp): isolate dedicated resume ownership and admit before SSH open
Reassign store ownership to dedicated-resume before reconnect work so
panel publishOwner cannot clobber progress, and open vault SFTP sessions
only after the renderer admission pool grants a slot.
2026-07-23 16:44:38 +08:00
bincxz 5ad60fec0c fix(sftp): cancel backend transfers for directory children
When cancelling a parent directory task, also cancel each non-terminal
child on the bridge so in-flight stream jobs stop immediately.
2026-07-23 16:37:35 +08:00
bincxz ecd1710f8f fix(sftp): cancel queued directory children and check cancel before pool open
Directory cancel now stops all non-terminal children on the renderer
scheduler, and transfer workers re-check cancel before acquiring pool
leases so cancelled bulk jobs do not open dedicated sessions.
2026-07-23 16:37:13 +08:00
bincxz d7ad6e256c fix(sftp): latch pre-start cancels and stop cancel/pause races
Remember cancels before startTransferNow registers the id, cancel the
renderer scheduler on orphan cancel, avoid pause completion resurrecting
cancelled rows, forward skipAdmission for temp downloads, and persist
progress checkpoints on background events.
2026-07-23 16:28:20 +08:00
bincxz 56e83d69a7 fix(sftp): harden resume admission, checkpoints, and terminal events
Share dedicated resume with the renderer admission pool, preserve queued
pause checkpoints, refuse to resurrect cancelled agent rows, and complete
dedicated resumes that finish after a reconnect-spinner pause.
2026-07-23 16:20:02 +08:00