diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 762311dcb..acbde1e74 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -52,9 +52,9 @@ jobs: - name: Test terminal decoration performance env: - ELECTRON_DISABLE_SANDBOX: "1" NETCATTY_TERMINAL_PERF_SHOW_WINDOW: "1" - run: xvfb-run -a npm run test:xterm-decoration-performance + # GitHub-hosted runners do not configure Electron's SUID sandbox helper. + run: xvfb-run -a ./node_modules/.bin/electron --no-sandbox scripts/xterm-decoration-performance.live.test.cjs - name: Build run: npm run build diff --git a/scripts/github-workflow-ci.test.cjs b/scripts/github-workflow-ci.test.cjs index 6ff1134db..95a3d3e62 100644 --- a/scripts/github-workflow-ci.test.cjs +++ b/scripts/github-workflow-ci.test.cjs @@ -76,7 +76,7 @@ test("PR validation runs once per commit and includes a production build", () => assert.match(testWorkflow, /sudo apt-get install -y fish xvfb/); assert.match( testWorkflow, - /- name: Test terminal decoration performance\s*\n\s*env:\s*\n\s*ELECTRON_DISABLE_SANDBOX: "1"\s*\n\s*NETCATTY_TERMINAL_PERF_SHOW_WINDOW: "1"\s*\n\s*run: xvfb-run -a npm run test:xterm-decoration-performance/, + /- name: Test terminal decoration performance\s*\n\s*env:\s*\n\s*NETCATTY_TERMINAL_PERF_SHOW_WINDOW: "1"\s*\n\s*# GitHub-hosted runners do not configure Electron's SUID sandbox helper\.\s*\n\s*run: xvfb-run -a \.\/node_modules\/\.bin\/electron --no-sandbox scripts\/xterm-decoration-performance\.live\.test\.cjs/, ); assert.match(testWorkflow, /- name: Build\s*\n\s*run: npm run build/); assert.doesNotMatch(testWorkflow, /\n mosh-windows-conpty:/);