From d4b64d564b5e807a97a4bec90d812151cc8618b2 Mon Sep 17 00:00:00 2001 From: bincxz <16399091+binaricat@users.noreply.github.com> Date: Thu, 22 Jan 2026 23:06:12 +0800 Subject: [PATCH] fix: accept any v* tag to match build.yml trigger pattern The workflow triggers on `v*` tags and build.yml extracts version from any v-prefixed tag. Updated the regex from `^v\d+\.\d+\.\d+` to `^v\d` to accept tags like v1, v1.2, v1.2.3, etc. This ensures version parsing stays in sync with build.yml behavior. Co-Authored-By: Claude --- .github/scripts/generate-release-note.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/scripts/generate-release-note.js b/.github/scripts/generate-release-note.js index a831bd80a..8ba3899a2 100644 --- a/.github/scripts/generate-release-note.js +++ b/.github/scripts/generate-release-note.js @@ -1,9 +1,15 @@ const fs = require('fs'); const path = require('path'); +// Check if refName is a version tag (matches v* pattern used by workflow trigger) +// This keeps parsing in sync with build.yml which triggers on tags: v* +function isVersionTag(refName) { + return refName && /^v\d/.test(refName); +} + // Determine version priority: // 1. VERSION env variable -// 2. Valid version tag (v1.2.3 format) +// 2. Any v* tag (v1, v1.2, v1.2.3, etc. - matches build.yml trigger) // 3. Short commit ID (first 7 chars of GITHUB_SHA) // 4. package.json version as fallback function getVersion() { @@ -12,8 +18,8 @@ function getVersion() { } const refName = process.env.GITHUB_REF_NAME; - // Check if refName is a valid version tag (e.g., v1.2.3) - if (refName && /^v\d+\.\d+\.\d+/.test(refName)) { + // Accept any v* tag to match build.yml behavior + if (isVersionTag(refName)) { return refName.replace(/^v/, ''); } @@ -36,7 +42,7 @@ function getVersion() { const version = getVersion(); const repo = process.env.GITHUB_REPOSITORY || 'binaricat/netcatty'; // For tag releases, use the tag; for workflow_dispatch, create a tag from version -const tag = (process.env.GITHUB_REF_NAME && /^v\d+\.\d+\.\d+/.test(process.env.GITHUB_REF_NAME)) +const tag = isVersionTag(process.env.GITHUB_REF_NAME) ? process.env.GITHUB_REF_NAME : `v${version}`; const baseUrl = `https://github.com/${repo}/releases/download/${tag}`;